Issue 378 in xmonad: Clean up WindowBringer interface

Status: New Owner: ---- New issue 378 by MathStuf: Clean up WindowBringer interface http://code.google.com/p/xmonad/issues/detail?id=378 The attached patch adds a bringMenu' function so that the user may specify a command for it as well. In addition, the other functions are cleaned up to use cascade with the default "dmenu" command. I tried doing "darcs record", but I do not have packages that satisfy the testing version dependencies and the xmonad update from cabal has dependency solving issues with the system version. Attachments: xmonad-contrib-windowbringer-cleanup.patch 2.2 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings

Updates: Status: Patch Labels: Component-Contrib Type-Patch Comment #1 on issue 378 by vogt.adam: Clean up WindowBringer interface http://code.google.com/p/xmonad/issues/detail?id=378 Nice work! Regarding your inability to "darcs record": Are you using 'cabal install' in the appropriate repos (first core, then contrib) to try to build the current development version? (If that's not what you did, does that work for you?) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings

Comment #2 on issue 378 by MathStuf: Clean up WindowBringer interface http://code.google.com/p/xmonad/issues/detail?id=378 The only packages I have in cabal is HInotify and xmobar. The rest are straight distribution packages (Fedora 12). Unfortunately, this is not much of a build box so building packages from the ground up is a little painful. When I get back from spring break, I'll run it on a more powerful machine. As for the dependency issues, it seems that an older version of the HTTP library had been removed, but not from the packages list. This in turn made the build system thing headers were missing and things went downhill from there. Rather than fiddling with the packages file and making things worse, i just reinstalled ghc. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings

Comment #3 on issue 378 by MathStuf: Clean up WindowBringer interface http://code.google.com/p/xmonad/issues/detail?id=378 Here's another patch. This replaces the earlier patch. This also adds support to be able to call the menu with arguments as well. Attachments: xmonad-contrib-windowbringer-args.patch 1.8 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings

Comment #4 on issue 378 by MathStuf: Clean up WindowBringer interface http://code.google.com/p/xmonad/issues/detail?id=378 I'll try darcs record/darcs send later today. Since I run XMonad from darcs these days, I shouldn't have the issues I had before.

Comment #5 on issue 378 by MathStuf: Clean up WindowBringer interface http://code.google.com/p/xmonad/issues/detail?id=378 Applied here: http://www.haskell.org/pipermail/xmonad/2010-October/010691.html. Issue can be closed.

Comment #6 on issue 378 by MathStuf: Clean up WindowBringer interface http://code.google.com/p/xmonad/issues/detail?id=378 Hmm...actually, the patches don't seem to be the same. Looking into this.

Comment #7 on issue 378 by MathStuf: Clean up WindowBringer interface http://code.google.com/p/xmonad/issues/detail?id=378 Seems these are in the repository (darcs send doesn't list this patch).

Updates: Status: Fixed Comment #8 on issue 378 by vogt.a...@gmail.com: Clean up WindowBringer interface http://code.google.com/p/xmonad/issues/detail?id=378 (No comment was entered for this change.)
participants (1)
-
codesite-noreply@google.com