Merged functionality from X.L.ThreeColumnsMiddle into X.L.ThreeColumns (and some new features)

I had a look at X.L.ThreeColumnsMiddle and X.L.Threecolumns and noticed that they are very similar, actually the first one is based on the second one. Therefore I tried to merge them together and here is the result. This somewhat breaks the configuration syntax, but that is unavoidable. There was a difference in the way column sizes was specified, I adopted the one from the Middle-version since I can't understand why it was done as it was in the original code. I also extended the ability to specify the column size a bit by allowing negative fractions. Negative fractions will specify the size for the slave columns and the behaviour will be different when there are only two windows to manage. Enjoy. /Anders Engström

* On Saturday, April 11 2009, Anders Engström wrote:
I had a look at X.L.ThreeColumnsMiddle and X.L.Threecolumns and noticed that they are very similar, actually the first one is based on the second one. Therefore I tried to merge them together and here is the result. This somewhat breaks the configuration syntax, but that is unavoidable.
I've had a look at your your merging, and I think that I've managed to keep the same constructors as the previous versions. The type signatures do change for users of ThreeColumnsMid (or whatever it is called) however, that could be changed too, but I think that the benefits of potentially allowing the toggling between the two outweigh the small effort for people who include lengthy type signatures in their configs. Might it be worth exporting ThreeColumns through ThreeColumnsMid (with depreciated warnings enabled etc.)?
There was a difference in the way column sizes was specified, I adopted the one from the Middle-version since I can't understand why it was done as it was in the original code. I also extended the ability to specify the column size a bit by allowing negative fractions. Negative fractions will specify the size for the slave columns and the behaviour will be different when there are only two windows to manage.
That change sounds reasonable. Thanks, Adam

I've pushed these:
Sat Apr 25 12:17:10 EDT 2009 Adam Vogt

On Sun, May 03, 2009 at 02:48:42PM -0400, Adam Vogt wrote:
I've pushed these:
Sat Apr 25 12:17:10 EDT 2009 Adam Vogt
* Export ThreeColMid from L.ThreeColumnsMiddle The configs that import it should continue to work with this module, though the type of the ThreeColMid constructor is now ThreeCol (previously ThreeColMid).
I doubt that many configs use ThreeColMid, since it is darcs-only. The compatibility module added by this patch might be worth removing before the next release?
Agreed. Combatibility is really only important across releases, we expect darcs users to be agile. Always happy to sign off on cruft removal, Spencer Janssen
participants (3)
-
Adam Vogt
-
Anders Engström
-
Spencer Janssen