Hi, if you follow planet.haskell.org you’ll have read that I attended the Darcs hacking sprint in Vienna. Together with the Darcs guys I integrated DarcsWatch better into their patch submission and review process. Let me outline it quickly * Darcs patches are sent to patches@darcs.net. * A new ticket (of type patch, not issue) is automatically created in their roundup instance. * The patch, with a reference to the ticket number, is sent by roundup to the darcs-users mailing list. * DarcsWatch is subscribed to that list and notices this mail as usual. * DarcsWatch detects the roundup patch tracker URL in the mail and remembers it. * It also sets a special "darcswatchurl" property of the roundup ticket (via e-Mail), to add a link to DarcsWatch on the roundup ticket view. * When the patch is eventually applied, DarcsWatch sends a mail to the roundup ticket, setting its state to "applied". A message about this is sent to the darcs-user list. This is not directly applicable to xmonad, of course. But due to the re-organization of the DarcsWatch code some new possibilities arise: 1. DarcsWatch could send bundle-applied-mails to the mailing list. Since patch submissions are on the list, this would we useful for people just following development. Also the submitter is likely happy to hear that his patch has been applied, without checking the repository or DarcsWatch. OTOH it would slightly increase the noise level on the list. 2. Users can subscribe to bundle-applied-mails about their own patches. It would be relatively easy to implement that I can give DarcsWatch a list of e-Mail-Adresses that want “Your bundle α was applied to repository β” notifications. This would be independent of xmonad, of course. Is anyone interested? I’d start with manually configuring the list with addresses people tell me about, and maybe later add an automatic subscription feature, if there is demand. 3. DarcsWatch could be integrated closer in the xmonad bug tracker. Of course, code.google.com will not be as easily hackable as a self-hosted roundup instance, but maybe some interaction is possible. Is there an API for that? Some features that are desirable are: * DarcsWatch should somehow be aware of patches submitted via code.google.com that were not sent to the mailing list. * DarcsWatch could be able to amend the ticket with the patch application status. * DarcsWatch could close tickets if a patch bundle is applied – but what if the patch does not work, if there are multiple patches etc.? The Darcs team has clearer semantics there, as patches and issues are tracked separately on roundup (but can refer to each other). Especially item 3 is meant to be a discussion starter :-) Greetings, Joachim -- Joachim "nomeata" Breitner mail: mail@joachim-breitner.de | ICQ# 74513189 | GPG-Key: 4743206C JID: nomeata@joachim-breitner.de | http://www.joachim-breitner.de/ Debian Developer: nomeata@debian.org
* On Thursday, November 26 2009, Joachim Breitner wrote:
Hi,
..
3. DarcsWatch could be integrated closer in the xmonad bug tracker. Of course, code.google.com will not be as easily hackable as a self-hosted roundup instance, but maybe some interaction is possible. Is there an API for that? Some features that are desirable are: * DarcsWatch should somehow be aware of patches submitted via code.google.com that were not sent to the mailing list.
It could be simple enough to scrape mails from codesite-noreply@google.com, grab the link to the issue number and patch filename, and then scrape that page for the last link ending in that name. http://www.haskell.org/pipermail/xmonad/2009-November/009218.html Ex, to guess that the patch filename referred is actually: http://xmonad.googlecode.com/issues/attachment?aid=5885454491537368539&name=track-currently-processing-event.dpatch But perhaps the googlecode bugtracker can (or should?) be adjusted to send the attachments to the list, which means that darcswatch should pick them up without any further modifications.
* DarcsWatch could be able to amend the ticket with the patch application status. * DarcsWatch could close tickets if a patch bundle is applied – but what if the patch does not work, if there are multiple patches etc.? The Darcs team has clearer semantics there, as patches and issues are tracked separately on roundup (but can refer to each other).
It would be convenient to mark bugs as patch-pending, but it looks like a lot of effort (and does google supply a stable API for it?) for relatively little benefit. Closing the bugs definitely doesn't fit with how we run things currently, but it should be same effort to implement as marking bugs as patch-pending. -- Adam
Hi, Am Freitag, den 27.11.2009, 16:29 -0500 schrieb Adam Vogt:
3. DarcsWatch could be integrated closer in the xmonad bug tracker. Of course, code.google.com will not be as easily hackable as a self-hosted roundup instance, but maybe some interaction is possible. Is there an API for that? Some features that are desirable are: * DarcsWatch should somehow be aware of patches submitted via code.google.com that were not sent to the mailing list.
It could be simple enough to scrape mails from codesite-noreply@google.com, grab the link to the issue number and patch filename, and then scrape that page for the last link ending in that name. http://www.haskell.org/pipermail/xmonad/2009-November/009218.html
Ex, to guess that the patch filename referred is actually: http://xmonad.googlecode.com/issues/attachment?aid=5885454491537368539&name=track-currently-processing-event.dpatch
I thought about this, but it seems quite hackish, so hopefully a more elegant solution can be found.
But perhaps the googlecode bugtracker can (or should?) be adjusted to send the attachments to the list, which means that darcswatch should pick them up without any further modifications.
That would be great.
* DarcsWatch could be able to amend the ticket with the patch application status. * DarcsWatch could close tickets if a patch bundle is applied – but what if the patch does not work, if there are multiple patches etc.? The Darcs team has clearer semantics there, as patches and issues are tracked separately on roundup (but can refer to each other).
It would be convenient to mark bugs as patch-pending, but it looks like a lot of effort (and does google supply a stable API for it?) for relatively little benefit. Closing the bugs definitely doesn't fit with how we run things currently, but it should be same effort to implement as marking bugs as patch-pending.
There actually is an API: http://code.google.com/p/support/wiki/IssueTrackerAPI which could be used to add a tag "Patch-Applied" to the ticket. The API does for some reason not include access to the attachements :-( Greetings, Joachim -- Joachim "nomeata" Breitner mail: mail@joachim-breitner.de | ICQ# 74513189 | GPG-Key: 4743206C JID: nomeata@joachim-breitner.de | http://www.joachim-breitner.de/ Debian Developer: nomeata@debian.org
On Thu, Nov 26, 2009 at 07:25:26PM +0100, Joachim Breitner wrote:
Hi,
if you follow planet.haskell.org you’ll have read that I attended the Darcs hacking sprint in Vienna. Together with the Darcs guys I integrated DarcsWatch better into their patch submission and review process. Let me outline it quickly * Darcs patches are sent to patches@darcs.net. * A new ticket (of type patch, not issue) is automatically created in their roundup instance. * The patch, with a reference to the ticket number, is sent by roundup to the darcs-users mailing list. * DarcsWatch is subscribed to that list and notices this mail as usual. * DarcsWatch detects the roundup patch tracker URL in the mail and remembers it. * It also sets a special "darcswatchurl" property of the roundup ticket (via e-Mail), to add a link to DarcsWatch on the roundup ticket view. * When the patch is eventually applied, DarcsWatch sends a mail to the roundup ticket, setting its state to "applied". A message about this is sent to the darcs-user list.
This is not directly applicable to xmonad, of course. But due to the re-organization of the DarcsWatch code some new possibilities arise:
1. DarcsWatch could send bundle-applied-mails to the mailing list. Since patch submissions are on the list, this would we useful for people just following development. Also the submitter is likely happy to hear that his patch has been applied, without checking the repository or DarcsWatch. OTOH it would slightly increase the noise level on the list.
At the very least I would find this useful. We already reply "Patch applied" to every patch, it would be nice to automate that.
2. Users can subscribe to bundle-applied-mails about their own patches. It would be relatively easy to implement that I can give DarcsWatch a list of e-Mail-Adresses that want “Your bundle α was applied to repository β” notifications. This would be independent of xmonad, of course. Is anyone interested? I’d start with manually configuring the list with addresses people tell me about, and maybe later add an automatic subscription feature, if there is demand.
If we send "patch applied" emails to the mailing list, it would be sensible to CC the original sender.
3. DarcsWatch could be integrated closer in the xmonad bug tracker. Of course, code.google.com will not be as easily hackable as a self-hosted roundup instance, but maybe some interaction is possible. Is there an API for that? Some features that are desirable are: * DarcsWatch should somehow be aware of patches submitted via code.google.com that were not sent to the mailing list. * DarcsWatch could be able to amend the ticket with the patch application status. * DarcsWatch could close tickets if a patch bundle is applied – but what if the patch does not work, if there are multiple patches etc.? The Darcs team has clearer semantics there, as patches and issues are tracked separately on roundup (but can refer to each other).
Especially item 3 is meant to be a discussion starter :-)
We've taken to setting 'Status: Patch' to issues that are only waiting on a patch to be applied. I would be comfortable with darcswatch marking these as 'Status: Fixed'. Any policy more complicated than that runs the risk of being more hassle than convenience. Cheers, Spencer Janssen
Hi, Am Samstag, den 28.11.2009, 13:35 -0600 schrieb Spencer Janssen:
On Thu, Nov 26, 2009 at 07:25:26PM +0100, Joachim Breitner wrote:
1. DarcsWatch could send bundle-applied-mails to the mailing list. Since patch submissions are on the list, this would we useful for people just following development. Also the submitter is likely happy to hear that his patch has been applied, without checking the repository or DarcsWatch. OTOH it would slightly increase the noise level on the list.
At the very least I would find this useful. We already reply "Patch applied" to every patch, it would be nice to automate that.
Implemented. The last mail from darcswatch is an example how these might look like. They have proper threading headers, and the subject is taking from the submitting mail (if available). For some older patches, these might not be stored, but it will be for any patches since two weeks ago.
2. Users can subscribe to bundle-applied-mails about their own patches. It would be relatively easy to implement that I can give DarcsWatch a list of e-Mail-Adresses that want “Your bundle α was applied to repository β” notifications. This would be independent of xmonad, of course. Is anyone interested? I’d start with manually configuring the list with addresses people tell me about, and maybe later add an automatic subscription feature, if there is demand.
If we send "patch applied" emails to the mailing list, it would be sensible to CC the original sender.
Not sure, I guess most are subscribed to the list anyways, and I don’t want to send unwanted mails to private addresses. But Opt-In is possible, just tell me if you want to join. This would then work for all your submissions that are tracked on DarcsWatch, not only those to xmonad.
3. DarcsWatch could be integrated closer in the xmonad bug tracker. Of course, code.google.com will not be as easily hackable as a self-hosted roundup instance, but maybe some interaction is possible. Is there an API for that? Some features that are desirable are: * DarcsWatch should somehow be aware of patches submitted via code.google.com that were not sent to the mailing list. * DarcsWatch could be able to amend the ticket with the patch application status. * DarcsWatch could close tickets if a patch bundle is applied – but what if the patch does not work, if there are multiple patches etc.? The Darcs team has clearer semantics there, as patches and issues are tracked separately on roundup (but can refer to each other).
Especially item 3 is meant to be a discussion starter :-)
We've taken to setting 'Status: Patch' to issues that are only waiting on a patch to be applied. I would be comfortable with darcswatch marking these as 'Status: Fixed'. Any policy more complicated than that runs the risk of being more hassle than convenience.
This would be doable. The real problem is actually accessing the patches in the bugtracker... Anyways, enough darcswatch hacking this weekend, I’ll put that back for now. Greetings, Joachim -- Joachim Breitner e-Mail: mail@joachim-breitner.de Homepage: http://www.joachim-breitner.de ICQ#: 74513189 Jabber-ID: nomeata@joachim-breitner.de
Hi, Am Sonntag, den 29.11.2009, 23:22 +0100 schrieb Joachim Breitner:
Am Samstag, den 28.11.2009, 13:35 -0600 schrieb Spencer Janssen:
On Thu, Nov 26, 2009 at 07:25:26PM +0100, Joachim Breitner wrote:
1. DarcsWatch could send bundle-applied-mails to the mailing list. Since patch submissions are on the list, this would we useful for people just following development. Also the submitter is likely happy to hear that his patch has been applied, without checking the repository or DarcsWatch. OTOH it would slightly increase the noise level on the list.
At the very least I would find this useful. We already reply "Patch applied" to every patch, it would be nice to automate that.
Implemented. The last mail from darcswatch is an example how these might look like. They have proper threading headers, and the subject is taking from the submitting mail (if available). For some older patches, these might not be stored, but it will be for any patches since two weeks ago.
this has been running for a while now and I’d like to hear if this is found useful/annoying/improvable/don’t care by you. Thanks, Joachim -- Joachim "nomeata" Breitner mail: mail@joachim-breitner.de | ICQ# 74513189 | GPG-Key: 4743206C JID: nomeata@joachim-breitner.de | http://www.joachim-breitner.de/ Debian Developer: nomeata@debian.org
On Sun, Dec 20, 2009 at 05:27:45PM +0100, Joachim Breitner wrote:
Hi,
Am Sonntag, den 29.11.2009, 23:22 +0100 schrieb Joachim Breitner:
Am Samstag, den 28.11.2009, 13:35 -0600 schrieb Spencer Janssen:
On Thu, Nov 26, 2009 at 07:25:26PM +0100, Joachim Breitner wrote:
1. DarcsWatch could send bundle-applied-mails to the mailing list. Since patch submissions are on the list, this would we useful for people just following development. Also the submitter is likely happy to hear that his patch has been applied, without checking the repository or DarcsWatch. OTOH it would slightly increase the noise level on the list.
At the very least I would find this useful. We already reply "Patch applied" to every patch, it would be nice to automate that.
Implemented. The last mail from darcswatch is an example how these might look like. They have proper threading headers, and the subject is taking from the submitting mail (if available). For some older patches, these might not be stored, but it will be for any patches since two weeks ago.
this has been running for a while now and I’d like to hear if this is found useful/annoying/improvable/don’t care by you.
Thanks, Joachim
I've found this useful so far. The one thing I find myself wondering is how often DarcsWatch checks the repository and sends out emails. It would be nice to know when to expect the "patch applied" messages. Cheers, Spencer Janssen
Hi, Am Sonntag, den 20.12.2009, 11:43 -0600 schrieb Spencer Janssen:
On Sun, Dec 20, 2009 at 05:27:45PM +0100, Joachim Breitner wrote:
Am Sonntag, den 29.11.2009, 23:22 +0100 schrieb Joachim Breitner:
Am Samstag, den 28.11.2009, 13:35 -0600 schrieb Spencer Janssen:
On Thu, Nov 26, 2009 at 07:25:26PM +0100, Joachim Breitner wrote:
1. DarcsWatch could send bundle-applied-mails to the mailing list. Since patch submissions are on the list, this would we useful for people just following development. Also the submitter is likely happy to hear that his patch has been applied, without checking the repository or DarcsWatch. OTOH it would slightly increase the noise level on the list.
At the very least I would find this useful. We already reply "Patch applied" to every patch, it would be nice to automate that.
Implemented. The last mail from darcswatch is an example how these might look like. They have proper threading headers, and the subject is taking from the submitting mail (if available). For some older patches, these might not be stored, but it will be for any patches since two weeks ago.
this has been running for a while now and I’d like to hear if this is found useful/annoying/improvable/don’t care by you.
I've found this useful so far. The one thing I find myself wondering is how often DarcsWatch checks the repository and sends out emails. It would be nice to know when to expect the "patch applied" messages.
every twenty minutes: $ nomeata.de crontab -l|grep darcswatch 5,25,45 * * * * /home/jojo/.cabal/bin/darcswatch-pull-repos /opt/darcswatch/real > /tmp/darcswatch-cron-output (this is on Western European time) Greetings, Joachim -- Joachim "nomeata" Breitner mail: mail@joachim-breitner.de | ICQ# 74513189 | GPG-Key: 4743206C JID: nomeata@joachim-breitner.de | http://www.joachim-breitner.de/ Debian Developer: nomeata@debian.org
On Sun, Dec 20, 2009 at 05:27:45PM +0100, Joachim Breitner wrote:
Hi,
Am Sonntag, den 29.11.2009, 23:22 +0100 schrieb Joachim Breitner:
Am Samstag, den 28.11.2009, 13:35 -0600 schrieb Spencer Janssen:
On Thu, Nov 26, 2009 at 07:25:26PM +0100, Joachim Breitner wrote:
1. DarcsWatch could send bundle-applied-mails to the mailing list. Since patch submissions are on the list, this would we useful for people just following development. Also the submitter is likely happy to hear that his patch has been applied, without checking the repository or DarcsWatch. OTOH it would slightly increase the noise level on the list.
At the very least I would find this useful. We already reply "Patch applied" to every patch, it would be nice to automate that.
Implemented. The last mail from darcswatch is an example how these might look like. They have proper threading headers, and the subject is taking from the submitting mail (if available). For some older patches, these might not be stored, but it will be for any patches since two weeks ago.
this has been running for a while now and I’d like to hear if this is found useful/annoying/improvable/don’t care by you.
I find it useful as well! It's a nice replacement for the manual "Applied, thx" mails and works as advertised. :-) Cheers! Jan
participants (4)
-
Adam Vogt -
Jan Vornberger -
Joachim Breitner -
Spencer Janssen