darcs patch: U.EZConfig: add xK_Print <Print> to special keys
Mon Mar 2 16:07:41 MST 2009 wirtwolff@gmail.com * U.EZConfig: add xK_Print <Print> to special keys Many setups are expecting xK_Print rather than xK_Sys_Req, so make it available in additionalKeysP.
Some older versions of the X11 binding do not have xK_Print iirc, so to avoid breaking builds with them (or does xmonad already depend relatively recent changes to X11?), perhaps this would better be done like the multimediaKeys in EZConfig? Then again, having more keybindings that may silently not work has been confusing. * On Monday, March 02 2009, Wirt Wolff wrote:
Mon Mar 2 16:07:41 MST 2009 wirtwolff@gmail.com * U.EZConfig: add xK_Print <Print> to special keys Many setups are expecting xK_Print rather than xK_Sys_Req, so make it available in additionalKeysP.
_______________________________________________ xmonad mailing list xmonad@haskell.org http://www.haskell.org/mailman/listinfo/xmonad
On 2009 Mar 2, at 18:43, Adam Vogt wrote:
Some older versions of the X11 binding do not have xK_Print iirc, so to avoid breaking builds with them (or does xmonad already depend relatively recent changes to X11?), perhaps this would better be done like the multimediaKeys in EZConfig?
xmonad triggers lots of bugs in older versions of the X11 bindings, and in fact has been *the* driving factor in their development and debugging, so the most recent version is mandatory. The multimedia keys, on the other hand, don't exist in many non-xorg versions of X11 (some commercial Unixes) and may not be bound to anything on some non- PC/Mac commercial workstations, so need to be conditional. -- brandon s. allbery [solaris,freebsd,perl,pugs,haskell] allbery@kf8nh.com system administrator [openafs,heimdal,too many hats] allbery@ece.cmu.edu electrical and computer engineering, carnegie mellon university KF8NH
Excerpts from Adam Vogt's message of Mon Mar 02 16:43:52 -0700 2009:
Some older versions of the X11 binding do not have xK_Print iirc, so to avoid breaking builds with them (or does xmonad already depend relatively recent changes to X11?), perhaps this would better be done like the multimediaKeys in EZConfig?
Luckily, we depend on X11>=1.4.3 which does have that keysym. Wish I could say I'd thought to check /before/ submitting the patch. Thanks for looking out for our users, and ensuring it got checked. -- wmw
On Mon, Mar 02, 2009 at 03:11:48PM -0800, Wirt Wolff wrote:
Mon Mar 2 16:07:41 MST 2009 wirtwolff@gmail.com * U.EZConfig: add xK_Print <Print> to special keys Many setups are expecting xK_Print rather than xK_Sys_Req, so make it available in additionalKeysP.
Applied, thanks.
participants (4)
-
Adam Vogt -
Brandon S. Allbery KF8NH -
Spencer Janssen -
Wirt Wolff