darcs patch: Tabbed.hs, SetWMName.hs: the modules need bitwise "or"

Valery V. Vorotyntsev

15 Nov 2007 15 Nov '07

2:48 p.m.

Thu Nov 15 16:37:58 EET 2007 "Valery V. Vorotyntsev" * Tabbed.hs, SetWMName.hs: the modules need bitwise "or" Tabbed.hs cleaned of trailing whitespace. -- vvv

Attachments:

Tabbed_SetWMName-import_bitwise_or.dpatch (text/plain — 34.4 KB)

Show replies by date

David Roundy

15 Nov 15 Nov

3:18 p.m.

Applied. Thanks! David On Thu, Nov 15, 2007 at 04:48:28PM +0200, Valery V. Vorotyntsev wrote:

...

Thu Nov 15 16:37:58 EET 2007 "Valery V. Vorotyntsev" * Tabbed.hs, SetWMName.hs: the modules need bitwise "or" Tabbed.hs cleaned of trailing whitespace.

David Roundy

4:10 p.m.

I take that back. This fails to compile for me (I hadn't actually compiled or pushed when I sent the email). David On Thu, Nov 15, 2007 at 07:18:40AM -0800, David Roundy wrote:

...

Applied. Thanks!

David

On Thu, Nov 15, 2007 at 04:48:28PM +0200, Valery V. Vorotyntsev wrote:

...
Thu Nov 15 16:37:58 EET 2007 "Valery V. Vorotyntsev" * Tabbed.hs, SetWMName.hs: the modules need bitwise "or" Tabbed.hs cleaned of trailing whitespace.

Valery V. Vorotyntsev

4:45 p.m.

...

...
On Thu, Nov 15, 2007 at 04:48:28PM +0200, Valery V. Vorotyntsev wrote:

...
Thu Nov 15 16:37:58 EET 2007 "Valery V. Vorotyntsev" * Tabbed.hs, SetWMName.hs: the modules need bitwise "or" Tabbed.hs cleaned of trailing whitespace.

On Thu, Nov 15, 2007 at 07:18:40AM -0800, David Roundy wrote:

...
Applied. Thanks!

On 11/15/07, David Roundy wrote:

...

I take that back. This fails to compile for me (I hadn't actually compiled or pushed when I sent the email).

Strange: it failed to build on my machine _without_ them... Well, it doesn't now. Sorry for misreporting. -- vvv

David Roundy

4:59 p.m.

On Thu, Nov 15, 2007 at 06:45:21PM +0200, Valery V. Vorotyntsev wrote:

...

...
...
On Thu, Nov 15, 2007 at 04:48:28PM +0200, Valery V. Vorotyntsev wrote:

...
Thu Nov 15 16:37:58 EET 2007 "Valery V. Vorotyntsev" * Tabbed.hs, SetWMName.hs: the modules need bitwise "or" Tabbed.hs cleaned of trailing whitespace.

On Thu, Nov 15, 2007 at 07:18:40AM -0800, David Roundy wrote:

...
Applied. Thanks!

On 11/15/07, David Roundy wrote:

...
I take that back. This fails to compile for me (I hadn't actually compiled or pushed when I sent the email).

Strange: it failed to build on my machine _without_ them... Well, it doesn't now.

Sorry for misreporting.

I actually pushed your change plus a fix. Can you check that it compiles for you? Dons pushed a change in the exporting in XMonad, which I think means we shouldn't need these imports. -- David Roundy Department of Physics Oregon State University

Valery V. Vorotyntsev

5:18 p.m.

On 11/15/07, David Roundy wrote:

...

I actually pushed your change plus a fix. Can you check that it compiles for you? Dons pushed a change in the exporting in XMonad, which I think means we shouldn't need these imports.

Darcs versions of xmonad and xmonad-contrib compile smoothly: clean >> configure >> build >> install -- no problem. Is that what you wanted me to check, David? -- vvv

Andrea Rossato

5:34 p.m.

New subject: darcs patch: Tabbed.hs, SetWMName.hs: the modules need bitwise "or"

On Thu, Nov 15, 2007 at 07:18:51PM +0200, Valery V. Vorotyntsev wrote:

...

On 11/15/07, David Roundy wrote:

...
I actually pushed your change plus a fix. Can you check that it compiles for you? Dons pushed a change in the exporting in XMonad, which I think means we shouldn't need these imports.

Darcs versions of xmonad and xmonad-contrib compile smoothly: clean >> configure >> build >> install -- no problem.

Is that what you wanted me to check, David?

XMonad/Layout/Tabbed.hs:176:34: Not in scope: `.|.' What am I missing here? Don yesterday removed Data.Bits from tabbed, but what about this line? mask = Just (exposureMask .|. buttonPressMask) Here HEAD is broken. Andrea

Andrea Rossato

5:38 p.m.

New subject: darcs patch: Tabbed.hs, SetWMName.hs: the modules need bitwise "or"

On Thu, Nov 15, 2007 at 08:59:13AM -0800, David Roundy wrote:

...

I actually pushed your change plus a fix. Can you check that it compiles for you? Dons pushed a change in the exporting in XMonad, which I think means we shouldn't need these imports.

Now I see this: Wed Nov 14 19:37:59 CET 2007 Don Stewart * comments, reexport Data.Bits Why? Is there any reason? Shouldn't be preferable to explicitly import what is needed, without relaying on the core re-exporting stuff for us? Andrea

David Roundy

6:28 p.m.

On Thu, Nov 15, 2007 at 06:38:16PM +0100, Andrea Rossato wrote:

...

On Thu, Nov 15, 2007 at 08:59:13AM -0800, David Roundy wrote:

...
I actually pushed your change plus a fix. Can you check that it compiles for you? Dons pushed a change in the exporting in XMonad, which I think means we shouldn't need these imports.

Now I see this:

Wed Nov 14 19:37:59 CET 2007 Don Stewart * comments, reexport Data.Bits

Why? Is there any reason? Shouldn't be preferable to explicitly import what is needed, without relaying on the core re-exporting stuff for us?

I suspect Don did this to make users' xmonad.hs smaller. I'm ambivalent. -- David Roundy Department of Physics Oregon State University

Brent Yorgey

6:46 p.m.

...

...
Why? Is there any reason? Shouldn't be preferable to explicitly import what is needed, without relaying on the core re-exporting stuff for us?

I suspect Don did this to make users' xmonad.hs smaller. I'm ambivalent.

I think the point is not to make xmonad.hs *smaller* so much as it is to make it *simpler*. The fewer things users have to worry about to create a working xmonad.hs, the better. From experience, when I switched my Config.hs over to xmonad.hs, I copied over some keybindings and then had an error that said .|. was not in scope. Of course, I knew exactly what the problem was and how to fix it, but someone unfamiliar with Haskell wouldn't. To some extent this can be ameliorated by good documentation and examples, but on general principle I think re-exporting various useful things from the core is probably a good idea. -Brent

Don Stewart

8:58 p.m.

valery.vv:

...

Thu Nov 15 16:37:58 EET 2007 "Valery V. Vorotyntsev" * Tabbed.hs, SetWMName.hs: the modules need bitwise "or" Tabbed.hs cleaned of trailing whitespace.

--

This are not needed. XMonad now reexports Data.Bits, so you don't need to import it explicitly in contrib code to use it. Be sure to update and reinstall xmonad, then clean and rebuild xmonad-contrib. -- Don

6442

Age (days ago)

6442

Last active (days ago)

List overview

Download

10 comments

5 participants

participants (5)

Andrea Rossato
Brent Yorgey
David Roundy
Don Stewart
Valery V. Vorotyntsev