U.Run.runProcessWithInputAndWait exceptions, dzenWithArgs
U.Run.runProcessWithInputAndWait calls waitForProcess and raises exceptions. I probably just should have filed a bug, but figured it's probably a quick fix for a real programmer, and byorgey seems to be on a contrib-patching extravaganza, so: http://www.moonpatio.com:8080/fastcgi/hpaste.fcgi/view?id=999 This mainly affects Hooks.UrgencyHook, although users may be using the dzenWithArgs functions in xmonad.hs Is is safe to simply remove waitForProcess from Util.Run.runProcessWithInputAndWait? Should dzenWithArgs do timeouts differently? (btw thanks Roman, Byorgey, et. al. for all the recent work) regards, wmw
On Tue, Jan 27, 2009 at 04:15:12PM -0700, wirtwolff wrote:
U.Run.runProcessWithInputAndWait calls waitForProcess and raises exceptions. I probably just should have filed a bug, but figured it's probably a quick fix for a real programmer, and byorgey seems to be on a contrib-patching extravaganza, so:
http://www.moonpatio.com:8080/fastcgi/hpaste.fcgi/view?id=999
Unfortunately, I know approximately nothing about processes, threads, etc. (well, I know enough to know I shouldn't touch such code) so someone else will have to look at this one...
(btw thanks Roman, Byorgey, et. al. for all the recent work)
You're welcome. =) -Brent
On Tue, Jan 27, 2009 at 04:15:12PM -0700, wirtwolff wrote:
U.Run.runProcessWithInputAndWait calls waitForProcess and raises exceptions. I probably just should have filed a bug, but figured it's probably a quick fix for a real programmer, and byorgey seems to be on a contrib-patching extravaganza, so:
http://www.moonpatio.com:8080/fastcgi/hpaste.fcgi/view?id=999
This mainly affects Hooks.UrgencyHook, although users may be using the dzenWithArgs functions in xmonad.hs Is is safe to simply remove waitForProcess from Util.Run.runProcessWithInputAndWait? Should dzenWithArgs do timeouts differently?
(btw thanks Roman, Byorgey, et. al. for all the recent work)
regards, wmw
Did this ever get submitted as a proper patch to contrib? If not, please do send one. Cheers, Spencer Janssen
Excerpts from Spencer Janssen's message of Fri Feb 20 10:08:10 -0700 2009:
On Tue, Jan 27, 2009 at 04:15:12PM -0700, wirtwolff wrote:
http://www.moonpatio.com:8080/fastcgi/hpaste.fcgi/view?id=999
Did this ever get submitted as a proper patch to contrib? If not, please do send one.
No, neither byorgey or I or anyone else apparently was confident removing it wouldn't create problems, but tested with dzenWithArgs and UrgencyHook and seems fine, patch sent. -- wmw
participants (4)
-
Brent Yorgey -
Spencer Janssen -
Wirt Wolff -
wirtwolff