Re: Issue 254 in xmonad: XMonad.Contrib.Util.Run.runInTerm does not work with terminal = "gnome-terminal"

Comment #6 on issue 254 by klu...@gmail.com: XMonad.Contrib.Util.Run.runInTerm does not work with terminal = "gnome-terminal" http://code.google.com/p/xmonad/issues/detail?id=254 I wrote a routine to double-quote and escape shell input, and it _seems_ to work for me. I've added it to Prompt.Ssh instead of changing runInTerm, but it logically belongs there. That is, I call ssh s = runInTerm "" (bashDblQuote ("ssh " ++ s)) where bashDblQuote is the quoting function. Attachments: dblquote.hs 866 bytes OtherSsh.hs 3.4 KB

Comment #7 on issue 254 by allbery.b: XMonad.Contrib.Util.Run.runInTerm does not work with terminal = "gnome-terminal" http://code.google.com/p/xmonad/issues/detail?id=254 I would say this is only correct as a sort of safeRunInTerm. The problem being, if you want to pass an actual shell command using builtins, multiple semicolon-separated commands, backgrounding, etc. then none of this will work and you will have to use "gnome-terminal -x" to get it to hand off the string to a shell for execution. (The current setup "just works" for most terminal programs; only gnome-terminal decided to do something incompatible with -e.)

Comment #8 on issue 254 by bryan.ri...@gmail.com: XMonad.Contrib.Util.Run.runInTerm does not work with terminal = "gnome-terminal" http://code.google.com/p/xmonad/issues/detail?id=254 I can't say how long this option has been around, but Ubuntu 12.04's gnome-terminal package includes a script named '/usr/bin/gnome-terminal.wrapper' that appears to map standard X arguments (-t, -e, -geometry, etc.) to gnome-terminal arguments. I think setting terminal = "gnome-terminal.wrapper" should clear up this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings

Comment #9 on issue 254 by denis.ka...@gmail.com: XMonad.Contrib.Util.Run.runInTerm does not work with terminal = "gnome-terminal" https://code.google.com/p/xmonad/issues/detail?id=254 This bit me on termite (https://github.com/thestinger/termite) as well since it also expects a single argument to -e. I had to write my own corrected safeRunInTerm' as a minimally invasive fix. It seems to me that passing arguments to exec individually in safeSpawn along with passing a single argument to -e in safeRunInTerm (as suggested in #5) is safer and cleaner semantically. Would this be an acceptable change in the API for the next version? If not, would you accept a patch adding such alternative versions of the functions? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings
participants (1)
-
codesite-noreply@google.com