darcs patch: change Dmenu functions to return IO/X (Maybe String)

Sat Oct 6 03:09:59 EDT 2007 Devin Mullins

On Saturday 06 October 2007 02:17:02 Devin Mullins wrote:
Sat Oct 6 03:09:59 EDT 2007 Devin Mullins
* change Dmenu functions to return IO/X (Maybe String) dmenu exits with code 1 when you hit Escape, and I wanna create a contrib that takes advantage of that. This required changes in four contribs (Commands, DirectoryPrompt, ShellPrompt, and WorkspaceDir), and might require changes in users' Configs. Also, I'm not sure some of the changes I made to the client code are very Haskelly. Would appreciate input there.
Applied.

On Sun, Oct 07, 2007 at 12:03:59AM -0500, Spencer Janssen wrote:
On Saturday 06 October 2007 02:17:02 Devin Mullins wrote:
Sat Oct 6 03:09:59 EDT 2007 Devin Mullins
* change Dmenu functions to return IO/X (Maybe String) dmenu exits with code 1 when you hit Escape, and I wanna create a contrib that takes advantage of that. This required changes in four contribs (Commands, DirectoryPrompt, ShellPrompt, and WorkspaceDir), and might require changes in users' Configs. Also, I'm not sure some of the changes I made to the client code are very Haskelly. Would appreciate input there.
Applied.
I don't think this is a useful patch: runProcessWithInpunt was a useful function that returned a String. Checking for an empty string was enough. Sounds to me very much like a Maybe [String]. Just my 2 cents. Andrea

On Sun, Oct 07, 2007 at 08:37:52AM +0200, Andrea Rossato wrote:
I don't think this is a useful patch: runProcessWithInpunt was a useful function that returned a String. Checking for an empty string was enough.
Actually, Andrea conviced me on #xmonad. If there's consensus, I'll send a reverse patch. :)
participants (3)
-
Andrea Rossato
-
Devin Mullins
-
Spencer Janssen