[patch] EwmhDesktops: make setActiveWindow set _NET_WM_STATE for gtk-3.4

Hi, I am not an expert on EWMH but this change seems to be necessary for coming GTK 3.4, when using themes like Adwaita, that now supports @theme_unfocused_fg_color which causes unfocused application's UI to be rendered unfocused in addition to the normal unfocused window manager decoration. Current desktopConfig triggers this causing all Gtk3 apps to be rendered as unfocused. Anyway I would appreciate review of this patch and feedback: perhaps there is a better more correct fix? I am planning to apply a patch for this shortly to Fedora 17 xmonad-contrib, otherwise GTK apps in gnomeConfig etc look terrible. There are more technical details in the changelog. I haven't found any other window manager that triggers this issue yet. Jens

On Mon, Mar 12, 2012 at 7:11 AM, Jens Petersen
Hi,
I am not an expert on EWMH but this change seems to be necessary for coming GTK 3.4, when using themes like Adwaita, that now supports @theme_unfocused_fg_color which causes unfocused application's UI to be rendered unfocused in addition to the normal unfocused window manager decoration. Current desktopConfig triggers this causing all Gtk3 apps to be rendered as unfocused.
Anyway I would appreciate review of this patch and feedback: perhaps there is a better more correct fix? I am planning to apply a patch for this shortly to Fedora 17 xmonad-contrib, otherwise GTK apps in gnomeConfig etc look terrible. There are more technical details in the changelog. I haven't found any other window manager that triggers this issue yet.
Does anyone have any thoughts on this? -- gwern http://www.gwern.net

On Wed, Mar 21, 2012 at 19:49, Gwern Branwen
Does anyone have any thoughts on this?
Technically we should also be setting _NET_WM_STATE_FOCUSED for focused windows and removing that atom when the windowe loses focus (this is a recent revision to EWMH; it didn't exist when EWMHDesktops was originally written). It would be interesting to see if doing so fixes any of the other occasional odd behaviors that get reported. -- brandon s allbery allbery.b@gmail.com wandering unix systems administrator (available) (412) 475-9364 vm/sms

Hi, Am Mittwoch, den 21.03.2012, 20:11 -0400 schrieb Brandon Allbery:
On Wed, Mar 21, 2012 at 19:49, Gwern Branwen
wrote: Does anyone have any thoughts on this? Technically we should also be setting _NET_WM_STATE_FOCUSED for focused windows and removing that atom when the windowe loses focus (this is a recent revision to EWMH; it didn't exist when EWMHDesktops was originally written). It would be interesting to see if doing so fixes any of the other occasional odd behaviors that get reported.
I tested this here, and just ensuring that _NET_WM_STATE exists did not seem to make a difference. The proper solution, as I gather from reading the mutter source, seems to be * Include _NET_WM_STATE_FOCUSED in _NET_SUPPORTED * For the active window, edit the list _NET_WM_STATE and include _NET_WM_STATE_FOCUSED (just appending will keep enlarging the list) * For other windows, remove it from the list. Greetings, Joachim -- Joachim "nomeata" Breitner Debian Developer nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata
participants (4)
-
Brandon Allbery
-
Gwern Branwen
-
Jens Petersen
-
Joachim Breitner