[PATCH] * Allow to limit maximum row count in X.Prompt completion window
Hi, -- Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software! mailto:fercerpav@gmail.com
I guess the new field should be set in defaultXPConfig. Whoever pushes
this patch can certainly do that.
I'm not a user of Prompt myself; is adding a field going to break
existing configs? (Do most people start from defaultXPConfig or one of
the other pre-defined configs, or do some people build the record from
scratch manually?)
~d
Quoting Paul Fertser
Hi,
-- Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software! mailto:fercerpav@gmail.com
On Thu, Feb 21, 2013 at 02:01:41PM -0500, wagnerdm@seas.upenn.edu wrote:
I guess the new field should be set in defaultXPConfig. Whoever pushes this patch can certainly do that.
I thought my patch already does that, giving Nothing by default, so it shouldn't break any existing configs. -- Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software! mailto:fercerpav@gmail.com
Quoting Paul Fertser
On Thu, Feb 21, 2013 at 02:01:41PM -0500, wagnerdm@seas.upenn.edu wrote:
I guess the new field should be set in defaultXPConfig. Whoever pushes this patch can certainly do that.
I thought my patch already does that, giving Nothing by default, so it shouldn't break any existing configs.
It does; I just read the patch incorrectly. Apologies. Following Gwern's search, I've pushed the patch. Thanks! ~d
On Thu, Feb 21, 2013 at 2:01 PM,
I'm not a user of Prompt myself; is adding a field going to break existing configs? (Do most people start from defaultXPConfig or one of the other pre-defined configs, or do some people build the record from scratch manually?)
Using my copy of the config archive (last updated a year ago or something, I should probably rerun the script), I don't think there are any direct users of the record. Grepping ' XPConfig {' and `grep 'XPConfig' *|grep -v 'default'` don't seem to turn up anything. This came up recently with a patch that I pushed, didn't it? I seem to recall running these searches sometime in the past few months, anyway. (Of course there could be uncontributed configs which do it. If so, they can pretty much go pound salt. We've been clear in the past that we use the config archive (http://www.haskell.org/haskellwiki/Xmonad/Config_archive) for making API and other coding decisions like this.) -- gwern http://www.gwern.net
This 1-patch bundle was just applied to http://code.haskell.org/XMonadContrib:
20130221122050 Paul Fertser
participants (4)
-
darcswatch＠nomeata.de -
Gwern Branwen -
Paul Fertser -
wagnerdm＠seas.upenn.edu