[patch] ppUrgent behaviour in X.H.DynamicLog

Hi, I wrote this little patch, see the detailed comments for more. Nils

I'd like to see this patch included in 0.9. This address a common problem in
a variety of situations, and if the current behavior is desired it's trivial
to implement in your xmonad.hs on top of this patch, unlike the opposite
where all kinds of filtering is required to remove the ppUrgent and ppHidden
composition. There was also talk in the xmonad IRC channel about other
possible chages to DynamicLog that might want to be considered along with
this change. I know I'm not alone in including some hackery in my xmonad.hs
specifically designed to address this issue, and it's common enough that a
couple helper functions have already made it in (in the form of dzenStrip
and xmobarStrip), and it would be nice to not have to resort to such things.
On Wed, Sep 9, 2009 at 9:32 PM, Nils
Hi,
I wrote this little patch, see the detailed comments for more.
Nils
_______________________________________________ xmonad mailing list xmonad@haskell.org http://www.haskell.org/mailman/listinfo/xmonad

Is there a reason why this patch didnt get applied yet? On Thu, Sep 10, 2009 at 03:32:16AM +0200, Nils wrote:
Hi,
I wrote this little patch, see the detailed comments for more.
Nils
Thu Sep 10 03:04:11 CEST 2009 mail@n-sch.de * Changing behaviour of ppUrgent with X.H.DynamicLog
Currently, the ppUrgent method is an addition to the ppHidden method. This doesn't make any sense since it is in fact possible to get urgent windows on the current and visible screens. So I've raised the ppUrgent printer to be above ppCurrent/ppVisible and dropped its dependency on ppHidden.
In addition to that this makes it a lot more easier to define a more custom ppUrgent printer, since you don't have to "undo" the ppHidden printer anymore. This also basicly removes the need for dzenStrip, although I just changed the description.
-- McManiaC / Nils

On Thu, Sep 10, 2009 at 03:32:16AM +0200, Nils wrote:
Hi,
I wrote this little patch, see the detailed comments for more.
Nils
Thu Sep 10 03:04:11 CEST 2009 mail@n-sch.de * Changing behaviour of ppUrgent with X.H.DynamicLog
Currently, the ppUrgent method is an addition to the ppHidden method. This doesn't make any sense since it is in fact possible to get urgent windows on the current and visible screens. So I've raised the ppUrgent printer to be above ppCurrent/ppVisible and dropped its dependency on ppHidden.
In addition to that this makes it a lot more easier to define a more custom ppUrgent printer, since you don't have to "undo" the ppHidden printer anymore. This also basicly removes the need for dzenStrip, although I just changed the description.
-- McManiaC / Nils
Applied, thanks.
participants (4)
-
Kyle Murphy
-
Nils
-
Nils
-
Spencer Janssen