darcs patch: NS_Placement (and 1 more)

Tue Apr 28 15:27:31 EDT 2009 konstantin.sobolev@gmail.com * NS_Placement Added ability to specify scratchpad manage hooks, mostly for defining window placement in a more flexible manner Tue Apr 28 16:01:36 EDT 2009 konstantin.sobolev@gmail.com * ScratchpadRewrite Scratchpad reimplementation in terms of NamedScratchpad. No interface changes.

This looks good, but I'm wondering whether NamedScratchpad should have to prefix everything in the new module with 'named'. IMHO, Scratchpad has long enough identifiers already. Ex:
namedScratchpadFilterOutWorkspace
I suggest at least dropping the 'named' from the functions in NamedScratchpad because you can import NamedScratchpad qualified to implement Scratchpad, and because I can't see people using both at once (in which case they can import qualified too). Adam * On Tuesday, April 28 2009, konstantin.sobolev@gmail.com wrote:
Tue Apr 28 15:27:31 EDT 2009 konstantin.sobolev@gmail.com * NS_Placement Added ability to specify scratchpad manage hooks, mostly for defining window placement in a more flexible manner
Tue Apr 28 16:01:36 EDT 2009 konstantin.sobolev@gmail.com * ScratchpadRewrite Scratchpad reimplementation in terms of NamedScratchpad. No interface changes.
_______________________________________________ xmonad mailing list xmonad@haskell.org http://www.haskell.org/mailman/listinfo/xmonad

I'll shut up after this, but why have two modules, why not just have Util.Scratchpad with all this stuff in it? shepheb, anyone else object to that, aside from that it would mean deleting an existing module (NamedScratchpad)? It's so new that doesn't seem like a big deal to me. Just seems to me that they are so much the same that that having everything in mone module would be best. -- wmw

On Tue, Apr 28, 2009 at 11:58 PM, Wirt Wolff
I'll shut up after this, but why have two modules, why not just have Util.Scratchpad with all this stuff in it? shepheb, anyone else object to that, aside from that it would mean deleting an existing module (NamedScratchpad)? It's so new that doesn't seem like a big deal to me. Just seems to me that they are so much the same that that having everything in mone module would be best.
OK, I was trying to avoid NamedScratchpad clashing with the Scratchpad and to keep Scratchpad API. Many people use it I think, I wouldn't like to break their configs. So what should I do now, keep them as 2 modules but make all NamedScrathpad functions shorter, merge them into one Scratchpad module and keep NS functions prefixed with 'named' or something else? I don't have my own preference.

On Wed, Apr 29, 2009 at 10:43 AM, Konstantin Sobolev
On Tue, Apr 28, 2009 at 11:58 PM, Wirt Wolff
wrote: I'll shut up after this, but why have two modules, why not just have Util.Scratchpad with all this stuff in it? shepheb, anyone else object to that, aside from that it would mean deleting an existing module (NamedScratchpad)? It's so new that doesn't seem like a big deal to me. Just seems to me that they are so much the same that that having everything in mone module would be best.
OK, I was trying to avoid NamedScratchpad clashing with the Scratchpad and to keep Scratchpad API. Many people use it I think, I wouldn't like to break their configs. So what should I do now, keep them as 2 modules but make all NamedScrathpad functions shorter, merge them into one Scratchpad module and keep NS functions prefixed with 'named' or something else? I don't have my own preference.
So, any suggestions on this one? Keep 2 modules and make NS names shorter, squeeze them into one, or may be something else?
participants (4)
-
Adam Vogt
-
Konstantin Sobolev
-
konstantin.sobolev@gmail.com
-
Wirt Wolff