darcs patch: Decoration.hs: removed redraw in case of... (and 1 more)

Hi,
the first patch remove from Decoration a call to redraw the decoration
windows in case of a propertyNotify event for the window they are a
decoration for.
I don't know if there are reasons for it - I did not find any, in
which case I think it is superfluous and can lead to unwanted results.
David, am I right?
The second one follow the patch David sent for XPrompt: here we have
the same problem.
Andrea
Wed Aug 8 11:49:27 CEST 2007 Andrea Rossato

On Fri, Aug 10, 2007 at 08:30:40PM +0200, Andrea Rossato wrote:
Hi,
the first patch remove from Decoration a call to redraw the decoration windows in case of a propertyNotify event for the window they are a decoration for.
I don't know if there are reasons for it - I did not find any, in which case I think it is superfluous and can lead to unwanted results. David, am I right?
I think this is in here so that we'd redraw the tab when a window title changes, so I think it should stay.
The second one follow the patch David sent for XPrompt: here we have the same problem.
This one looks good. -- David Roundy Department of Physics Oregon State University

On Fri, Aug 10, 2007 at 12:20:31PM -0700, David Roundy wrote:
On Fri, Aug 10, 2007 at 08:30:40PM +0200, Andrea Rossato wrote:
I don't know if there are reasons for it - I did not find any, in which case I think it is superfluous and can lead to unwanted results. David, am I right?
I think this is in here so that we'd redraw the tab when a window title changes, so I think it should stay.
Yes indeed. I noticed a strange behavior when a propertyNotify event is sent to the rood window and then propagated (BadGC and BadDrawable warnings generated inside withGC). I will try to further investigate. Sorry. Andrea

On Friday 10 August 2007 13:30:40 Andrea Rossato wrote:
Hi,
the first patch remove from Decoration a call to redraw the decoration windows in case of a propertyNotify event for the window they are a decoration for.
I don't know if there are reasons for it - I did not find any, in which case I think it is superfluous and can lead to unwanted results. David, am I right?
The second one follow the patch David sent for XPrompt: here we have the same problem.
Andrea
Wed Aug 8 11:49:27 CEST 2007 Andrea Rossato
* Decoration.hs: removed redraw in case of a propertyNotify event There is no reason to redraw the decoration window when a propertyNotify is send to the decoreted window.
Didn't apply this one, it interferes with window title updates? Please correct me if I'm wrong.
Fri Aug 10 20:24:33 CEST 2007 Andrea Rossato
* Decoration: don't crash when given a non-existent font
Applied this one.
participants (3)
-
Andrea Rossato
-
David Roundy
-
Spencer Janssen