darcs patch: avoid Data.Ratio and % operator in XMonad.Config

This was inspired by a difficulty I observed by a Haskell newbie
trying to configure xmonad. No reason to import this % operator
that I can see.
David
Sun Nov 11 10:37:08 PST 2007 David Roundy

On 11/11/07, David Roundy
This was inspired by a difficulty I observed by a Haskell newbie trying to configure xmonad. No reason to import this % operator that I can see.
David
Sun Nov 11 10:37:08 PST 2007 David Roundy
* avoid Data.Ratio and % operator in XMonad.Config I think this'll make Config.hs more friendly as a template for folks to modify.
Probably. As for me, I prefer rational numbers. Compare `755%1024' with `0.7373046875'. :) -- vvv

droundy:
This was inspired by a difficulty I observed by a Haskell newbie trying to configure xmonad. No reason to import this % operator that I can see.
David
Sun Nov 11 10:37:08 PST 2007 David Roundy
* avoid Data.Ratio and % operator in XMonad.Config I think this'll make Config.hs more friendly as a template for folks to modify.
I'm not so sure about this David (particularly for pixel sizes). Do you have the logs of the user errors? Or a description of what went wrong? -- Don

On Sun, Nov 11, 2007 at 12:16:32PM -0800, Don Stewart wrote:
I'm not so sure about this David (particularly for pixel sizes). Do you have the logs of the user errors? Or a description of what went wrong? It happened in #xmonad, when delaril wanted to modify the list of layouts, and copied from Config.hs (or perhaps one of the example configs in the wiki, I forget) as a place to start.
Perhaps a re-export would be an answer, here. Perhaps some methods to addLayout and removeLayout, if that's feasible.

On Sunday 11 November 2007 12:38:24 David Roundy wrote:
This was inspired by a difficulty I observed by a Haskell newbie trying to configure xmonad. No reason to import this % operator that I can see.
David
Sun Nov 11 10:37:08 PST 2007 David Roundy
* avoid Data.Ratio and % operator in XMonad.Config I think this'll make Config.hs more friendly as a template for folks to modify.
Applied. For all those concerned with this patch: note that the types have not changed from Rational, we're merely constructing them with overloaded numeric literals rather than (%). I agree with David that (%) is more complicated than necessary here. Cheers, Spencer Janssen
participants (5)
-
David Roundy
-
Devin Mullins
-
Don Stewart
-
Spencer Janssen
-
Valery V. Vorotyntsev