
Hi, It looks like the way Yhc version is determined prevents usage of tarballs created by darcs dist. In the file "version.py" there is a line count of the "inventory" file to count number of patches and thus determine the version of Yhc. Thus, if buiding from a dist tarball, _darcs is not there, nor is inventory, and scons build fails. OTOH I never really saw Yhc printing its version: it always says (unversioned). So is there any need to keep this logic in version.py, or maybe it might be at least conditional upon the presence of the inventory file. Thanks. PS I hope someone maintaining the python part could fix this quickly. Otherwise I'll try to take care of it myself, but I am not a python expert. -- Dimitry Golubovsky Anywhere on the Web

Dimitry, I certainly don't know Python! The version.py sets the version, but should set unversioned unless it is doing a buildbot build - on the basis that a buildbot build is a "releaseable" version, but all others are custom made. A simple 'file exists' check before reading the inventory and a default of 1 (or something) would be fine.
It looks like the way Yhc version is determined prevents usage of tarballs created by darcs dist.
In the file "version.py" there is a line count of the "inventory" file to count number of patches and thus determine the version of Yhc.
Thus, if buiding from a dist tarball, _darcs is not there, nor is inventory, and scons build fails.
OTOH I never really saw Yhc printing its version: it always says (unversioned).
So is there any need to keep this logic in version.py, or maybe it might be at least conditional upon the presence of the inventory file.
Thanks.
PS I hope someone maintaining the python part could fix this quickly. Otherwise I'll try to take care of it myself, but I am not a python expert.
Ah, maintainers for the build system, how I long for those days! Thanks Neil

Neil,
Well, that's not so critical to me, just an observation I made trying
to use darcs dist created tarball. I'd put in on medium priority: next
time I need the tarball, and it is not fixed, I'll try to fix it
myself.
Thanks.
On 2/25/08, Neil Mitchell
are custom made. A simple 'file exists' check before reading the inventory and a default of 1 (or something) would be fine.
-- Dimitry Golubovsky Anywhere on the Web

Dimitry,
Feel free to open a bug on it - its an easy fix that someone without
any Haskell knowledge could make.
Thanks
Neil
On Mon, Feb 25, 2008 at 2:01 PM, Dimitry Golubovsky
Neil,
Well, that's not so critical to me, just an observation I made trying to use darcs dist created tarball. I'd put in on medium priority: next time I need the tarball, and it is not fixed, I'll try to fix it myself.
Thanks.
On 2/25/08, Neil Mitchell
wrote: are custom made. A simple 'file exists' check before reading the inventory and a default of 1 (or something) would be fine.
-- Dimitry Golubovsky
Anywhere on the Web
participants (2)
-
Dimitry Golubovsky
-
Neil Mitchell