January 2009 - cabal-devel

Re: [Hackage] #93: Incorrect permissions on library install
by Hackage 30 Jan '09

30 Jan '09

#93: Incorrect permissions on library install ----------------------------+----------------------------------------------- Reporter: guest | Owner: Type: defect | Status: closed Priority: normal | Milestone: Cabal-1.8 Component: Cabal library | Version: 1.1.4 Severity: normal | Resolution: fixed Keywords: | Difficulty: normal Ghcversion: 6.4.2 | Platform: Linux ----------------------------+----------------------------------------------- Changes (by duncan): * status: new => closed * resolution: => fixed Comment: Fixed in cabal head and the 1.6 branch. The behavior now when installing is that we ignore the permissions the files had in the build tree and the user's umask. We explicitly set permissions for all files we install. The only inconsistency is that we're not yet setting the permissions of directories we create when installing. So they currently inherit the umask of the installing user. In the case in this bug that will work fine. -- Ticket URL: <http://hackage.haskell.org/trac/hackage/ticket/93#comment:7> Hackage <http://haskell.org/cabal/> Hackage: Cabal and related projects

1 0

Re: Bug in Cabal?
by Duncan Coutts 30 Jan '09

30 Jan '09

On Wed, 2009-01-28 at 13:13 +0000, Duncan Coutts wrote: > The solution I think, is never to copy the read-only attribute when > installing files. It's thoroughly unhelpful. I've got a patch to do this > which I shall push to Cabal HEAD shortly. If you have a moment to help > me test that it would be much appreciated. I've attached a darcs patch against the Cabal-1.6 branch (rather than the head branch). darcs get --partial http://darcs.haskell.org/cabal-branches/cabal-1.6/ If you or anyone else can test it on Windows that'd be great. I checked it by setting the read-only attribute on a LICENSE file and where previously the attribute would get copied (preventing further re-installs) it is now not copied. On Unix it should solve this problem: http://hackage.haskell.org/trac/hackage/ticket/93 Though I've not tested that yet. The patch for the 1.6 branch is fairly minimal and doesn't change any API. In Cabal HEAD I'll do it slightly differently so that the code is more consistent and comprehensible, but it involves api changes to exposed utility functions. Duncan

1 1

patch applied (cabal-branches/cabal-1.6): Make the Compat.CopyFile module with with old and new ghc
by Duncan Coutts 30 Jan '09

30 Jan '09

Thu Jan 29 14:54:23 PST 2009 Duncan Coutts <duncan(a)haskell.org> * Make the Compat.CopyFile module with with old and new ghc M ./Distribution/Compat/CopyFile.hs -9 +26 View patch online: http://darcs.haskell.org/cabal-branches/cabal-1.6/_darcs/patches/2009012922…

1 0

patch applied (cabal-branches/cabal-1.6): Export setFileOrdinary and setFileExecutable from Compat.CopyFile
by Duncan Coutts 30 Jan '09

30 Jan '09

Thu Jan 29 09:34:13 PST 2009 Duncan Coutts <duncan(a)haskell.org> * Export setFileOrdinary and setFileExecutable from Compat.CopyFile M ./Distribution/Compat/CopyFile.hs -10 +10 View patch online: http://darcs.haskell.org/cabal-branches/cabal-1.6/_darcs/patches/2009012917…

1 0

patch applied (cabal-branches/cabal-1.6): Use copyOrdinaryFile and copyExecutableFile instead of copyFile
by Duncan Coutts 30 Jan '09

30 Jan '09

Wed Jan 28 11:41:43 PST 2009 Duncan Coutts <duncan(a)haskell.org> * Use copyOrdinaryFile and copyExecutableFile instead of copyFile This is a minimal patch for the Cabal-1.6 branch only. M ./Distribution/Simple/GHC.hs -1 +8 M ./Distribution/Simple/Haddock.hs -2 +3 M ./Distribution/Simple/Utils.hs -2 +4 View patch online: http://darcs.haskell.org/cabal-branches/cabal-1.6/_darcs/patches/2009012819…

1 0

patch applied (cabal-branches/cabal-1.6): Add Distribution.Compat.CopyFile module
by Duncan Coutts 30 Jan '09

30 Jan '09

Wed Jan 28 10:11:15 PST 2009 Duncan Coutts <duncan(a)haskell.org> * Add Distribution.Compat.CopyFile module This is to work around the file permissions problems with the standard System.Directory.copyFile function. When installing files we do not want to copy permissions or attributes from the source files. On unix we want to use specific permissions and on windows we want to inherit default permissions. On unix: copyOrdinaryFile sets the permissions to -rw-r--r-- copyExecutableFile sets the permissions to -rwxr-xr-x M ./Cabal.cabal +1 A ./Distribution/Compat/CopyFile.hs M ./Makefile -1 +1 View patch online: http://darcs.haskell.org/cabal-branches/cabal-1.6/_darcs/patches/2009012818…

1 0

patch applied (cabal): Misc minor comment and help message changes
by Duncan Coutts 30 Jan '09

30 Jan '09

Thu Jan 29 15:34:55 PST 2009 Duncan Coutts <duncan(a)haskell.org> * Misc minor comment and help message changes M ./Distribution/PackageDescription/Check.hs -5 M ./Distribution/Simple/NHC.hs -1 +1 M ./Distribution/Simple/Setup.hs -1 +1 View patch online: http://darcs.haskell.org/cabal/_darcs/patches/20090129233455-adfee-e4f2bfa4…

1 0

patch applied (cabal): Deprecate smartCopySources and copyDirectoryRecursiveVerbose
by Duncan Coutts 30 Jan '09

30 Jan '09

Thu Jan 29 15:32:34 PST 2009 Duncan Coutts <duncan(a)haskell.org> * Deprecate smartCopySources and copyDirectoryRecursiveVerbose Also use simplified implementation in terms of recently added functions. M ./Distribution/Simple/Utils.hs -39 +12 View patch online: http://darcs.haskell.org/cabal/_darcs/patches/20090129233234-adfee-ba3894e8…

1 0

patch applied (cabal): Switch copyFileVerbose to use compat copyFile
by Duncan Coutts 30 Jan '09

30 Jan '09

Thu Jan 29 15:31:25 PST 2009 Duncan Coutts <duncan(a)haskell.org> * Switch copyFileVerbose to use compat copyFile All remaining uses of it do not require copying permissions M ./Distribution/Simple/Utils.hs -2 +2 View patch online: http://darcs.haskell.org/cabal/_darcs/patches/20090129233125-adfee-fb8eaa3a…

1 0

patch applied (cabal): Let the setFileExecutable function work with hugs too
by Duncan Coutts 30 Jan '09

30 Jan '09

Thu Jan 29 15:29:48 PST 2009 Duncan Coutts <duncan(a)haskell.org> * Let the setFileExecutable function work with hugs too M ./Distribution/Compat/CopyFile.hs -1 +1 View patch online: http://darcs.haskell.org/cabal/_darcs/patches/20090129232948-adfee-b1a6b2ac…

1 0