August 2011 - cabal-devel

patch applied (/home/srv/code/hackage-server): "Rename the server Config to ServerEnv to reduce confusion"
by duncan＠lun.haskell.org 12 Aug '11

12 Aug '11

Sun Aug 7 21:33:37 BST 2011 Duncan Coutts <duncan(a)community.haskell.org> * Rename the server Config to ServerEnv to reduce confusion Ignore-this: 177124869e8dcb6368eedd4c3602c76d M ./Distribution/Server.hs -10 +11 M ./Distribution/Server/Features.hs -21 +20 M ./Distribution/Server/Features/BuildReports.hs -3 +3 M ./Distribution/Server/Features/Check.hs -3 +3 M ./Distribution/Server/Features/Core.hs -2 +3 M ./Distribution/Server/Features/Distro.hs -1 +1 M ./Distribution/Server/Features/Documentation.hs -3 +4 M ./Distribution/Server/Features/DownloadCount.hs -1 +1 M ./Distribution/Server/Features/HaskellPlatform.hs -1 +1 M ./Distribution/Server/Features/Html.hs -3 +3 M ./Distribution/Server/Features/Mirror.hs -3 +3 M ./Distribution/Server/Features/NameSearch.hs -3 +3 M ./Distribution/Server/Features/PackageList.hs -1 +1 M ./Distribution/Server/Features/Packages.hs -1 +1 M ./Distribution/Server/Features/PreferredVersions.hs -1 +1 M ./Distribution/Server/Features/ReverseDependencies.hs -1 +1 M ./Distribution/Server/Features/StaticFiles.hs -3 +3 M ./Distribution/Server/Features/Tags.hs -1 +1 M ./Distribution/Server/Features/Upload.hs -3 +3 M ./Distribution/Server/Features/Users.hs -1 +1 M ./Distribution/Server/Framework/Types.hs -3 +25

1 0

patch applied (/home/srv/code/hackage-server): "Un-hardcode the "/tmp" directory." and 35 others
by duncan＠lun.haskell.org 12 Aug '11

12 Aug '11

Fri Jul 22 19:33:15 BST 2011 David Lazar <lazar6(a)illinois.edu> * Un-hardcode the "/tmp" directory. Ignore-this: d9be80c40935d2407e3c3cfdd78495b9 M ./Distribution/Server.hs -1 +2 Fri Jul 22 19:47:11 BST 2011 David Lazar <lazar6(a)illinois.edu> * Fix minor layout issue. Ignore-this: b28272a0634254d47f4af55966b9a8fb M ./Distribution/Server.hs -2 +2 Fri Jul 22 20:15:27 BST 2011 David Lazar <lazar6(a)illinois.edu> * Delete todo comment about hardcoded /tmp. Ignore-this: 5a8c59628c6c5aaf107e65b041bb5592 M ./Distribution/Server.hs -1 +1 Fri Jul 22 20:17:19 BST 2011 David Lazar <lazar6(a)illinois.edu> * Add missing word in upload notes. Ignore-this: 8b84bd4104069b7fb92c78bf53cacec2 M ./static/upload.html -1 +1 Fri Jul 22 21:42:41 BST 2011 Jeremy Shaw <jeremy(a)seereason.com> * migrate from happstack-data/happstack-state to safecopy/acid-state Ignore-this: 9daef014eb49d9efeeb337960016e6ad M ./Data/IntTrie.hs -6 +3 M ./Data/StringTable.hs -6 +3 M ./Data/TarIndex.hs -15 +5 M ./Distribution/Server.hs -14 +11 M ./Distribution/Server/Auth/Types.hs -8 +5 M ./Distribution/Server/BuildReport/Backup.hs -1 +1 M ./Distribution/Server/BuildReport/BuildReports.hs -14 +14 M ./Distribution/Server/BuildReport/State.hs -43 +29 M ./Distribution/Server/Distributions/Backup.hs -1 +1 M ./Distribution/Server/Distributions/State.hs -9 +8 M ./Distribution/Server/Distributions/Types.hs -14 +6 M ./Distribution/Server/Features/Check.hs -1 +1 M ./Distribution/Server/Features/Core.hs -1 +1 M ./Distribution/Server/Features/Distro.hs -1 +1 M ./Distribution/Server/Features/Documentation.hs -1 +1 M ./Distribution/Server/Features/DownloadCount.hs -1 +1 M ./Distribution/Server/Features/HaskellPlatform.hs -2 +1 M ./Distribution/Server/Features/Html.hs -1 +1 M ./Distribution/Server/Features/Mirror.hs -2 +1 M ./Distribution/Server/Features/NameSearch.hs -1 +1 M ./Distribution/Server/Features/PackageList.hs -2 +1 M ./Distribution/Server/Features/Packages.hs -1 +1 M ./Distribution/Server/Features/PreferredVersions.hs -1 +1 M ./Distribution/Server/Features/Reports.hs -1 +1 M ./Distribution/Server/Features/ReverseDependencies.hs -1 +1 M ./Distribution/Server/Features/Tags.hs -1 +1 M ./Distribution/Server/Features/Upload.hs -1 +1 M ./Distribution/Server/Features/Users.hs -1 +1 M ./Distribution/Server/Instances.hs -44 +21 M ./Distribution/Server/Packages/Backup.hs -2 +1 M ./Distribution/Server/Packages/Backup/Tags.hs -1 +1 M ./Distribution/Server/Packages/Downloads.hs -15 +11 M ./Distribution/Server/Packages/Platform.hs -12 +10 M ./Distribution/Server/Packages/Preferred.hs -20 +17 M ./Distribution/Server/Packages/Reverse.hs -18 +14 M ./Distribution/Server/Packages/State.hs -96 +57 M ./Distribution/Server/Packages/Tag.hs -20 +17 M ./Distribution/Server/Packages/Types.hs -22 +22 R ./Distribution/Server/State.hs M ./Distribution/Server/Users/Backup.hs -4 +9 M ./Distribution/Server/Users/Group.hs -9 +8 M ./Distribution/Server/Users/State.hs -42 +33 M ./Distribution/Server/Users/Types.hs -18 +11 M ./Distribution/Server/Users/Users.hs -3 +3 M ./Distribution/Server/Util/BlobStorage.hs -2 +2 M ./Distribution/Server/Util/NameIndex.hs -7 +2 M ./Distribution/Server/Util/TarIndex.hs -10 +6 M ./hackage-server.cabal -4 +5 Fri Jul 22 22:23:58 BST 2011 Jeremy Shaw <jeremy(a)seereason.com> * added missing Distribution.Server.Acid Ignore-this: 1692c0b788ec2f0efd697e8c3c0c3772 A ./Distribution/Server/Acid.hs Fri Jul 22 23:24:57 BST 2011 David Lazar <lazar6(a)illinois.edu> * Fix mungeRequest (thanks to Jeremy). Ignore-this: 72483da60ccf900e5fcb6ae66652e71d M ./Distribution/Server.hs -1 +1 Sat Jul 23 00:46:23 BST 2011 Thomas.DuBuisson(a)gmail.com * Fix the tags edit capability Ignore-this: e0ed903d62b6f067ab4ddb0a05afe45f M ./Distribution/Server/Features/Html.hs -5 +20 M ./Distribution/Server/Features/Tags.hs +2 Sat Jul 23 01:16:14 BST 2011 David Lazar <lazar6(a)illinois.edu> * Improve deprecation form. Ignore-this: ebcd1fff01fecf29366108f024f959c3 M ./Distribution/Server/Features/Html.hs -3 +3 Sat Jul 23 01:16:35 BST 2011 Duncan Coutts <duncan(a)well-typed.com> * Change how we handle exceptions that result in error pages Ignore-this: 7ebf7080445454ec9e252f8529e3dd0f Instead of returning (Either ErrorResponse a) everywhere, use an error monad layered on top of ServerPartT. So now we can throw ErrorResponse as exceptions and not clutter up the code with error checking. We can also still do nicely formatted html error pages by using an exception handler. M ./Distribution/Server/Auth/Basic.hs -18 +15 M ./Distribution/Server/Error.hs -56 +89 M ./Distribution/Server/Features/Check.hs -50 +42 M ./Distribution/Server/Features/Core.hs -23 +23 M ./Distribution/Server/Features/Documentation.hs -15 +16 M ./Distribution/Server/Features/Html.hs -102 +99 M ./Distribution/Server/Features/LegacyRedirects.hs -6 +3 M ./Distribution/Server/Features/PreferredVersions.hs -16 +16 M ./Distribution/Server/Features/Reports.hs -35 +64 M ./Distribution/Server/Features/Tags.hs -3 +3 M ./Distribution/Server/Features/Upload.hs -23 +20 M ./Distribution/Server/Features/Users.hs -32 +32 M ./Distribution/Server/Util/ActionLog.hs -2 +2 M ./Distribution/Server/Util/Happstack.hs -2 +2 M ./Distribution/Server/Util/Serve.hs -3 +4 Sat Jul 23 05:17:23 BST 2011 Thomas.DuBuisson(a)gmail.com * Fix build error, probably from the Either/Error patch Ignore-this: b5eb91ea00e0d139d0a92042454ab4d6 M ./Distribution/Server/Util/Happstack.hs -1 +2 Sat Jul 23 10:47:42 BST 2011 Duncan Coutts <duncan(a)well-typed.com> * Clarify the top level quota stuff and the http method hack Ignore-this: c4c671221a799a3b63a2b712678a2d3d M ./Distribution/Server.hs -20 +36 Sat Jul 23 10:48:44 BST 2011 Duncan Coutts <duncan(a)well-typed.com> * Add a TODO about clean shutdowns Ignore-this: 942ce02c27c447188250df0b59e6da7e M ./Distribution/Server.hs +2 Sat Jul 23 10:49:14 BST 2011 Duncan Coutts <duncan(a)well-typed.com> * Add consumeRequestBody utility and use it to replace takeRequestBody Ignore-this: a380baaad71e7236b075e18609c65476 It simplifies the error handling. M ./Distribution/Server/Features/Distro.hs -7 +5 M ./Distribution/Server/Features/Documentation.hs -8 +6 M ./Distribution/Server/Features/Reports.hs -18 +13 M ./Distribution/Server/Util/Happstack.hs -1 +16 Sat Jul 23 11:28:51 BST 2011 Duncan Coutts <duncan(a)well-typed.com> * Fix to the user group editor resource: fix removal of users Ignore-this: 84df907391174af1fd500f046d4c829f The groupResourceAt function makes a user group into a resource. It was not handling the remove correctly. M ./Distribution/Server/Features/Users.hs -1 +1 Sat Jul 23 17:58:29 BST 2011 Duncan Coutts <duncan(a)well-typed.com> * Fix the 401 not authorised response in the basic & digest auth code Ignore-this: 10d776ccffa2aeaa99a3f285372b4665 M ./Distribution/Server/Auth/Basic.hs -1 +1 M ./Distribution/Server/Error.hs -3 +3 Sat Jul 23 22:18:04 BST 2011 Duncan Coutts <duncan(a)well-typed.com> * Allow listing specific packages to mirror on the command line Ignore-this: 5cf915250f68b74786f842251905f3bf ./MirrorMain.hs -> ./MirrorClient.hs M ./MirrorClient.hs -11 +40 M ./hackage-server.cabal -1 +1 Sat Jul 23 20:55:32 BST 2011 David Lazar <lazar6(a)illinois.edu> * Prevent packages from being deprecated in favor of themselves. Ignore-this: 12fd7511b1e486dd54e8cc9be1884dd5 M ./Distribution/Server/Features/PreferredVersions.hs -3 +5 Sat Jul 23 22:25:56 BST 2011 Thomas.DuBuisson(a)gmail.com * Calculate the immutable tags on package upload Ignore-this: 71d495a7dbf48174f18ae448ac07bb4 M ./Distribution/Server/Features/Html.hs -6 +3 M ./Distribution/Server/Features/Tags.hs -18 +28 Sat Jul 23 22:48:29 BST 2011 Thomas.DuBuisson(a)gmail.com * Clean up Tags related cruft due to an inattentive developer Ignore-this: 740ec1302b026c6a594ebd89e1a19687 M ./Distribution/Server/Features/Tags.hs -11 +5 Sat Jul 23 23:08:46 BST 2011 Duncan Coutts <duncan(a)well-typed.com> * Rework the Mirror upload feature Ignore-this: d251e00d329db4e342a7e03a3643cb22 So it now does not use multi-part format, just PUT the raw .cabal or .tar.gz file directly. M ./Distribution/Server/Features/Mirror.hs -74 +86 M ./Distribution/Server/Packages/Unpack.hs -4 +19 Sat Jul 23 23:36:30 BST 2011 David Lazar <lazar6(a)illinois.edu> * Link to the user registration page from the User accounts page. Ignore-this: 8a2b280e6911aecaadae19339b7c9ff7 M ./static/accounts.html -1 +2 Sat Jul 23 23:49:40 BST 2011 Matthew Gruen <wikigracenotes(a)gmail.com> * Correct inconsistency in auth realm Ignore-this: 7790a4a19af198a8fc5febff806bcc6f Realms do likely need more customization/coordination M ./Distribution/Server/Features/Users.hs -1 +1 Sun Jul 24 03:24:22 BST 2011 Matthew Gruen <wikigracenotes(a)gmail.com> * Fix PackageList not recognizing newly uploaded packages Ignore-this: edac02156481c0b9b5f25dbe54938f9 M ./Distribution/Server/Features/PackageList.hs -17 +25 M ./Distribution/Server/Features/Tags.hs -2 +2 Sun Jul 24 19:38:29 BST 2011 Duncan Coutts <duncan(a)well-typed.com> * Use digest auth by default Ignore-this: b607227f21d8a67bf01f2e5dea6a4d81 M ./Distribution/Server/Auth/Basic.hs -1 +1 Sun Jul 24 19:41:14 BST 2011 Duncan Coutts <duncan(a)well-typed.com> * Warn but do not fail on packages that are rejected Ignore-this: 2af4c4176a2d79de58203a3135f1f4ec M ./MirrorClient.hs -2 +1 Sun Jul 24 21:28:55 BST 2011 Duncan Coutts <duncan(a)well-typed.com> * Move and rename a number of modules Ignore-this: 892c67234f999d3ed29cfd964a5121c8 Trying to get a handle on what goes together logically and what the module dependencies are. ./Distribution/Server/Backup -> ./Distribution/Server/LegacyImport ./Distribution/Server/BuildReport -> ./Distribution/Server/Features/BuildReports ./Distribution/Server/Cache.hs -> ./Distribution/Server/Framework/Cache.hs ./Distribution/Server/Distributions -> ./Distribution/Server/Features/Distro ./Distribution/Server/Error.hs -> ./Distribution/Server/Framework/Error.hs ./Distribution/Server/Feature.hs -> ./Distribution/Server/Framework/Feature.hs ./Distribution/Server/Features/Reports.hs -> ./Distribution/Server/Features/BuildReports.hs ./Distribution/Server/Hook.hs -> ./Distribution/Server/Framework/Hook.hs ./Distribution/Server/Instances.hs -> ./Distribution/Server/Framework/Instances.hs ./Distribution/Server/LegacyImport/Export.hs -> ./Distribution/Server/Framework/BackupDump.hs ./Distribution/Server/LegacyImport/Import.hs -> ./Distribution/Server/Framework/BackupRestore.hs ./Distribution/Server/PackageIndex.hs -> ./Distribution/Server/Packages/PackageIndex.hs ./Distribution/Server/Resource.hs -> ./Distribution/Server/Framework/Resource.hs ./Distribution/Server/ResourceTypes.hs -> ./Distribution/Server/Framework/ResourceTypes.hs ./Distribution/Server/Types.hs -> ./Distribution/Server/Framework/Types.hs ./Distribution/Server/Util/BlobStorage.hs -> ./Distribution/Server/Framework/BlobStorage.hs ./Distribution/Server/Util/Serve.hs -> ./Distribution/Server/Util/ServeTarball.hs M ./Data/IntTrie.hs -1 +1 M ./Data/StringTable.hs -1 +1 M ./Distribution/Server.hs -10 +9 M ./Distribution/Server/Acid.hs -3 +3 M ./Distribution/Server/Auth/Basic.hs -1 +1 M ./Distribution/Server/Features.hs -56 +124 M ./Distribution/Server/Features/BuildReports.hs -19 +14 M ./Distribution/Server/Features/BuildReports/Backup.hs -10 +10 M ./Distribution/Server/Features/BuildReports/BuildReport.hs -1 +1 M ./Distribution/Server/Features/BuildReports/BuildReports.hs -5 +5 M ./Distribution/Server/Features/BuildReports/State.hs -4 +3 M ./Distribution/Server/Features/Check.hs -11 +6 M ./Distribution/Server/Features/Core.hs -14 +8 M ./Distribution/Server/Features/Distro.hs -9 +4 M ./Distribution/Server/Features/Distro/Backup.hs -6 +6 M ./Distribution/Server/Features/Distro/Distributions.hs -2 +2 M ./Distribution/Server/Features/Distro/State.hs -3 +3 M ./Distribution/Server/Features/Distro/Types.hs -2 +2 M ./Distribution/Server/Features/Documentation.hs -12 +7 M ./Distribution/Server/Features/DownloadCount.hs -5 +2 M ./Distribution/Server/Features/HaskellPlatform.hs -3 +1 M ./Distribution/Server/Features/Html.hs -11 +6 M ./Distribution/Server/Features/Json.hs -1 +1 M ./Distribution/Server/Features/LegacyRedirects.hs -5 +1 M ./Distribution/Server/Features/Mirror.hs -8 +3 M ./Distribution/Server/Features/NameSearch.hs -9 +5 M ./Distribution/Server/Features/PackageList.hs -5 +3 M ./Distribution/Server/Features/Packages.hs -8 +5 M ./Distribution/Server/Features/PreferredVersions.hs -8 +3 M ./Distribution/Server/Features/ReverseDependencies.hs -7 +3 M ./Distribution/Server/Features/StaticFiles.hs -5 +3 M ./Distribution/Server/Features/Tags.hs -10 +5 M ./Distribution/Server/Features/Upload.hs -10 +5 M ./Distribution/Server/Features/Users.hs -6 +2 A ./Distribution/Server/Framework/ M ./Distribution/Server/Framework/BackupDump.hs -4 +4 M ./Distribution/Server/Framework/BackupRestore.hs -4 +7 M ./Distribution/Server/Framework/BlobStorage.hs -1 +1 M ./Distribution/Server/Framework/Cache.hs -1 +1 M ./Distribution/Server/Framework/Error.hs -1 +1 M ./Distribution/Server/Framework/Feature.hs -4 +4 M ./Distribution/Server/Framework/Hook.hs -1 +1 M ./Distribution/Server/Framework/Instances.hs -1 +1 M ./Distribution/Server/Framework/Resource.hs -2 +2 M ./Distribution/Server/Framework/ResourceTypes.hs -3 +3 M ./Distribution/Server/Framework/Types.hs -2 +2 M ./Distribution/Server/LegacyImport/BulkImport.hs -4 +4 M ./Distribution/Server/LegacyImport/UploadLog.hs -1 +1 R ./Distribution/Server/LegacyImport/Utils.hs M ./Distribution/Server/Packages/Backup.hs -6 +5 M ./Distribution/Server/Packages/Backup/Tags.hs -1 +1 M ./Distribution/Server/Packages/Downloads.hs -1 +1 M ./Distribution/Server/Packages/Index.hs -1 +1 M ./Distribution/Server/Packages/PackageIndex.hs -2 +2 M ./Distribution/Server/Packages/Platform.hs -1 +1 M ./Distribution/Server/Packages/Preferred.hs -1 +1 M ./Distribution/Server/Packages/Reverse.hs -2 +2 M ./Distribution/Server/Packages/State.hs -4 +4 M ./Distribution/Server/Packages/Tag.hs -1 +1 M ./Distribution/Server/Packages/Types.hs -2 +2 M ./Distribution/Server/Pages/BuildReports.hs -3 +3 M ./Distribution/Server/Pages/Distributions.hs -1 +1 M ./Distribution/Server/Pages/Index.hs -1 +1 M ./Distribution/Server/Users/Backup.hs -1 +1 M ./Distribution/Server/Users/State.hs -1 +1 M ./Distribution/Server/Users/Users.hs -1 +1 M ./Distribution/Server/Util/ActionLog.hs -1 +1 M ./Distribution/Server/Util/Index.hs -2 +2 M ./Distribution/Server/Util/ServeTarball.hs -2 +2 M ./Distribution/Server/Util/TarIndex.hs -1 +1 M ./MirrorClient.hs -1 +1 M ./hackage-server.cabal -25 +24 Mon Jul 25 01:42:17 BST 2011 Duncan Coutts <duncan(a)well-typed.com> * Stop exporting various internals of features Ignore-this: 588ae6524965706bbcb44a73447a0609 M ./Distribution/Server/Features/BuildReports.hs -1 +2 M ./Distribution/Server/Features/Check.hs -1 +3 M ./Distribution/Server/Features/Core.hs -2 +13 M ./Distribution/Server/Features/Distro.hs -1 +3 M ./Distribution/Server/Features/Documentation.hs -1 +1 M ./Distribution/Server/Features/DownloadCount.hs -1 +12 M ./Distribution/Server/Features/HaskellPlatform.hs -1 +2 M ./Distribution/Server/Features/Html.hs -3 +4 M ./Distribution/Server/Features/Json.hs -1 +1 M ./Distribution/Server/Features/Mirror.hs -2 +3 M ./Distribution/Server/Features/NameSearch.hs -1 +2 M ./Distribution/Server/Features/PackageList.hs -2 +3 M ./Distribution/Server/Features/Packages.hs -1 +14 M ./Distribution/Server/Features/PreferredVersions.hs -1 +6 M ./Distribution/Server/Features/ReverseDependencies.hs -1 +3 M ./Distribution/Server/Features/Tags.hs -1 +4 M ./Distribution/Server/Features/Upload.hs -3 +7 M ./Distribution/Server/Features/Users.hs -34 +40 Mon Jul 25 02:48:51 BST 2011 Duncan Coutts <duncan(a)well-typed.com> * Support conditional/cached downloads Ignore-this: 790049ba617d69379c51ab457d66a73b Requires another patch to the HTTP lib M ./MirrorClient.hs -2 +50 Mon Jul 25 03:30:21 BST 2011 Duncan Coutts <duncan(a)well-typed.com> * Handle old hackage URLs in the mirror client Ignore-this: 601eb58403a7a1d6b74ef0d6ba786e8f M ./MirrorClient.hs -7 +14 Fri Jul 29 11:49:32 BST 2011 Duncan Coutts <duncan(a)community.haskell.org> * Remove unused dependency on the uri package Ignore-this: 937aa41b93536d2c5dec696cdb39b756 M ./Distribution/Server/Pages/Distributions.hs -2 M ./hackage-server.cabal -2 Fri Jul 29 11:51:24 BST 2011 Duncan Coutts <duncan(a)community.haskell.org> * Update author, maintainer and copyright info in .cabal file Ignore-this: c0d05aebd6954a7af85b3bda0e1ecc0e M ./hackage-server.cabal -7 +9 Fri Jul 29 12:08:40 BST 2011 Duncan Coutts <duncan(a)community.haskell.org> * Tidy up the .cabal file Ignore-this: 5d71117dbad46b249baf0f5b62097bae M ./hackage-server.cabal -42 +45 Sat Aug 6 12:12:31 BST 2011 Duncan Coutts <duncan(a)community.haskell.org> * Add the missing Framework module Ignore-this: 9a1c9474edd077a0d451d19635da3b33 A ./Distribution/Server/Framework.hs M ./hackage-server.cabal +1 Sat Aug 6 12:36:12 BST 2011 Duncan Coutts <duncan(a)community.haskell.org> * Add a cabal flag for a build configuration with a minimal featureset Ignore-this: 9e9c46dc434a33b7545e6d9909a8e42d M ./Distribution/Server/Features.hs -7 +12 M ./hackage-server.cabal -25 +39 Sun Aug 7 11:39:54 BST 2011 Duncan Coutts <duncan(a)community.haskell.org> * Move to Cabal-1.8 rules for component deps Ignore-this: 33eeb44a6a1fe84a465f9ae4e24b75e5 M ./hackage-server.cabal -15 +8

1 0

Re: HLint binary path
by Neil Mitchell 09 Aug '11

09 Aug '11

Hi Andrew, I'm afraid I have no idea, I only use HLint on Windows, where it gets installed with all other Haskell binaries which is on the $PATH. I suspect the cabal-devel list will have an answer. Thanks, Neil On Sat, Jul 30, 2011 at 4:11 AM, Andrew Pennebaker <andrew.pennebaker(a)gmail.com> wrote: > HLint is very cool, but by default the binary is put > in ~/Library/Haskell/ghc-7.0.3/lib/hlint-1.8.13/bin without being added to > $PATH. Is there a cabal option to either put it in a directory known to > $PATH or add ~/Library/Haskell/ghc-7.0.3/lib/hlint-1.8.13/bin to $PATH as > part of the installation process? > > Cheers, > Andrew Pennebaker > www.yellosoft.us

2 1

Re: darcs patch: Use Safe Haskell for GHC >= 7.2
by Duncan Coutts 08 Aug '11

08 Aug '11

On Tue, 2011-08-02 at 11:09 -0700, David Terei wrote: > Hi Duncan and Ian, > > Attached is a patch that enables Safe Haskell for Cabal modules when > its built with GHC >= 7.2. I'd love to get this patch included asap as > I'm hoping to get all the libraries included with GHC using Safe > Haskell for the 7.2 release. Is there any issue with pulling in the > latest Cabal for 7.2? If there is the patch should backport fine, > probably would apply cleanly in it current state. Hi David, Sorry, just got back from holiday. I understand from Ian that 7.2.1 is being built as we speak, so it's too late for this for 7.2.1. I don't know if there will be a 7.2.2 or if we just wait for 7.4.1 around post-ICFP time. I see that you're adding +{-# LANGUAGE CPP #-} +#if __GLASGOW_HASKELL__ >= 701 +{-# LANGUAGE Trustworthy #-} +#endif In basically every module in Cabal. Is it necessary to use a language pragma here or could we just use an extension in the .cabal file, which would apply it to every module. We can do this conditionally on the ghc version. I prefer not to have all modules using CPP if I can help it. I'm also slightly confused as to why so many modules are marked as 'Trustworthy' rather than as simply 'Safe'. In particular, many simple pure modules that have no FFI etc you're marking with 'Trustworthy'. As I understand it from the docs on the ghc wiki, 'Trustworthy' is only needed for modules that use unsafe features in a way that the module author claims is externally safe. In fact, it's not obvious to me that any modules in Cabal need to be marked as 'Trustworthy'. We don't use any exotic extensions and all the FFI imports we use are in IO, not pure. We don't use Typeable, unsafePerformIO, bytestring etc. We use unsafeInterleaveIO in one place. Is unsafeInterleaveIO unsafe in the SafeHaskell sense? (If so I'd be interested in why, but that'd be an orthogonal argument.) I also notice in a couple places that you're changing: -import Text.PrettyPrint.HughesPJ +import Text.PrettyPrint Is this necessary? Duncan

1 0

Re: [Hackage] #303: cabal clean: Error while removing dist/: dist/setup: removeDirectory: unsatisified constraints (Directory not empty)
by Hackage 08 Aug '11

08 Aug '11

#303: cabal clean: Error while removing dist/: dist/setup: removeDirectory: unsatisified constraints (Directory not empty) ----------------------------+----------------------------------------------- Reporter: simonmar | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: Cabal library | Version: 1.4.0.1 Severity: normal | Keywords: Difficulty: normal | Ghcversion: 6.8.3 Platform: | ----------------------------+----------------------------------------------- Comment(by Phyx): Isn't a simple solution to never let Setup delete it's own exe? Worse case if using the setup script clean leaves an exe, if cabal was used it can remove the exe left behind. If it's a big deal to not leave anything at all the hackish way around it would be to inject some shellscript into a running program like explorer and have it delete the exe. -- Ticket URL: <http://hackage.haskell.org/trac/hackage/ticket/303#comment:2> Hackage <http://haskell.org/cabal/> Hackage: Cabal and related projects

1 0

patch applied (cabal): "Fix for intra-package build-tools dependencies"
by Duncan Coutts 08 Aug '11

08 Aug '11

Mon Aug 8 09:50:45 PDT 2011 Duncan Coutts <duncan(a)community.haskell.org> * Fix for intra-package build-tools dependencies M ./cabal/Distribution/Simple/Build.hs -13 +56 M ./cabal/Distribution/Simple/Configure.hs -24 +20 M ./cabal/Distribution/Simple/Program/Types.hs -16 +24 View patch online: http://darcs.haskell.org/cgi-bin/darcsweb.cgi?r=cabal;a=darcs_commitdiff;h=…

1 0

[Hackage] #868: cabal clean crash
by Hackage 08 Aug '11

08 Aug '11

#868: cabal clean crash ---------------------------------+------------------------------------------ Reporter: Phyx | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: cabal-install tool | Version: 1.8.0.6 Severity: normal | Keywords: Difficulty: unknown | Ghcversion: Platform: | ---------------------------------+------------------------------------------ When using a custom build type, clean wil always crash (atleast on windows). Cabal leaves cleaning up to the compiled Setup.exe, which itself resides in sdist, so an attempt to clean *all* files in sdist requires Setup.exe to be deleted aswell. And since a program can't delete itself, this will always result in the following crash: PS C:\Users\Phyx\Documents\Haskell\cabaltest> cabal clean cleaning... Error while removing dist/: DeleteFile "dist\\setup\\setup.exe": permission denied (Access is denied.) -- Ticket URL: <http://hackage.haskell.org/trac/hackage/ticket/868> Hackage <http://haskell.org/cabal/> Hackage: Cabal and related projects

1 1

darcs patch: Protect internal ' in quoted system comm... (and 1 more)
by Matthew William Cox 05 Aug '11

05 Aug '11

Hello, 2 patches to contribute to cabal. The first is a simple oversite I noticed while implementing the second. Essentially, the call out to an external command by system has every supplied string wrapped in ', but doesn't escape this character. This is fixed in the first patch. Thu Aug 4 20:06:11 EDT 2011 matt(a)mattcox.ca * Protect internal ' in quoted system commands The previous implementation did not escape ' in the input which causes them to break the quotation. The second is support that I require for a project which needs to use hooks to invoke cmake and make to build a legacy C component. I followed the existing code conventions which make a few questionable choices. For one, the progInvokeEnv field is [(String, String)] rather than Maybe [(String, String)] like is used by e.g., runInteractiveProcess. The interpretation in the existing code is that this is a supplemental list of environment variables rather than a complete environment. There is no way to remove existing variable with this representation other than assigning them empty values. This is a different interpretation to that used by rawSystemExitWithEnv, which uses it as the entire environment. I had the runInvokation functions merge the supplied environment on top of the system environment rather than modify the behaviour of the rawSystemExitWithEnv function. The rawSystemExit functions were given variants accepting working directories rather than adding a Maybe FilePath argument and changing the type signature. I hope that this can go in for 1.12. In particular, I'd like to suggest a bump to 1.11.3 so that I can depend on the version to ensure the behaviour introduced in this patch is available. Fri Aug 5 12:19:48 EDT 2011 matt(a)mattcox.ca * Finish implementing Distribution.Simple.Program.Run The environment and working directory settings in the ProgramInvocation record were not totally handled by the run invocation functions in the module. The selection of a working directory was implemented for all functions, and input set in the invocation is handled by getProgramInvocation output. The environment in the record is taken to be a list of supplemental environment settings to add or override the system environment variables, rather than as a complete environment. This is the behaviour implemented by the functions in Distribution.Simple.Program.Script. New functions taking an environment and working directory were added to the Distribution.Simple.Utils module.

1 0