Wolfgang Jeltsch pushed to branch wip/jeltsch/more-efficient-home-unit-imports-finding at Glasgow Haskell Compiler / GHC Commits: 36e0da1f by Wolfgang Jeltsch at 2026-04-29T13:17:06+03:00 Remove the sorted-dependencies `assertPpr` After the recent code simplifications, the assertion is now obviously true. - - - - - 1 changed file: - compiler/GHC/Unit/Finder.hs Changes: ===================================== compiler/GHC/Unit/Finder.hs ===================================== @@ -270,16 +270,7 @@ sortHomeUnitsByLikelihoodFor home_module_name_providers_map mod_name hpt_deps = cached_module_providers = lookupWithDefaultUniqMap home_module_name_providers_map Set.empty mod_name cached_providing_deps = Set.toList (Set.intersection hpt_deps cached_module_providers) uncached_providing_deps = Set.toList (Set.difference hpt_deps cached_module_providers) - - all_deps = cached_providing_deps ++ uncached_providing_deps - in - assertPpr - (hpt_deps == Set.fromList all_deps) - ( text "Sorting must not remove HomeUnits" - $$ text "Module:" <+> ppr mod_name - $$ text "Original:" <+> ppr hpt_deps - $$ text "Sorted: " <+> ppr (Set.fromList all_deps)) - all_deps + in cached_providing_deps ++ uncached_providing_deps -- | Locate a plugin module requested by the user, for a compiler -- plugin. This consults the same set of exposed packages as View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/36e0da1fb67cae7f0902a8a35d19317a... -- View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/36e0da1fb67cae7f0902a8a35d19317a... You're receiving this email because of your account on gitlab.haskell.org.