24 Jul
2026
24 Jul
'26
10:47 p.m.
On Fri, Jul 24, 2026 at 10:16 AM Sebastian Graf via ghc-devs < ghc-devs@haskell.org> wrote:
Sashiko sometimes find bugs in adjacent code, but submitters don't want to have to fix bugs they didn't create.
I had my fair share of patches reviewed by humans like Simon and others where they caught a bug in adjacent code as well. While I understand the scope creep frustration, I'm convinced that it makes the code base better overall because it means patch authors have to think about how their contribution fits into the design of the component they are touching.
I don't think any of my GHC reviews have done that, but it's happened a few times with Cabal reviews. It's definitely a thing. -- brandon s allbery kf8nh allbery.b@gmail.com