1% is huge! Good to do. | -----Original Message----- | From: Ben Gamari [mailto:ben@well-typed.com] | Sent: 19 December 2015 11:51 | To: Simon Peyton Jones <simonpj@microsoft.com>; ghc-devs@haskell.org | Subject: RE: [commit: ghc] master: SrcLoc: Eliminate constructors of | RealSrcSpan (987426c) | | Simon Peyton Jones <simonpj@microsoft.com> writes: | | > Does this change yield any benefits? Eg. if we can now unbox SrcLoc | does something go faster? | > | Compiler allocations in the testsuite decrease between 0 and 1% [1]. | | Moreover, it still seemed like a reasonable clean-up given it is a net | reduction in code length with no loss of clarity. | | Cheers, | | - Ben | | | [1] https://perf.haskell.org/ghc/#table-6