Actually, I was able to make "the right way" work after all, thanks to SPJ's help! I'll merge it today (after Harbormaster validates it). Ryan S. On Thu, Feb 9, 2017 at 2:12 PM, Ben Gamari <ben@well-typed.com> wrote:
Ryan Scott <ryan.gl.scott@gmail.com> writes:
Hi Ben,
Hi Ryan,
Sorry for not asking this sooner, but I'd like to merge some form of https://phabricator.haskell.org/D2961 in time for 8.2 if possible. Sadly, doing it "the right way" (according to Simon) is proving to be extremely challenging. A previous iteration of D2961 does work (albeit the code is not as pretty as it ought to be).
Are you still planning to cut the 8.2 release tomorrow? If so, I think I'll revert back to the working version of D2961 and merge that, and leave doing it the right way as future work.
Indeed I was hoping to and the way things are looking at the moment I believe this plan is still feasible. I would be fine with reverting back to the old version. Perhaps you would like to update the Diff appropriately?
Cheers,
- Ben