Looking here https://gitlab.haskell.org/ghc/ghc/merge_requests/116//diffs I see literally NO discussions with a "toggle discussion" button. Indeed if I search for "toggle" I get no hits. When I initially clicked on "changes", the diff for TcHsType was initially collapsed; I had to click on "Click to expand it". I can't account for why the behaviour is different for you. Simon | -----Original Message----- | From: Mikolaj Konarski | Sent: 14 January 2019 09:46 | To: Simon Peyton Jones | Cc: ghc-devs | Subject: Re: GHC | Some refactoring in tcInferApps (!116) | | > Either way, I can’t see any comments whatsoever! It says 5/5 discussions | resolved, but I can’t actually see them. There is not “toggle discussion” | button anywhere. | | Hello Simon, | | Just below "5/5 discussions resolved" I can see 5 discussions with “toggle | discussion” link to the right of each one. | Is that what you can't see, or do mean a single button that toggles all | resolved discussions (I can't see any)? | Or do you mean a button that un-resolves them permanently (neither can I | see one)?

| (without the 'diff' at the end) you can see the collapsed discussion items? Yes, in the discussion tab I can. But of course that is out of context; you just get a little (non-expandable) snippet. Simon | -----Original Message----- | From: Mikolaj Konarski | Sent: 14 January 2019 10:30 | To: Simon Peyton Jones | Cc: ghc-devs | Subject: Re: GHC | Some refactoring in tcInferApps (!116) | | > Looking here | > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitl | > ab.haskell.org%2Fghc%2Fghc%2Fmerge_requests%2F116%2F%2Fdiffs&data= | > 02%7C01%7Csimonpj%40microsoft.com%7Cb565eeb2f6fe445fc64f08d67a0b40fe%7 | > C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636830586093208883&sda | > ta=qAcz0zoXCCQHFeJ39ABKAVwtN5a2pIwyRSbfJcLSurk%3D&reserved=0 | > I see literally NO discussions with a "toggle discussion" button. Indeed | if I search for "toggle" I get no hits. | | Oh, I see, you are right with respect to the link you cited now. | None of the buttons help, just as you say. I have to navigate back from the | "Changes" to the "Discussion" tab, which gets me to the link you gave | initially | (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h | askell.org%2Fghc%2Fghc%2Fmerge_requests%2F116&data=02%7C01%7Csimonpj%40 | microsoft.com%7Cb565eeb2f6fe445fc64f08d67a0b40fe%7C72f988bf86f141af91ab2d7c | d011db47%7C1%7C0%7C636830586093208883&sdata=1pFmcwPyptWE8XOs%2FdnykEqsm | 4ag7%2BqBi3c4qpAE7sE%3D&reserved=0) | where the discussions are available, but I can't see them in the context of | the whole diff and none of the buttons there let me extend the view of the | diff. That's quite suboptimal. | | Could you confirm that at | | https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.ha | skell.org%2Fghc%2Fghc%2Fmerge_requests%2F116&data=02%7C01%7Csimonpj%40m | icrosoft.com%7Cb565eeb2f6fe445fc64f08d67a0b40fe%7C72f988bf86f141af91ab2d7cd | 011db47%7C1%7C0%7C636830586093208883&sdata=1pFmcwPyptWE8XOs%2FdnykEqsm4 | ag7%2BqBi3c4qpAE7sE%3D&reserved=0 | | (without the 'diff' at the end) you can see the collapsed discussion items?

Hi Simon, In the diff view, you can click on the avatars on the left to expand discussions: Or you can click on the "toggle comments for this file" button: If you are willing to use GreaseMonkey (Firefox extension) or TamperMonkey (Chrome/Chromium extension), you can use the attached script to add new buttons to GitLab UI: Tested on Firefox and Chromium on Linux. Sylvain On 14/01/2019 11:58, Simon Peyton Jones via ghc-devs wrote:

| (without the 'diff' at the end) you can see the collapsed discussion items?

Yes, in the discussion tab I can. But of course that is out of context; you just get a little (non-expandable) snippet.

Simon

| -----Original Message----- | From: Mikolaj Konarski | Sent: 14 January 2019 10:30 | To: Simon Peyton Jones | Cc: ghc-devs | Subject: Re: GHC | Some refactoring in tcInferApps (!116) | | > Looking here | > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitl | > ab.haskell.org%2Fghc%2Fghc%2Fmerge_requests%2F116%2F%2Fdiffs&data= | > 02%7C01%7Csimonpj%40microsoft.com%7Cb565eeb2f6fe445fc64f08d67a0b40fe%7 | > C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636830586093208883&sda | > ta=qAcz0zoXCCQHFeJ39ABKAVwtN5a2pIwyRSbfJcLSurk%3D&reserved=0 | > I see literally NO discussions with a "toggle discussion" button. Indeed | if I search for "toggle" I get no hits. | | Oh, I see, you are right with respect to the link you cited now. | None of the buttons help, just as you say. I have to navigate back from the | "Changes" to the "Discussion" tab, which gets me to the link you gave | initially | (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h | askell.org%2Fghc%2Fghc%2Fmerge_requests%2F116&data=02%7C01%7Csimonpj%40 | microsoft.com%7Cb565eeb2f6fe445fc64f08d67a0b40fe%7C72f988bf86f141af91ab2d7c | d011db47%7C1%7C0%7C636830586093208883&sdata=1pFmcwPyptWE8XOs%2FdnykEqsm | 4ag7%2BqBi3c4qpAE7sE%3D&reserved=0) | where the discussions are available, but I can't see them in the context of | the whole diff and none of the buttons there let me extend the view of the | diff. That's quite suboptimal. | | Could you confirm that at | | https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.ha | skell.org%2Fghc%2Fghc%2Fmerge_requests%2F116&data=02%7C01%7Csimonpj%40m | icrosoft.com%7Cb565eeb2f6fe445fc64f08d67a0b40fe%7C72f988bf86f141af91ab2d7cd | 011db47%7C1%7C0%7C636830586093208883&sdata=1pFmcwPyptWE8XOs%2FdnykEqsm4 | ag7%2BqBi3c4qpAE7sE%3D&reserved=0 | | (without the 'diff' at the end) you can see the collapsed discussion items? _______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

I confirm that I see "Unresolve discussion" buttons in the "Discussion" page, after "Toggle Discussion" is clicked. Perhaps we have this working convention: the dev that starts the discussion is expected to resolve it. I doubt GL can enforce that convention, but we can just agree to it all. So, in the case at hand, I wrote the patch, and Simon started several discussions. As I address them, instead of resolving the discussions (as I did), I would just say "Done" (or similar). Then, Simon's re-review would spot my comments and then click resolve, when the matter has met his satisfaction. Ben: I imagine this will not be the only such convention we arrive at in this vein. Is it possible (and reasonably easy) to set up some service whereby new contributors get a "welcome" email upon their first submission of an MR? (But only upon the *first* submission!) This would include hearty thanks for contributing, etc., but also a few GL pointers and our working conventions. To be honest, even forgetting about working conventions, an email of thanks at that stage would probably set the stage for a nice working environment for contributors. (Right now, they probably submit, get some silence, then see a slew of comments telling them what they've done wrong, and then get a "Thanks so much!" after all those negative comments. This may be somewhat standard in open-source -- and isn't so bad that it *needs* change -- but that doesn't mean we can't do better.) Richard

On Jan 14, 2019, at 7:30 AM, Mikolaj Konarski wrote:

On Mon, Jan 14, 2019 at 10:28 AM Simon Peyton Jones via ghc-devs mailto:ghc-devs@haskell.org> wrote:

...

I suppose we could issue guidance NEVER to resolve a discussion, but that seems like the wrong conclusion.

It seems gitlab's "resolve discussion" action is supposed to mean "I think nobody needs to look at these comments (in detail) any more".

So if somebody addressed your comment, he should probably ping you with "this comment addressed", then you look at the comment, at the old diff, at the new diff (no idea how easy it is to switch between the old and new diffs) and then *you* resolve the discussion, if satisfied. And if somebody resolves discussion prematurely, you unresolve it with the button or checkbox, meaning "actually, I'd like to have one more close look before the discussion is hidden forever". You can even add an unresolve comment explaining why you think the additional look is needed after all.

All this is quite troublesome if there is a lot of comments and they need to be pinged about, resolved and unresolved in bulk (unless I'm missing some bulk button).

_______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs