Re: [ghc-steering-committee] Please review #678: Amendment to ImportShadowing

I’m in favor of the backward compatible one, it’s a bit more complicated but (I think) clearer. I’ve left some comments on the PR itself. /Matti Palli On Mon, Oct 21, 2024 at 10:48 Simon Peyton Jones < simon.peytonjones@gmail.com> wrote:

...

we'd be well served by a better spec for what `module M` means in an export list,

Well, that's the entire purpose of this amendment!

- Do you think it now gives a clear spec? - Do you prefer the alternative (more complicated, but backward compatible) spec I suggested here https://github.com/ghc-proposals/ghc-proposals/pull/678#issuecomment-2421884... ?

Simon

On Mon, 21 Oct 2024 at 09:27, Matthías Páll Gissurarson wrote:

...

I'm in support. I agree with Simon's comment, we'd be well served by a better spec for what `module M` means in an export list, but this amendment is closer to what we would want.

On Mon, 21 Oct 2024 at 04:50, Arnaud Spiwack wrote:

...

I find it a little annoying that this isn't backward compatible. But on the other hand, it's a very obscure bit of Haskell semantics which is modified, module re-export is something that most people frequently get wrong anyway. At any rate, my feeling is that the proposed change is the right behaviour: if a module defines a function `foo`, and exports a *different* function `foo`, this is at least a smell, isn't it?

So, in favour.

On Fri, 18 Oct 2024 at 17:43, Jakob Brünker wrote:

...

Seems like a reasonable amendment, I'm in support.

On Fri, Oct 18, 2024 at 10:33 AM Malte Ott wrote:

...

I support as well.

...

I support, subject to a couple of typos I have identified.

Simon

On Thu, 17 Oct 2024 at 00:38, Erik de Castro Lopo < erikd@mega-nerd.com> wrote:

> Hi all, > > I have recommended "accept" for this minor modification of this

On 2024-10-17 08:58, Simon Peyton Jones wrote: proposal.

...

> > I would appreciate it if everyone else on the committee would vote. > > Thanks, > Erik > > > Adam Gundry wrote: > > > Dear Committee, > > > > Gergő Érdi proposes to amend his import shadowing proposal #652 to > > clarify the behaviour of module re-exports: > > > > https://github.com/ghc-proposals/ghc-proposals/pull/678 > > > > I'd like to nominate Erik de Castro Lopo as the shepherd, as he > > shepherded the original proposal. > > > > Please guide us to a conclusion as outlined in > > https://github.com/ghc-proposals/ghc-proposals#committee-process > > > > Cheers, > > > > Adam > > > > > > -- > > Adam Gundry, Haskell Consultant > > Well-Typed LLP, https://www.well-typed.com/ > > > > Registered in England & Wales, OC335890 > > 27 Old Gloucester Street, London WC1N 3AX, England https://www.google.com/maps/search/27+Old+Gloucester+Street,+London+WC1N+3AX,+England?entry=gmail&source=g > > > > > -- >

---

...

> Erik de Castro Lopo > http://www.mega-nerd.com/ > _______________________________________________ > ghc-steering-committee mailing list > ghc-steering-committee@haskell.org > https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee >

...

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- Arnaud Spiwack Director, Research at https://moduscreate.com and https://tweag.io. _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- -- Matthías Páll Gissurarson http://mpg.is/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee