
6 Dec
2024
6 Dec
'24
12:38 p.m.
Hi all, I've so far essentially been using the "Needs revision" label to indicate that the next concrete step has to be taken by the author, regardless of how big the changes I suggest are. After I did this yesterday, VitWW commented https://github.com/ghc-proposals/ghc-proposals/pull/621#issuecomment-2523299..., essentially saying it's only intended for cases where major rewrites are required.
From what I can tell, in past proposals, if relatively minor changes came up during the shepherding phase, sometimes "Needs revision" was used, and sometimes not.
Is there a guideline I should follow, or that you tend to follow here? Jakob