Joachim * Could we add a tag for "Implemented" so that we can have convenient lists for "accepted and implemented" vs "accepted and not yet implemented"? Easy, and valuable. * The "under discussion" list seems terribly short - only two proposals! https://github.com/ghc-proposals/ghc-proposals/pulls?q=is%3Aopen+is%3Apr+no%... There are tons of proposals under discussion! What's wrong? Thanks Simon
Hi, Am Montag, den 03.12.2018, 16:08 +0000 schrieb Simon Peyton Jones:
Joachim Could we add a tag for “Implemented” so that we can have convenient lists for “accepted and implemented” vs “accepted and not yet implemented”? Easy, and valuable.
So far I shied away from the bureaucracy of having to track what happens after acceptance (including keeping the `trac` and `implemented` fields on top up-to-date). Occasionally people have updated this metadata. I am happy to introduce an Implemented label, but do not promise that I will track GHC changes close enough to always set it correctly. Do we consider it as implemented when a DR is created, when it hits master, or when it is released?
The “under discussion” list seems terribly short – only two proposals! https://github.com/ghc-proposals/ghc-proposals/pulls?q=is%3Aopen+is%3Apr+no%... There are tons of proposals under discussion! What’s wrong?
Oh, darn! Vitaly started tagging Proposals with the tag “Proposal”, which is a nice idea, but it breaks the current setup where “no tag” means “Proposal under discussion”. Not using a tag was a deliberate choice, as it has the advantage that newly created proposals are automatically correctly categorized. Note that contributors who are not members of the team don’t have permissions to set a tag, so we can’t ask them to set a “Under discussion“ tag. Vitaly, how about we delete the Proposal tag, and maybe mark non- proposals with a tag (maybe with a grey or dull color). Given that most pull requests are proposals, let’s mark the exceptions instead! Cheers, Joachim -- Joachim Breitner mail@joachim-breitner.de http://www.joachim-breitner.de/
Vitaly, how about we delete the Proposal tag, and maybe mark non-
proposals with a tag (maybe with a grey or dull color). Given that most pull requests are proposals, let’s mark the exceptions instead!
Ok, I'll do that. Sorry for messing things up, I wanted to count all proposals but took a longer road. Vitaly
Hi, Am Montag, den 03.12.2018, 11:24 -0500 schrieb Vitaly Bragilevsky:
Vitaly, how about we delete the Proposal tag, and maybe mark non-
proposals with a tag (maybe with a grey or dull color). Given that most pull requests are proposals, let’s mark the exceptions instead!
Ok, I'll do that. Sorry for messing things up, I wanted to count all proposals but took a longer road.
depending on what you want to do, the code at https://github.com/nomeata/ghc-proposals-stats might be useful. Cheers, Joachim -- Joachim Breitner mail@joachim-breitner.de http://www.joachim-breitner.de/
Hi,
I've fixed "under discussion" list and added "Non-proposal" label.
I am volunteering to keep track of the implemented proposals with
"Implemented" label. I think hitting master is the right time to consider
the proposal implemented, are there other ideas on that?
Vitaly
On Mon, Dec 3, 2018 at 8:24 AM Vitaly Bragilevsky
Vitaly, how about we delete the Proposal tag, and maybe mark non-
proposals with a tag (maybe with a grey or dull color). Given that most pull requests are proposals, let’s mark the exceptions instead!
Ok, I'll do that. Sorry for messing things up, I wanted to count all proposals but took a longer road.
Vitaly
Hi, Am Montag, den 03.12.2018, 11:41 -0500 schrieb Vitaly Bragilevsky:
I've fixed "under discussion" list and added "Non-proposal" label.
Great!
I am volunteering to keep track of the implemented proposals with "Implemented" label. I think hitting master is the right time to consider the proposal implemented, are there other ideas on that?
Even greater. Agreed that hitting master is the right time. Cheers, Joachim -- Joachim Breitner mail@joachim-breitner.de http://www.joachim-breitner.de/
* I agree with “hitting master”.
* The “implemented status does not need to be 100% up to date; but it would be good to explain how to ask for a proposal to be moved from “accepted” to “implemented”.
* There should be a link in the “timeline” list on https://github.com/ghc-proposals/ghc-proposals, so that people can find the list. Perhaps “6. Later, someone may implement the proposal. We count it as “implemented” when it hits the GHC mater banch” <link>
THanks!
Simon
From: Vitaly Bragilevsky
Hi, Am Montag, den 03.12.2018, 17:09 +0000 schrieb Simon Peyton Jones via ghc-steering-committee:
The “implemented status does not need to be 100% up to date; but it would be good to explain how to ask for a proposal to be moved from “accepted” to “implemented”.
Yup
There should be a link in the “timeline” list on https://github.com/ghc-proposals/ghc-proposals, so that people can find the list. Perhaps “6. Later, someone may implement the proposal. We count it as “implemented” when it hits the GHC mater banch” <link>
Good point, added: https://github.com/ghc-proposals/ghc-proposals#what-is-the-timeline-of-a-pro... Cheers, Joachim -- Joachim Breitner mail@joachim-breitner.de http://www.joachim-breitner.de/
participants (3)
-
Joachim Breitner -
Simon Peyton Jones -
Vitaly Bragilevsky