July 2014 - ghc-tickets

[GHC] #8517: Add library function retrieve label set by GHC.Conc.Sync.labelThread
by GHC 18 Nov '14

18 Nov '14

#8517: Add library function retrieve label set by GHC.Conc.Sync.labelThread ------------------------------------+------------------------------------- Reporter: blitzcode | Owner: Type: feature request | Status: new Priority: normal | Milestone: Component: libraries/base | Version: 7.6.3 Keywords: | Operating System: Unknown/Multiple Architecture: Unknown/Multiple | Type of failure: None/Unknown Difficulty: Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | ------------------------------------+------------------------------------- It would be useful to be able to retrieve the label set by the labelThread function. For instance, a logging / tracing system could output a human readable string for the thread the trace originated from instead of just the thread ID. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8517> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 1

[GHC] #8558: Build xhtml and haddock only when `HADDOCK_DOCS=YES`
by GHC 18 Nov '14

18 Nov '14

#8558: Build xhtml and haddock only when `HADDOCK_DOCS=YES` ------------------------------------+------------------------------------- Reporter: nomeata | Owner: Type: feature request | Status: new Priority: normal | Milestone: Component: Build System | Version: 7.6.3 Keywords: | Operating System: Unknown/Multiple Architecture: Unknown/Multiple | Type of failure: None/Unknown Difficulty: Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | ------------------------------------+------------------------------------- In order to save contributor’s time, and in order to run the test suite faster, I suggest to not builds haddock and its dependencies (xhtml, anything else?) if `HADDOCK_DOCS=YES` is specified. The change is rather simple: {{{ diff --git a/ghc.mk b/ghc.mk index dd91a82..b0f93a0 100644 --- a/ghc.mk +++ b/ghc.mk @@ -437,7 +437,9 @@ REGULAR_INSTALL_PACKAGES += compiler endif REGULAR_INSTALL_PACKAGES += $(addprefix libraries/,$(PACKAGES_STAGE2)) +ifeq "$(HADDOCK_DOCS)" "YES" PACKAGES_STAGE1 += xhtml +endif ifeq "$(Windows_Target)" "NO" ifneq "$(TargetOS_CPP)" "ios" PACKAGES_STAGE1 += terminfo @@ -652,8 +654,10 @@ BUILD_DIRS += libraries/integer-gmp/gmp BUILD_DIRS += libraries/integer-gmp/mkGmpDerivedConstants endif +ifeq "$(HADDOCK_DOCS)" "YES" BUILD_DIRS += utils/haddock BUILD_DIRS += utils/haddock/doc +endif BUILD_DIRS += compiler BUILD_DIRS += utils/hsc2hs BUILD_DIRS += utils/ghc-pkg }}} and it does not affect validate runs, as validate has `HADDOCK_DOCS` set to `YES`. If this is introduced, I suggest to annotate these two with a tag in packages, so that one can run `./sync-all get --no-haddock`, similar to `--no-dph`. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8558> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 5

[GHC] #8544: Auto-Reference ticket-related branches in tickets
by GHC 18 Nov '14

18 Nov '14

#8544: Auto-Reference ticket-related branches in tickets ------------------------------------+------------------------------------- Reporter: nomeata | Owner: Type: feature request | Status: new Priority: normal | Milestone: Component: Trac & Git | Version: 7.6.3 Keywords: | Operating System: Unknown/Multiple Architecture: Unknown/Multiple | Type of failure: None/Unknown Difficulty: Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | ------------------------------------+------------------------------------- This has two possible implementations (and both are useful and can complement each other): * Add a new field to the description „Related branch“. If for ticket #1234 there is a branch matching `T1234` (usually something like `wip/T1234`), link it from there. * When such a branch is created or deleted, post a message to the ticket. This way subscribers know about a possible ongoing implementation, and can review it. These should link somewhere I believe `https://ghc.haskell.org/trac/ghc/log/ghc?rev=<branchname>` is the most useful link. If the link is part of the „branch created“ message, it will become dangling after the branch is closed (presumably because the feature was merged; then the actually commits, if they reference the bug, will be auto-linked). I don’t think this is a problem. But if that is a problem, only put the link in the “Related branches” field, and clear it when the branch is deleted. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8544> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 2

[GHC] #8527: container's Typeable.h is being shadowed by base's Typeable.h during preprocessing
by GHC 18 Nov '14

18 Nov '14

#8527: container's Typeable.h is being shadowed by base's Typeable.h during preprocessing ------------------------------------+------------------------------------- Reporter: parcs | Owner: parcs Type: bug | Status: new Priority: normal | Milestone: Component: Package system | Version: 7.7 Keywords: | Operating System: Unknown/Multiple Architecture: Unknown/Multiple | Type of failure: None/Unknown Difficulty: Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | ------------------------------------+------------------------------------- Here's a reduced test case: == cpp.hs == {{{ #!haskell {-# LANGUAGE CPP #-} #include "Typeable.h" main = return () }}} == command line == {{{ $ ghc-stage2 -c -package base cpp.hs In file included from cpp.hs:4:0: /home/patrick/code/ghc/libraries/base/include/Typeable.h:17:2: warning: #warning <Typeable.h> is obsolete and will be removed in GHC 7.10 [-Wcpp] #warning <Typeable.h> is obsolete and will be removed in GHC 7.10 ^ compilation IS NOT required $ ghc-stage2 -c -package base -package containers cpp.hs compilation IS NOT required $ ghc-stage2 -c -package containers -package base cpp.hs }}} Notice that if I pass `-package containers` to ghc, the cpp warning from Typeable.h (from the base library) doesn't appear. This is because containers also has a Typeable.h in its include path, and in the invocation of the preprocessor, containers' include path precedes base's no matter how I order the `-package` directives. This behavior is intuitive and limiting. To fix this, I think that the ordering of -I directives passed to the preprocessor should be consistent with the ordering of -package directives passed to ghc. For example, in the above test case, a warning should be shown in the 1st and 2nd invocations of ghc but not the 3rd, because in the 3rd invocation containers precedes base. Does this sound okay? -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8527> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 2

[GHC] #8528: Preprocessor issues building GHC HEAD on Mavericks
by GHC 18 Nov '14

18 Nov '14

#8528: Preprocessor issues building GHC HEAD on Mavericks ----------------------------------+---------------------------------------- Reporter: guest | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.7 Keywords: | Operating System: MacOS X Architecture: x86_64 (amd64) | Type of failure: Building GHC failed Difficulty: Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | ----------------------------------+---------------------------------------- I can't build GHC HEAD on Mavericks with Xcode 5 and GCC 4.2. My system: * Mavericks, Xcode 5. * Building with GHC 7.6.3 x64 installed from . * Apple GCC 4.2 installed via homebrew. In /Library/Frameworks/GHC.framework/Versions/7.6.3-x86_64/usr/lib/ghc-7.6.3/settings, I've changed the compiled to this: ("C compiler command", "/Users/nkpart/bin/gcc"), ~/bin/gcc is #!/bin/sh echo $* >> ~/bin/gcc_log gcc-4.2 $@ I have run: $ git clone .. $ perl boot $ ./configure $ make The error I get is: "/usr/bin/ghc" -M -static -H64m -O0 -fasm -package-db libraries/bootstrapping.conf -i -iutils/genprimopcode/. -iutils/genprimopcode/dist/build -iutils/genprimopcode/dist/build/autogen -Iutils/genprimopcode/dist/build -Iutils/genprimopcode/dist/build/autogen -package array -no-user-package-db -rtsopts -odir utils/genprimopcode/dist/build -hidir utils/genprimopcode/dist/build -stubdir utils/genprimopcode/dist/build -dep-makefile utils/genprimopcode/dist/build/.depend.haskell.tmp -dep-suffix "" -include-pkg-deps utils/genprimopcode/dist/build/Lexer.hs utils/genprimopcode/./Main.hs utils/genprimopcode/./ParserM.hs utils/genprimopcode/dist/build/Parser.hs utils/genprimopcode/./Syntax.hs line-map.c: file "templates/GenericTemplate.hs" left but not entered utils/genprimopcode/dist/build/Lexer.hs:143:0: error: #else without #if utils/genprimopcode/dist/build/Lexer.hs:144:0: warning: "GTE" redefined utils/genprimopcode/dist/build/Lexer.hs:141:0: warning: this is the location of the previous definition utils/genprimopcode/dist/build/Lexer.hs:145:0: warning: "EQ" redefined utils/genprimopcode/dist/build/Lexer.hs:142:0: warning: this is the location of the previous definition utils/genprimopcode/dist/build/Lexer.hs:146:0: error: #endif without #if utils/genprimopcode/dist/build/Lexer.hs:197:0: error: #else without #if utils/genprimopcode/dist/build/Lexer.hs:200:0: error: #endif without #if make[1]: *** [utils/genprimopcode/dist/build/.depend.haskell] Error 1 make: *** [all] Error 2 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8528> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 14

[GHC] #8545: Reorganize Git repositories
by GHC 18 Nov '14

18 Nov '14

#8545: Reorganize Git repositories ------------------------------------+------------------------------------- Reporter: hvr | Owner: hvr Type: task | Status: new Priority: normal | Milestone: 7.10.1 Component: Trac & Git | Version: Keywords: git | Operating System: Unknown/Multiple Architecture: Unknown/Multiple | Type of failure: None/Unknown Difficulty: Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #8251 | ------------------------------------+------------------------------------- This is to track the progress for the GitRepoReorganization which is to be tackled post-7.8 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8545> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 17

[GHC] #8559: Compiling dph-lifted fails with "NoSpecConstr" not in scope
by GHC 18 Nov '14

18 Nov '14

#8559: Compiling dph-lifted fails with "NoSpecConstr" not in scope -------------------------------------+------------------------------------- Reporter: trommler | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Data Parallel | Version: 7.7 Haskell | Operating System: Linux Keywords: | Type of failure: Building GHC Architecture: powerpc64 | failed Difficulty: Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | -------------------------------------+------------------------------------- Building ghc-7.7.20131120 fails with this on powerpc64 Linux: {{{ "inplace/bin/ghc-stage2" -hisuf hi -osuf o -hcsuf hc -static -H32m -O -package-name dph-lifted-copy-0.8.0.1 -hide-all-packages -i -ilibraries/dph/dph-lifted-copy/. -ilibraries/dph/dph-lifted-copy/dist- install/build -ilibraries/dph/dph-lifted-copy/dist-install/build/autogen -Ilibraries/dph/dph-lifted-copy/dist-install/build -Ilibraries/dph/dph- lifted-copy/dist-install/build/autogen -Ilibraries/dph/dph-lifted-copy/. -optP-include -optPlibraries/dph/dph-lifted-copy/dist- install/build/autogen/cabal_macros.h -package array-0.5.0.0 -package base-4.7.0.0 -package dph-base-0.8.0.1 -package dph-prim-par-0.8.0.1 -package ghc-7.7.20131115 -package random-1.0.1.1 -package template- haskell-2.9.0.0 -package vector-0.10.9.1 -Odph -funbox-strict-fields -fcpr-off -fno-warn-orphans -fno-warn-missing-signatures -XHaskell98 -XTypeFamilies -XGADTs -XRankNTypes -XBangPatterns -XMagicHash -XUnboxedTuples -XTypeOperators -O2 -no-user-package-db -rtsopts -odir libraries/dph/dph-lifted-copy/dist-install/build -hidir libraries/dph/dph-lifted-copy/dist-install/build -stubdir libraries/dph /dph-lifted-copy/dist-install/build -c libraries/dph/dph-lifted- copy/./Data/Array/Parallel/PArray/PData.hs -o libraries/dph/dph-lifted- copy/dist-install/build/Data/Array/Parallel/PArray/PData.o [23775s] [23775s] libraries/dph/dph-lifted- copy/Data/Array/Parallel/PArray/PData.hs:49:20: [23775s] Not in scope: data constructor `NoSpecConstr' [23775s] make[1]: *** [libraries/dph/dph-lifted-copy/dist- install/build/Data/Array/Parallel/PArray/PData.o] Error 1 [23775s] make: *** [all] Error 2 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8559> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 1

[GHC] #9057: Remove /usr/bin/… references
by GHC 18 Nov '14

18 Nov '14

#9057: Remove /usr/bin/… references -------------------------------------------+------------------------------- Reporter: Fuuzetsu | Owner: Type: task | Status: new Priority: normal | Milestone: Component: Build System | Version: 7.8.2 Keywords: | Operating System: Architecture: Unknown/Multiple | Unknown/Multiple Difficulty: Easy (less than 1 hour) | Type of failure: Blocked By: | None/Unknown Related Tickets: | Test Case: | Blocking: -------------------------------------------+------------------------------- The use of /usr/bin/perl in sync-all makes it difficult to work with on distros which don't store binaries in /usr/bin, such as NixOS. A more portable solution would be to use /usr/bin/env perl. It'd be very nice if someone turned such shebangs to use env rather than direct reference. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9057> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 9

[GHC] #8627: mallocForeignPtrBytes documentation unobvious regarding memory alignment
by GHC 17 Nov '14

17 Nov '14

#8627: mallocForeignPtrBytes documentation unobvious regarding memory alignment ------------------------------------+------------------------------------- Reporter: schernichkin | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Documentation | Version: 7.6.3 Keywords: | Operating System: Unknown/Multiple Architecture: Unknown/Multiple | Type of failure: None/Unknown Difficulty: Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | ------------------------------------+------------------------------------- According to the current documentation: mallocForeignPtr - is equivalent to do { p <- malloc; newForeignPtr finalizerFree p }. It's ok since we can read that the "block of memory is sufficiently aligned" if the mallocBytes function descriprion and newAlignedPinnedByteArray in the function implementation. mallocForeignPtrBytes - "similar to mallocForeignPtr" but will it alloc aligned memory? Internally it uses newPinnedByteArray which implies memory will not be aligned, but does it really makes any sense? Plz correct documentation to make it more obvious. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8627> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 3

[GHC] #8647: Reduce allocations in `integer-gmp`
by GHC 17 Nov '14

17 Nov '14

#8647: Reduce allocations in `integer-gmp` ------------------------------+-------------------------------------------- Reporter: hvr | Owner: Type: task | Status: new Priority: normal | Milestone: 7.8.1 Component: libraries | Version: 7.6.3 (other) | Operating System: Unknown/Multiple Keywords: | Type of failure: Runtime performance bug Architecture: x86_64 | Test Case: (amd64) | Blocking: Difficulty: Unknown | Blocked By: | Related Tickets: #8638 | ------------------------------+-------------------------------------------- I've added `printf(3)`s to `integer-gmp`s GMP allocation/reallocation functions, and noticed there to a significant amount of allocations going on. This is due to the fact that the CMM wrappers call `gmpz_init()` to initialize the result, and this already allocates a 1-limb `StgArray`. But the actual GMP operations perform a reallocate-call (which by contract also needs `memcpy` the untouched limb over to the newly allocated structure) based on the type of operation and the involved operands, causing the optimistically allocated 1-limb structure to become garbage right away w/o even being written to. I've been able to get rid of most such superfluous allocations by replacing {{{#!c ccall __gmpz_init(mp_result1 "ptr"); }}} by {{{#!c MP_INT__mp_alloc(mp_result1) = 0; MP_INT__mp_size(mp_result1) = 0; MP_INT__mp_d(mp_result1) = 0; // (1) }}} which is handled properly by all GMP operations we make use of currently. This elegantly lets the very first allocation be performed within the GMP operation (which has better knowledge with respect to how many limbs the result will require) I've got working proof-of-concept code, which reduces the allocations the big-num heavy `nofib` programs (I've omitted the benchmarks which had a 0% allocation change): {{{ -------------------------------------------------------------------------------- Program Size Allocs Runtime Elapsed TotalMem -------------------------------------------------------------------------------- ... bernouilli -0.1% -5.2% 0.12 0.12 +0.0% kahan -0.1% -10.5% 0.17 0.17 +0.0% primetest -0.1% -12.8% 0.07 0.07 +0.0% rsa -0.1% -13.8% 0.02 0.02 +0.0% symalg -0.1% -2.3% 0.01 0.01 +0.0% ... -------------------------------------------------------------------------------- Min -0.1% -13.8% -3.1% -3.1% -6.5% Max -0.0% +0.4% +4.0% +4.0% +1.5% Geometric Mean -0.1% -0.5% +0.5% +0.4% -0.1% }}} `(1)` This should actually point to a proper static closure I didn't need this for the proof-of-concept ---- Another place which helps avoiding temporarily allocating 1-limb `StgArrays` which live only for the duration of GMP FFI calls are those caused by the `toBig`-casts, which I'm also experimenting by making use of GMP's big-int/small-int add/sub/mul primitives (the deltas shown above are actually measured on top of this optimization), here's what to expect from such an optimization by itself (i.e. w/o the realloc-optimization from above): {{{ bernouilli +0.1% -4.2% 0.12 0.12 +0.0% kahan +0.1% -12.6% 0.17 0.17 +0.0% power +0.1% -2.7% +2.2% +2.2% +0.0% rsa +0.1% -4.1% 0.02 0.02 +0.0% scs +0.1% -2.6% -1.6% -1.6% +0.0% }}} Thus, the `kahan` benchmark benefits from this optimization by -12.6%, and on top of that another -10.5% by also avoiding the GMP-reallocations. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/8647> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 20