Re: [GHC] #13076: GHC panics can cause text-formatting changes from colorized error messages to linger

#13076: GHC panics can cause text-formatting changes from colorized error messages to linger -------------------------------------+------------------------------------- Reporter: RyanGlScott | Owner: Type: bug | Status: patch Priority: high | Milestone: 8.2.1 Component: Compiler | Version: 8.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: #8809, #12785 | Differential Rev(s): Phab:D2932 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari ): In [changeset:"22845adcc51b40040b9d526c36d2d36edbb11dd7/ghc" 22845ad/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="22845adcc51b40040b9d526c36d2d36edbb11dd7" Fix terminal corruption bug and clean up SDoc interface. - Fix #13076 by wrapping `printDoc_` so that the terminal color is reset even if an exception occurs. - Add `printSDoc`, `printSDocLn`, and `bufLeftRenderSDoc` to keep `SDoc` values abstract (they are wrappers of `printDoc_`, `printDoc`, and `bufLeftRender` respectively). - Remove unused function: `printForAsm` Test Plan: manual Reviewers: RyanGlScott, austin, dfeuer, bgamari Reviewed By: dfeuer, bgamari Subscribers: dfeuer, mpickering, thomie Differential Revision: https://phabricator.haskell.org/D2932 GHC Trac Issues: #13076 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13076#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler