Re: [GHC] #14189: Renamer does not preserve location for IEThingWith list items

15 Sep 2017

      #14189: Renamer does not preserve location for IEThingWith list items
-------------------------------------+-------------------------------------
        Reporter:  alanz             |                Owner:  alanz
            Type:  bug               |               Status:  new
        Priority:  normal            |            Milestone:  8.2.2
       Component:  Compiler          |              Version:  8.2.1
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
 Type of failure:  Incorrect API     |  Unknown/Multiple
  annotation                         |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D3968
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari ):

 In [changeset:"9498c50ef5af2680305e0aaea6f32439cacc3da0/ghc" 9498c50/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="9498c50ef5af2680305e0aaea6f32439cacc3da0"
 Renamer now preserves location for IEThingWith list items

 Prior to this, in the RenamedSource for

     module Renaming.RenameInExportedType
       (
       MyType (NT)
       ) where

     data MyType = MT Int | NT

 The (NT) was given the location of MyType earlier on the line in the
 export list.

 Also the location was discarded for any field labels, and replaced with
 a `noLoc`.

 Test Plan: ./validate

 Reviewers: bgamari, austin

 Reviewed By: bgamari

 Subscribers: rwbarton, thomie

 GHC Trac Issues: #14189

 Differential Revision: https://phabricator.haskell.org/D3968
 }}}

-- 
Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14189#comment:4
GHC http://www.haskell.org/ghc/
The Glasgow Haskell Compiler