[GHC] #15968: configure doesn't error out when --enable-dwarf-unwind is given but libdw cannot be found
#15968: configure doesn't error out when --enable-dwarf-unwind is given but libdw cannot be found -------------------------------------+------------------------------------- Reporter: nh2 | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.8.1 Component: Build System | Version: 8.6.2 (make) | Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Other Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- Against expectations, the GHC bindist supposedly having DWARF support provided at https://downloads.haskell.org/~ghc/8.4.4/ghc-8.4.4-x86_64-deb9-linux- dwarf.tar.xz doesn't actually have DWARF support. According to bgamari, this is because `./configure --enable-dwarf-unwind` doesn't actually complain when the required dependency `libdw` isn't found; instead, it continues silently. Most programs I know will barf out when something isn't found but also *explicitly* requested via the command line; for the cases where this wasn't, the project maintainers did consider this a bug. GHC's `./configure` suite should fail hard when `--enable-dwarf-unwind` is given but `libdw` cannot be found. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15968> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15968: configure doesn't error out when --enable-dwarf-unwind is given but libdw cannot be found -------------------------------------+------------------------------------- Reporter: nh2 | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: 8.8.1 Component: Build System | Version: 8.6.2 (make) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D5424 Wiki Page: | -------------------------------------+------------------------------------- Changes (by harpocrates): * status: new => patch * differential: => Phab:D5424 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15968#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15968: configure doesn't error out when --enable-dwarf-unwind is given but libdw cannot be found -------------------------------------+------------------------------------- Reporter: nh2 | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: 8.8.1 Component: Build System | Version: 8.6.2 (make) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D5424 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"cb882fc993b4972f7f212b291229ef9e9ade0af9/ghc" cb882fc/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="cb882fc993b4972f7f212b291229ef9e9ade0af9" Require 'libdw' for '--enable-dwarf-unwind' This causes './configure --enable-dwarf-unwind' to exit with a helpful error message when 'libdw' cannot be found (compared to the previous behaviour of silently pretending the user hadn't requested DWARF support at all). Test Plan: ./configure --enable-dwarf-unwind # on systems with/without libdw Reviewers: bgamari, nh2 Reviewed By: nh2 Subscribers: nh2, rwbarton, erikd, carter GHC Trac Issues: #15968 Differential Revision: https://phabricator.haskell.org/D5424 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15968#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15968: configure doesn't error out when --enable-dwarf-unwind is given but libdw cannot be found -------------------------------------+------------------------------------- Reporter: nh2 | Owner: (none) Type: bug | Status: closed Priority: normal | Milestone: 8.8.1 Component: Build System | Version: 8.6.2 (make) | Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D5424 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15968#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15968: configure doesn't error out when --enable-dwarf-unwind is given but libdw cannot be found -------------------------------------+------------------------------------- Reporter: nh2 | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.8.1 Component: Build System | Version: 8.6.2 (make) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D5424 Wiki Page: | -------------------------------------+------------------------------------- Changes (by nh2): * status: closed => new * resolution: fixed => Comment: Reopening because the merged patch has a syntax error (missing `,` that none of us spotted, including `autoconf`). -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15968#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15968: configure doesn't error out when --enable-dwarf-unwind is given but libdw cannot be found -------------------------------------+------------------------------------- Reporter: nh2 | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.8.1 Component: Build System | Version: 8.6.2 (make) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D5424 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"126aa794743b807b7447545697b96dd165ec3e16/ghc" 126aa79/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="126aa794743b807b7447545697b96dd165ec3e16" Add missing comma in 'libdw' configure check Fix a bug from cb882fc993b4972f7f212b291229ef9e9ade0af9. Without the comma, all non-diverging codepaths set 'UseLibdw=NO'. Reviewers: bgamari, nh2 Reviewed By: nh2 Subscribers: rwbarton, erikd, carter GHC Trac Issues: #15968 Differential Revision: https://phabricator.haskell.org/D5459 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15968#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15968: configure doesn't error out when --enable-dwarf-unwind is given but libdw cannot be found -------------------------------------+------------------------------------- Reporter: nh2 | Owner: (none) Type: bug | Status: closed Priority: normal | Milestone: 8.8.1 Component: Build System | Version: 8.6.2 (make) | Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D5424 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15968#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC