[GHC] #15995: Make Control.Concurrent.QSem a newtype
#15995: Make Control.Concurrent.QSem a newtype -------------------------------------+------------------------------------- Reporter: chessai | Owner: (none) Type: feature | Status: new request | Priority: normal | Milestone: 8.6.3 Component: | Version: 8.6.2 libraries/base | Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- {{{#!hs data QSem = QSem !(MVar (Int, [MVar ()], [MVar ()])) }}} I think this should be a newtype. The strictness annotations on the outter `MVar` could just be at each site where pattern matching on the `QSem`. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15995> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15995: Make Control.Concurrent.QSem a newtype -------------------------------------+------------------------------------- Reporter: chessai | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: 8.6.3 Component: libraries/base | Version: 8.6.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by chessai): this goes for `QSemN` too. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15995#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15995: Make Control.Concurrent.QSem a newtype -------------------------------------+------------------------------------- Reporter: chessai | Owner: (none) Type: feature request | Status: new Priority: normal | Milestone: Component: libraries/base | Version: 8.6.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"f5e98bb31cf4dae740c8dc598ef207aa79d5a179/ghc" f5e98bb/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="f5e98bb31cf4dae740c8dc598ef207aa79d5a179" make QSem and QSemN newtypes Reviewers: RyanGlScott, ekmett, hvr, bgamari Reviewed By: bgamari Subscribers: rwbarton, carter GHC Trac Issues: #15995 Differential Revision: https://phabricator.haskell.org/D5456 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15995#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15995: Make Control.Concurrent.QSem a newtype -------------------------------------+------------------------------------- Reporter: chessai | Owner: (none) Type: feature request | Status: closed Priority: normal | Milestone: 8.8.1 Component: libraries/base | Version: 8.6.2 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed * milestone: => 8.8.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15995#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC