[GHC] #15372: GHCi leaks in DEBUG mode
#15372: GHCi leaks in DEBUG mode -------------------------------------+------------------------------------- Reporter: goldfire | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.4.3 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- The solution to ticket #15111 fixes some space leaks in GHCi. That ticket also installs `-fghci-leak-check` to the testsuite, so that we'll know when these leaks return. This is all good. However, the `DEBUG` compile still leaks in GHCi. This means that many ghci tests fail in the testsuite when using a `DEBUG` compiler. I thus have two requests: 1. (hopefully quick) Teach the testsuite not to use `-fghci-leak-check` on a `DEBUG` compiler. I tried to do this myself but got lost, never having worked on the testsuite harness. 2. Fix the leaks. If someone could post the fix to (1) in the short term (even if you don't commit it), I'd be grateful. This is holding me up. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15372 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15372: GHCi leaks in DEBUG mode -------------------------------------+------------------------------------- Reporter: goldfire | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.4.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #15246 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by RyanGlScott): * cc: simonmar (added) * related: => #15246 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15372#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15372: GHCi leaks in DEBUG mode -------------------------------------+------------------------------------- Reporter: goldfire | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.4.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #15246 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by simonmar): Try this? {{{ diff --git a/testsuite/config/ghc b/testsuite/config/ghc index f41f372..dde5bac 100644 --- a/testsuite/config/ghc +++ b/testsuite/config/ghc @@ -80,7 +80,7 @@ config.way_flags = { 'prof_no_auto' : ['-prof', '-static', '-fasm'], 'profasm' : ['-O', '-prof', '-static', '-fprof-auto'], 'profthreaded' : ['-O', '-prof', '-static', '-fprof-auto', '-threaded'], - 'ghci' : ['--interactive', '-v0', '-ignore-dot-ghci', '-fno- ghci-history', '-fghci-leak-check', '+RTS', '-I0.1', '-RTS'], + 'ghci' : ['--interactive', '-v0', '-ignore-dot-ghci', '-fno- ghci-history', '+RTS', '-I0.1', '-RTS'] + ['-fghci-leak-check'] if not config.compiler_debugged else [], 'sanity' : ['-debug'], 'threaded1' : ['-threaded', '-debug'], 'threaded1_ls' : ['-threaded', '-debug'], }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15372#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15372: GHCi leaks in DEBUG mode -------------------------------------+------------------------------------- Reporter: goldfire | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.4.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #15246 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by goldfire): That almost worked. Here is the correct line: {{{ 'ghci' : ['--interactive', '-v0', '-ignore-dot-ghci', '-fno- ghci-history', '+RTS', '-I0.1', '-RTS'] + (['-fghci-leak-check'] if not config.compiler_debugged else []), }}} Note the parens around the new bit. I will push my changes shortly, hopefully. Thanks for the quick response! -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15372#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15372: GHCi leaks in DEBUG mode
-------------------------------------+-------------------------------------
Reporter: goldfire | Owner: (none)
Type: bug | Status: new
Priority: normal | Milestone: 8.6.1
Component: Compiler | Version: 8.4.3
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: #15246 | Differential Rev(s):
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Richard Eisenberg
#15372: GHCi leaks in DEBUG mode -------------------------------------+------------------------------------- Reporter: goldfire | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.4.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #15246 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by goldfire): NB: comment:4 does not fix this bug, solving only issue (1) from the OP. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15372#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15372: GHCi leaks in DEBUG mode -------------------------------------+------------------------------------- Reporter: goldfire | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.4.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #15246 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by simonmar): I'm OK with not fixing this. Even if we fixed it once, it would be impractical to keep it fixed in the long run. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15372#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15372: GHCi leaks in DEBUG mode -------------------------------------+------------------------------------- Reporter: goldfire | Owner: (none) Type: bug | Status: closed Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.4.3 Resolution: wontfix | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #15246 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by goldfire): * status: new => closed * resolution: => wontfix Comment: comment:6 sounds reasonable to me. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15372#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC