#15101: $tooldir not expanded for NoFib -------------------------------------+------------------------------------- Reporter: AndreasK | Owner: alpmestan Type: bug | Status: new Priority: normal | Milestone: 8.6.1 Component: NoFib benchmark | Version: suite | Resolution: | Keywords: Operating System: Windows | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by alpmestan): * cc: alpmestan (added) * owner: (none) => alpmestan Comment: On IRC, Andreas pointed me to the `--info` output for both 8.2.1 and HEAD. See [http://lpaste.net/365396 this lpaste]. The problem is that nofib uses the output of `--info` to set `CC` (and surely some other env vars), and we do not expand `$tooldir` in the `--info` output yet. We need to add a settings field `tooldir :: Maybe FilePath` and use it in `compilerInfo` to expand all occurences of `$tooldir`, using `expandToolDir`. The result should be a patch similar to [https://phabricator.haskell.org/D4222 this one], only for tooldir instead of topdir. I'll do my best to submit a diff that implements this sometimes this week. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15101#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#15101: $tooldir not expanded for NoFib -------------------------------------+------------------------------------- Reporter: AndreasK | Owner: alpmestan Type: bug | Status: patch Priority: normal | Milestone: 8.6.1 Component: NoFib benchmark | Version: suite | Resolution: | Keywords: Operating System: Windows | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4667 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Tamar Christina ): In [changeset:"37810347dfeda977e7036cf8bc87ba079f094baa/ghc" 3781034/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="37810347dfeda977e7036cf8bc87ba079f094baa" Expand $tooldir in ghc --info output Summary: This requires adding an `sToolDir :: Maybe FilePath` field to Settings, since compilerInfo is pure and therefore needs to have all the information available in the DynFlags. This should fix #15101 and #15107. Test Plan: ./validate --fast Reviewers: Phyx, bgamari Reviewed By: Phyx Subscribers: rwbarton, thomie, carter GHC Trac Issues: #15101, #15107 Differential Revision: https://phabricator.haskell.org/D4686 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15101#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#15101: $tooldir not expanded for NoFib -------------------------------------+------------------------------------- Reporter: AndreasK | Owner: alpmestan Type: bug | Status: closed Priority: normal | Milestone: 8.6.1 Component: NoFib benchmark | Version: suite | Resolution: fixed | Keywords: Operating System: Windows | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4667 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Phyx-): Thanks @alpmestan! -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15101#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler