Folks Olaf points out a problem with the specification of 'deriving' Show. In particular: | "The representation will be enclosed in parentheses | if the precedence of the top-level constructor operator in x | is less than d." Olaf proposes that we should change "less than" to "less than or equal to". His reasoning is below, and seems persuasive to me. Briefly, the consequences of the change would be: a) The current specification yields syntactically incorrect Haskell for some associativities. The changed specification would avoid this. b) The changed spec would yield more than the minimum number of parentheses. c) The current spec makes it hard for simple recursive descent parsers, such as that suggested by the Report for Read, to avoid divergence on left recursion. The changed spec makes it easy. d) The downside is that all compilers would need to change, slightly. Any comments? Simon | In all Haskell implementations (tested Hugs,Ghc and nhc98) | show sometimes produces output that does not represent | well-formed expressions. For example: | | data Tree a = Node a | Tree a :^: Tree a | Tree a ::: Tree a | deriving (Eq,Show) | | infixl 6 ::: | infixr 6 :^: | | main = print ((Node True :^: Node False) ::: Node True) | | yields | | Node True :^: Node False ::: Node True | | The expression is ill-formed because one constructor is left- | and the other one is right-associative. | | Finally, left-recursive data constructors that are | left-associative lead read into infinite recursion. Example: | | infixl 5 :^: | | data Tree a = Leaf a | Tree a :^: Tree a deriving (Show,Read) | | main = do | print (read "(Leaf True :^: Leaf False) :^: Leaf True" :: Tree Bool) | | | I have a solution for the two last problems. It means all | Haskell compilers have to change, but I believe that it is worth it. | | The source of the show problem is that show tries to handle | associativity of infix constructors. But there is no way to | do this correctly. showsPrec gets as argument the precedence | of the surounding expression, but not its associativity. This | associativity would be needed to use associativity of | constructors correctly. | | The solution is simple: dont' try to use associativity to | avoid parenthesis. Thus you get some superfluous paranthesis, | but the output is always correct and the implementation of | deriving is even a bit simpler. E.g.: | | showsPrec d (u :^: v) = showParen (d > 5) showStr | where | showStr = showsPrec 6 u . | showString " :^: " . | showsPrec 6 v | For all of | | infix 5 :^: | infixl 5 :^: | infixr 5 :^: | | The second advantage of this simplification is, that the | additional parentheses prevent infinite left recursion. You | can read in the tree expression given above, because | parentheses are now compulsory: | | instance (Read a) => Read (Tree a) where | | readsPrec d r = readParen (d > 5) | (\r -> [(u:^:v,w) | | (u,s) <- readsPrec 6 r, | (":^:",t) <- lex s, | (v,w) <- readsPrec 6 t]) r | | ++ readParen (d > 9) | (\r -> [(Leaf m,t) | | ("Leaf",s) <- lex r, | (m,t) <- readsPrec 10 s]) r | | What do you think? | | Discussing all the other minor problems with the report | specification doesn't make sense before this major issue is | cleared up. | | Ciao, | Olaf | | -- | OLAF CHITIL, | Dept. of Computer Science, The University of York, York YO10 | 5DD, UK. | URL: http://www.cs.york.ac.uk/~olaf/ | Tel: +44 1904 434756; Fax: +44 1904 432767 |