Alright, everything seems fine to me. Some more comments: * Besides the fact that I think HttpCIByteString is too verbose, it presents another problem: I cannot transparently switch over to it in WAI and http-enumerator. If you kept the same name (CIByteString), I could simply switch over to your version without any breaking changes. * I like methodGet et al. * Do you want to consider some parsing functions? I can provide you the code. Some things I would imagine would be: * parseQueryString :: ByteString -> [(ByteString, Maybe ByteString)] (I'm not sure if in practice anyone cares about the Maybe btw, but you are right that it is more theoretically correct) * renderQueryString :: [(ByteString, Maybe ByteString)] -> ByteString * parsePath :: ByteString -> [String], which would do all splitting-on-slash, percent decoding and UTF-8 decoding * renderPath :: [String] -> ByteString, which would be the reverse of parsePath * renderPathQuery :: [String] -> [(ByteString, ByteString)] -> ByteString * parseHttpAccept :: ByteString -> [ByteString] * Are you planning on adding headers as well? Basically, feel free to raid Network.Wai.Parse[1]. [1] http://hackage.haskell.org/packages/archive/wai-extra/0.3.1/doc/html/Network... On Fri, Feb 4, 2011 at 12:23 AM, Aristid Breitkreuz <aristidb@googlemail.com> wrote:
OK, I uploaded a fixed version: http://hackage.haskell.org/package/http-types-0.1.1
Good night! Aristid
2011/2/3 Aristid Breitkreuz <aristidb@googlemail.com>
Status 700 "Crazy status" ... but I forgot to export the Status constructor. That was an oversight. I made the same error with HttpVersion.
Aristid
2011/2/3 Michael Snoyman <michael@snoyman.com>
On Thu, Feb 3, 2011 at 11:42 PM, Aristid Breitkreuz <aristidb@googlemail.com> wrote:
Hi, I just wanted to announce that I uploaded a first version of http-types to hackage: http://hackage.haskell.org/package/http-types-0.1 This version is very much an Alpha version. And, uh, do give feedback: I promise that I will keep myself better in check, this time.
Aristid _______________________________________________ web-devel mailing list web-devel@haskell.org http://www.haskell.org/mailman/listinfo/web-devel
Quick question: how do you create new statuses?
Michael