Thanks Anton, I've pushed the patch. Unfortunately I've made a bit of a mess of the history by including both patches, and then needing to address the conflicts with another patch. Regards, Adam On Wed, Mar 4, 2015 at 3:36 AM, Anton Pirogov <anton.pirogov@gmail.com> wrote:
Hi Adam,
thank you for your suggestions! Indeed I didn't need those instances and I changed the message to your more flexible idea!
I don't know what is the right way to do it here and with darcs in general, I used "darcs obliterate --last 1" and recorded a new patch. Here is the updated patch, I hope it is ok now.
Regards, Anton
2015-03-04 1:03 GMT+01:00 adam vogt <vogt.adam@gmail.com>:
Hi Anton,
Do you actually need the Read/Show instances? I think it's better to put a function in the message:
data ModifySpacing = ModifySpacing (Int -> Int)
And possibly export these convenience functions:
setSpacing n = sendMessage (ModifySpacing (\_ -> n)) incSpacing n = sendMessage (ModifySpacing (+n))
Regards, Adam
On Tue, Mar 3, 2015 at 4:09 PM, Anton Pirogov <anton.pirogov@gmail.com> wrote:
This is such a small change that I think that it makes more sense to patch it, instead of rolling my own. It just adds the message, nothing more, so it does not break anything.
Thanks!
Best regards, Anton Pirogov
_______________________________________________ xmonad mailing list xmonad@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/xmonad
_______________________________________________ xmonad mailing list xmonad@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/xmonad