On Fri, Jun 29, 2012 at 2:45 PM, Carsten Mattner wrote:

On Fri, Jun 29, 2012 at 12:58 AM, Carlos López Camey wrote:

...

Hello,

please find attached the following patch.

I just built xmonad and xmonad-contrib+your_patch from darcs and it works. Thanks a lot.

I forgot if I did try to start the auto-selected completion but when I try now and hit Return it doesn't start the selected entry. Can you confirm this bug?

2012/8/1 Carsten Mattner :

On Fri, Jun 29, 2012 at 5:37 PM, Carsten Mattner wrote:

...

On Fri, Jun 29, 2012 at 2:45 PM, Carsten Mattner wrote:

...

On Fri, Jun 29, 2012 at 12:58 AM, Carlos López Camey wrote:

...

Hello,

please find attached the following patch.

I just built xmonad and xmonad-contrib+your_patch from darcs and it works. Thanks a lot.

I forgot if I did try to start the auto-selected completion but when I try now and hit Return it doesn't start the selected entry. Can you confirm this bug?

Carlos any bug update?

Hello Carsten, I apologize for the very late response. I wanted to give a full one but I haven't fixed the bug yet. It happens on my setup too, if I remember correctly it is due to the function highlightedItem returning an empty String as a result of having no completion window (a Nothing). I don't know why that is happening (comments appreciated) A completion window is needed to know the number of rows and columns of the window because the index in the state is in terms of a current row and a current column. I will try to get the (Maybe) current autocompletion String saved in the state instead of the index, but that may lead to possible invalid states (e.g. XPS { complString = Just "google-chrome", alwaysHighlight=False}). Did you try the other module? Cheers, Carlos

2012/6/29 Carsten Mattner :

On Fri, Jun 29, 2012 at 2:45 PM, Carsten Mattner wrote:

...

On Fri, Jun 29, 2012 at 12:58 AM, Carlos López Camey wrote:

...

Hello,

please find attached the following patch.

I just built xmonad and xmonad-contrib+your_patch from darcs and it works. Thanks a lot.

I forgot if I did try to start the auto-selected completion but when I try now and hit Return it doesn't start the selected entry. Can you confirm this bug?

I believe the attached patch contains the fix. It also contains the previous two patches. I hope that the changes on import indentations are not a problem with code guidelines (stylish-haskell does that). cheers, Carlos

On Sun, Aug 12, 2012 at 4:18 PM, Carsten Mattner wrote:

On Sat, Aug 11, 2012 at 5:43 PM, Carlos López Camey wrote:

...

2012/6/29 Carsten Mattner :

...

On Fri, Jun 29, 2012 at 2:45 PM, Carsten Mattner wrote:

...

On Fri, Jun 29, 2012 at 12:58 AM, Carlos López Camey wrote:

...

Hello,

please find attached the following patch.

I just built xmonad and xmonad-contrib+your_patch from darcs and it works. Thanks a lot.

I forgot if I did try to start the auto-selected completion but when I try now and hit Return it doesn't start the selected entry. Can you confirm this bug?

I believe the attached patch contains the fix. It also contains the previous two patches.

I hope that the changes on import indentations are not a problem with code guidelines (stylish-haskell does that).

cheers, Carlos

Patch works, thanks Carlos.

Carlos any idea when this will be applied upstream?

On Thu, Aug 16, 2012 at 11:03 AM, Carlos López Camey wrote:

2012/8/15 Carsten Mattner :

...

On Sun, Aug 12, 2012 at 4:18 PM, Carsten Mattner wrote:

...

On Sat, Aug 11, 2012 at 5:43 PM, Carlos López Camey wrote:

...

2012/6/29 Carsten Mattner :

...

On Fri, Jun 29, 2012 at 2:45 PM, Carsten Mattner wrote:

...

On Fri, Jun 29, 2012 at 12:58 AM, Carlos López Camey wrote: > Hello, > > please find attached the following patch.

I just built xmonad and xmonad-contrib+your_patch from darcs and it works. Thanks a lot.

I forgot if I did try to start the auto-selected completion but when I try now and hit Return it doesn't start the selected entry. Can you confirm this bug?

I believe the attached patch contains the fix. It also contains the previous two patches.

I hope that the changes on import indentations are not a problem with code guidelines (stylish-haskell does that).

cheers, Carlos

Patch works, thanks Carlos.

Carlos any idea when this will be applied upstream?

Nope, no idea. I'm sure the people who have the power have seen this and other patches. Maybe they haven't tested it or they are waiting for people to test it.

Guess I'll have to report then that the launcher patch has been working well for a couple weeks of daily use now. Therefore I suggest to apply it upstream in XMonadContrib.

2012/8/26 Gwern Branwen :

I haven't been following this discussion very closely since it started last month. What's the latest version of each patch, what do they do, and who vouches for them?

Hello Gwern, I am attaching the latest set of patches, which contains a bug fix and documentation improvements. Changes: * Add an option `alwaysHighlight :: Bool` to XPConfig which always highlights the first completion if it is True. * Add mkPromptWithModes, which creates a XPrompt given a list of XPrompt`s.

On Fri, Sep 14, 2012 at 11:04 PM, Gwern Branwen wrote:

On Sun, Aug 26, 2012 at 5:30 AM, Carlos López Camey wrote:

...

Hello Gwern, I am attaching the latest set of patches, which contains a bug fix and documentation improvements.

Changes: * Add an option `alwaysHighlight :: Bool` to XPConfig which always highlights the first completion if it is True. * Add mkPromptWithModes, which creates a XPrompt given a list of XPrompt`s.

If no one objects, I will push this set of patches in a week.

I've pushed this patch-bundle of 7 patches. -- gwern http://www.gwern.net

This 4-patches bundle was just applied to http://code.haskell.org/XMonadContrib: 20120628101749 c.lopez@kmels.net * Changes on XPrompt: * Adds mkPromptWithModes, creates a prompt given a list of modes (list of XPType). * Adds Setting `alwaysHighlight` to defaultXPConfig. When set to true, autocompletion always highlight the first result if it is not highlighted. Adds module XMonad.Actions.Launcher. This module allows to combine and switch between instances of XPrompt. It includes a default set of modes which require the programs `hoogle`, `locate` and `calc` to be installed to work properly. 20120628114533 c.lopez@kmels.net * Removes warnings, adds a browser value for LauncherConfig in haddock comments 20120811104805 c.lopez@kmels.net * Correctly get the autocompletion item when alwaysHighlight in XMonad.Prompt is True 20120811112502 c.lopez@kmels.net * Fixes typos in Actions.Launcher haddock documentation -- This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__code.haskell.org_XMonadContrib.html...

On Fri, Jun 29, 2012 at 3:16 PM, wrote:

You could consider sending a patch to xmonad-extras if you want to add something with extra dependencies. A dependency on dbus makes me especially wary, though. If you only need to send things on dbus or can do your sends and receives synchronously, you should be fine; but if you need to send and receive asynchronously, you're a bit out of luck: xmonad currently runs on a single OS thread, which will be blocking in an X call most of the time.

We need to fix that at some point; Xlib exports a macro that can be used to get at the fd and tell the I/O manager about it, then we make non-blocking XNextEvent() calls, which would make multithreaded behave more sanely even if Xlib is left nonthreaded for performance. Built with -threaded, a forkOS thread could do dbus calls and then establish its own Xlib connection and XSendEvent() or install a property on the root window to relay the result. This doesn't necessarily need to be a one-way connection, but nothing in the main thread can block to wait on a response from the dbus thread (instead, use handleEventHook). -- brandon s allbery allbery.b@gmail.com wandering unix systems administrator (available) (412) 475-9364 vm/sms

Oh, interesting. Thanks for the note. I don't know if the communication is asynchronous but I would guess so.. I will check and I hope not. Are you (or Brandon) normally in IRC? 2012/6/29 :

You could consider sending a patch to xmonad-extras if you want to add something with extra dependencies. A dependency on dbus makes me especially wary, though. If you only need to send things on dbus or can do your sends and receives synchronously, you should be fine; but if you need to send and receive asynchronously, you're a bit out of luck: xmonad currently runs on a single OS thread, which will be blocking in an X call most of the time.

~d

Quoting Carlos López Camey :

...

Hello,

please find attached the following patch.

I have a question in case it gets applied. I'd like to improve the mode to search for files (locate isn't fast/good enough). So far I thought of tracker [0] and recollq [1] but as noted none seemed 100% right. I thought of loading the db written by 'updatedb' in the memory [2] but I don't know if that's acceptable as xmonad tries to stay lightweight.

cheers, Carlos

[0] it would be fast, but it needs to add dbus as a dependency http://projects.gnome.org/tracker/ [1] the query language doesn't apply to file *names* only (it works to search for terms *in* files) http://www.lesbonscomptes.com/recoll/ [2] my mlocate.db is 37M for a 1.5TB disk

Comments on the patch: ------------- 2 patches for repository http://code.haskell.org/XMonadContrib:

Thu Jun 28 12:17:49 CEST 2012 c.lopez@kmels.net * Changes on XPrompt:

* Adds mkPromptWithModes, creates a prompt given a list of modes (list of XPType).

* Adds Setting `alwaysHighlight` to defaultXPConfig. When set to true, autocompletion always highlight the first result if it is not highlighted.

Adds module XMonad.Actions.Launcher. This module allows to combine and switch between instances of XPrompt. It includes a default set of modes which require the programs `hoogle`, `locate` and `calc` to be installed to work properly.

Thu Jun 28 13:45:33 CEST 2012 c.lopez@kmels.net * Removes warnings, adds a browser value for LauncherConfig in haddock comments

_______________________________________________ xmonad mailing list xmonad@haskell.org http://www.haskell.org/mailman/listinfo/xmonad

I'm "dmwit" in #xmonad. Not always around, but a lot. ~d Quoting Carlos López Camey :

Oh, interesting. Thanks for the note.

I don't know if the communication is asynchronous but I would guess so.. I will check and I hope not. Are you (or Brandon) normally in IRC?

2012/6/29 :

...

You could consider sending a patch to xmonad-extras if you want to add something with extra dependencies. A dependency on dbus makes me especially wary, though. If you only need to send things on dbus or can do your sends and receives synchronously, you should be fine; but if you need to send and receive asynchronously, you're a bit out of luck: xmonad currently runs on a single OS thread, which will be blocking in an X call most of the time.

~d

Quoting Carlos López Camey :

...

Hello,

please find attached the following patch.

I have a question in case it gets applied. I'd like to improve the mode to search for files (locate isn't fast/good enough). So far I thought of tracker [0] and recollq [1] but as noted none seemed 100% right. I thought of loading the db written by 'updatedb' in the memory [2] but I don't know if that's acceptable as xmonad tries to stay lightweight.

cheers, Carlos

[0] it would be fast, but it needs to add dbus as a dependency http://projects.gnome.org/tracker/ [1] the query language doesn't apply to file *names* only (it works to search for terms *in* files) http://www.lesbonscomptes.com/recoll/ [2] my mlocate.db is 37M for a 1.5TB disk

Comments on the patch: ------------- 2 patches for repository http://code.haskell.org/XMonadContrib:

Thu Jun 28 12:17:49 CEST 2012 c.lopez@kmels.net * Changes on XPrompt:

* Adds mkPromptWithModes, creates a prompt given a list of modes (list of XPType).

* Adds Setting `alwaysHighlight` to defaultXPConfig. When set to true, autocompletion always highlight the first result if it is not highlighted.

Adds module XMonad.Actions.Launcher. This module allows to combine and switch between instances of XPrompt. It includes a default set of modes which require the programs `hoogle`, `locate` and `calc` to be installed to work properly.

Thu Jun 28 13:45:33 CEST 2012 c.lopez@kmels.net * Removes warnings, adds a browser value for LauncherConfig in haddock comments

_______________________________________________ xmonad mailing list xmonad@haskell.org http://www.haskell.org/mailman/listinfo/xmonad