On 02/26/2012 05:18 PM, Gwern Branwen wrote:

On Sun, Feb 26, 2012 at 7:16 AM, Steffen Schuldenzucker wrote:

...

Hey Guys,

a tiny fix. Contributing never felt this painless. Awesome work, really!

-- Steffen

1 patch for repository http://code.haskell.org/XMonadContrib:

Sun Feb 26 11:52:29 CET 2012 Steffen Schuldenzucker * Prompt.Directory: fix completion for paths containing whitespace

Are you sure that works right? It looks a little dodgy - for example, is it right to match only on ' ' and not use something like Data.Char.isSpace?

Naah, of course you're right. In particular, it will drop backslashs from directories containing ones. I'll fix it as soon as I find some time.

On Mon, Feb 27, 2012 at 7:32 AM, Steffen Schuldenzucker wrote:

On 02/26/2012 05:18 PM, Gwern Branwen wrote:

...

On Sun, Feb 26, 2012 at 7:16 AM, Steffen Schuldenzucker  wrote:

...

Hey Guys,

a tiny fix. Contributing never felt this painless. Awesome work, really!

-- Steffen

1 patch for repository http://code.haskell.org/XMonadContrib:

Sun Feb 26 11:52:29 CET 2012  Steffen Schuldenzucker  * Prompt.Directory: fix completion for paths containing whitespace

Are you sure that works right? It looks a little dodgy - for example, is it right to match only on ' ' and not use something like Data.Char.isSpace?

Second try... (amended my previous patch)

Note that L.WorkspaceDir.changeDir still won't work without my other patch

Mon Feb 27 13:20:04 CET 2012  Steffen Schuldenzucker  * fix L.WorkspaceDir special char handling: remove "echo -n" processing

Anyone else want to comment on this? If not, I'll push in 5 days. -- gwern http://www.gwern.net