May 2006 - C2hs - Haskell.org

darcs patch: Try parsing C99 compound literals (and 2 more)
by Duncan Coutts 29 May '06

29 May '06

A bunch of patches to the C parser. These need reviewing and testing. The first one seems to fix Ville's problem with parsing xmmintrin.h at least when still using c2hs -C-D__extension__= The second fixes it for me even without using -C-D__extension__= The reason was that the gramar was such that if it saw the __extension__ keyword at the beginning of an external decleration then it assumed that it could only be a data decleration and not a function decleration. This changes the __extension__ handling about quite a bit but the end result is that it allows __extension__ on functions too, which was the problem in Ville's example. This is the change that most needs testing since while it may fix this use of __extension__ is may break others where we were previously working ok. I guess we really need a regression test that tries loads of common system headers eg /usr/include/*.h . The last is mainly a tidy up. It hides a shift/reduce conflict. I checked that it doesn't change the parser's state transition tables. Still I'm not sure if using context-dependent precedence should be necessary here. Duncan Mon May 29 11:50:14 BST 2006 Duncan Coutts <duncan.coutts(a)worc.ox.ac.uk> * Try parsing C99 compound literals Mon May 29 14:32:54 BST 2006 Duncan Coutts <duncan.coutts(a)worc.ox.ac.uk> * Change handling of gnu __extension__ keyword GNU C allows __extension__ in various places we don't at the moment. This is a bit tricky to follow exactly without getting lots of shift/reduce conflicts. So what I've got here is a compromise. Sadly allowing __extension__ in expressions conflicts with it's use in declerations. So, instead of allowing __extension__ in any declaration I only allow it in an external decleration (top level). Fortunately I think that almost all uses of __extension__ in declarations are actually external declarations. So I think this is the right compromise. Mon May 29 14:55:34 BST 2006 Duncan Coutts <duncan.coutts(a)worc.ox.ac.uk> * Use precedence to eliminate an s/r in the C if-then-else syntax

1 0

BUG: string.h, (FC4 x86_64)
by Ville Tirronen 26 May '06

26 May '06

Hello, I think I've got a bug with c2hs 0.14.5. I have a program that compiles neatly on FC4 but fails when tried on x86_64 FC4. c2hs fails on string.h. Attached are the string.h of the system and relevant .i file. ----------- [aleator@thoth HopenCV]$ c2hs -k --cppopts='-I/usr/include/opencv' cvWrapLEO.h Image.chs c2hs: Error in C header file. /usr/include/string.h:270: (column 99) [FATAL] >>> Syntax error! The symbol `__attribute__' does not fit here. -- The previous produces rather lot of output, but -- the following might be enough? [aleator@thoth HopenCV]$ c2hs -k string.h Image.chs c2hs: Error in C header file. /usr/include/string.h:270: (column 99) [FATAL] >>> Syntax error! The symbol `__attribute__' does not fit here. [aleator@thoth HopenCV]$ uname -s -r Linux 2.6.16-1.2108_FC4smp [aleator@thoth HopenCV]$ /lib/libc.so.6 GNU C Library development release version 2.3.6, by Roland McGrath et al. Copyright (C) 2005 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Compiled by GNU CC version 4.0.2 20051125 (Red Hat 4.0.2-8). Compiled on a Linux 2.4.20 system on 2006-03-14. Available extensions: GNU libio by Per Bothner crypt add-on version 2.1 by Michael Glad and others Native POSIX Threads Library by Ulrich Drepper et al The C stubs add-on version 2.1.2. BIND-8.2.3-T5B NIS(YP)/NIS+ NSS modules 0.19 by Thorsten Kukuk Glibc-2.0 compatibility add-on by Cristian Gafton GNU Libidn by Simon Josefsson Thread-local storage support included. For bug reporting instructions, please see: <http://www.gnu.org/software/libc/bugs.html>. -- Ville Tirronen, University Of Jyväskylä # 1 "Image.h" # 1 "<built-in>" # 1 "<command line>" # 1 "Image.h" # 1 "/usr/include/string.h" 1 3 4 # 26 "/usr/include/string.h" 3 4 # 1 "/usr/include/features.h" 1 3 4 # 319 "/usr/include/features.h" 3 4 # 1 "/usr/include/sys/cdefs.h" 1 3 4 # 320 "/usr/include/features.h" 2 3 4 # 342 "/usr/include/features.h" 3 4 # 1 "/usr/include/gnu/stubs.h" 1 3 4 # 1 "/usr/include/bits/wordsize.h" 1 3 4 # 5 "/usr/include/gnu/stubs.h" 2 3 4 # 1 "/usr/include/gnu/stubs-64.h" 1 3 4 # 10 "/usr/include/gnu/stubs.h" 2 3 4 # 343 "/usr/include/features.h" 2 3 4 # 27 "/usr/include/string.h" 2 3 4 # 1 "/usr/lib/gcc/x86_64-redhat-linux/4.0.2/include/stddef.h" 1 3 4 # 214 "/usr/lib/gcc/x86_64-redhat-linux/4.0.2/include/stddef.h" 3 4 typedef long unsigned int size_t; # 34 "/usr/include/string.h" 2 3 4 extern void *memcpy (void *__restrict __dest, __const void *__restrict __src, size_t __n) __attribute__ ((__nothrow__)) __attribute__ ((__nonnull__ (1, 2))); extern void *memmove (void *__dest, __const void *__src, size_t __n) __attribute__ ((__nothrow__)) __attribute__ ((__nonnull__ (1, 2))); extern void *memccpy (void *__restrict __dest, __const void *__restrict __src, int __c, size_t __n) __attribute__ ((__nothrow__)) __attribute__ ((__nonnull__ (1, 2))); extern void *memset (void *__s, int __c, size_t __n) __attribute__ ((__nothrow__)) __attribute__ ((__nonnull__ (1))); extern int memcmp (__const void *__s1, __const void *__s2, size_t __n) __attribute__ ((__nothrow__)) __attribute__ ((__pure__)) __attribute__ ((__nonnull__ (1, 2))); extern void *memchr (__const void *__s, int __c, size_t __n) __attribute__ ((__nothrow__)) __attribute__ ((__pure__)) __attribute__ ((__nonnull__ (1))); # 82 "/usr/include/string.h" 3 4 extern char *strcpy (char *__restrict __dest, __const char *__restrict __src) __attribute__ ((__nothrow__)) __attribute__ ((__nonnull__ (1, 2))); extern char *strncpy (char *__restrict __dest, __const char *__restrict __src, size_t __n) __attribute__ ((__nothrow__)) __attribute__ ((__nonnull__ (1, 2))); extern char *strcat (char *__restrict __dest, __const char *__restrict __src) __attribute__ ((__nothrow__)) __attribute__ ((__nonnull__ (1, 2))); extern char *strncat (char *__restrict __dest, __const char *__restrict __src, size_t __n) __attribute__ ((__nothrow__)) __attribute__ ((__nonnull__ (1, 2))); extern int strcmp (__const char *__s1, __const char *__s2) __attribute__ ((__nothrow__)) __attribute__ ((__pure__)) __attribute__ ((__nonnull__ (1, 2))); extern int strncmp (__const char *__s1, __const char *__s2, size_t __n) __attribute__ ((__nothrow__)) __attribute__ ((__pure__)) __attribute__ ((__nonnull__ (1, 2))); extern int strcoll (__const char *__s1, __const char *__s2) __attribute__ ((__nothrow__)) __attribute__ ((__pure__)) __attribute__ ((__nonnull__ (1, 2))); extern size_t strxfrm (char *__restrict __dest, __const char *__restrict __src, size_t __n) __attribute__ ((__nothrow__)) __attribute__ ((__nonnull__ (2))); # 130 "/usr/include/string.h" 3 4 extern char *strdup (__const char *__s) __attribute__ ((__nothrow__)) __attribute__ ((__malloc__)) __attribute__ ((__nonnull__ (1))); # 165 "/usr/include/string.h" 3 4 extern char *strchr (__const char *__s, int __c) __attribute__ ((__nothrow__)) __attribute__ ((__pure__)) __attribute__ ((__nonnull__ (1))); extern char *strrchr (__const char *__s, int __c) __attribute__ ((__nothrow__)) __attribute__ ((__pure__)) __attribute__ ((__nonnull__ (1))); # 181 "/usr/include/string.h" 3 4 extern size_t strcspn (__const char *__s, __const char *__reject) __attribute__ ((__nothrow__)) __attribute__ ((__pure__)) __attribute__ ((__nonnull__ (1, 2))); extern size_t strspn (__const char *__s, __const char *__accept) __attribute__ ((__nothrow__)) __attribute__ ((__pure__)) __attribute__ ((__nonnull__ (1, 2))); extern char *strpbrk (__const char *__s, __const char *__accept) __attribute__ ((__nothrow__)) __attribute__ ((__pure__)) __attribute__ ((__nonnull__ (1, 2))); extern char *strstr (__const char *__haystack, __const char *__needle) __attribute__ ((__nothrow__)) __attribute__ ((__pure__)) __attribute__ ((__nonnull__ (1, 2))); extern char *strtok (char *__restrict __s, __const char *__restrict __delim) __attribute__ ((__nothrow__)) __attribute__ ((__nonnull__ (2))); extern char *__strtok_r (char *__restrict __s, __const char *__restrict __delim, char **__restrict __save_ptr) __attribute__ ((__nothrow__)) __attribute__ ((__nonnull__ (2, 3))); extern char *strtok_r (char *__restrict __s, __const char *__restrict __delim, char **__restrict __save_ptr) __attribute__ ((__nothrow__)) __attribute__ ((__nonnull__ (2, 3))); # 240 "/usr/include/string.h" 3 4 extern size_t strlen (__const char *__s) __attribute__ ((__nothrow__)) __attribute__ ((__pure__)) __attribute__ ((__nonnull__ (1))); # 254 "/usr/include/string.h" 3 4 extern char *strerror (int __errnum) __attribute__ ((__nothrow__)); # 270 "/usr/include/string.h" 3 4 extern int strerror_r (int __errnum, char *__buf, size_t __buflen) __asm__ ("" "__xpg_strerror_r") __attribute__ ((__nothrow__)) __attribute__ ((__nonnull__ (2))); # 288 "/usr/include/string.h" 3 4 extern void __bzero (void *__s, size_t __n) __attribute__ ((__nothrow__)) __attribute__ ((__nonnull__ (1))); extern void bcopy (__const void *__src, void *__dest, size_t __n) __attribute__ ((__nothrow__)) __attribute__ ((__nonnull__ (1, 2))); extern void bzero (void *__s, size_t __n) __attribute__ ((__nothrow__)) __attribute__ ((__nonnull__ (1))); extern int bcmp (__const void *__s1, __const void *__s2, size_t __n) __attribute__ ((__nothrow__)) __attribute__ ((__pure__)) __attribute__ ((__nonnull__ (1, 2))); extern char *index (__const char *__s, int __c) __attribute__ ((__nothrow__)) __attribute__ ((__pure__)) __attribute__ ((__nonnull__ (1))); extern char *rindex (__const char *__s, int __c) __attribute__ ((__nothrow__)) __attribute__ ((__pure__)) __attribute__ ((__nonnull__ (1))); extern int ffs (int __i) __attribute__ ((__nothrow__)) __attribute__ ((__const__)); # 325 "/usr/include/string.h" 3 4 extern int strcasecmp (__const char *__s1, __const char *__s2) __attribute__ ((__nothrow__)) __attribute__ ((__pure__)) __attribute__ ((__nonnull__ (1, 2))); extern int strncasecmp (__const char *__s1, __const char *__s2, size_t __n) __attribute__ ((__nothrow__)) __attribute__ ((__pure__)) __attribute__ ((__nonnull__ (1, 2))); # 348 "/usr/include/string.h" 3 4 extern char *strsep (char **__restrict __stringp, __const char *__restrict __delim) __attribute__ ((__nothrow__)) __attribute__ ((__nonnull__ (1, 2))); # 426 "/usr/include/string.h" 3 4 # 1 "Image.h" 2

4 7

patch applied (c2hs): Cancel previous patch installing the c2hs library
by chak＠cse.unsw.edu.au 25 May '06

25 May '06

Thu May 25 11:17:26 PDT 2006 Manuel M T Chakravarty <chak(a)cse.unsw.edu.au> * Cancel previous patch installing the c2hs library M ./c2hs.cabal -2

1 0

patch applied (c2hs): Install helper library for use by other packages
by chak＠cse.unsw.edu.au 25 May '06

25 May '06

Tue Feb 7 14:45:32 PST 2006 Jelmer Vernooij <jelmer(a)samba.org> * Install helper library for use by other packages M ./c2hs.cabal +2

3 2

patch applied (c2hs): Teach c2hs about C style line pragmas for accurate source location info.
by Duncan Coutts 24 May '06

24 May '06

Wed May 24 10:42:16 PDT 2006 Duncan Coutts <duncan.coutts(a)worc.ox.ac.uk> * Teach c2hs about C style line pragmas for accurate source location info. M ./c2hs/chs/CHS.hs +7 M ./c2hs/chs/CHSLexer.hs +26 M ./c2hs/gen/GenBind.hs +1 M ./c2hs/gen/GenHeader.hs +2

1 0

making c2hs undrstand line pragmas
by Duncan Coutts 24 May '06

24 May '06

Manuel, I've got a patch to c2hs to make it do something with C style line pragmas in .chs files, eg: # 1 "gtk/Graphics/UI/Gtk/TreeList/TreeStore.chs.pp" These are produced by the C preprocessor. Currently c2hs chokes on these and so people have to use the -P option to cpp to suppress them. They are actually rather useful if the code in fact does need preprocessing (as most of gtk2hs's .chs files do) because they point to the original file name and source locations. For example it means that ghc's errors will report accurate locations in the .chs.pp file rather than reporting locations in the .chs file. c2hs already produces accurate Haskell line pragmas {-# LINE ... #-} in the .hs files it produces for exactly that reason. I want to extend that to the case that the .chs file itself has had a preprocessor used on it. One other reason to preserve the original file name is that haddock can now include links to the source files, and it uses the line pragmas to find the original source file. It doesn't do much good however if haddock links to a non-existant .chs file when the real original file was .chs.pp. So here's an example; the Gtk2Hs docs with source code links to our darcs repository: http://haskell.org/gtk2hs/docs/devel/ For example the link at the top of this page: http://haskell.org/gtk2hs/docs/devel/Graphics-UI-Gtk-Abstract-Widget.html points to: http://darcs.haskell.org/gtk2hs/gtk/Graphics/UI/Gtk/Abstract/Widget.chs.pp which is right. Of course, without the patch it'd point to the non-existant file Widget.chs. The way my patch works is to make the lexer recognise the line directives and update the current position. However to get the line directives emitted correctly we also have to insert a special token into the token stream. When it comes to finally printing the token stream, this special token puts the printer into a state in which it will add a Haskell {-# LINE ... #-} pragma before the next Haskell source fragment. The only thing that's wrong is that c2hs doesn't recognise cpp directives as the first line in a .chs file. You can see why this is so from the code below: cpp :: CHSLexer cpp = directive where directive = string "\n#" +> alt ('\t':inlineSet)`star` epsilon `lexmeta` \(_:_:dir) pos s -> -- strip off the "\n#" case dir of ... etc It's requires a cpp directive to start with a newline followed by a '#' character. I'm not sufficiently familiar with the style of c2hs's chs lexer to figure out how to fix this. Perhaps it can be done by checking if we're at the beginning of a line in a different way. Perhaps it can be done by checking the current column rather than looking for a '\n' character. -------------- So in summary: Manuel, so if you don't complain about how this change works I'll commit it in the next few days. And my my question is how to fix this issue with recognising cpp directives on the first line. Duncan

2 2

sizeof hook calculates the wrong size
by Volker Wysk 24 May '06

24 May '06

Hello The sizeof hook calculates the size wrong in this example: ----------------------------------------------------------------- main = putStrLn (show {# sizeof loop_info64_t #}) #c #include <linux/loop.h> typedef struct loop_info64 loop_info64_t; #endc ----------------------------------------------------------------- Translated to: ----------------------------------------------------------------- ... {-# LINE 1 "bug.chs" #-}main = putStrLn (show 72) ----------------------------------------------------------------- The structure is much larger. loop_info64 is defined in /usr/include/linux/loop.h like this: ----------------------------------------------------------------- struct loop_info64 { __u64 lo_device; /* ioctl r/o */ __u64 lo_inode; /* ioctl r/o */ __u64 lo_rdevice; /* ioctl r/o */ __u64 lo_offset; __u64 lo_sizelimit;/* bytes, 0 == max available */ __u32 lo_number; /* ioctl r/o */ __u32 lo_encrypt_type; __u32 lo_encrypt_key_size; /* ioctl w/o */ __u32 lo_flags; /* ioctl r/o */ __u8 lo_file_name[LO_NAME_SIZE]; __u8 lo_crypt_name[LO_NAME_SIZE]; __u8 lo_encrypt_key[LO_KEY_SIZE]; /* ioctl w/o */ __u64 lo_init[2]; }; ----------------------------------------------------------------- It looks like the the arrays are mistaken for pointers. There's another small bug. If you reorder main and the C block in the example above, such that "#c" is the first line, then you get a parse error. -- public key fingerprint: 6A10 66F1 40A2 C441 BB55 0AA8 FAB1 4FC1 08BE 24EF

2 1

patch applied (c2hs): Fix typo
by chak＠cse.unsw.edu.au 24 May '06

24 May '06

Tue Feb 7 16:47:33 PST 2006 Jelmer Vernooij <jelmer(a)samba.org> * Fix typo M ./TODO -1 +1

1 0

patch applied (c2hs): Use PreCST for CParser to avoid unnecessary module deps
by Duncan Coutts 23 May '06

23 May '06

Tue May 23 07:24:34 PDT 2006 Duncan Coutts <duncan.coutts(a)worc.ox.ac.uk> * Use PreCST for CParser to avoid unnecessary module deps M ./c2hs/c/CParser.y -2 +2

1 0

patch applied (c2hs): Make the C parser test prog build again.
by Duncan Coutts 23 May '06

23 May '06

Tue May 23 06:58:22 PDT 2006 Duncan Coutts <duncan.coutts(a)worc.ox.ac.uk> * Make the C parser test prog build again. This program is useful for reproducing C parser errors for when users send in their .i files. Just run: ./parse foo.i Build using: ghc --make Main.hs -o parse ../i -i../../../base/general -i../../../base/admin -i../../../base/errors -i../../../base/state -i../../../base/syms -i../../state M ./c2hs/c/tests/Main.hs -9 +9

1 0