January 2008 - cabal-devel

patch applied (cabal): Find original sources for main-is when creating sdist
by Duncan Coutts 31 Jan '08

31 Jan '08

Thu Jan 31 03:49:09 PST 2008 Duncan Coutts <duncan(a)haskell.org> * Find original sources for main-is when creating sdist Also add a package sanity check that main-is must specify a .hs or .lhs file. So the bahaviour is now that main-is specifies the main source file, even if that is generated by a pre-processor. This isn't really a change in behaviour since previously if you specified main-is: main.hsc then it would try to pass the .hsc file to ghc dirctly which would not work. For ticket #14 things were fixed to that it would look for main.hsc if you used main-is: main.hs an that file did not exist directy. This completes the other half, of actually being able to make a src distribution. So this should fix bug #217. Note that this still needs some work, we do not run platform-independent preprocessors and put the result into the tarball for main-is files. Generally, main-is has been the second class citizen compared to normal modules. We should try and refactor so both use the same code paths. M ./Distribution/PackageDescription.hs -4 +8 M ./Distribution/Simple/SrcDist.hs -1 +5

1 0

patch applied (cabal): Eliminate now-redundant Bool flag on smartCopySources
by Duncan Coutts 31 Jan '08

31 Jan '08

Thu Jan 31 03:45:11 PST 2008 Duncan Coutts <duncan(a)haskell.org> * Eliminate now-redundant Bool flag on smartCopySources and simplfy the implementation to be a simple composition of findFileWithExtension' and copyFiles with some additonal error checking. M ./Distribution/Simple/GHC.hs -2 +2 M ./Distribution/Simple/Hugs.hs -2 +2 M ./Distribution/Simple/NHC.hs -1 +1 M ./Distribution/Simple/Utils.hs -9 +2

1 0

patch applied (cabal): Stop using smartCopySources in SrcDist
by Duncan Coutts 31 Jan '08

31 Jan '08

Thu Jan 31 03:41:43 PST 2008 Duncan Coutts <duncan(a)haskell.org> * Stop using smartCopySources in SrcDist This was the old module using it in with preserveDirs = True. Anyway, we should be using smartCopySources for each lib and exe, we should be collecting all the files to copy together into one list, then eliminating duplicates and doing a single copyFiles operation. Yes, there can be duplicates because for example exes can specify the libbrary's modules or even the other exe's main module as other-modules. M ./Distribution/Simple/SrcDist.hs -9 +18

1 0

patch applied (cabal): findPackageDesc has to return a relative path for SrcDist
by Duncan Coutts 31 Jan '08

31 Jan '08

Thu Jan 31 03:37:26 PST 2008 Duncan Coutts <duncan(a)haskell.org> * findPackageDesc has to return a relative path for SrcDist otherwise we fail to copy the .cabal file when into the src tree M ./Distribution/Simple/Utils.hs -1 +1

1 0

patch applied (cabal): Remove one Bool parameter to smartCopySources which was True in all uses
by Duncan Coutts 31 Jan '08

31 Jan '08

Wed Jan 30 03:28:42 PST 2008 Duncan Coutts <duncan(a)haskell.org> * Remove one Bool parameter to smartCopySources which was True in all uses The remaining Bool parameter is False for all uses except in SrcDirs M ./Distribution/Simple/GHC.hs -2 +2 M ./Distribution/Simple/Hugs.hs -2 +2 M ./Distribution/Simple/NHC.hs -1 +1 M ./Distribution/Simple/SrcDist.hs -1 +1 M ./Distribution/Simple/Utils.hs -9 +6

1 0

patch applied (cabal): Remove handling for .hi-boot files, which was only needed for ghc-6.2
by Duncan Coutts 31 Jan '08

31 Jan '08

Tue Jan 29 16:18:45 PST 2008 Duncan Coutts <duncan(a)haskell.org> * Remove handling for .hi-boot files, which was only needed for ghc-6.2 which we have removed support for. It is not clear if we need any similar handling for .hs-boot files. These were also the only uses of smartCopySources which used exitIfNone set to False. M ./Distribution/Simple/GHC.hs -6 +2

1 0

patch applied (cabal): Remove utils testing code for functions that are being removed
by Duncan Coutts 31 Jan '08

31 Jan '08

Tue Jan 29 16:08:48 PST 2008 Duncan Coutts <duncan(a)haskell.org> * Remove utils testing code for functions that are being removed M ./Distribution/Simple/Utils.hs -45

1 0

patch applied (cabal): Simplify smartCopySources using findFileWithExtension' and copyFiles
by Duncan Coutts 31 Jan '08

31 Jan '08

Tue Jan 29 16:01:29 PST 2008 Duncan Coutts <duncan(a)haskell.org> * Simplify smartCopySources using findFileWithExtension' and copyFiles Previously it used moduleToFilePath2 which returns all the locations in which a source file is found, in different search dirs and with different extensions and it just collected all these locations. This is totally bogus since we do not want to copy multiple source files per-module, only one of them could have been used to be pre-processed into the final source module. This is one example of how almost every use of moduleToFilePath is convoluted or broken. This function it still used for too many different purposes, witness the two flags to customise its behaviour which at all call sites are constants. M ./Distribution/Simple/Utils.hs -17 +13

1 0

patch applied (cabal): Add utils functions copyFiles, findFileWithExtension, findFileWithExtension'
by Duncan Coutts 31 Jan '08

31 Jan '08

Tue Jan 29 15:55:59 PST 2008 Duncan Coutts <duncan(a)haskell.org> * Add utils functions copyFiles, findFileWithExtension, findFileWithExtension' and rewrite findFile in a similar style. These are to help simplify and replace the existing functions smartCopySources, moduleToFilePath and moduleToFilePath2. M ./Distribution/Simple/Utils.hs -7 +70

1 0

patch applied (cabal): Update testsuite for unlit changes
by Duncan Coutts 31 Jan '08

31 Jan '08

Sat Dec 29 17:38:43 PST 2007 Duncan Coutts <duncan(a)haskell.org> * Update testsuite for unlit changes Follow the H98 report and replace ">" with " " not "". Output the whitespace for blank lines rather than "". Adjust to changes in unlit error handling, now more explicit. M ./tests/UnlitTest.hs -23 +22

1 0