July 2005 - Cvs-hugs - Haskell.org

make check on Windows (MSYS), with patch
by Brian Smith 05 Sep '05

05 Sep '05

I have attached a patch that allows "make check" run more or less successfully on Windows. The patch converts Windows-style newlines to Unix-style newlines from the output of the test, so that when the actual output is compared to the expected output, the newline differences don't set off false positives. It also fixes a couple obvious problems with the tests to make them work on MSYS. I have also attached the results of "make check." I went through all the failures and gave some notes below. ./../src/hugs +q -w -pHugs: static/mod154.hs < nul This seems to be a known bug in Hugs since mod154.hs says "Hugs gets this wrong." ./../src/hugs +q -w -pHugs: rts/read.hs < rts/read.input The exponents on floating point numbers include an extra leading "0": "-3.10862446895044e-015" instead of "-3.10862446895044e-15" and "2.384186e-007" instead of "2.384186e-07". GHCi strips all the leading zeros from the exponents in both cases. So, there is a bug in the tests (doesn't properly take leading zeros into account in exponents) and/or Hugs (if the Haskell spec. requires leading zeros to be stripped like GHCi does). ./../src/hugs +q -w -pHugs: rts/arith.hs < rts/arith.input There is a difference "-0" vs. "0" that seems not totally unreasonable. The other difference "inf" vs. "1.#INF" seems like a bug in Hugs. ./../src/hugs +q -w -pHugs: ffi/Sin.hs < ffi/Sin.input The unexpected signal is troubling, but I don't know what the problem is. ./../src/hugs +q -w -pHugs: ffi/FileIO.hs < ffi/FileIO.input The unexpected error seems to be caused by the fact that "/tmp/test_write" is being opened, when this file doesn't exist normally on Windows. This is a bug in the test. ./../src/hugs +q -w -pHugs: ffi/Sparc.hs < ffi/Sparc.input I have no idea what is wrong. ./../src/ffihugs +q -w -pHugs: ffi/Callback.hs ffi/callback.c < nul This test assumes a case-sensitive file system that can distinguish between "Callback.c" and "callback.c." This test can be fixed by renaming "Callback.hs" to "CallbackTest.hs" and renaming callback.c to callback_c.c. Patch included, but you have to do the renaming of the file yourself. However, after getting it to build successfully, it still fails with output "unexpected signal" and exit code 1, and I have no idea why. ./../src/hugs +q -w -pHugs: System libs/system1.hs < libs/system1.input If I run this test directly it gives the expected output. But, inside of "make check" it fails because MSYS's SHELL is "sh.exe" instead of "sh." Patch included. ./../src/hugs +q -w -pHugs: Directory libs/dirTest.hs < libs/dirTest.input This test fails, but I think it is simply because NTFS doesn't support the same permission combinations as Unix/Linux. Either a Windows-specifc version should be written, or the test should be skipped on Windows.

2 6

cvs commit: hugs98/tests runstdtest
by Ross Paterson 31 Jul '05

31 Jul '05

ross 2005/07/31 03:48:52 PDT Modified files: tests runstdtest Log: revert rev. 1.5: unnecessary and wrong, as Hugs output should use the same line termination convention as text files. Revision Changes Path 1.6 +1 -3 hugs98/tests/runstdtest

1 0

cvs commit: hugs98 configure.ac
by Ross Paterson 31 Jul '05

31 Jul '05

ross 2005/07/31 03:46:59 PDT Modified files: . configure.ac Log: avoid continuation lines inside macros -- they're reported as not working under MSYSdtk. Also eliminated a multi-line substitution variable -- autoconf doesn't like these. Revision Changes Path 1.39 +7 -17 hugs98/configure.ac

1 0

cvs commit: hugs98 Makefile RPM.mk
by Ross Paterson 30 Jul '05

30 Jul '05

ross 2005/07/30 08:40:09 PDT Modified files: . Makefile RPM.mk Log: move Cabal/DefaultSetup.lhs into examples to avoid confusing make_bootlib Revision Changes Path 1.62 +2 -0 hugs98/Makefile 1.39 +1 -0 hugs98/RPM.mk

1 0

cvs commit: hugs98/tests runstdtest
by Ross Paterson 29 Jul '05

29 Jul '05

ross 2005/07/29 17:06:27 PDT Modified files: tests runstdtest Log: obscure sed command to strip trailing \r (problem on Windows) Revision Changes Path 1.5 +3 -1 hugs98/tests/runstdtest

1 0

cvs commit: hugs98/tests testScript hugs98/tests/ffi callbacks.c callbacks.h Callback.hs FileIO.hs FileIO.output callback.c callback.h hugs98/tests/libs system1.hs
by Ross Paterson 29 Jul '05

29 Jul '05

ross 2005/07/29 02:25:28 PDT Modified files: tests testScript tests/ffi Callback.hs FileIO.hs FileIO.output tests/libs system1.hs Added files: tests/ffi callbacks.c callbacks.h Removed files: tests/ffi callback.c callback.h Log: Portability fixes to tests, from Brian Smith: * renamed callback.c to avoid clash with Callback.c on case-insensitive filesystems. * avoided /tmp inside FileIO.hs. * added sh.exe to the list of known shells. Revision Changes Path 1.67 +1 -1 hugs98/tests/testScript 1.3 +2 -2 hugs98/tests/ffi/Callback.hs 1.7 +4 -2 hugs98/tests/ffi/FileIO.hs 1.7 +1 -3 hugs98/tests/ffi/FileIO.output 1.3 +2 -1 hugs98/tests/libs/system1.hs

1 0

cvs commit: hugs98/libraries Makefile.in
by Ross Paterson 28 Jul '05

28 Jul '05

ross 2005/07/28 16:52:34 PDT Modified files: libraries Makefile.in Log: minor fixes associated with make clean Revision Changes Path 1.18 +8 -8 hugs98/libraries/Makefile.in

1 0

cvs commit: hugs98 RPM.mk Makefile
by Ross Paterson 28 Jul '05

28 Jul '05

ross 2005/07/28 15:56:42 PDT Modified files: . RPM.mk Makefile Log: remove fptools/libraries/HaXml/configure from the build -- Cabal doesn't need it, so we don't want it left there for Cabal to run. Revision Changes Path 1.38 +1 -0 hugs98/RPM.mk 1.61 +2 -0 hugs98/Makefile

1 0

cvs commit: hugs98/src iomonad.c
by Ross Paterson 28 Jul '05

28 Jul '05

ross 2005/07/26 17:51:13 PDT Modified files: src iomonad.c Log: fix treatment of arguments, which was breaking on backslashes. Revision Changes Path 1.99 +8 -4 hugs98/src/iomonad.c

3 3

cvs commit: hugs98 MkDefs.in configure.ac hugs98/libraries Makefile.in hugs98/libraries/tools convert_libraries
by Ross Paterson 28 Jul '05

28 Jul '05

ross 2005/07/28 09:53:34 PDT Modified files: . MkDefs.in configure.ac libraries Makefile.in libraries/tools convert_libraries Log: pass host platform value down to network/configure (only) Revision Changes Path 1.4 +1 -0 hugs98/MkDefs.in 1.38 +2 -0 hugs98/configure.ac 1.17 +1 -1 hugs98/libraries/Makefile.in 1.25 +7 -7 hugs98/libraries/tools/convert_libraries

1 0