- Cvs-hugs - Haskell.org

cvs commit: hugs98/docs/building win32.txt
by Ross Paterson 08 Sep '05

08 Sep '05

ross 2005/09/08 10:14:45 PDT Modified files: docs/building win32.txt Log: update Win32 instructions Revision Changes Path 1.7 +36 -17 hugs98/docs/building/win32.txt

1 0

cvs commit: hugs98/src/winhugs DlgMain.c Header.h IORemap.c RtfWindow.c
by Ross Paterson 08 Sep '05

08 Sep '05

ross 2005/09/08 09:17:49 PDT Modified files: src/winhugs DlgMain.c Header.h IORemap.c RtfWindow.c Log: from Neil Mitchell: repair interact and getChar for WinHugs. The implementation in this version is superior to that in the old version of WinHugs, including that the stop button now stops immediately (not after one char is pressed) and the status bar changes to advise the user that input is required. The approach uses a Content semaphore to pause the calculating thread when no input is available. Like all threading code, this is not particularly fun to write or easy to understand. Revision Changes Path 1.10 +15 -3 hugs98/src/winhugs/DlgMain.c 1.4 +7 -0 hugs98/src/winhugs/Header.h 1.3 +76 -1 hugs98/src/winhugs/IORemap.c 1.5 +8 -1 hugs98/src/winhugs/RtfWindow.c

1 0

cvs commit: hugs98/src input.c
by Ross Paterson 08 Sep '05

08 Sep '05

ross 2005/09/08 09:14:19 PDT Modified files: src input.c Log: from Neil Mitchell: WinHugs reads a command from a single line; an empty line used to trigger an EOF and and exit; now it's ignored. Revision Changes Path 1.88 +7 -3 hugs98/src/input.c

1 0

cvs commit: hugs98/src/winhugs winhugs.vcproj
by Ross Paterson 08 Sep '05

08 Sep '05

ross 2005/09/08 09:08:53 PDT Modified files: src/winhugs winhugs.vcproj Log: from Neil Mitchell: Change the include directory list order so that WinHugs picks up its local config.h first. I'm still not sure this is good enough; if you want to build with both MSYS and Visual Studio they are going to be competing for config.h space. Revision Changes Path 1.2 +2 -2 hugs98/src/winhugs/winhugs.vcproj

1 0

cvs commit: hugs98/src/winhugs Legacy.c
by Ross Paterson 08 Sep '05

08 Sep '05

ross 2005/09/08 09:04:41 PDT Modified files: src/winhugs Legacy.c Log: from Neil Mitchell: fix includes Revision Changes Path 1.4 +2 -1 hugs98/src/winhugs/Legacy.c

1 0

cvs commit: hugs98/src prelude.h hugs98/src/winhugs Winhugs.h
by Ross Paterson 08 Sep '05

08 Sep '05

ross 2005/09/08 09:02:03 PDT Modified files: src prelude.h src/winhugs Winhugs.h Log: delete unused kbhit() Revision Changes Path 1.78 +6 -19 hugs98/src/prelude.h 1.14 +0 -3 hugs98/src/winhugs/Winhugs.h

1 0

cvs commit: hugs98/src/winhugs resrc1.h winhugs.rc
by Ross Paterson 08 Sep '05

08 Sep '05

ross 2005/09/08 08:55:48 PDT Modified files: src/winhugs resrc1.h winhugs.rc Log: from Neil Mitchell: clean up menus. The plan is for Help/Contents to point at the User's Guide. Revision Changes Path 1.5 +2 -1 hugs98/src/winhugs/resrc1.h 1.20 +17 -34 hugs98/src/winhugs/winhugs.rc

1 0

WinHugs, fix up menu help messages
by Neil Mitchell 08 Sep '05

08 Sep '05

Hi, This puts sensible descriptions for each menu item. Where the menu item has gone, the description is removed. Where new menu items are created, they have the appropriate description. Thanks Neil

2 4

WinHugs, interact support
by Neil Mitchell 08 Sep '05

08 Sep '05

Hi, This patch adds interact and getChar support to WinHugs. The implementation in this version is superior to that in the old version of WinHugs, including that the stop button now stops immediately (not after one char is pressed) and the status bar changes to advise the user that input is sought. The appropach uses a Content semaphore to pause the calculating thread when no input is available. Like all threading code, this is not particularly fun to write or easy to understand. Thanks Neil

1 0

WinHugs, Bug quit
by Neil Mitchell 08 Sep '05

08 Sep '05

Hi, Bug: if a blank command is entered on WinHugs, the program quits. This patch makes an EOF character be treated as no command on WinHugs. Thanks Neil

1 0

WinHugs, back to life
by Neil Mitchell 08 Sep '05

08 Sep '05

Hi, I'm not sure before that WinHugs was correctly defining HUGS_FOR_WINDOWS, some places that conditionaled on it seem to have not hit it. This puts a definition in the WinHugs config.h file, so it should be remembered. Additionally, once this happens a few things break. This patch cleans them back up. kbhit was referencing dead window handles, and since I don't really have a clue what its meant to do, defining it as nothing seems reasonable. Thanks Neil

1 1

WinHugs, project files
by Neil Mitchell 08 Sep '05

08 Sep '05

Hi, Change the include directory list order. This means WinHugs picks up its local config.h first. I'm still not sure this is good enough, if you want to build with both MSYS and Visual Studio they are going to be competing for config.h space. Thanks Neil

1 0

cvs commit: hugs98/src machdep.c
by Ross Paterson 08 Sep '05

08 Sep '05

ross 2005/09/07 16:12:48 PDT Modified files: src machdep.c Log: fix to <dir>/* feature on Windows: handle hierarchical module names. Revision Changes Path 1.132 +5 -5 hugs98/src/machdep.c

1 0

cvs commit: hugs98/src/winhugs winhugs.rc
by Ross Paterson 07 Sep '05

07 Sep '05

ross 2005/09/07 09:32:22 PDT Modified files: src/winhugs winhugs.rc Log: from Neil Mitchell: remove unused resources. (The files are retained in case someone finds a use for them.) Revision Changes Path 1.19 +0 -94 hugs98/src/winhugs/winhugs.rc

4 3

cvs commit: hugs98/src iomonad.c
by Ross Paterson 07 Sep '05

07 Sep '05

ross 2005/09/07 13:28:05 PDT Modified files: src iomonad.c Log: throw exception on EOF in getChar Revision Changes Path 1.100 +13 -4 hugs98/src/iomonad.c

1 0

WinHugs, resource tidy up
by Neil Mitchell 07 Sep '05

07 Sep '05

Hi, The old resource file had kept accumulating things forever, including lots of things that were unused. This patch removes those unused elements. It also has the effect of reducing the end binary by 20Kb. In addition, the winhugs/resource directory contains the following unused files: button.bmp copybutt.bmp cutbutto.bmp deletebu.bmp disabled.bmp editbutt.bmp exitbutt.bmp gc.cur hand.cur helpbutt.bmp hierarch.bmp hierbutt.bmp hugs2.ico hugs32bm.bmp lambda.ico makebutt.bmp noassign.ico openfile.bmp openproj.bmp optionsb.bmp optionsd.bmp pastebut.bmp pushedbu.bmp relobutt.bmp resizeco.bmp runbutto.bmp smanbutt.bmp stopbutt.bmp world.ico Thanks Neil

1 0

cvs commit: hugs98/src/winhugs menusbm.c
by Ross Paterson 07 Sep '05

07 Sep '05

ross 2005/09/07 08:45:41 PDT Removed files: src/winhugs menusbm.c Log: unused file

1 0

cvs commit: hugs98/src/winhugs RtfWindow.c
by Ross Paterson 07 Sep '05

07 Sep '05

ross 2005/09/07 08:40:32 PDT Modified files: src/winhugs RtfWindow.c Log: from Neil Mitchell: strip trailing newline characters from pasted text. Revision Changes Path 1.4 +24 -1 hugs98/src/winhugs/RtfWindow.c

1 0

cvs commit: hugs98/src/winhugs winhugs.sln winhugs.vcproj
by Ross Paterson 07 Sep '05

07 Sep '05

ross 2005/09/07 08:28:37 PDT Added files: src/winhugs winhugs.sln winhugs.vcproj Log: from Neil Mitchell: visual studio project files for WinHugs

1 0

cvs commit: hugs98/src/winhugs ScriptMan.c
by Ross Paterson 07 Sep '05

07 Sep '05

ross 2005/09/07 08:27:00 PDT Removed files: src/winhugs ScriptMan.c Log: unused file

1 0

cvs commit: hugs98/src/winhugs Winhugs.h
by Ross Paterson 07 Sep '05

07 Sep '05

ross 2005/09/07 08:22:20 PDT Modified files: src/winhugs Winhugs.h Log: from Neil Mitchell: declare stopEvaluatorThread() (required by error.c) Revision Changes Path 1.13 +1 -0 hugs98/src/winhugs/Winhugs.h

1 0

WinHugs, paste without trailing newlines
by Neil Mitchell 07 Sep '05

07 Sep '05

Hi, This strips all trailing newline characters off paste in WinHugs, to make it fit on one line. Thanks Neil

1 0

WinHugs, project files
by Neil Mitchell 07 Sep '05

07 Sep '05

Hi, Attached, WinHugs visual studio project files, for placing in src\winhugs. Thanks Neil

1 0

Include stopEvaluatorThread
by Neil Mitchell 07 Sep '05

07 Sep '05

Hi, Adds the declaration of stopEvaluatorThread to Winhugs.h, which is required by error.c With this the WinHugs builds with no warnings or errors. (With 64bit portability warnings turned off). Thanks Neil

1 0

Location of visual studio WinHugs project
by Neil Mitchell 07 Sep '05

07 Sep '05

Hi, I'm ready to send in the WinHugs.sln files to build WinHugs with visual studio. Where would these be best placed? Under msc with the other visual studio project files? Under winhugs? They have relative paths, so let me know where is best and i'll submit them. Thanks Neil

2 1

cvs commit: hugs98/src/winhugs DlgMain.c MruFiles.c
by Ross Paterson 07 Sep '05

07 Sep '05

ross 2005/09/07 06:44:40 PDT Modified files: src/winhugs DlgMain.c MruFiles.c Log: from Neil Mitchell: fixes two small bugs with the MRU files. The first bug involved an incorrect initialisation when the MRU menu was empty. The second bug caused a crash when matched up with the command history feature. Revision Changes Path 1.9 +1 -1 hugs98/src/winhugs/DlgMain.c 1.2 +2 -2 hugs98/src/winhugs/MruFiles.c

1 0

cvs commit: hugs98/src/winhugs DlgMain.c Header.h StartCode.c
by Ross Paterson 07 Sep '05

07 Sep '05

ross 2005/09/07 06:42:09 PDT Modified files: src/winhugs DlgMain.c Header.h StartCode.c Log: from Neil Mitchell: recover properly from a failed file load. Revision Changes Path 1.8 +7 -6 hugs98/src/winhugs/DlgMain.c 1.3 +1 -0 hugs98/src/winhugs/Header.h 1.6 +1 -0 hugs98/src/winhugs/StartCode.c

1 0

cvs commit: hugs98/src/winhugs DlgMain.c hugs98/src/winhugs/resource toolbar.bmp
by Ross Paterson 07 Sep '05

07 Sep '05

ross 2005/09/07 06:39:45 PDT Modified files: src/winhugs DlgMain.c src/winhugs/resource toolbar.bmp Log: from Neil Mitchell: remove the Module Manager, Heirarchy and Edit buttons from the toolbar. Revision Changes Path 1.7 +2 -3 hugs98/src/winhugs/DlgMain.c 1.2 +1 -1 hugs98/src/winhugs/resource/toolbar.bmp

1 0

WinHugs, MruFiles bugs
by Neil Mitchell 07 Sep '05

07 Sep '05

Hi, This fixes two small bugs with the MRU files. The first bug was involving an incorrect initialisation when the MRU menu was empty. The second bug caused a crash when matched up with the command history feature. Thanks Neil

1 0

WinHugs, run mode bug fix
by Neil Mitchell 07 Sep '05

07 Sep '05

Hi, BUG: If you load a file that fails, i.e. because of a syntax error, then the program remains in run mode with the Run button disabled and the Stop button enabled. This patch fixes this bug. Instead of relying on executing after doCommand, it traps the message pump which is restarted after longjmp. Thanks Neil

1 0

WinHugs, Toolbar patch
by Neil Mitchell 07 Sep '05

07 Sep '05

Hi, This patch removes 3 buttons from the toolbar that I don't think many people ever clicked. They are still accessible via the menus. The buttons are Module Manager, Heirarchy and Edit. Please put toolbar.bmp into winhugs/resources Thanks Neil

2 2

cvs commit: hugs98/src/winhugs DlgAbout.c DlgOptions.c Legacy.c
by Ross Paterson 07 Sep '05

07 Sep '05

ross 2005/09/07 05:10:36 PDT Modified files: src/winhugs DlgAbout.c DlgOptions.c Legacy.c Log: warning avoidance: DialogProc's should return INT_PTR Revision Changes Path 1.4 +5 -5 hugs98/src/winhugs/DlgAbout.c 1.5 +9 -11 hugs98/src/winhugs/DlgOptions.c 1.3 +34 -34 hugs98/src/winhugs/Legacy.c

1 0

cvs commit: hugs98/src/winhugs DlgMain.c
by Ross Paterson 07 Sep '05

07 Sep '05

ross 2005/09/07 04:28:45 PDT Modified files: src/winhugs DlgMain.c Log: from Neil Mitchell: pop up a context menu when the user right clicks on the main window. Revision Changes Path 1.6 +25 -0 hugs98/src/winhugs/DlgMain.c

1 0

cvs commit: hugs98/src/winhugs DlgMain.c RtfWindow.c RtfWindow.h resrc1.h winhugs.rc
by Ross Paterson 07 Sep '05

07 Sep '05

ross 2005/09/07 04:25:00 PDT Modified files: src/winhugs DlgMain.c RtfWindow.c RtfWindow.h resrc1.h winhugs.rc Log: from Neil Mitchell: clean up menus, implement all the previously unimplemented menu items, and add a Clear Screen entry, which deletes your command history. Revision Changes Path 1.5 +27 -136 hugs98/src/winhugs/DlgMain.c 1.3 +42 -5 hugs98/src/winhugs/RtfWindow.c 1.2 +5 -0 hugs98/src/winhugs/RtfWindow.h 1.4 +5 -1 hugs98/src/winhugs/resrc1.h 1.18 +10 -11 hugs98/src/winhugs/winhugs.rc

1 0

WinHugs, context menu
by Neil Mitchell 07 Sep '05

07 Sep '05

Hi, When the user right clicks on the main window, a context menu should appear. This patch makes it do so. Thanks Neil

1 0

WinHugs, Menu tidyup
by Neil Mitchell 07 Sep '05

07 Sep '05

Hi, This patch makes the menus a bit more sensible (apart from options, has anyone any idea where options should go in windows??) and implements all the previously unimplemented menu items. It also adds the new feature of Clear Screen, which deletes all your command history. Thanks Neil

1 1

cvs commit: hugs98/src prelude.h hugs98/src/winhugs IORemap.c IORemap.h RtfWindow.c StartCode.c Winhugs.h
by Ross Paterson 07 Sep '05

07 Sep '05

ross 2005/09/06 16:38:16 PDT Modified files: src prelude.h src/winhugs IORemap.c RtfWindow.c StartCode.c Added files: src/winhugs Winhugs.h Removed files: src/winhugs IORemap.h Log: Rename external interface IORemap.h as Winhugs.h, and add include guard. Revision Changes Path 1.77 +3 -3 hugs98/src/prelude.h 1.2 +1 -1 hugs98/src/winhugs/IORemap.c 1.2 +1 -1 hugs98/src/winhugs/RtfWindow.c 1.5 +2 -2 hugs98/src/winhugs/StartCode.c

1 0

cvs commit: hugs98/src/winhugs Legacy.c
by Ross Paterson 06 Sep '05

06 Sep '05

ross 2005/09/06 12:59:16 PDT Modified files: src/winhugs Legacy.c Log: include <windows.h> Revision Changes Path 1.2 +1 -0 hugs98/src/winhugs/Legacy.c

1 0

cvs commit: hugs98/src/winhugs IORemap.h StartCode.c
by Ross Paterson 06 Sep '05

06 Sep '05

ross 2005/09/06 12:51:26 PDT Modified files: src/winhugs IORemap.h StartCode.c Log: from Neil Mitchell: renable stack overflow trapping in the thread (used by WinHugs). Revision Changes Path 1.4 +1 -0 hugs98/src/winhugs/IORemap.h 1.4 +42 -39 hugs98/src/winhugs/StartCode.c

1 0

cvs commit: hugs98/src hugs.c
by Ross Paterson 06 Sep '05

06 Sep '05

ross 2005/09/06 12:48:29 PDT Modified files: src hugs.c Log: from Neil Mitchell: add link to source of the stack overflow recovery code. Revision Changes Path 1.144 +3 -2 hugs98/src/hugs.c

1 0

WinHugs, stack overflow support
by Neil Mitchell 06 Sep '05

06 Sep '05

Hi, Under WinHugs, the evaluation is spawned in a separate thread. This means that the stack overflow trapping code in hugs.c is in the wrong thread and it results in a crash on stack overflow. This patch adds it to the thread, so it nicely gives an error message and lets you resume. Thanks Neil

1 0

Hugs.c, add comment
by Neil Mitchell 06 Sep '05

06 Sep '05

The stack overflow detection code is pretty opaque at best. Its based on code from a Dr Gui column which is no longer easily available. I have found it on the MSDN archive, so here's a patch to add the URL. If anyone ever wants to figure out what it does, they will need that link! Thanks Neil

1 0

cvs commit: hugs98/src/winhugs DlgOptions.c Editors.c Header.h
by Ross Paterson 06 Sep '05

06 Sep '05

ross 2005/09/06 03:49:27 PDT Modified files: src/winhugs DlgOptions.c Header.h Added files: src/winhugs Editors.c Log: from Neil Mitchell: factor out the editors list into a separate file, and add support for the Syn editor. Revision Changes Path 1.4 +6 -70 hugs98/src/winhugs/DlgOptions.c 1.2 +1 -0 hugs98/src/winhugs/Header.h

1 0

WinHugs, Editors.c
by Neil Mitchell 06 Sep '05

06 Sep '05

Hi, This patch splits off the editors list from the DlgOptions, and puts it in a separate file, Editors.c, so as not to swamp the main options. It also reworks this file to make it easier and quicker to add additional editors. It also adds support for the Syn editor. Thanks Neil

1 0

cvs commit: hugs98/src/winhugs DlgMain.c
by Ross Paterson 06 Sep '05

06 Sep '05

ross 2005/09/06 02:36:10 PDT Modified files: src/winhugs DlgMain.c Log: from Neil Mitchell: close main window on :quit Revision Changes Path 1.4 +2 -1 hugs98/src/winhugs/DlgMain.c

1 0

cvs commit: hugs98/src hugs.c hugs98/src/winhugs IORemap.h StartCode.c
by Ross Paterson 06 Sep '05

06 Sep '05

ross 2005/09/06 02:34:45 PDT Modified files: src hugs.c src/winhugs IORemap.h StartCode.c Log: from Neil Mitchell: rename MessagePump to WinHugsMessagePump. Revision Changes Path 1.143 +3 -3 hugs98/src/hugs.c 1.3 +1 -0 hugs98/src/winhugs/IORemap.h 1.3 +1 -1 hugs98/src/winhugs/StartCode.c

1 0

WinHugs, :quit support
by Neil Mitchell 06 Sep '05

06 Sep '05

Hi, Yep, I broke :quit. This fixes it. If quit is detected then send a close message to the main window. Thanks Neil

1 0

WinHugs MessagePump, exporting
by Neil Mitchell 06 Sep '05

06 Sep '05

Hi, This patch renames MessagePump to WinHugsMessagePump. It also exports this function via IORemap. Without the export this is a compile error. Thanks Neil

1 0

cvs commit: hugs98/docs/users_guide Makefile.in
by Ross Paterson 05 Sep '05

05 Sep '05

ross 2005/09/05 14:00:12 PDT Modified files: docs/users_guide Makefile.in Log: from Brian Smith: MSYS's sed apparently does not like carriage returns in any scripts that it is passed with its "-f" option. So generate and use a carriage-return-free xml2sgml script. Revision Changes Path 1.16 +9 -2 hugs98/docs/users_guide/Makefile.in

1 0

Wrapper FFI appears broken on Hugs/Windows
by Brian Smith 05 Sep '05

05 Sep '05

The tests that use the "wrapper" FFI scheme all fail with an unexpected signal: ffi/Sin.input ffi/Sparc.input ffi/Callback.input This leads me to believe that "wrapper" FFI declarations are broken on Windows. Unfortunately, I have no idea how to fix it. Can somebody help? Regards, Brian

1 0

make check on Windows (MSYS), with patch
by Brian Smith 05 Sep '05

05 Sep '05

I have attached a patch that allows "make check" run more or less successfully on Windows. The patch converts Windows-style newlines to Unix-style newlines from the output of the test, so that when the actual output is compared to the expected output, the newline differences don't set off false positives. It also fixes a couple obvious problems with the tests to make them work on MSYS. I have also attached the results of "make check." I went through all the failures and gave some notes below. ./../src/hugs +q -w -pHugs: static/mod154.hs < nul This seems to be a known bug in Hugs since mod154.hs says "Hugs gets this wrong." ./../src/hugs +q -w -pHugs: rts/read.hs < rts/read.input The exponents on floating point numbers include an extra leading "0": "-3.10862446895044e-015" instead of "-3.10862446895044e-15" and "2.384186e-007" instead of "2.384186e-07". GHCi strips all the leading zeros from the exponents in both cases. So, there is a bug in the tests (doesn't properly take leading zeros into account in exponents) and/or Hugs (if the Haskell spec. requires leading zeros to be stripped like GHCi does). ./../src/hugs +q -w -pHugs: rts/arith.hs < rts/arith.input There is a difference "-0" vs. "0" that seems not totally unreasonable. The other difference "inf" vs. "1.#INF" seems like a bug in Hugs. ./../src/hugs +q -w -pHugs: ffi/Sin.hs < ffi/Sin.input The unexpected signal is troubling, but I don't know what the problem is. ./../src/hugs +q -w -pHugs: ffi/FileIO.hs < ffi/FileIO.input The unexpected error seems to be caused by the fact that "/tmp/test_write" is being opened, when this file doesn't exist normally on Windows. This is a bug in the test. ./../src/hugs +q -w -pHugs: ffi/Sparc.hs < ffi/Sparc.input I have no idea what is wrong. ./../src/ffihugs +q -w -pHugs: ffi/Callback.hs ffi/callback.c < nul This test assumes a case-sensitive file system that can distinguish between "Callback.c" and "callback.c." This test can be fixed by renaming "Callback.hs" to "CallbackTest.hs" and renaming callback.c to callback_c.c. Patch included, but you have to do the renaming of the file yourself. However, after getting it to build successfully, it still fails with output "unexpected signal" and exit code 1, and I have no idea why. ./../src/hugs +q -w -pHugs: System libs/system1.hs < libs/system1.input If I run this test directly it gives the expected output. But, inside of "make check" it fails because MSYS's SHELL is "sh.exe" instead of "sh." Patch included. ./../src/hugs +q -w -pHugs: Directory libs/dirTest.hs < libs/dirTest.input This test fails, but I think it is simply because NTFS doesn't support the same permission combinations as Unix/Linux. Either a Windows-specifc version should be written, or the test should be skipped on Windows.

2 6

cvs commit: hugs98/src hugs.c
by Ross Paterson 05 Sep '05

05 Sep '05

ross 2005/09/05 09:08:35 PDT Modified files: src hugs.c Log: comment Revision Changes Path 1.142 +3 -3 hugs98/src/hugs.c

1 0

cvs commit: hugs98/src hugs.c connect.h hugs98/src/winhugs DlgMain.c
by Ross Paterson 05 Sep '05

05 Sep '05

ross 2005/09/05 09:07:53 PDT Modified files: src hugs.c connect.h src/winhugs DlgMain.c Log: from Neil Mitchell: refactor the main loop to loop for standard Hugs and use normal Windows message pump (looping via longjmp) for WinHugs. This gives WinHugs much better performance and no polling. (I had to adjust this to make :q work for standard Hugs. I don't see how it works for WinHugs.) Revision Changes Path 1.141 +68 -50 hugs98/src/hugs.c 1.91 +5 -4 hugs98/src/connect.h 1.3 +1 -2 hugs98/src/winhugs/DlgMain.c

1 0

cvs commit: hugs98/src/winhugs DlgAbout.c
by Ross Paterson 05 Sep '05

05 Sep '05

ross 2005/09/05 08:47:44 PDT Modified files: src/winhugs DlgAbout.c Log: repair previous commit Revision Changes Path 1.3 +3 -1 hugs98/src/winhugs/DlgAbout.c

1 0

WinHugs, about dialog includes
by Neil Mitchell 05 Sep '05

05 Sep '05

Hi, It is insufficient to just include <connect.h>, you need storage and prelude as its dependancies. Thanks Neil

1 0

cvs commit: hugs98/src/winhugs winhugs.rc DlgAbout.c resrc1.h
by Ross Paterson 05 Sep '05

05 Sep '05

ross 2005/09/05 08:23:34 PDT Modified files: src/winhugs winhugs.rc DlgAbout.c resrc1.h Log: from Neil Mitchell: adds the version number to the About dialog box, and makes the hyperlinks to hugs-bugs and haskell.org/hugs clickable. Revision Changes Path 1.17 +4 -4 hugs98/src/winhugs/winhugs.rc 1.2 +36 -0 hugs98/src/winhugs/DlgAbout.c 1.3 +1 -0 hugs98/src/winhugs/resrc1.h

1 0

WinHugs, about dialog box
by Neil Mitchell 05 Sep '05

05 Sep '05

Hi, This patch modifies the about dialog box. It adds the version number for bug reports (this is the standard place for it in Windows), and makes the hyperlinks to hugs-bugs and haskell.org/hugs clickable. Thanks Neil

1 0

Hugs.c, main loop patch
by Neil Mitchell 05 Sep '05

05 Sep '05

Hi, This is the most invasive change in the hugs directory, and the last one. Split the main loop into invoke (which performs the computation) and prefix (which sets up the required bits). Change the main loop to call while(1){prefix(); invoke();} for the standard hugs. WinHugs now uses the normal windows message pump which gives it much better performance and no polling. It does this by calling invoke directly. If people would like to see revisions to this patch just ask, its a little more violent than I would like, but I'm not sure there is any better way. If you look at the code for the non-winhugs path, it comes out identical to what was being called before. With this patch, on Windows WinHugs now outperforms the standard console version by about 2 times in output intensive programs ([1..]), and is the same for compute intensive ones (nqueens). Thanks Neil

1 0

cvs commit: hugs98/src/winhugs DlgOptions.c resrc1.h winhugs.rc
by Ross Paterson 05 Sep '05

05 Sep '05

ross 2005/09/05 04:23:52 PDT Modified files: src/winhugs DlgOptions.c resrc1.h winhugs.rc Log: from Neil Mitchell: first page of the options dialog, including overlapping instances, here documents and H98 mode. Changing H98 mode is marked as "requires restart", but in fact: If you load a non-haskell 98 doc with +98, it fails. If you then go to options and set -98, then either :l or :r, it succeeds. If you then go to options and flip back to +98, :r succeeds (wrongly), but :l fails. Revision Changes Path 1.3 +28 -0 hugs98/src/winhugs/DlgOptions.c 1.2 +7 -1 hugs98/src/winhugs/resrc1.h 1.16 +13 -11 hugs98/src/winhugs/winhugs.rc

1 0

WinHugs, options dialog Haskell 98 mode
by Neil Mitchell 05 Sep '05

05 Sep '05

Hi, This patch implements the first page of the options dialog, including overlapping instances, here documents and haskell 98 mode. This does allow changing between haskell98 and not at runtime, but I have marked it with the warning "requires restart". This is not entirely true... If you load a non-haskell 98 doc with +98, it fails. If you then go to options and set -98, then either :l or :r, it succeeds. If you then go to options and flip back to +98, :r succeeds (wrongly), but :l fails. Thanks Neil

1 0

cvs commit: hugs98/src/winhugs DlgOptions.c
by Ross Paterson 05 Sep '05

05 Sep '05

ross 2005/09/05 02:48:40 PDT Modified files: src/winhugs DlgOptions.c Log: from Neil Mitchell: add Vim to the editor list Revision Changes Path 1.2 +29 -4 hugs98/src/winhugs/DlgOptions.c

1 0

WinHugs, Vim support
by Neil Mitchell 05 Sep '05

05 Sep '05

Hi, This patch provides Vim support. It detects if Vim is installed and allows the user to select it easily without memorising command line options. If anyone has a favourite editor that is not TextPad or Vim, let me know and I'll add support. I would add Emacs support, but I have no idea what a popular port of Emacs is, there seem to be quite a few - anyone who uses one is welcome to let me know. Thanks Neil

1 1

cvs commit: hugs98/src hugs.c
by Ross Paterson 05 Sep '05

05 Sep '05

ross 2005/09/04 17:16:08 PDT Modified files: src hugs.c Log: (I was hesitant about this one, as it changes a long-standing and presumably deliberately designed behaviour.) from Neil Mitchell: add an & in front of the default notepad editor on Windows, to make it open asynchronously. Revision Changes Path 1.140 +5 -4 hugs98/src/hugs.c

1 0

cvs commit: hugs98/src errors.c
by Ross Paterson 04 Sep '05

04 Sep '05

ross 2005/09/04 08:16:37 PDT Modified files: src errors.c Log: ask users to report internal errors as bugs (hope I got the WinHugs bit right). Revision Changes Path 1.8 +9 -0 hugs98/src/errors.c

1 0

cvs commit: hugs98/src builtin.c
by Ross Paterson 04 Sep '05

04 Sep '05

ross 2005/09/04 07:27:05 PDT Modified files: src builtin.c Log: Make the Trex builtin recBrk conform to the IMPORTANT NOTICE in builtin.c. This fixes the bug reported by Adam Wyner in http://www.haskell.org/pipermail/haskell-cafe/2005-August/011056.html Revision Changes Path 1.87 +4 -3 hugs98/src/builtin.c

1 0

WinHugs error
by Neil Mitchell 02 Sep '05

02 Sep '05

Hi, There is an error in WinHugs now, caused by Prelude.h, which relates to this line (line 725-750 ish): #define STD_EMPTY_MODULE "Hugs" It used to be #define STD_EMPTY_MODULE "Hugs.Base" which works fine on windows, the new version doesn't. This seems to have been changed in revision 1.74, my first patch to remove the status bar. I certainly don't remember putting that in my patch, and if I did it was unintentional. Thanks Neil

2 3

cvs commit: hugs98/src/winhugs Registry.c winhugs.rc
by Ross Paterson 02 Sep '05

02 Sep '05

ross 2005/09/02 07:02:17 PDT Modified files: src/winhugs Registry.c winhugs.rc Log: from Neil Mitchell: When starting WinHugs for the first time the font would be set to size 2pt, about 2 pixels high per letter. This patch changes it to be a sensible size, 10pt. It also makes the default window size big enough to display the ascii art logo without wrapping. Revision Changes Path 1.2 +5 -1 hugs98/src/winhugs/Registry.c 1.15 +1 -1 hugs98/src/winhugs/winhugs.rc

1 0

Notepad editor, & prefix
by Neil Mitchell 02 Sep '05

02 Sep '05

Hi, This patch puts an & in front of the default notepad editor on Windows, to make it open asyncronously. In Windows its very unusual for an editor to block like it does with WinHugs, I tried to turn it off when I encountered it first (years ago), but never figured out how. By default non-blocking opening is much better. Thanks Neil

1 0

cvs commit: hugs98/src/winhugs DlgMain.c winhugs.rc
by Ross Paterson 02 Sep '05

02 Sep '05

ross 2005/09/02 06:57:43 PDT Modified files: src/winhugs DlgMain.c winhugs.rc Log: from Neil Mitchell: In WindowsXP classic mode the toolbar did not repaint correctly when resized. This patch makes the toolbar start large enough, and never resize, which fixes the problem. Revision Changes Path 1.2 +0 -1 hugs98/src/winhugs/DlgMain.c 1.14 +1 -1 hugs98/src/winhugs/winhugs.rc

1 0

cvs commit: hugs98/src script.c hugs.c opts.c
by Ross Paterson 02 Sep '05

02 Sep '05

ross 2005/09/02 06:56:09 PDT Modified files: src script.c hugs.c opts.c Log: from Neil Mitchell: changes the MRU (Most Recently Used) behaviour on windows. Instead of keeping the 10 most recently loaded modules, which includes dependancies, it only keeps track of those explicitly :load'ed. This means that the most recently used list does not fill up as fast, and are those which the users knows about. It removes the existing MRU hooks, and adds a new one. Revision Changes Path 1.15 +0 -1 hugs98/src/script.c 1.139 +7 -3 hugs98/src/hugs.c 1.22 +0 -5 hugs98/src/opts.c

1 0

WinHugs, Sensible defaults
by Neil Mitchell 02 Sep '05

02 Sep '05

Hi, When starting WinHugs for the first time the font would be set to size 2pt, about 2 pixels high per letter. This patch changes it to be a sensible size, 10pt. It also makes the default window size big enough to display the ascii art logo without wrapping. Thanks Neil

1 0

WinHugs, toolbar repainting
by Neil Mitchell 02 Sep '05

02 Sep '05

In WindowsXP classic mode the toolbar did not repaint correctly when resized. This patch makes the toolbar start large enough, and never resize, which fixes the problem. Thanks Neil

1 0

MruFiles WinHugs
by Neil Mitchell 02 Sep '05

02 Sep '05

Hi, This patch changes the MRU (Most Recently Used) behaviour on windows. Instead of keeping the 10 most recently loaded modules, which includes dependancies, it only keeps track of those explicitly :load'ed. This means that the most recently used list does not fill up as fast, and are those which the users knows about. It removes the existing MRU hooks, and adds a new one. After this patch, the only modified file is hugs.c, the main interpretter loop. Unfortunately its quite substantially modified, and a bit of a mess. I'll clean it up and submit that one next week. If anyone has a desparate desire to compile and test WinHugs private email me for the slightly unpleasant patch, pre-cleanup. Thanks Neil

1 0

cvs commit: hugs98/src hugs.c
by Ross Paterson 02 Sep '05

02 Sep '05

ross 2005/09/02 06:03:11 PDT Modified files: src hugs.c Log: from Neil Mitchell: Remove the call to SaveGUIOptions, the GUI options are saved by the GUI as required. Remove windows and winhugs headers. Revision Changes Path 1.138 +2 -14 hugs98/src/hugs.c

1 0

cvs commit: hugs98/src hugs.c
by Ross Paterson 02 Sep '05

02 Sep '05

ross 2005/09/02 05:58:43 PDT Modified files: src hugs.c Log: from Neil Mitchell: make WinHugs print out the website address and the mailto address in the startup banner as hyperlinks, so clicking one will take you to the hugs website and the other will compose a mail for hugs-bugs. Revision Changes Path 1.137 +8 -4 hugs98/src/hugs.c

1 0

Remove windows stuff from hugs.c
by Neil Mitchell 02 Sep '05

02 Sep '05

Hi, Remove the call to SaveGUIOptions, the GUI options are saved by the GUI as required. Remove windows and winhugs headers. Thanks Neil

1 0

cvs commit: hugs98/src script.c
by Ross Paterson 02 Sep '05

02 Sep '05

ross 2005/09/02 05:53:01 PDT Modified files: src script.c Log: from Neil Mitchell: removes unnecessary windows headers. Also adds hyperlinks when printing loaded modules names. This enables the user to click on them to open them in the editor. Revision Changes Path 1.14 +9 -5 hugs98/src/script.c

1 0

hugs.c, change the WinHugs banner
by Neil Mitchell 02 Sep '05

02 Sep '05

Hi, This patch makes WinHugs print out the website address and the mailto address in the startup banner as hyperlinks, so clicking one will take you to the hugs website and the other will compose a mail for hugs-bugs. Thanks Neil

1 0

Script.c patch, print hyperlinks when loading modules
by Neil Mitchell 02 Sep '05

02 Sep '05

Hi, This patch removes unnecessary windows headers. Also adds hyperlinks when printing loaded modules names. This enables the user to click on them to open them in the editor. Thanks Neil

1 0

cvs commit: hugs98/src opts.c
by Ross Paterson 02 Sep '05

02 Sep '05

ross 2005/09/02 04:08:38 PDT Modified files: src opts.c Log: from Neil Mitchell: Instead of using MessageBox and hWnd use InfoBox for warnings. Remove call to ReadGUIOptions: WinHugs will manage its own options. This means that <winhugs.h> is not required. Revision Changes Path 1.21 +2 -8 hugs98/src/opts.c

1 0

WinHugs opt.c, use new functions
by Neil Mitchell 02 Sep '05

02 Sep '05

Hi, Instead of using MessageBox and hWnd use InfoBox for warnings. Remove call to ReadGUIOptions, WinHugs will manage its own options within its code. This means that <winhugs.h> is not required. Thanks Neil

1 0

cvs commit: hugs98/src machdep.c hugs98/src/winhugs IORemap.h StartCode.c
by Ross Paterson 02 Sep '05

02 Sep '05

ross 2005/09/02 03:54:52 PDT Modified files: src machdep.c src/winhugs IORemap.h StartCode.c Log: from Neil Mitchell: instead of destroying the main window with windows API calls and the magic hWndMain in response to exit, be nice and call WinHugsExit (renamed from KillWindow). Revision Changes Path 1.131 +3 -3 hugs98/src/machdep.c 1.2 +2 -0 hugs98/src/winhugs/IORemap.h 1.2 +1 -1 hugs98/src/winhugs/StartCode.c

1 0

cvs commit: hugs98/src machdep.c
by Ross Paterson 02 Sep '05

02 Sep '05

ross 2005/09/02 03:49:32 PDT Modified files: src machdep.c Log: from Neil Mitchell: This removes the feature where the cursor changes to the rubbish bin during garbage collection. I've never seen this in action, which probably means that it either didn't work, or that on a modern machine GC is too fast to spot it. Either way, a garbage can on windows means delete files, not freeing memory! Revision Changes Path 1.130 +2 -15 hugs98/src/machdep.c

1 0

WinHugs patch, machdep.c
by Neil Mitchell 02 Sep '05

02 Sep '05

Hi, Patch for machdep.c. This removes the feature where the cursor changes to the rubbish bin during garbage collection. I've never seen this in action, which probably means that it either didn't work, or that on a modern machine GC is too fast to spot it. Either way, a garbage can on windows means delete files, not freeing memory! Also instead of destroying the main window with windows API calls and the magic hWndMain in response to exit, be nice and call WinHugsExit. WinHugs.patch renames this call from KillWindow to WinHugsExit and adds it to the appropriate header. Thanks Neil

1 0

cvs commit: hugs98/src prelude.h
by Ross Paterson 01 Sep '05

01 Sep '05

ross 2005/09/01 08:26:38 PDT Modified files: src prelude.h Log: from Neil Mitchell: Take a lot of stuff out of the Hugs prelude, specifically <windows.h> and the window handles. Only allow communication through simple and non-windows based commands. IORemap is now included, which mainly does redefining puts, printf etc to the WinHugs console and also has a few required API definitions. Revision Changes Path 1.76 +6 -35 hugs98/src/prelude.h

1 0

cvs commit: hugs98/src output.c
by Ross Paterson 01 Sep '05

01 Sep '05

ross 2005/09/01 08:23:51 PDT Modified files: src output.c Log: from Neil Mitchell: Change INT to int, so it doesn't require windows.h Revision Changes Path 1.39 +3 -3 hugs98/src/output.c

1 0

Output.c, change INT to int
by Neil Mitchell 01 Sep '05

01 Sep '05

Change INT to int, so it doesn't require windows.h Thanks Neil

1 0

cvs commit: hugs98/src errors.c
by Ross Paterson 01 Sep '05

01 Sep '05

ross 2005/09/01 08:16:17 PDT Modified files: src errors.c Log: From Neil Mitchell: * removed dependencies on windows.h * turned compile time errors into hyperlinks on WinHugs. Revision Changes Path 1.7 +21 -12 hugs98/src/errors.c

1 0

WinHugs Prelude Patch
by Neil Mitchell 01 Sep '05

01 Sep '05

Take a lot of stuff out of the Hugs prelude, specifically <windows.h> and the window handles. Only allow communication through simple and non-windows based commands. IORemap is now included, which mainly does redefining puts, printf etc to the WinHugs console and also has a few required API definitions. Thanks Neil

1 0

cvs commit: hugs98/src errors.h
by Ross Paterson 01 Sep '05

01 Sep '05

ross 2005/09/01 07:57:50 PDT Modified files: src errors.h Log: from Neil Mitchell: use WinHugsColor() instead of the magic hWndText. Revision Changes Path 1.13 +3 -3 hugs98/src/errors.h

1 0

cvs commit: hugs98/src input.c
by Ross Paterson 01 Sep '05

01 Sep '05

ross 2005/09/01 07:49:24 PDT Modified files: src input.c Log: from Neil Mitchell: When saving stuff before auto-reloading files, it is no longer necessary to save the input buffer in Windows - the standard control takes care of this automatically. Revision Changes Path 1.87 +2 -8 hugs98/src/input.c

1 0

Patch for input.c
by Neil Mitchell 01 Sep '05

01 Sep '05

Hi, When saving stuff before auto-reloading files, it is no longer necessary to save the input buffer in Windows - the standard control takes care of this automatically. Thanks Neil

1 0

cvs commit: hugs98/src errors.h
by Ross Paterson 01 Sep '05

01 Sep '05

ross 2005/09/01 07:35:34 PDT Modified files: src errors.h Log: whitespace Revision Changes Path 1.12 +5 -5 hugs98/src/errors.h

1 0

Patches for error.h and error.c
by Neil Mitchell 01 Sep '05

01 Sep '05

Hi, Attached is a patch for error.h/.c. Some comments: The WinHugs specific bit now uses int instead of INT, so its not dependant on windows.h The error message on compile time errors now puts out a hyperlink, this is #if'd so shouldn't change non WinHugs. This allows WinHugs users to click when an error occurs and be brought to that location in their editor. Instead of proding MessageBox(hWnd), I have defined InfoBox and ErrorBox which WinHugs does something sensible with. The header file uses cleaner interaction with WinHugs, instead of poking the magic hWnd.. Thanks Neil

1 0

cvs commit: hugs98/src/winhugs menusbm.c winhugs.rc
by Ross Paterson 01 Sep '05

01 Sep '05

ross 2005/09/01 05:42:00 PDT Modified files: src/winhugs menusbm.c winhugs.rc Log: missing bits from last commit Revision Changes Path 1.3 +4 -4 hugs98/src/winhugs/menusbm.c 1.13 +328 -216 hugs98/src/winhugs/winhugs.rc

1 0

cvs commit: hugs98/src/winhugs DlgAbout.c DlgMain.c DlgOptions.c General.c Header.h History.c IORemap.c IORemap.h Legacy.c MruFiles.c Registry.c Registry.h RtfWindow.c RtfWindow.h ScriptMan.c StartCode.c Winbrows.c Winframe.c Winframe.h Winhint.c ...
by Ross Paterson 01 Sep '05

01 Sep '05

ross 2005/09/01 05:22:19 PDT Modified files: src/winhugs/resource hugs1.ico hugsdoc.ico logo.bmp Added files: src/winhugs DlgAbout.c DlgMain.c DlgOptions.c General.c Header.h History.c IORemap.c IORemap.h Legacy.c MruFiles.c Registry.c Registry.h RtfWindow.c RtfWindow.h ScriptMan.c StartCode.c resrc1.h src/winhugs/resource rt_manif.bin toolbar.bmp winhugs.manifest Removed files: src/winhugs Winbrows.c Winframe.c Winframe.h Winhint.c Winhint.h Winhugs.h Wintext.c Wintext.h Wintoolb.c Wintoolb.h Winutils.c Winutils.h config.bat winhugs.c Log: New WinHugs implementation, from Neil Mitchell, reformatted in house style. Changes in .. to make it work are on the way. Revision Changes Path 1.2 +14 -1 hugs98/src/winhugs/resource/hugs1.ico 1.2 +1 -1 hugs98/src/winhugs/resource/hugsdoc.ico 1.2 +1 -1 hugs98/src/winhugs/resource/logo.bmp

1 0

WinHugs progress report
by Neil Mitchell 01 Sep '05

01 Sep '05

Hi, I've been working on rewriting WinHugs recently, to make it work and to make it more Windows compliant. I have put a screenshot up at http://www-users.cs.york.ac.uk/~ndm/projects/winhugs.php, and my todo list is http://www.haskell.org/hawiki/NeilMitchell/HugsNotes which includes the bugs I'm working on, and a list of the good and bad points about the rewrite. I have a version which I am now using as my primary development environment. Its stable and reliable. Out of the bugs mentioned in the Todo list only the options dialog not giving people -/+98 and other super-haskell options is real enough to stop people using it, if they want non-standard haskell. All the others are very minor. While I'm rewriting it I've tried to reduce the amount Hugs knows about WinHugs. For example, I've removed #include <windows.h> from prelude.h. There are quite a few changes to the hugs files, 8 files have been modified, none that substantially. All the changes are pretty local, and in general seem to be positive ones, I think. The changes in the WinHugs directory are pretty much total, its almost unrecognisable. There are 4 chunks of code that have survived, and those have all been marked with big warnings. Most of the files have changed name, there are a lot more smaller and self contained modules. It's not the same at all. Once the first modifications are made to the hugs directory, the existing winhugs code will be dead forever, the two code bases are sufficiently different that its unlikely to be able to run them side by side off the same hugs code, without some effort (not too much, but I can't imagine anyone will want to do it). With this in mind, how would be best to go about merging in WinHugs2? 1) Delete WinHugs and start from scratch. 2) Make a WinHugs2 directory, and keep WinHugs around for the past, accepting it probably won't build. 3) Find someone who wants to resurect the dead WinHugs1... (maybe) And also when does WinHugs2 integration want to take place? Thanks Neil

2 4

Updated hugs msc projects
by Neil Mitchell 31 Aug '05

31 Aug '05

Hi, Attached are the updated project files for hugs and runhugs, the console versions, with the required files to build on windows. They are in the VS.NET format, the existing ones are broken (not badly, just slightly) and in VS6 format. These can happily coexist with the old ones. With these project files, the latest version of hugs builds from CVS on Windows with Visual Studio .NET happily, without any patches. Please place these files in src/msc Thanks Neil

2 2

Hugs for Windows icons
by Neil Mitchell 31 Aug '05

31 Aug '05

Hi, I have updated the icons in the "icons" directory. In the past these were a 32x32 icon which is scaled by the OS for 16x16 and 48x48 sizes, which doesn't look very good at all. The attached icons are all natively in all 3 sizes. In addition, they use anti-aliasing on the lambda to make it fit in better with the rest of the computer. They are still 16 color, using the standard windows 16 color palette, so should work perfectly on older computers as well. I have uploaded a .png of all the icons, see http://www-users.cs.york.ac.uk/~ndm/projects/winhugs.php at the bottom. The first 3 are attached to this email (in order: hsicon, hugsicon, hsxicon), the bottom row are the new WinHugs icons, which aren't attached. Thanks Neil

1 0

WinHugs, Haskell bug
by Neil Mitchell 31 Aug '05

31 Aug '05

Hi, The following code > let x = 1 in x Gives the following error on WinHugs, the latest development build (my private one) > ERROR - Syntax error in expression (unexpected keyword "in") When run in either a very old copy of WinHugs, or GHCi I get > 1 I think this has been occuring ever since I started development, quite possibly before, as a few early bugs were caused by this - long before I was tracking bugs. Does the vanilla CVS version accept this? I haven't changed much (as far as I can tell, none) parsing/execution code. Thanks Neil

1 1