- Cvs-hugs - Haskell.org

cvs commit: hugs98/src hugs.c hugs98/src/winhugs Editors.c Winhugs.h
by Ross Paterson 16 Sep '05

16 Sep '05

ross 2005/09/16 09:55:10 PDT Modified files: src hugs.c src/winhugs Editors.c Winhugs.h Log: from Neil Mitchell: use notepad only if no other editor is found. Revision Changes Path 1.145 +6 -2 hugs98/src/hugs.c 1.2 +15 -0 hugs98/src/winhugs/Editors.c 1.15 +2 -0 hugs98/src/winhugs/Winhugs.h

1 0

Re: WinHugs and Unicode
by Ross Paterson 16 Sep '05

16 Sep '05

On Fri, Sep 16, 2005 at 04:58:03PM +0100, Neil Mitchell wrote: > In Windows both the WinHugs "fake" console and the standard console > are already unicode compliant on NT/2K/XP and have wrapper functions > such as wprintf which are unicode and tprintf which is either ASCII or > Unicode depending on some #define's. If you change the user-default ANSI code page, can it print out non-ASCII Chars, and read them in? (Identifiers are restricted to Latin-1, though.) > How does Hugs deal with unicode, i.e. are the filenames etc. stored by > the program as unicode, or is it just the Haskell elements that are > Unicode. Module filenames, no. Filenames in H98 library calls are String, which is Unicode. String literals are byte-encoded Unicode, though. > Attatched is a patch which includes the unicode compliant header along > with commented out definitions for unicode in WinHugs. If you > uncomment those definitions it will not work, but then I can work on > converting files one by one and when they are all done hopefully a > Unicode enabled Hugs on windows will result :) > > This process should not alter the non unicode code paths at all, > beause of various defines in Windows. I fear you may be opening a can of worms, and you may end up having to change things everywhere.

2 1

cvs commit: hugs98/src/winhugs Header.h
by Ross Paterson 16 Sep '05

16 Sep '05

ross 2005/09/16 09:51:25 PDT Modified files: src/winhugs Header.h Log: from Neil Mitchell: include tchar.h Revision Changes Path 1.5 +3 -0 hugs98/src/winhugs/Header.h

1 0

WinHugs, sensible defaults (II)
by Neil Mitchell 16 Sep '05

16 Sep '05

Hi, At the moment, WinHugs defaults to notepad as the editor. Notepad cannot open a specific line or char, which means its not great for using with WinHugs, much of the impressive bits of WinHugs become less useful. This patch makes it use any editor but notepad if it can find one, otherwise notepad. With this patch, and the auto-reload files one (sent previously) it would mean that the average WinHugs user does not need a trip to the options dialog before they are running WinHugs at its optimum. Thanks Neil

1 0

cvs commit: hugs98/src builtin.c
by Ross Paterson 16 Sep '05

16 Sep '05

ross 2005/09/16 09:03:46 PDT Modified files: src builtin.c Log: delete unused assert() Revision Changes Path 1.91 +2 -3 hugs98/src/builtin.c

1 0

WinHugs and Unicode
by Neil Mitchell 16 Sep '05

16 Sep '05

Hi, The new version of WinHugs is not unicode compliant, and is unlikely to be in time for the release. While its relatively easy to change it to be unicode compliant, unfortunately a lot of the useful unicode functions are only available on NT/2k/XP, and some are 98/ME/NT/2K/XP, but not 95. Because of this, its going to be difficult to ensure that a Unicode WinHugs works everywhere, the main problem being testing rather than coding. I may start sending some unicode patches over, so I can get WinHugs building in Unicode mode, since these are ignored when compiling in ANSI mode. The other question is to what degree Hugs in Unicode compliant? Are filenames etc. unicode based, or is it just the interaction? Thanks Neil

2 2

cvs commit: hugs98/src builtin.c
by Ross Paterson 16 Sep '05

16 Sep '05

ross 2005/09/13 12:35:00 PDT Modified files: src builtin.c Log: cosmetic changes to adjustor stuff. Revision Changes Path 1.90 +93 -100 hugs98/src/builtin.c

2 1

cvs commit: hugs98/src/winhugs DlgMain.c
by Ross Paterson 14 Sep '05

14 Sep '05

ross 2005/09/14 03:15:35 PDT Modified files: src/winhugs DlgMain.c Log: from Neil Mitchell: fix a sizeof() Revision Changes Path 1.11 +1 -1 hugs98/src/winhugs/DlgMain.c

1 0

WinHugs, bugglet fix
by Neil Mitchell 14 Sep '05

14 Sep '05

Hi, There was a minor bugglet, not necessarily causing issues but certainly wrong. Its allocating an array with malloc(sizeof(Item) * Number), but Item accidentally refers to some totally unrelated structure because of a typo. Thanks Neil

1 0

cvs commit: hugs98/src builtin.c
by Ross Paterson 13 Sep '05

13 Sep '05

ross 2005/09/13 08:28:53 PDT Modified files: src builtin.c Log: Another tilt at the Windows DEP problem: make the thunk_data RWX (though actually only the code part needs it). Revision Changes Path 1.89 +5 -3 hugs98/src/builtin.c

2 1

WinHugs, make AutoReload the default
by Neil Mitchell 13 Sep '05

13 Sep '05

Hi, This patch makes automatic reloading of modified files the default behaviour under Windows. How this has not been the default behaviour always is beyond me, I know of noone who knows about this flag and has it turned off. Thanks Neil

1 0

Fwd: cvs commit: hugs98/src builtin.c
by Brian Smith 12 Sep '05

12 Sep '05

On 9/11/05, Ross Paterson <ross(a)galois.com> wrote: > > steal a bit more of mallocBytesRWX() from GHC. > > Maybe this will fix the Windows DEP problem reported by Brian Smith. No, it didn't fix it. I think that the problem that needed fixed in GHCi was different than the problem with Hugs. With the GHCi error, the Windows DEP error dialog box would pop up, (I believe) asking the user to report the problem to Microsoft, and providing a button that opened up the DEP settings dialog box. In the Hugs error, the Windows DEP error dialog box never pops up. Instead, Hugs just reports that it received an unexpected signal. The signal it receives is SIGSEGV. - Brian

1 0

Releasing WinHugs
by Neil Mitchell 12 Sep '05

12 Sep '05

Hi, With the patches that have been submitted, the bug list for WinHugs hits 0, see http://www.haskell.org/hawiki/NeilMitchell_2fHugsNotes . If anyone knows of any other bugs, or finds any, please let me know. If anyone thinks anything in the polish section is a bit more important also let me know. I think I'm ready for limited beta testing, so if anyone wants that also let me know. Also if anyone has any overall comments (I miss this, why did you change that, how do I do this, i can't see the use of that) I'd love to hear them. When does it suit to release WinHugs? It needs a bit longer for beta testing etc, but is a Hugs release being planned soon, or should WinHugs be released separately? How stable is the Hugs code base, i.e. is it release worthy? Thanks Neil

6 13

cvs commit: hugs98/src builtin.c
by Ross Paterson 11 Sep '05

11 Sep '05

ross 2005/09/11 17:26:33 PDT Modified files: src builtin.c Log: steal a bit more of mallocBytesRWX() from GHC. Maybe this will fix the Windows DEP problem reported by Brian Smith. Revision Changes Path 1.88 +12 -4 hugs98/src/builtin.c

1 0

Hugs on Windows, FFI
by Brian Smith 11 Sep '05

11 Sep '05

On 9/9/05, Neil Mitchell <ndmitchell(a)gmail.com> wrote: > > Hi, > > Running "make check" I get the following, dropping most of the > begining since it seems sensible enough. Apparently this should show > if FFI works on Windows? I noticed that your test results didn't include failures for Sparc.hs/Callback.hs/Sin.hs. After more investigation, I found that these tests only fail when Windows Data Execution Prevention (DEP) [1] is enabled. When I disable DEP for hugs.exe, these tests pass; when I enabled DEP then the tests fail. So, apparently the code that builds the thunks used for callbacks does not correctly set the executable/non-writable flags on the thunk after it is created. There was a very similar bug in GHCi/runghc that was fixed just a few weeks ago. I think the solution to this problem is probably simple for somebody familiar with the GHCi solution, or somebody familiar with the Windows memory management API's. But, failing a fix, we should at least note this problem in the release notes, and the installer should automatically disable DEP for hugs.exe, runhugs.exe, and WinHugs.exe. [1] http://support.microsoft.com/kb/875352 - Brian

2 1

cvs commit: hugs98/src HsFFI.h
by Ross Paterson 11 Sep '05

11 Sep '05

ross 2005/09/11 04:46:47 PDT Modified files: src HsFFI.h Log: match DLL stuff in prelude.h Revision Changes Path 1.18 +8 -8 hugs98/src/HsFFI.h

1 0

cvs commit: hugs98/src prelude.h
by Ross Paterson 10 Sep '05

10 Sep '05

ross 2005/09/10 17:33:00 PDT Modified files: src prelude.h Log: Do __declspec(dllimport) and __declspec(dllexport) for MinGW as well as MSVC, for interoperability. Revision Changes Path 1.80 +12 -10 hugs98/src/prelude.h

1 0

cvs commit: hugs98/src server.c
by Ross Paterson 10 Sep '05

10 Sep '05

ross 2005/09/10 02:42:26 PDT Modified files: src server.c Log: minor improvements to error messages Revision Changes Path 1.45 +6 -4 hugs98/src/server.c

1 0

cvs commit: hugs98/src static.c
by Ross Paterson 10 Sep '05

10 Sep '05

ross 2005/09/10 02:41:09 PDT Modified files: src static.c Log: refer to Hugs.Trex in error messages Revision Changes Path 1.174 +14 -14 hugs98/src/static.c

1 0

cvs commit: hugs98 configure.ac
by Ross Paterson 10 Sep '05

10 Sep '05

ross 2005/09/10 02:14:26 PDT Modified files: . configure.ac Log: some explanation of the prejudice against byacc. Revision Changes Path 1.40 +4 -0 hugs98/configure.ac

1 0

Hugs on Windows, FFI
by Neil Mitchell 09 Sep '05

09 Sep '05

Hi, Running "make check" I get the following, dropping most of the begining since it seems sensible enough. Apparently this should show if FFI works on Windows? Thanks Neil ----- /bin/cp hugs-ug.css users_guide test -z '' || \ --dsl hugs-ug.dsl users_guide.sgml make[2]: Leaving directory `/d/sources/hugs/hugs98/docs/users_guide' make[1]: Leaving directory `/d/sources/hugs/hugs98/docs' cd tests && sh testScript | egrep -v '^--( |-----)' ./../src/hugs +q -w -pHugs: static/mod154.hs < nul expected stdout not matched by reality *** static/Loaded.output Fri Jul 19 23:41:51 2002 --- /tmp/runtest4056.3 Fri Sep 9 12:38:19 2005 *************** *** 1,2 **** ! Type :? for help Hugs:[Leaving Hugs] --- 1,3 ---- ! ERROR "static/mod154.hs" - Conflicting exports of entity "sort" ! *** Could refer to Data.List.sort or M.sort Hugs:[Leaving Hugs] ./../src/hugs +q -w -pHugs: rts/read.hs < rts/read.input expected stdout not matched by reality *** rts/read.output Fri Jul 18 14:43:51 2003 --- /tmp/runtest4060.3 Fri Sep 9 12:38:46 2005 *************** *** 28,32 **** Hugs:False ! Hugs:2.384186e-07 Hugs:False ! Hugs:-3.10862446895044e-15 Hugs:[Leaving Hugs] --- 28,32 ---- Hugs:False ! Hugs:2.384186e-007 Hugs:False ! Hugs:-3.10862446895044e-015 Hugs:[Leaving Hugs] ./../src/hugs +q -w -pHugs: rts/arith.hs < rts/arith.input expected stdout not matched by reality *** rts/arith.output Fri Jul 18 14:43:50 2003 --- /tmp/runtest1228.3 Fri Sep 9 12:38:47 2005 *************** *** 36,39 **** Hugs:"(True,False)" ! Hugs:"[1.666667,-1.666667,-0.0,0.0,-1.666667,1.666667]" ! Hugs:"inf" Hugs:Hugs:"3.141593" --- 36,39 ---- Hugs:"(True,False)" ! Hugs:"[1.666667,-1.666667,0.0,0.0,-1.666667,1.666667]" ! Hugs:"1.#INF" Hugs:Hugs:"3.141593" ./../src/hugs +q -w -pHugs: ffi/FileIO.hs < ffi/FileIO.input expected stdout not matched by reality *** ffi/FileIO.output Wed Aug 31 14:56:18 2005 --- /tmp/runtest2412.3 Fri Sep 9 12:39:03 2005 *************** *** 10,12 **** import Foreign.C.String ! import System.Directory (removeFile) --- 10,12 ---- import Foreign.C.String ! import System.Directory (remo ./../src/hugs +q -w -pHugs: Directory libs/dirTest.hs < libs/dirTest.input expected stdout not matched by reality *** libs/dirTest.output Sat Jan 10 12:47:32 2004 --- /tmp/runtest2104.3 Fri Sep 9 12:39:38 2005 *************** *** 18,22 **** Hugs:Permissions {readable = True, writable = True, executable = False, search able = True} ! Permissions {readable = True, writable = True, executable = False, searchable = False} ! Permissions {readable = False, writable = True, executable = False, searchable = False} ! got expected IO error --- 18,22 ---- Hugs:Permissions {readable = True, writable = True, executable = False, search able = True} ! Permissions {readable = True, writable = True, executable = True, searchable = False} ! Permissions {readable = True, writable = True, executable = True, searchable = False} ! dir7_test_dir/a: Directory.removeFile: permission denied

2 3

cvs commit: hugs98/src machdep.c
by Ross Paterson 09 Sep '05

09 Sep '05

ross 2005/09/09 16:42:30 PDT Modified files: src machdep.c Log: If the module filename doesn't contain a slash, prefix ./ to the corresponding shared object file name, to avoid using LD_LIBRARY_PATH or its equivalent. Revision Changes Path 1.134 +11 -5 hugs98/src/machdep.c

1 0

cvs commit: hugs98/src prelude.h machine.c
by Ross Paterson 09 Sep '05

09 Sep '05

ross 2005/09/09 02:03:07 PDT Modified files: src prelude.h machine.c Log: Place a limit on the number of nested calls to eval(), to avoid C stack overflows. Revision Changes Path 1.79 +10 -2 hugs98/src/prelude.h 1.25 +8 -2 hugs98/src/machine.c

1 0

cvs commit: hugs98/src machdep.c
by Ross Paterson 08 Sep '05

08 Sep '05

ross 2005/09/08 16:45:41 PDT Modified files: src machdep.c Log: remove unused argument Revision Changes Path 1.133 +7 -8 hugs98/src/machdep.c

1 0

Documentation, /docs/building/Win32.txt
by Neil Mitchell 08 Sep '05

08 Sep '05

Hi, I read the documentation in docs/buiding/win32.txt and it didn't really help. Brian gave me detailed instructions via email, I have modified them slightly with a few extra steps that I found were needed. These new instructions don't describe building by cygwin, but cygwin is pretty awful so I'd say thats a good thing. They do include MSYS instruction which is far better, and results in a perfectly working binary. They also describe building using Visual Studio, not from the command line but from the project files. Thanks Neil

2 1