January 2013 - ghc-devs

RE: [GHC] #1614: Type checker does not use functional dependency to avoid ambiguity
by Simon Peyton-Jones 27 Jan '13

27 Jan '13

Please do endanger the code base! GHC needs people willing to have a go. * We try to review offered patches promptly (yell if this does not happen) * Worth discussing the general approach before investing a lot of time; the more substantial the change/fix the more discussion! Simon | -----Original Message----- | From: Andrew Adams-Moran [mailto:morabbin@gmail.com] | Sent: 27 January 2013 00:19 | To: Simon Peyton-Jones | Cc: ghc-devs(a)haskell.org | Subject: Re: [GHC] #1614: Type checker does not use functional dependency to | avoid ambiguity | | | Hi all! | | Thanks Simon; I figured this was good way for me to learn the conventions of the | team without endangering the code base. | | Thanks for the feedback, and consider it taken on board. | | Cheers, | | Andy | | On Jan 26, 2013, at 4:11 PM, Simon Peyton-Jones <simonpj(a)microsoft.com> | wrote: | | > Ah, so the mysterious and highly-active morabbin is none other than our old | friend and drinking companion Andy Adams-Moran! Welcome Andy! Thanks for | looking through these old tickets. | > | > | "Bump" is a cutesy internet name for this kind of bubbling something up to | the | > | top of the dev list. Please have another look at this ticket; here's what | > | I see (or not), maybe we can get rid of it." | > | > The trouble is that there aren't enough of these GHC devs to deal with the | hundreds of open tickets, bumped or not. When adding to a long-existing ticket, | there are really three modes of operation | > | > * This ticket is mission-critical to me; here's why; please please help. | > | > * Here is some new information. Eg. I tripped over this myself; here is the repro | case; or I think I may have an idea what's going on. | > | > * I'm going to have ago at fixing this. Here's how I propose to do it. Please yell | if I'm going awry here. | > | > But your "bump" seems to mean "I've looked at this and it still seems to be | open", and I don't know what to do about that. I'd love to have them *all* | attended to, but we need a lot more people to help if we are to achieve that. | > | > To simply indicate interest, the protocol is to add yourself to the cc list. Long cc | lists get more attention. Well some more attention! | http://hackage.haskell.org/trac/ghc/wiki/WorkingConventions/BugTracker | > | > Simon | > | > | -----Original Message----- | > | From: Andrew Adams-Moran [mailto:morabbin@gmail.com] | > | Sent: 26 January 2013 23:42 | > | To: Simon Peyton-Jones | > | Cc: ghc-devs(a)haskell.org | > | Subject: Re: [GHC] #1614: Type checker does not use functional dependency | to | > | avoid ambiguity | > | | > | | > | Hi Simon; | > | | > | "Bump" is a cutesy internet name for this kind of bubbling something up to | the | > | top of the dev list. | > | | > | "Please have another look at this ticket; here's what I see (or not), maybe | we | > | can get rid of it." | > | | > | In this case, it's also means that the commit is result of my ongoing attempt | to | > | revivify the bug sweep. So folks should feel free to ignore. | > | | > | (Also, do let me know if this is counter to GHC conventions, and I'll adapt | > | accordingly.) | > | | > | Cheers, | > | | > | Andy | > | | > | On Jan 26, 2013, at 3:15 PM, Simon Peyton-Jones <simonpj(a)microsoft.com> | > | wrote: | > | | > | > Morabbin, what's the semantics of "bump"? I don't know what you intend | by | > | it! | > | > | > | > Simon | > | > | > | > | -----Original Message----- | > | > | From: ghc-tickets-bounces(a)haskell.org [mailto:ghc-tickets- | > | bounces(a)haskell.org] | > | > | On Behalf Of GHC | > | > | Sent: 26 January 2013 22:12 | > | > | Cc: ghc-tickets(a)haskell.org | > | > | Subject: Re: [GHC] #1614: Type checker does not use functional | dependency | > | to | > | > | avoid ambiguity | > | > | | > | > | #1614: Type checker does not use functional dependency to avoid | ambiguity | > | > | --------------------------------------+------------------------------------- | > | > | Reporter: guest | Owner: | > | > | Type: bug | Status: new | > | > | Priority: normal | Milestone: _|_ | > | > | Component: Compiler (Type checker) | Version: 6.7 | > | > | Resolution: | Keywords: | > | > | Os: Unknown/Multiple | Architecture: Unknown/Multiple | > | > | Failure: None/Unknown | Difficulty: Unknown | > | > | Testcase: | Blockedby: | > | > | Blocking: | Related: | > | > | --------------------------------------+------------------------------------- | > | > | Changes (by morabbin): | > | > | | > | > | * failure: => None/Unknown | > | > | | > | > | | > | > | Comment: | > | > | | > | > | Bump; chak saya this was fixed in HEAD, and then SPJ closes as | wontfix? | > | > | Was the fix backed out? | > | > | | > | > | -- | > | > | Ticket URL: | <http://hackage.haskell.org/trac/ghc/ticket/1614#comment:11> | > | > | GHC <http://www.haskell.org/ghc/> | > | > | The Glasgow Haskell Compiler | > | > | | > | > | _______________________________________________ | > | > | ghc-tickets mailing list | > | > | ghc-tickets(a)haskell.org | > | > | http://www.haskell.org/mailman/listinfo/ghc-tickets | > | > | > | > _______________________________________________ | > | > ghc-devs mailing list | > | > ghc-devs(a)haskell.org | > | > http://www.haskell.org/mailman/listinfo/ghc-devs | >

1 0

RE: [GHC] #1614: Type checker does not use functional dependency to avoid ambiguity
by Simon Peyton-Jones 27 Jan '13

27 Jan '13

Ah, so the mysterious and highly-active morabbin is none other than our old friend and drinking companion Andy Adams-Moran! Welcome Andy! Thanks for looking through these old tickets. | "Bump" is a cutesy internet name for this kind of bubbling something up to the | top of the dev list. Please have another look at this ticket; here's what | I see (or not), maybe we can get rid of it." The trouble is that there aren't enough of these GHC devs to deal with the hundreds of open tickets, bumped or not. When adding to a long-existing ticket, there are really three modes of operation * This ticket is mission-critical to me; here's why; please please help. * Here is some new information. Eg. I tripped over this myself; here is the repro case; or I think I may have an idea what's going on. * I'm going to have ago at fixing this. Here's how I propose to do it. Please yell if I'm going awry here. But your "bump" seems to mean "I've looked at this and it still seems to be open", and I don't know what to do about that. I'd love to have them *all* attended to, but we need a lot more people to help if we are to achieve that. To simply indicate interest, the protocol is to add yourself to the cc list. Long cc lists get more attention. Well some more attention! http://hackage.haskell.org/trac/ghc/wiki/WorkingConventions/BugTracker Simon | -----Original Message----- | From: Andrew Adams-Moran [mailto:morabbin@gmail.com] | Sent: 26 January 2013 23:42 | To: Simon Peyton-Jones | Cc: ghc-devs(a)haskell.org | Subject: Re: [GHC] #1614: Type checker does not use functional dependency to | avoid ambiguity | | | Hi Simon; | | "Bump" is a cutesy internet name for this kind of bubbling something up to the | top of the dev list. | | "Please have another look at this ticket; here's what I see (or not), maybe we | can get rid of it." | | In this case, it's also means that the commit is result of my ongoing attempt to | revivify the bug sweep. So folks should feel free to ignore. | | (Also, do let me know if this is counter to GHC conventions, and I'll adapt | accordingly.) | | Cheers, | | Andy | | On Jan 26, 2013, at 3:15 PM, Simon Peyton-Jones <simonpj(a)microsoft.com> | wrote: | | > Morabbin, what's the semantics of "bump"? I don't know what you intend by | it! | > | > Simon | > | > | -----Original Message----- | > | From: ghc-tickets-bounces(a)haskell.org [mailto:ghc-tickets- | bounces(a)haskell.org] | > | On Behalf Of GHC | > | Sent: 26 January 2013 22:12 | > | Cc: ghc-tickets(a)haskell.org | > | Subject: Re: [GHC] #1614: Type checker does not use functional dependency | to | > | avoid ambiguity | > | | > | #1614: Type checker does not use functional dependency to avoid ambiguity | > | --------------------------------------+------------------------------------- | > | Reporter: guest | Owner: | > | Type: bug | Status: new | > | Priority: normal | Milestone: _|_ | > | Component: Compiler (Type checker) | Version: 6.7 | > | Resolution: | Keywords: | > | Os: Unknown/Multiple | Architecture: Unknown/Multiple | > | Failure: None/Unknown | Difficulty: Unknown | > | Testcase: | Blockedby: | > | Blocking: | Related: | > | --------------------------------------+------------------------------------- | > | Changes (by morabbin): | > | | > | * failure: => None/Unknown | > | | > | | > | Comment: | > | | > | Bump; chak saya this was fixed in HEAD, and then SPJ closes as wontfix? | > | Was the fix backed out? | > | | > | -- | > | Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/1614#comment:11> | > | GHC <http://www.haskell.org/ghc/> | > | The Glasgow Haskell Compiler | > | | > | _______________________________________________ | > | ghc-tickets mailing list | > | ghc-tickets(a)haskell.org | > | http://www.haskell.org/mailman/listinfo/ghc-tickets | > | > _______________________________________________ | > ghc-devs mailing list | > ghc-devs(a)haskell.org | > http://www.haskell.org/mailman/listinfo/ghc-devs

1 0

RE: [GHC] #1614: Type checker does not use functional dependency to avoid ambiguity
by Simon Peyton-Jones 27 Jan '13

27 Jan '13

Morabbin, what's the semantics of "bump"? I don't know what you intend by it! Simon | -----Original Message----- | From: ghc-tickets-bounces(a)haskell.org [mailto:ghc-tickets-bounces@haskell.org] | On Behalf Of GHC | Sent: 26 January 2013 22:12 | Cc: ghc-tickets(a)haskell.org | Subject: Re: [GHC] #1614: Type checker does not use functional dependency to | avoid ambiguity | | #1614: Type checker does not use functional dependency to avoid ambiguity | --------------------------------------+------------------------------------- | Reporter: guest | Owner: | Type: bug | Status: new | Priority: normal | Milestone: _|_ | Component: Compiler (Type checker) | Version: 6.7 | Resolution: | Keywords: | Os: Unknown/Multiple | Architecture: Unknown/Multiple | Failure: None/Unknown | Difficulty: Unknown | Testcase: | Blockedby: | Blocking: | Related: | --------------------------------------+------------------------------------- | Changes (by morabbin): | | * failure: => None/Unknown | | | Comment: | | Bump; chak saya this was fixed in HEAD, and then SPJ closes as wontfix? | Was the fix backed out? | | -- | Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/1614#comment:11> | GHC <http://www.haskell.org/ghc/> | The Glasgow Haskell Compiler | | _______________________________________________ | ghc-tickets mailing list | ghc-tickets(a)haskell.org | http://www.haskell.org/mailman/listinfo/ghc-tickets

2 1

Re: pgj (x86 FreeBSD HEAD), build 925, Failure
by Ian Lynagh 26 Jan '13

26 Jan '13

On Fri, Jan 25, 2013 at 05:47:03PM -0800, Builder wrote: > pgj (x86 FreeBSD HEAD), build 925 > > Build failed > Details: http://darcs.haskell.org/ghcBuilder/builders/pgj/925.html > > checking for __gmpz_fdiv_qr in -lgmp... no > checking for __gmpz_fdiv_qr in -lgmp3... no > configure: error: Failed to compute size of sizeof (MP_INT) > gmake[1]: *** [libraries/integer-gmp/dist-install/package-data.mk] Error 1 > gmake: *** [all] Error 2 > checking for sizeof (MP_INT) size... My Win32 HEAD build failed the same way: checking for __gmpz_fdiv_qr in -lgmp3... no checking for sizeof (MP_INT) size... configure: error: Failed to compute size of sizeof (MP_INT) libraries/integer-gmp/ghc.mk:4: recipe for target `libraries/integer-gmp/dist-install/package-data.mk' failed make[1]: *** [libraries/integer-gmp/dist-install/package-data.mk] Error 1 Does anyone know what's up? Thanks Ian

4 3

Problem in C Code Generator, with patch
by Christopher Vollick 26 Jan '13

26 Jan '13

Hey guys! So, I was working on some cross-compiling, and found a bug (http://hackage.haskell.org/trac/ghc/ticket/7620) Eventually I found that the issue was with C CodeGen in general, and had nothing to do with ARM. I've attached the patch there, but it may be only part of a bigger problem. The rough problem came from two things: 1) -(-128 :: Int8) => -128 You can't negate the smallest int in an integer space because of how 2s compliment works. There aren't enough bits to store +128. 2) We have a number of operations that transform: | i < 0 = a + i => a - (negative i) And | i < 0 = a - i => a + (negative i) And the assumption is that any integer can be negated, but that's not true in exactly one case. So, for example, it could turn thing+-128 into thing--128 Which is not valid C. That (but for Int32) was what I was seeing, and causing me trouble building integer simple. So, that was the bug I had encountered, and I don't know how the GHC code works, I just trawled through until I found the line that was causing me trouble, but I just figured I'd remind people that not every integer can be negated, in case the same mistake is being done in other places.

1 0

[PATCH] fix runtests to set LD_LIBRARY_PATH environment variable
by Karel Gardas 26 Jan '13

26 Jan '13

This patch follows Windows and Darwin way of setting environment variable to set the file-system paths to GHC's shared libraries. It does the same thing for any other OS, which should be Unix-like OS presumably. This patch fixes a lot of `dyn' tests failures on Solaris which fail with following error message: Failed to open shared library: ld.so.1: T3807-load: fatal: libffi.so.6: open failed: No such file or directory --- driver/runtests.py | 48 ++++++++++++++++++++++++++---------------------- 1 files changed, 26 insertions(+), 22 deletions(-) diff --git a/driver/runtests.py b/driver/runtests.py index 66e3bf4..16deda6 100644 --- a/driver/runtests.py +++ b/driver/runtests.py @@ -181,28 +181,32 @@ from testlib import * # On Windows we need to set $PATH to include the paths to all the DLLs # in order for the dynamic library tests to work. -if windows or darwin: - pkginfo = getStdout([config.ghc_pkg, 'dump']) - topdir = config.libdir - for line in pkginfo.split('\n'): - if line.startswith('library-dirs:'): - path = line.rstrip() - path = re.sub('^library-dirs: ', '', path) - path = re.sub('\\$topdir', topdir, path) - if path.startswith('"'): - path = re.sub('^"(.*)"$', '\\1', path) - path = re.sub('\\\\(.)', '\\1', path) - if windows: - if config.cygwin: - # On cygwin we can't put "c:\foo" in $PATH, as : is a - # field separator. So convert to /cygdrive/c/foo instead. - # Other pythons use ; as the separator, so no problem. - path = re.sub('([a-zA-Z]):', '/cygdrive/\\1', path) - path = re.sub('\\\\', '/', path) - os.environ['PATH'] = os.pathsep.join([path, os.environ.get("PATH", "")]) - else: - # darwin - os.environ['DYLD_LIBRARY_PATH'] = os.pathsep.join([path, os.environ.get("DYLD_LIBRARY_PATH", "")]) +# if windows or darwin: +pkginfo = getStdout([config.ghc_pkg, 'dump']) +topdir = config.libdir +for line in pkginfo.split('\n'): + if line.startswith('library-dirs:'): + path = line.rstrip() + path = re.sub('^library-dirs: ', '', path) + path = re.sub('\\$topdir', topdir, path) + if path.startswith('"'): + path = re.sub('^"(.*)"$', '\\1', path) + path = re.sub('\\\\(.)', '\\1', path) + if windows: + if config.cygwin: + # On cygwin we can't put "c:\foo" in $PATH, as : is a + # field separator. So convert to /cygdrive/c/foo instead. + # Other pythons use ; as the separator, so no problem. + path = re.sub('([a-zA-Z]):', '/cygdrive/\\1', path) + path = re.sub('\\\\', '/', path) + os.environ['PATH'] = os.pathsep.join([path, os.environ.get("PATH", "")]) + elif darwin: + # darwin + os.environ['DYLD_LIBRARY_PATH'] = os.pathsep.join([path, os.environ.get("DYLD_LIBRARY_PATH", "")]) + else: + # unix + os.environ['LD_LIBRARY_PATH'] = os.pathsep.join([path, os.environ.get("LD_LIBRARY_PATH", "")]) + global testopts_local testopts_local.x = TestOptions() -- 1.7.3.2

4 8

Bug names
by Ian Lynagh 25 Jan '13

25 Jan '13

Hi all, Would anyone mind if I were to rename all the numeric bug names, e.g. rename 1750 to T1750? I find names like 1750 a pain to search for in testlog, as they match lines like "=====> plugins01(normal) 1750 of 3403 [0, 6, 0]". Thanks Ian

4 3

seem to have some test suite failures for ghc 7.6.2rc on my mac
by Carter Schonwald 25 Jan '13

25 Jan '13

Hey all, the summary of a make test run on my macbook air is as follows is this a good outcome for running make test, or are any of these issues with the release candidate? (i'm just getting started with ghc dev related matters, so i'm not sure how to interpret this) thanks! -Carter OVERALL SUMMARY for test run started at Fri Jan 25 01:58:38 EST 2013 3402 total tests, which gave rise to 16608 test cases, of which 10 caused framework failures 13530 were skipped 2971 expected passes 50 had missing libraries 35 expected failures 1 unexpected passes 21 unexpected failures Unexpected passes: ../../libraries/directory/tests T4113 (normal) Unexpected failures: codeGen/should_run cgrun071 [bad exit code] (normal) dynlibs T3807 [bad exit code] (normal) llvm/should_compile 5486 [stderr mismatch] (optllvm) llvm/should_compile 5681 [stderr mismatch] (optllvm) perf/compiler T4801 [stat too good] (normal) perf/compiler T6048 [stat not good enough] (optasm) perf/compiler T783 [stat not good enough] (normal) perf/haddock haddock.Cabal [stat not good enough] (normal) perf/haddock haddock.base [stat not good enough] (normal) perf/haddock haddock.compiler [stat not good enough] (normal) safeHaskell/check/pkg01 ImpSafeOnly01 [exit code non-0] (normal) safeHaskell/check/pkg01 ImpSafeOnly02 [exit code non-0] (normal) safeHaskell/check/pkg01 ImpSafeOnly03 [stderr mismatch] (normal) safeHaskell/check/pkg01 ImpSafeOnly04 [exit code non-0] (normal) safeHaskell/check/pkg01 ImpSafeOnly05 [stderr mismatch] (normal) safeHaskell/check/pkg01 ImpSafeOnly06 [exit code non-0] (normal) safeHaskell/check/pkg01 ImpSafeOnly07 [stderr mismatch] (normal) safeHaskell/check/pkg01 ImpSafeOnly08 [stderr mismatch] (normal) safeHaskell/check/pkg01 ImpSafeOnly09 [stderr mismatch] (normal) safeHaskell/check/pkg01 ImpSafeOnly10 [exit code non-0] (normal) safeHaskell/check/pkg01 safePkg01 [bad exit code] (normal)

1 0

[Patch] Android cross compile support
by Nathan Hüsken 25 Jan '13

25 Jan '13

Hey, Appened is a patch that enables cross compilation to android. For the patch to work, config.guess and config.sub have to be updated to a newer version so that they recognize linux-android. For the libraries some additional patches are needed, I will send them also to this list. Will this patch be applied to ghc HEAD? Regards, Nathan

4 4

[PATCH] do not use -rpath-link linker option on Solaris
by Karel Gardas 25 Jan '13

25 Jan '13

This patch removes usage of -rpath-link option on Solaris OS since it is not supported by the Solaris' linker and its usage causes failures of a lot of `dyn' testcases --- compiler/main/DriverPipeline.hs | 11 ++++++++++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/compiler/main/DriverPipeline.hs b/compiler/main/DriverPipeline.hs index f47aea7..34d045c 100644 --- a/compiler/main/DriverPipeline.hs +++ b/compiler/main/DriverPipeline.hs @@ -1752,7 +1752,16 @@ linkBinary dflags o_files dep_packages = do rpath = if gopt Opt_RPath dflags then ["-Wl,-rpath", "-Wl," ++ libpath] else [] - in ["-L" ++ l, "-Wl,-rpath-link", "-Wl," ++ l] ++ rpath + -- Solaris 11's linker does not support -rpath-link option. It silently + -- ignores it and then complains about next option which is -l<some + -- dir> as being a directory and not expected object file, E.g + -- ld: elf error: file + -- /tmp/ghc-src/libraries/base/dist-install/build: + -- elf_begin: I/O error: region read: Is a directory + rpath-link = if (platformOS platform) == OSSolaris2 + then [] + else ["-Wl,-rpath-link", "-Wl," ++ l] + in ["-L" ++ l] ++ rpath-link ++ rpath | otherwise = ["-L" ++ l] let lib_paths = libraryPaths dflags -- 1.7.3.2

2 1