February 2013 - ghc-devs

ticky/cc profiling and heap checks
by Nicolas Frisby 18 Feb '13

18 Feb '13

I noticed some suspicious wiggling in my ticky reports' entry counts. SPJ suggested they were due to the counter ticking before the heap check: if it fails, then it ticks again when we re-enter after the stg_gc function does its thing. After looking into it a bit further, I have a couple questions. Here's what I found. * for functions (StgCmmBind.closureCodeBody), tickyEnterFun and enterCostCentreFun are before the heap check * for thunks (StgCmmBind.thunkCode), tickyEnterThunk is before the heap check and enterCostCentreThunk is after. Questions: * Does any object to me moving both ticky counters after the heap check? * Is there a reason the two cost centre profiling entries are on opposite sides of the heap check? Thanks.

2 4

low-level profiling
by Nicolas Frisby 18 Feb '13

18 Feb '13

I'm way below my depth here, but I'd like to use the perf tool to see where a program is spending its time. Unfortunately, the recipe here http://hackage.haskell.org/trac/ghc/wiki/Debugging/LowLevelProfiling/Perf isn't working for me. I get output like this instead 90.20% drbg_test drbg_test [.] 0x2515ef 5.71% drbg_test [kernel.kallsyms] [k] 0xffffffff8103e0ca 1.53% drbg_test libc-2.15.so [.] bsearch 1.02% drbg_test libc-2.15.so [.] 0x9194c 0.43% drbg_test libgmp.so.10.0.2 [.] __gmpz_mul_2exp 0.27% drbg_test libgmp.so.10.0.2 [.] __gmpz_add 0.16% drbg_test [vdso] [.] 0x7fffd3d25983 0.16% drbg_test libgmp.so.10.0.2 [.] __gmpn_lshift 0.10% drbg_test libgmp.so.10.0.2 [.] 0x13565 0.05% drbg_test libgmp.so.10.0.2 [.] __gmpz_init 0.05% drbg_test libc-2.15.so [.] __select 0.05% drbg_test libgmp.so.10.0.2 [.] __gmpn_modexact_1_odd 0.05% drbg_test libgmp.so.10.0.2 [.] __gmpz_realloc 0.05% drbg_test libc-2.15.so [.] __errno_location 0.05% drbg_test drbg_test [.] __gmpz_init@plt 0.05% drbg_test librt-2.15.so [.] clock_gettime 0.05% drbg_test libgmp.so.10.0.2 [.] __gmpn_add_n Again --- below my depth here --- but I don't know how to investigate what 0x2515ef indicates. Does anyone have any pointers? I was hoping that the address would be a nice RTS-ish symbol, like in the Wiki's examples. Thanks for your time.

4 12

unprotected use of global variables in base:GHC.IO.Encoding
by Nicolas Frisby 18 Feb '13

18 Feb '13

I've noticed some suspicious code in base:GHC.IO.Encoding. setLocaleEncoding, setFileSystemEncoding, setForeignEncoding :: TextEncoding -> IO () (getLocaleEncoding, setLocaleEncoding) = mkGlobal initLocaleEncoding (getFileSystemEncoding, setFileSystemEncoding) = mkGlobal initFileSystemEncoding (getForeignEncoding, setForeignEncoding) = mkGlobal initForeignEncoding mkGlobal :: a -> (IO a, a -> IO ()) mkGlobal x = unsafePerformIO $ do x_ref <- newIORef x return (readIORef x_ref, writeIORef x_ref) I've not elided any pragmas and there's no relevant LANGUAGE or OPTIONS pragmas. With HEAD from a couple weeks ago, mkGlobal is not getting inlined. But with some of my experimental alterations of sizeExpr, it is getting inlined. So this code should probably have some of the guards for faking global variables, right?

2 1

Current testsuite failures
by José Pedro Magalhães 17 Feb '13

17 Feb '13

Hi all, (resending without attachment because the previous email got rejected) Last night I've built GHC HEAD with the default settings, and ran the testsuite with just `make`. It ran into 77 unexpected failures; the failure log is available at http://hpaste.org/82291. The summary is at the end of this email. I've fixed the Data.Typeable.Proxy ones in the meantime. The rest I don't know, but maybe some of you can relate to some of these failures. Cheers, Pedro Unexpected failures: ../../libraries/base/tests/IO hClose002 [bad exit code] (ghci,threaded1,threaded2) ../../libraries/directory/tests getPermissions001 [bad stdout] (normal,hpc,optasm,threaded1,threaded2) ../../libraries/hpc/tests/simple/tixs hpc_help_draft [bad stdout] (normal) ../../libraries/hpc/tests/simple/tixs hpc_help_markup [bad stdout] (normal) ../../libraries/hpc/tests/simple/tixs hpc_help_overlay [bad stdout] (normal) ../../libraries/hpc/tests/simple/tixs hpc_help_report [bad stdout] (normal) ../../libraries/hpc/tests/simple/tixs hpc_help_show [bad stdout] (normal) ../../libraries/hpc/tests/simple/tixs hpc_markup_error_001 [bad stdout] (normal) ../../libraries/hpc/tests/simple/tixs hpc_markup_error_002 [bad stdout] (normal) ../../libraries/hpc/tests/simple/tixs hpc_report_error_001 [bad stdout] (normal) ../../libraries/hpc/tests/simple/tixs hpc_report_error_002 [bad stdout] (normal) ../../libraries/hpc/tests/simple/tixs hpc_show_error_001 [bad stdout] (normal) ../../libraries/hpc/tests/simple/tixs hpc_show_error_002 [bad stdout] (normal) ../../libraries/hpc/tests/simple/tixs hpc_version [bad stdout] (normal) ../../libraries/process/tests process007 [bad stderr] (threaded1,threaded2) ../../libraries/process/tests process007 [bad stdout or stderr] (ghci) ../../libraries/unix/tests getEnvironment02 [bad exit code] (ghci) ../../libraries/unix/tests/libposix posix005 [bad stdout or stderr] (ghci) codeGen/should_compile jmp_tbl [exit code non-0] (hpc) codeGen/should_compile massive_array [exit code non-0] (hpc) codeGen/should_run cgrun068 [bad exit code] (ghci) concurrent/should_run T5611 [bad exit code] (ghci) concurrent/should_run foreignInterruptible [bad exit code] (ghci) driver/recomp006 recomp006 [bad stderr] (normal) ffi/should_run T1679 [bad exit code] (ghci) ffi/should_run T7170 [bad stdout or stderr] (ghci) ghc-api T6145 [bad exit code] (normal) ghc-api/T4891 T4891 [bad exit code] (normal) numeric/should_run arith016 [bad exit code] (ghci) numeric/should_run expfloat [bad exit code] (ghci) parser/should_run readRun002 [bad exit code] (ghci) parser/should_run readRun004 [bad exit code] (hpc) perf/compiler T1969 [stat not good enough] (normal) perf/compiler T3064 [stat not good enough] (normal) perf/compiler T3294 [stat not good enough] (normal) perf/compiler T4801 [stat not good enough] (normal) perf/compiler T5030 [stat not good enough] (normal) perf/compiler T5321FD [stat not good enough] (normal) perf/compiler T5321Fun [stat not good enough] (normal) perf/compiler T5631 [stat not good enough] (normal) perf/compiler T5642 [stat not good enough] (normal) perf/compiler T5837 [stat not good enough] (normal) perf/compiler T6048 [stat not good enough] (optasm) perf/compiler T783 [stat not good enough] (normal) perf/compiler parsing001 [stat not good enough] (normal) perf/should_run lazy-bs-alloc [stat too good] (normal) plugins plugins01 [bad stderr] (normal) programs/andy_cherry andy_cherry [bad exit code] (ghci) programs/barton-mangler-bug barton-mangler-bug [bad exit code] (hpc,optasm,threaded2) programs/life_space_leak life_space_leak [bad exit code] (ghci) programs/seward-space-leak seward-space-leak [bad exit code] (ghci) rts stack002 [bad exit code] (threaded1,threaded2) simplCore/should_compile T4908 [stderr mismatch] (optasm) simplCore/should_compile spec-inline [stderr mismatch] (optasm) th TH_emptycase [stderr mismatch] (normal)

2 1

[PATCH] fixes for android in libraries/unix
by Nathan Hüsken 17 Feb '13

17 Feb '13

Hey, These patches are for libraries/unix. They may need some discussing, because I am not sure if this is the right thing. 1. On android the passwd struct does not define pw_gecos. The first patch therefor sets it to the empty string. 2. The android ndk does not define _POSIX_VDISABLE, but it defines _PC_VDISABLE. The second patch defines _POSIX_VDISABLE to _PC_VIDISABLE, which is (as I undestand it) what the POSIX programmer guide suggests. 3. The android ndk does not define telldir and seekdir. The third patch removes them when compiling for android.

3 5

[PATCH] (haskeline) Include termios.h on android
by Nathan Hüsken 17 Feb '13

17 Feb '13

Hey, This patch is for libraries/haskeline. On android, winsize is defined in termios.h and therefor termios.h must be included.

2 3

Re: [commit: ghc] master: Build fix for dyn way on Windows; patch from nus (c39d315)
by Bill Tutt 17 Feb '13

17 Feb '13

On Sat, Feb 16, 2013 at 5:04 PM, Ian Lynagh <igloo(a)earth.li> wrote: > diff --git a/rts/Prelude.h b/rts/Prelude.h > index dcd7b94..89e80a0 100644 > --- a/rts/Prelude.h > +++ b/rts/Prelude.h > @@ -93,6 +93,7 @@ PRELUDE_INFO(base_GHCziStable_StablePtr_con_info); > > #define runSparks_closure > DLL_IMPORT_DATA_REF(base_GHCziConcziSync_runSparks_closure) > #define ensureIOManagerIsRunning_closure > DLL_IMPORT_DATA_REF(base_GHCziConcziIO_ensureIOManagerIsRunning_closure) > +#define ioManagerCapabilitiesChanged_closure > DLL_IMPORT_DATA_REF(base_GHCziConcziIO_ioManagerCapabilitiesChanged_closure) > #define runHandlers_closure > DLL_IMPORT_DATA_REF(base_GHCziConcziSignal_runHandlers_closure) > > #define flushStdHandles_closure > DLL_IMPORT_DATA_REF(base_GHCziTopHandler_flushStdHandles_closure) > > diff --git a/rts/Schedule.c b/rts/Schedule.c > index f39ef96..ea779dd 100644 > --- a/rts/Schedule.c > +++ b/rts/Schedule.c > @@ -2070,7 +2070,7 @@ setNumCapabilities (nat new_n_capabilities > USED_IF_THREADS) > // Notify IO manager that the number of capabilities has changed. > rts_evalIO( > &cap, > - &base_GHCziConcziIO_ioManagerCapabilitiesChanged_closure, > + > DLL_IMPORT_DATA_REF(base_GHCziConcziIO_ioManagerCapabilitiesChanged_closure), > NULL); > Shouldn't this use the new #define you added to Prelude.h just above? This bit in rts\Win32\ThrIOManager.c should also use the Prelude.h macro: #if defined(COMPILING_WINDOWS_DLL) # if defined(x86_64_HOST_ARCH) rts_evalIO(&cap,__imp_base_GHCziConcziIO_ensureIOManagerIsRunning_closure,NULL); # else rts_evalIO(&cap,_imp__base_GHCziConcziIO_ensureIOManagerIsRunning_closure,NULL); # endif #else rts_evalIO(&cap,&base_GHCziConcziIO_ensureIOManagerIsRunning_closure,NULL); #endif Bill

2 1

validate failure due to haddock
by Andreas Voellmy 16 Feb '13

16 Feb '13

Hi, I just ran ./sync-all pull and ran validate on Linux. I got the following error, apparently due to something missing in haddock: "/home/andi/temp/ghc-build/inplace/bin/haddock" --odir="libraries/ghc-prim/dist-install/doc/html/ghc-prim" --no-tmp-comp-dir --dump-interface=libraries/ghc-prim/dist-install/doc/html/ghc-prim/ghc-prim.haddock --html --hoogle --title="ghc-prim-0.3.1.0: GHC primitives" --prologue="libraries/ghc-prim/dist-install/haddock-prologue.txt" --optghc=-static --optghc=-H32m --optghc=-O --optghc=-Werror --optghc=-Wall --optghc=-H64m --optghc=-O0 --optghc=-package-name --optghc=ghc-prim-0.3.1.0 --optghc=-hide-all-packages --optghc=-i --optghc=-ilibraries/ghc-prim/. --optghc=-ilibraries/ghc-prim/dist-install/build --optghc=-ilibraries/ghc-prim/dist-install/build/autogen --optghc=-Ilibraries/ghc-prim/dist-install/build --optghc=-Ilibraries/ghc-prim/dist-install/build/autogen --optghc=-Ilibraries/ghc-prim/. --optghc=-optP-include --optghc=-optPlibraries/ghc-prim/dist-install/build/autogen/cabal_macros.h --optghc=-package --optghc=rts-1.0 --optghc=-package-name --optghc=ghc-prim --optghc=-XHaskell98 --optghc=-XCPP --optghc=-XMagicHash --optghc=-XForeignFunctionInterface --optghc=-XUnliftedFFITypes --optghc=-XUnboxedTuples --optghc=-XEmptyDataDecls --optghc=-XNoImplicitPrelude --optghc=-O2 --optghc=-O --optghc=-dcore-lint --optghc=-fno-warn-deprecated-flags --optghc=-no-user-package-db --optghc=-rtsopts --optghc=-odir --optghc=libraries/ghc-prim/dist-install/build --optghc=-hidir --optghc=libraries/ghc-prim/dist-install/build --optghc=-stubdir --optghc=libraries/ghc-prim/dist-install/build --optghc=-hisuf --optghc=hi --optghc=-osuf --optghc=o --optghc=-hcsuf --optghc=hc libraries/ghc-prim/./GHC/Classes.hs libraries/ghc-prim/./GHC/CString.hs libraries/ghc-prim/./GHC/Debug.hs libraries/ghc-prim/./GHC/Magic.hs libraries/ghc-prim/dist-install/build/GHC/PrimopWrappers.hs libraries/ghc-prim/./GHC/IntWord64.hs libraries/ghc-prim/./GHC/Tuple.hs libraries/ghc-prim/./GHC/Types.hs libraries/ghc-prim/dist-install/build/autogen/GHC/Prim.hs +RTS -tlibraries/ghc-prim/dist-install/doc/html/ghc-prim/ghc-prim.haddock.t --machine-readable Haddock coverage: 100% ( 1 / 1) in 'GHC.IntWord64' 78% ( 7 / 9) in 'GHC.Types' 17% ( 1 / 6) in 'GHC.CString' 3% ( 2 / 63) in 'GHC.Tuple' 0% ( 0 / 3) in 'GHC.Debug' 0% ( 0 /338) in 'GHC.PrimopWrappers' 30% (160 /527) in 'GHC.Prim' 100% ( 3 / 3) in 'GHC.Magic' 38% ( 6 / 16) in 'GHC.Classes' haddock: internal error: /home/andi/temp/ghc-build/inplace/lib/html/Ocean.std-theme/ocean.css: copyFile: does not exist (No such file or directory) make[1]: *** [libraries/ghc-prim/dist-install/doc/html/ghc-prim/ghc-prim.haddock] Error 1 make[1]: *** Deleting file `libraries/ghc-prim/dist-install/doc/html/ghc-prim/ghc-prim.haddock' make[1]: *** Waiting for unfinished jobs.... make: *** [all] Error 2 -Andi

1 0

Re: Heads-up: new parallel I/O manager merged
by Bill Tutt 16 Feb '13

16 Feb '13

Yes, it should. Here's the combined patch that just succeded in being built. Bill On Sat, Feb 16, 2013 at 11:26 AM, Andreas Voellmy <andreas.voellmy(a)gmail.com > wrote: > > > in rts/ThrIOManager.hs >> > > Sorry, this should have been rts/win32/ThrIOManager.c. >

1 0

Re: [commit: ghc] master: Find LLVM tools when version number at end (e.g., llc-3.0) (#7661) (64aaaa1)
by Ian Lynagh 16 Feb '13

16 Feb '13

On Wed, Feb 13, 2013 at 07:11:11PM -0800, David Terei wrote: > > +AC_DEFUN([FIND_LLVM_PROG],[ > + FP_ARG_WITH_PATH_GNU_PROG_OPTIONAL([$1], [$2], [$3]) > + if test "$1" == ""; then > + GOOD_PATH=`echo $PATH | tr ':,;' ' '` Hmm. I don't think we'll ever have a $PATH containing a path like c:/..., but there could certainly be paths containing spaces. > + $1=`${FindCmd} ${GOOD_PATH} -type f -perm +111 -maxdepth 1 -regex '.*/$3-[[0-9]]\.[[0-9]]' | ${SortCmd} -n | tail -1` This feels rather unpleasant to me. Is it likely that someone will have programs called llc-3.0 etc, but no llc? If not, I'd suggest that we just detect llc and they can override which llc gets used with a --with-llc flag if they want to. In fact, i think we should do that regardless. After all, we don't try searching for gcc-4.6 etc either. Thanks Ian

2 1