August 2016 - ghc-devs

Fwd: Help on first ticket
by Richard Fung 14 Aug '16

14 Aug '16

---------- Forwarded message ---------- From: Richard Fung <minesasecret(a)gmail.com> Date: Tue, Aug 9, 2016 at 8:33 AM Subject: Re: Help on first ticket To: Simon Peyton Jones <simonpj(a)microsoft.com> It's been a while but I've been able to spend more time on it recently made some progress. I believe I have an idea of what I need to fix in terms of the generating of ModDetails/ModInfo. First off, please tell me if this is wrong.. it seems like ModDetails is made in mkBootModDetailsTc and tidyProgram. In tidyProgram there are several functions which take omit_prags, which I think is automatically set to True on -O0. These are the things we'll have to change because they are used in mkIface_ to generate the [IfaceDecl] used to make ModInfo in addFingerprints. Hopefully I'm understanding that part correctly. However, I'm not really sure how to write a proper test case for this ticket. Also, I think I have an idea of where to start looking for the place the inlining/unfolding happens but pointers definitely wouldn't hurt. Thanks and sorry this is taking me so long! On Fri, Jun 24, 2016 at 12:26 PM, Simon Peyton Jones <simonpj(a)microsoft.com> wrote: > Great. No rush. Yell if you need help. > > > > Simon > > > > *From:* Richard Fung [mailto:minesasecret@gmail.com] > *Sent:* 24 June 2016 19:05 > *To:* Simon Peyton Jones <simonpj(a)microsoft.com> > *Cc:* ghc-devs(a)haskell.org > > *Subject:* Re: Help on first ticket > > > > Hi Simon, I am making progress but slowly (I only have time to work on > this outside of work unfortunately). > > > > If this needs to be done soon feel free to reassign it to someone else! > Otherwise, while at times I feel like I'm over my head I would like to keep > at it. > > > > On Fri, Jun 24, 2016 at 4:20 AM, Simon Peyton Jones <simonpj(a)microsoft.com> > wrote: > > Richard, did you get on ok? > > Simon > > > | -----Original Message----- > | From: ghc-devs [mailto:ghc-devs-bounces@haskell.org] On Behalf Of Ben > | Gamari > | Sent: 04 June 2016 23:20 > | To: Richard Fung <minesasecret(a)gmail.com>; ghc-devs(a)haskell.org > | Subject: Re: Help on first ticket > | > | Richard Fung <minesasecret(a)gmail.com> writes: > | > | > Hello! I apologize if this isn't the right place to ask; if it isn't > | > please steer me in the right direction. > | > > | Hi Richard! > | > | > Would anyone be willing to advise me on my first ticket? I've been > | > trying to work on it on and off but haven't made much progress on my > | own. > | > > | > It's ticket #9370: https://ghc.haskell.org/trac/ghc/ticket/9370 > | > > | Great, I'm happy to hear that someone has picked this one up. I think > | it is a nice choice for a self-contained newcomers project. > | > | > I think I understand the issue conceptually but I don't know where > | to > | > look for the code that needs to be changed.. > | > > | I don't know where the code responsible for this is off the top of my > | head, however I can provide some pointers. > | > | So the unfoldings you are looking to preserve come from interface > | files. > | The machinery for all of this is in compiler/iface. IfaceSyn.hs is of > | particular interest and there you will find the definition of > | IfaceUnfolding, which is the unfolding representation which is stored > | in the interface file. Unfoldings live inside of IdInfo values, which > | hold various miscellaneous information which we need to preserve about > | a particular Id (identifier). > | > | There is a somewhat useful comment regarding how IdInfo is treated > | above the definition of IfaceIdInfo in IfaceSyn. In particular it > | seems that interface files for modules compiled with -O0 will have > | their IdInfo fields set to NoInfo. It's not clear what happens when an > | interface file is read. However, grepping for NoInfo reveals a use- > | site in TcIface.tcIdInfo which looks interesting (in particular the > | ignore_prags guard). I think this should be enough to get you going on > | the interface file part of this. > | > | The other part of this ticket is deciding whether to use an unfolding > | when considering whether to inline. This will be done in the > | simplifier (compiler/simplCore). Grepping for "inline" and "unfold" in > | simplCore/Simplify.hs (as well as reading the notes in that file) will > | likely be enough to get you started. > | > | Do let me know if you still feel lost or want to discuss this further. > | I look forward to hearing how it goes. > | > | Cheers, > | > | - Ben > > | _______________________________________________ > | ghc-devs mailing list > | ghc-devs(a)haskell.org > | https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fmail.h > | askell.org > <https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2faskell.org&…> > %2fcgi-bin%2fmailman%2flistinfo%2fghc- > | devs&data=01%7c01%7csimonpj%40064d.mgd.microsoft.com > <https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2f40064d.mgd.…> > %7c5ce47a744a1448f > | ff5cb08d38cc666b8%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=V22RG%2 > | fAiO1lD5bLCR%2fXz2jv5QCzYAK5HUi6dDaAFQLA%3d > > >

2 2

Harbourmaster is still not building diffs
by Matthew Pickering 14 Aug '16

14 Aug '16

Since a couple of months ago, harbourmaster no longer builds diffs. This is quite a large barrier to entry for new contributors as running ./validate takes a long time. It seems to be a very low priority issue to get it back working. Are there plans to get harbourmaster to build diffs again? Matt

2 2

enumFromThenTo for Doubles
by Andrew Farmer 12 Aug '16

12 Aug '16

Noticed this today: ghci> let xs = [0.0,0.1 .. 86400.0] in maximum xs 86400.0000005062 enumFromThenTo is implemented by numericEnumFromThenTo: https://github.com/ghc/ghc/blob/a90085bd45239fffd65c01c24752a9bbcef346f1/li… Which probably accumulates error in numericEnumFromThen with the (m+m-n): numericEnumFromThen n m = n `seq` m `seq` (n : numericEnumFromThen m (m+m-n)) Why not define numericEnumFromThen as: numericEnumFromThen n m = let d = m - n in d `seq` go d n where go delta x = x `seq` (x : go delta (x + delta)) (or with BangPatterns) numericEnumFromThen n m = go (m - n) n where go !delta !x = x : go delta (x + delta) Seems like we'd save a lot of subtractions by using the worker function.

4 4

Noticing how the Rust team is improving compiler errors
by Christopher Allen 12 Aug '16

12 Aug '16

https://blog.rust-lang.org/2016/08/10/Shape-of-errors-to-come.html I'd particularly note that their compiler errors were dramatically better to begin with, now they're doing this. Thought the list would be interested in this. --- Chris

1 0

[ANNOUNCE] Hac φ: a Haskell Exchange in Philadelphia, Oct 21–23
by Kenny Foner 11 Aug '16

11 Aug '16

Hello Haskellers, Hac Phi, a yearly weekend of Haskell in Philadelphia, will take place Oct. 21–23, 2016, at the University of Pennsylvania. Hac Phi is a gathering of hackers and Haskell enthusiasts. Come bring a project you’re working on or offer to help someone else on a project of theirs. Come give a talk if you’ve got something to share. Come to learn something new. What do we mean by a “Haskell Exchange”? Less pressurized than a hackathon, more informal than a conference, bigger than a meetup – Hac Phi is a weekend where academics, professionals, and hobbyists can all meet, mingle, hack on each others’ projects, and generally have a good time. (And it’s not to be confused with the Haskell eXchange, an entirely different event.) All the details are on the wiki page <https://wiki.haskell.org/Hac_%CF%86>; please register online <https://docs.google.com/forms/d/e/1FAIpQLSd4i-tURfHBqmwxqOqozkjoyHfmMUl99Ax…> if you’re coming. We hope to see you there! —The Hac φ team Antal Spector-Zabusky Kenny Foner

1 0

Improving cost center reports to show residency?
by Ömer Sinan Ağacan 09 Aug '16

09 Aug '16

One thing that we can't currently see in cost center reports is the residency and because of that cost centers can't be used for fixing memory leaks or reducing max. memory residency. For example, I can have a function that returns an `Int` but allocates lots of intermediate data on the way. In the reports I see this function as allocates a lot, but it has no effect on my program's residency (especially if it runs fast). So I'm thinking of somehow using cost centers for reasoning about memory residency. One idea is to print a summary after every major GC, by doing another pass on the whole heap and recording attributions. This can be used for plotting live data of cost centers over time. (like hp2ps but for cost centers) Another idea is to add "residency" column in the profiling reports. Not sure how to update this column in runtime though. The main use case for me is fixing T1969, but of course this is a very general solution. Does anyone have any other ideas?

2 1

Can we offer ~ without GADTs or type families?
by David Feuer 06 Aug '16

06 Aug '16

It seems to me that equality constraints could potentially be supported by an implementation with neither GADTs nor type families. Type families don't really seem to have much to do with it, and GADTs are strictly heavier (GADTs ~= ExistentialQuantification + TypeEquality). Could we get a separate LANGUAGE pragma just for equality constraints?

3 2

Re: [commit: ghc] master: Replace some `length . filter` with `count` (02614fd)
by Joachim Breitner 06 Aug '16

06 Aug '16

Hi, Am Freitag, den 05.08.2016, 22:41 +0000 schrieb git(a)git.haskell.org: > commit 02614fd61f57b599c5e4fd5e85f00a4e1ce37bc7 > Author: Ömer Sinan Ağacan <omeragacan(a)gmail.com> > Date: Fri Aug 5 20:58:02 2016 +0000 > > Replace some `length . filter` with `count` Well intended! I wouldn’t be surprised if this is actually making the code worse, considering that "count" is implemented in the “wrong”, stackeating way (whereas lenght . filter could, thanks to list fusion, produce the desired code) count :: (a -> Bool) -> [a] -> Int count _ [] = 0 count p (x:xs) | p x = 1 + count p xs | otherwise = count p xs I would say that the regression reported by https://perf.haskell.org/ghc/#revision/02614fd61f57b599c5e4fd5e85f00a4e1ce3… confirms this, but T6048 is simply unreliable. So practically, it does not seem to matter either way. I’ll change the implementation of count. (Although even then it is not clear that the change is a win, as "length . filter" might fuse with the producer, whereas "count" without a lot of extra hassle will not.) Joachim -- Joachim “nomeata” Breitner mail(a)joachim-breitner.de • https://www.joachim-breitner.de/ XMPP: nomeata(a)joachim-breitner.de • OpenPGP-Key: 0xF0FBF51F Debian Developer: nomeata(a)debian.org

1 0

Re: Can we offer ~ without GADTs or type families?
by Ryan Scott 06 Aug '16

06 Aug '16

Hi David, > Could we get a separate LANGUAGE pragma just for equality constraints? I think we should, and I don't think we'd even need to introduce a new pragma, since there's already a perfectly good one: -XTypeOperators! After all, there's nothing really that special about (~) other than some typechecking details. A fix to Trac #9194 [1] would give us this. Ryan S. ----- [1] https://ghc.haskell.org/trac/ghc/ticket/9194

2 2

Deriving tweaking
by David Feuer 06 Aug '16

06 Aug '16

I know there's been some discussion about letting users select the deriving mechanism they want, but I'd like to propose a separate tweak to the defaults. Specifically, it's annoying to have to use three pragmas to let me write newtype Foo f a = Foo (f a) deriving (Functor, Foldable, Traversable) data Bar f a = Bar (f a) deriving (Functor, Foldable, Traversable) and more annoying still that I'll end up with Foldable and Functor instances for Foo that may be much worse than GND-derived ones. The tweaks I'm after: 1. Prefer GND to the built-in derivations for Functor and Foldable, and probably also Eq and Ord. 2. Make DeriveTraversable imply DeriveFunctor and DeriveFoldable.

2 2