March 2017 - ghc-devs

Getting exceptions right
by David Feuer 07 Mar '17

07 Mar '17

I've put together a wiki page describing the issues I think we need to address, and laying out the model I think we want to implement for precise exceptions. Hopefully, this will help us figure out what we need to do to get a better story here. https://ghc.haskell.org/trac/ghc/wiki/FixingExceptions Thanks, David Feuer

2 1

Windows build broken again
by Simon Peyton Jones 07 Mar '17

07 Mar '17

The Windows build is broken again. Here's the tail of the log It would be good if we could stop this happening Simon == End post-build package check make: Entering directory '/c/code/HEAD/testsuite/tests' WARNING: cache is out of date: C:\code\HEAD\inplace\lib\package.conf.d\package.cache ghc will see an old view of this package db. Use 'ghc-pkg recache' to fix. WARNING: cache is out of date: C:\code\HEAD\inplace\lib\package.conf.d\package.cache ghc will see an old view of this package db. Use 'ghc-pkg recache' to fix. "/c/code/HEAD/inplace/bin/ghc-stage2.exe" --make -o ../mk/ghc-config ../mk/ghc-config.hs [1 of 1] Compiling Main ( ..\mk\ghc-config.hs, ..\mk\ghc-config.o ) Linking ../mk/ghc-config.exe ... ../mk/ghc-config "/c/code/HEAD/inplace/bin/ghc-stage2.exe" >"../mk/ghcconfig_c_code_HEAD_inplace_bin_ghc-stage2.exe.mk"; if [ $? != 0 ]; then rm -f "../mk/ghcconfig_c_code_HEAD_inplace_bin_ghc-stage2.exe.mk"; exit 1; fi WARNING: cache is out of date: C:\code\HEAD\inplace\lib\package.conf.d\package.cache ghc will see an old view of this package db. Use 'ghc-pkg recache' to fix. WARNING: cache is out of date: C:\code\HEAD\inplace\lib\package.conf.d\package.cache ghc will see an old view of this package db. Use 'ghc-pkg recache' to fix. # See Note [validate and testsuite speed] in toplevel Makefile. make SPEED=2 make[1]: Entering directory '/c/code/HEAD/testsuite/tests' WARNING: cache is out of date: C:\code\HEAD\inplace\lib\package.conf.d\package.cache ghc will see an old view of this package db. Use 'ghc-pkg recache' to fix. WARNING: cache is out of date: C:\code\HEAD\inplace\lib\package.conf.d\package.cache ghc will see an old view of this package db. Use 'ghc-pkg recache' to fix. Looks like you don't have timeout, building it first... make -C ../timeout all make[2]: Entering directory '/c/code/HEAD/testsuite/timeout' rm -f -f TimeMe.o TimeMe.hi TimeMe TimeMe.exe python3 calibrate '' > calibrate.out rm -rf install-inplace '/c/code/HEAD/inplace/bin/ghc-stage2.exe' --make Setup [1 of 1] Compiling Main ( Setup.hs, Setup.o ) Linking Setup.exe ... ./Setup configure --with-compiler='/c/code/HEAD/inplace/bin/ghc-stage2.exe' \ --with-hc-pkg='/c/code/HEAD/inplace/bin/ghc-pkg.exe' \ --with-hsc2hs='/c/code/HEAD/inplace/bin/hsc2hs.exe' \ \ --ghc-option=-threaded --prefix='/c/code/HEAD/testsuite/timeout/install-inplace' Configuring timeout-1... ./Setup build Preprocessing executable 'timeout' for timeout-1.. Building executable 'timeout' for timeout-1.. [1 of 2] Compiling WinCBindings ( dist\build\timeout\timeout-tmp\WinCBindings.hs, dist\build\timeout\timeout-tmp\WinCBindings.o ) [2 of 2] Compiling Main ( timeout.hs, dist\build\timeout\timeout-tmp\Main.o ) Linking dist\build\timeout\timeout.exe ... ./Setup install Installing executable timeout in C:/code/HEAD/testsuite/timeout/install-inplace\bin Warning: The directory C:/code/HEAD/testsuite/timeout/install-inplace\bin is not in the system search path. make[2]: Leaving directory '/c/code/HEAD/testsuite/timeout' PYTHON="python3" "python3" ../driver/runtests.py -e ghc_compiler_always_flags="'-dcore-lint -dcmm-lint -no-user-package-db -rtsopts -fno-warn-missed-specialisations -fshow-warning-groups -fdiagnostics-color=never -fno-diagnostics-show-caret -dno-debug-output'" -e config.compiler_debugged=False -e ghc_with_native_codegen=1 -e config.have_vanilla=True -e config.have_dynamic=False -e config.have_profiling=False -e ghc_with_threaded_rts=1 -e ghc_with_dynamic_rts=0 -e config.have_interp=True -e config.unregisterised=False -e config.ghc_dynamic_by_default=False -e config.ghc_dynamic=False -e ghc_with_smp=1 -e ghc_with_llvm=0 -e windows=True -e darwin=False -e config.in_tree_compiler=True --threads=5 -e config.cleanup=True -e config.local=False --rootdir=. --configfile=../config/ghc -e 'config.confdir="../config"' -e 'config.platform="x86_64-unknown-mingw32"' -e 'config.os="mingw32"' -e 'config.arch="x86_64"' -e 'config.wordsize="64"' -e 'config.timeout=int() or config.timeout' -e 'config.exeext=".exe"' -e 'config.top="/c/code/HEAD/testsuite"' --config 'compiler="/c/code/HEAD/inplace/bin/ghc-stage2.exe"' --config 'ghc_pkg="/c/code/HEAD/inplace/bin/ghc-pkg.exe"' --config 'haddock="/c/code/HEAD/inplace/bin/haddock.exe"' --config 'hp2ps="/c/code/HEAD/inplace/bin/hp2ps.exe"' --config 'hpc="/c/code/HEAD/inplace/bin/hpc.exe"' --config 'gs="gs"' --config 'timeout_prog="../timeout/install-inplace/bin/timeout.exe"' -e "config.stage=2" --summary-file "../../testsuite_summary.txt" --no-print-summary 1 --rootdir=../../libraries/Win32/tests --rootdir=../../libraries/array/tests --rootdir=../../libraries/base/tests --rootdir=../../libraries/binary/tests --rootdir=../../libraries/bytestring/tests --rootdir=../../libraries/containers/tests --rootdir=../../libraries/deepseq/tests --rootdir=../../libraries/directory/tests --rootdir=../../libraries/filepath/tests --rootdir=../../libraries/ghc-compact/tests --rootdir=../../libraries/ghc-prim/tests --rootdir=../../libraries/haskeline/tests --rootdir=../../libraries/hpc/tests --rootdir=../../libraries/pretty/tests --rootdir=../../libraries/process/tests --rootdir=../../libraries/template-haskell/tests \ \ \ \ \ \ -e config.speed="2" \ Traceback (most recent call last): File "../driver/runtests.py", line 189, in <module> pkginfo = str(getStdout([config.ghc_pkg, 'dump'])) File "/c/code/HEAD/testsuite/driver/testutil.py", line 25, in getStdout raise Exception("stderr from command: " + str(cmd_and_args)) Exception: stderr from command: ['"/c/code/HEAD/inplace/bin/ghc-pkg.exe"', 'dump'] make[1]: *** [../mk/test.mk:299: test] Error 1 make[1]: Leaving directory '/c/code/HEAD/testsuite/tests' make: *** [../mk/test.mk:315: fasttest] Error 2 make: Leaving directory '/c/code/HEAD/testsuite/tests' make: Entering directory '/c/code/HEAD/testsuite/tests/stage1' WARNING: cache is out of date: C:\code\HEAD\inplace\lib\package.conf.d\package.cache ghc will see an old view of this package db. Use 'ghc-pkg recache' to fix. ../../mk/ghc-config "/c/code/HEAD/inplace/bin/ghc-stage1.exe" >"../../mk/ghcconfig_c_code_HEAD_inplace_bin_ghc-stage1.exe.mk"; if [ $? != 0 ]; then rm -f "../../mk/ghcconfig_c_code_HEAD_inplace_bin_ghc-stage1.exe.mk"; exit 1; fi WARNING: cache is out of date: C:\code\HEAD\inplace\lib\package.conf.d\package.cache ghc will see an old view of this package db. Use 'ghc-pkg recache' to fix. # See Note [validate and testsuite speed] in toplevel Makefile. make SPEED=2 make[1]: Entering directory '/c/code/HEAD/testsuite/tests/stage1' WARNING: cache is out of date: C:\code\HEAD\inplace\lib\package.conf.d\package.cache ghc will see an old view of this package db. Use 'ghc-pkg recache' to fix. PYTHON="python3" "python3" ../../driver/runtests.py -e ghc_compiler_always_flags="'-dcore-lint -dcmm-lint -no-user-package-db -rtsopts -fno-warn-missed-specialisations -fshow-warning-groups -fdiagnostics-color=never -fno-diagnostics-show-caret -dno-debug-output'" -e config.compiler_debugged=True -e ghc_with_native_codegen=1 -e config.have_vanilla=True -e config.have_dynamic=False -e config.have_profiling=False -e ghc_with_threaded_rts=1 -e ghc_with_dynamic_rts=0 -e config.have_interp=False -e config.unregisterised=False -e config.ghc_dynamic_by_default=False -e config.ghc_dynamic=False -e ghc_with_smp=1 -e ghc_with_llvm=0 -e windows=True -e darwin=False -e config.in_tree_compiler=True --threads=5 -e config.cleanup=True -e config.local=False --rootdir=. --configfile=../../config/ghc -e 'config.confdir="../../config"' -e 'config.platform="x86_64-unknown-mingw32"' -e 'config.os="mingw32"' -e 'config.arch="x86_64"' -e 'config.wordsize="64"' -e 'config.timeout=int() or config.timeout' -e 'config.exeext=".exe"' -e 'config.top="/c/code/HEAD/testsuite"' --config 'compiler="/c/code/HEAD/inplace/bin/ghc-stage1.exe"' --config 'ghc_pkg="/c/code/HEAD/inplace/bin/ghc-pkg.exe"' --config 'haddock="/c/code/HEAD/inplace/bin/haddock.exe"' --config 'hp2ps="/c/code/HEAD/inplace/bin/hp2ps.exe"' --config 'hpc="/c/code/HEAD/inplace/bin/hpc.exe"' --config 'gs="gs"' --config 'timeout_prog="../../timeout/install-inplace/bin/timeout.exe"' -e "config.stage=1" --summary-file "../../../testsuite_summary_stage1.txt" --no-print-summary 1 \ \ \ \ \ \ -e config.speed="2" \ Traceback (most recent call last): File "../../driver/runtests.py", line 189, in <module> pkginfo = str(getStdout([config.ghc_pkg, 'dump'])) File "/c/code/HEAD/testsuite/driver/testutil.py", line 25, in getStdout raise Exception("stderr from command: " + str(cmd_and_args)) Exception: stderr from command: ['"/c/code/HEAD/inplace/bin/ghc-pkg.exe"', 'dump'] make[1]: *** [../../mk/test.mk:299: test] Error 1 make[1]: Leaving directory '/c/code/HEAD/testsuite/tests/stage1' make: *** [../../mk/test.mk:315: fasttest] Error 2 make: Leaving directory '/c/code/HEAD/testsuite/tests/stage1' ==== STAGE 1 TESTS ==== cat: testsuite_summary_stage1.txt: No such file or directory /c/code/HEAD$

5 8

Additional catch notes
by David Feuer 03 Mar '17

03 Mar '17

I dug a little further into what you tried to do with catch and where I think it went wrong. You can see my thoughts in the notes I added in D3263. It could even be possible to fix the problem for real by changing the DmdRes domain again. Originally, we broke it up into Diverges and Dunno. You added an additional ThrowsExn to mean "diverges or throws an exception". But I think a critical point in the domain, for this analysis, is "definitely does not throw an exception". If we have catch# m f s then we can speculatively evaluate/unbox only those expressions in (m s) that definitely don't throw exceptions (whether they succeed or diverge). One other thought: it might be worth considering a catchIO# primitive. This would catch exceptions thrown by raiseIO# but *not* by raise#. This could be made *much* stricter, I believe, if give raiseIO# a special place in the result domain. David

1 0

collectBindersPushingCo
by Simon Peyton Jones 01 Mar '17

01 Mar '17

David Thanks for moving my early-inline patch series to HEAD. You'll remember that I pushed this patch (below) to spj-early-inline2 Can you be sure to cherry-pick this one too? It's important and I don't see it in HEAD yet. I'm surprised that there isn't a validate failure (T9505 if memory serves - see attached). Simon commit 002192aa8df463ae945e8a94147cfc1d848f43a5 Author: Simon Peyton Jones <simonpj(a)microsoft.com> Date: Fri Feb 24 16:55:36 2017 +0000 Fix a nasty bug in CoreSubst.collectBindersPushingCo The bug wsa in the use of (mkNthCo 0) to get the argument part of a function coercion. Not so! Now (->) takes four arguments so that 0 should have been 2. Enough with magic numbers. I defined decomposeFunCo, and used it throughout. Much nicer now; and correct. The nete effect, incidentally, was that T9509 was failing to specialise. (And that was the initial reason for introducing collectBindersPushingCo in the first place.)

2 2

RE: Windows build broken
by David Feuer 28 Feb '17

28 Feb '17

I can't fix that (no windows) but I just broke all the builds with a -Werror mistake and I can fix that one... David FeuerWell-Typed, LLP -------- Original message --------From: Simon Peyton Jones via ghc-devs <ghc-devs(a)haskell.org> Date: 2/28/17 7:07 PM (GMT-05:00) To: ghc-devs(a)haskell.org Subject: Windows build broken Windows build is broken again. Might someone fix? Simon "inplace/bin/ghc-stage1.exe" -optc-fno-stack-protector -optc-Wall -optc-Werror -optc-Wall -optc-Wextra -optc-Wstrict-prototypes -optc-Wmissing-prototypes -optc-Wmissing-declarations -optc-Winline -optc-Waggregate-return -optc-Wpointer-arith -optc-Wmissing-noreturn -optc-Wnested-externs -optc-Wredundant-decls -optc-Iincludes -optc-Iincludes/dist -optc-Iincludes/dist-derivedconstants/header -optc-Iincludes/dist-ghcconstants/header -optc-Irts -optc-Irts/dist/build -optc-DCOMPILING_RTS -optc-fno-strict-aliasing -optc-fno-common -optc-Irts/dist/build/./autogen -optc-Wno-error=inline -optc-O2 -optc-fomit-frame-pointer -optc-g -optc-DRtsWay=\"rts_p\" -optc-DWINVER=0x06000100 -static -prof -eventlog -O0 -H64m -Wall -fllvm-fill-undef-with-garbage -Werror -Iincludes -Iincludes/dist -Iincludes/dist-derivedconstants/header -Iincludes/dist-ghcconstants/header -Irts -Irts/dist/build -DCOMPILING_RTS -this-unit-id rts -dcmm-lint -i -irts -irts/dist/build -Irts/dist/build -irts/dist/build/./autogen -Irts/dist/build/./autogen -O2 -Wnoncanonical-monad-instances -c rts/Sparks.c -o rts/dist/build/Sparks.p_o rts\Profiling.c: In function 'reportCCSProfiling': rts\Profiling.c:704:9: error: error: implicit declaration of function 'writeCCSReportJson' [-Werror=implicit-function-declaration] writeCCSReportJson(prof_file, stack, totals); ^~~~~~~~~~~~~~~~~~ | 704 | writeCCSReportJson(prof_file, stack, totals); | ^ rts\Profiling.c:704:9: error: error: nested extern declaration of 'writeCCSReportJson' [-Werror=nested-externs] | 704 | writeCCSReportJson(prof_file, stack, totals); | ^ cc1.exe: all warnings being treated as errors `gcc.exe' failed in phase `C Compiler'. (Exit code: 1) make[1]: *** [rts/ghc.mk:255: rts/dist/build/Profiling.p_o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:127: all] Error 2 /c/code/HEAD$

1 0

Windows build broken
by Simon Peyton Jones 28 Feb '17

28 Feb '17

Windows build is broken again. Might someone fix? Simon "inplace/bin/ghc-stage1.exe" -optc-fno-stack-protector -optc-Wall -optc-Werror -optc-Wall -optc-Wextra -optc-Wstrict-prototypes -optc-Wmissing-prototypes -optc-Wmissing-declarations -optc-Winline -optc-Waggregate-return -optc-Wpointer-arith -optc-Wmissing-noreturn -optc-Wnested-externs -optc-Wredundant-decls -optc-Iincludes -optc-Iincludes/dist -optc-Iincludes/dist-derivedconstants/header -optc-Iincludes/dist-ghcconstants/header -optc-Irts -optc-Irts/dist/build -optc-DCOMPILING_RTS -optc-fno-strict-aliasing -optc-fno-common -optc-Irts/dist/build/./autogen -optc-Wno-error=inline -optc-O2 -optc-fomit-frame-pointer -optc-g -optc-DRtsWay=\"rts_p\" -optc-DWINVER=0x06000100 -static -prof -eventlog -O0 -H64m -Wall -fllvm-fill-undef-with-garbage -Werror -Iincludes -Iincludes/dist -Iincludes/dist-derivedconstants/header -Iincludes/dist-ghcconstants/header -Irts -Irts/dist/build -DCOMPILING_RTS -this-unit-id rts -dcmm-lint -i -irts -irts/dist/build -Irts/dist/build -irts/dist/build/./autogen -Irts/dist/build/./autogen -O2 -Wnoncanonical-monad-instances -c rts/Sparks.c -o rts/dist/build/Sparks.p_o rts\Profiling.c: In function 'reportCCSProfiling': rts\Profiling.c:704:9: error: error: implicit declaration of function 'writeCCSReportJson' [-Werror=implicit-function-declaration] writeCCSReportJson(prof_file, stack, totals); ^~~~~~~~~~~~~~~~~~ | 704 | writeCCSReportJson(prof_file, stack, totals); | ^ rts\Profiling.c:704:9: error: error: nested extern declaration of 'writeCCSReportJson' [-Werror=nested-externs] | 704 | writeCCSReportJson(prof_file, stack, totals); | ^ cc1.exe: all warnings being treated as errors `gcc.exe' failed in phase `C Compiler'. (Exit code: 1) make[1]: *** [rts/ghc.mk:255: rts/dist/build/Profiling.p_o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:127: all] Error 2 /c/code/HEAD$

1 0