April 2017 - ghc-devs

ghc-stage2 —interactive segfaults on Mac OS X 10.11.6 (build flavour = prof)
by Alfredo Di Napoli 14 Apr '17

14 Apr '17

Hey all, I’m trying to compile GHC HEAD (cloning from master) with the `prof` build flavour on a Mac OS X 10.11.6 machine and I have noticed that, despite ghc-stage2 works as expected, when invoked with —interactive it starts before crashing with a segmentation fault: ``` ☁ compiler [master] ⚡ ../inplace/bin/ghc-stage2 --interactive GHCi, version 8.3.20170413: http://www.haskell.org/ghc/ :? for help [1] 79176 segmentation fault ../inplace/bin/ghc-stage2 --interactive ``` Did it happen to somebody else or it’s just me? Shall I try throwing gdb at it to try and see what’s going on? Thanks, Alfredo

3 5

Join points and loopificaiton
by Simon Peyton Jones 12 Apr '17

12 Apr '17

Luke Kavon Farvardin is here as an intern, mainly working on LLVM backend stuff. But he knows a lot about CPS etc and he'd read our paper. In talking about it, we realised a new Join Point Win! I've written it up in https://ghc.haskell.org/trac/ghc/wiki/Commentary/Compiler/Loopification under "New idea: use join points". Let's do it! Ticket here: https://ghc.haskell.org/trac/ghc/ticket/13567 Simon

2 1

Re: Join points and loopificaiton
by Thomas Jakway 12 Apr '17

12 Apr '17

woops, meant to reply list On 04/12/2017 11:29 AM, Thomas Jakway wrote: > > This would go great with https://ghc.haskell.org/trac/ghc/ticket/13051 > (which I have not abandoned by the way!) > > > On 04/12/2017 11:25 AM, Simon Peyton Jones via ghc-devs wrote: >> >> Luke >> >> Kavon Farvardin is here as an intern, mainly working on LLVM backend >> stuff. But he knows a lot about CPS etc and he'd read our paper. In >> talking about it, we realised a new Join Point Win! >> >> I’ve written it up in >> >> https://ghc.haskell.org/trac/ghc/wiki/Commentary/Compiler/Loopification >> >> under “New idea: use join points”. Let’s do it! >> >> Ticket here: https://ghc.haskell.org/trac/ghc/ticket/13567 >> >> Simon >> >> >> >> _______________________________________________ >> ghc-devs mailing list >> ghc-devs(a)haskell.org >> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs >

1 0

submodules
by Simon Peyton Jones 11 Apr '17

11 Apr '17

Devs I want to build a GHC from someone else repo; this one actually git@github.com:Tritlo/ghc.git<mailto:git@github.com:Tritlo/ghc.git>. But when I clone it, and then do git submodule init; git submodule update, I get lots of git submodule update Cloning into '.arc-linters/arcanist-external-json-linter'... ERROR: Repository not found. fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. Clone of 'git@github.com:Tritlo/arcanist-external-json-linter.git' into submodule path '.arc-linters/arcanist-external-json-linter' failed simonpj@cam-05-unx:~/code/ghc-holes$ What is the kosher way to do this? Thanks Simon

2 2

Setting Up a OpenBSD System for Building GHC Wiki Page
by Adam Steen 10 Apr '17

10 Apr '17

Hi All I have created the Building/Preparation/OpenBSD Wiki Page, i have not yet link it to Building/Preparation <https://ghc.haskell.org/trac/ghc/wiki/Building/Preparation> page yet, but am looking for a review Setting Up a OpenBSD System for Building GHC <https://ghc.haskell.org/trac/ghc/wiki/Building/Preparation/OpenBSD> Cheers Adam

5 7

Re: Where do I start if I would like help improve GHC compilation times?
by David Feuer 09 Apr '17

09 Apr '17

Be aware that some of the biggest performance problems with TH simply can't be fixed without changes to the TH language. For details, see Edward Yang's blog post: http://blog.ezyang.com/2016/07/what-template-haskell-gets-wrong-and-racket-… There was a Reddit thread discussing that post at https://www.reddit.com/r/haskell/comments/4tfzah/what_template_haskell_gets… David FeuerWell-Typed, LLP -------- Original message --------From: Alfredo Di Napoli <alfredo.dinapoli(a)gmail.com> Date: 4/9/17 5:37 AM (GMT-05:00) To: Ben Gamari <ben(a)smart-cactus.org> Cc: ghc-devs(a)haskell.org Subject: Re: Where do I start if I would like help improve GHC compilation times? Hey Ben, as promised I’m back to you with something more articulated and hopefully meaningful. I do hear you perfectly — probably trying to dive head-first into this without at least a rough understanding of the performance hotspots or the GHC overall architecture is going to do me more harm than good (I get the overall picture and I’m aware of the different stages of the GHC compilation pipeline, but it’s far from saying I’m proficient with the architecture as whole). I have also read a couple of years ago the GHC chapter on the “Architeture of Open Source Applications” book, but I don’t know how much that is still relevant. If it is, I guess I should refresh my memory. I’m currently trying to move on 2 fronts — please advice if I’m a fool flogging a dead horse or if I have any hope of getting anything done ;) 1. I’m trying to treat indeed the compiler as a black block (as you adviced) trying to build a sufficiently large program where GHC is not “as fast as I would like” (I know that’s a very lame definition of “slow”, hehe). In particular, I have built the stage2 compiler with the “prof” flavour as you suggested, and I have chosen 2 examples as a reference “benchmark” for performance; DynFlags.hs (which seems to have been mentioned multiple times as a GHC perf killer) and the highlighting-kate package as posted here: https://ghc.haskell.org/trac/ghc/ticket/9221 . The idea would be to compile those with -v +RTS -p -hc -RTS enabled, look at the output from the .prof file AND the `-v` flag, find any hotspot, try to change something, recompile, observe diff, rinse and repeat. Do you think I have any hope of making progress this way? In particular, I think compiling DynFlags.hs is a bit of a dead-end; I whipped up this buggy script which escalated into a Behemoth which is compiling pretty much half of the compiler once again :D ```#!/usr/bin/env bash ../ghc/inplace/bin/ghc-stage2 --make -j8 -v +RTS -A256M -qb0 -p -h \-RTS -DSTAGE=2 -I../ghc/includes -I../ghc/compiler -I../ghc/compiler/stage2 \-I../ghc/compiler/stage2/build \-i../ghc/compiler/utils:../ghc/compiler/types:../ghc/compiler/typecheck:../ghc/compiler/basicTypes \-i../ghc/compiler/main:../ghc/compiler/profiling:../ghc/compiler/coreSyn:../ghc/compiler/iface:../ghc/compiler/prelude \-i../ghc/compiler/stage2/build:../ghc/compiler/simplStg:../ghc/compiler/cmm:../ghc/compiler/parser:../ghc/compiler/hsSyn \-i../ghc/compiler/ghci:../ghc/compiler/deSugar:../ghc/compiler/simplCore:../ghc/compile/specialise \-fforce-recomp -c $@``` I’m running it with `./dynflags.sh ../ghc/compiler/main/DynFlags.hs` but it’s taking a lot to compile (20+ mins on my 2014 mac Pro) because it’s pulling in half of the compiler anyway :D I tried to reuse the .hi files from my stage2 compilation but I failed (GHC was complaining about interface file mismatch). Short story short, I don’t think it will be a very agile way to proceed. Am I right? Do you have any recommendation in such sense? Do I have any hope to compile DynFlags.hs in a way which would make this perf investigation feasible? The second example (the highlighting-kate package) seems much more promising. It takes maybe 1-2 mins on my machine, which is enough to take a look at the perf output. Do you think I should follow this second lead? In principle any 50+ modules package I think would do (better if with a lot of TH ;) ) but this seems like a low-entry barrier start. 2. The second path I’m exploring is simply to take a less holistic approach and try to dive in into a performance ticket like the ones listed here: https://www.reddit.com/r/haskell/comments/45q90s/is_anything_being_done_to_… some are very specific, but it seems like fixing small things and move forward could help giving me understanding of different sub-parts of GHC, which seems less intimidating than the black-box approach. In conclusion, what do you think is the best approach, 1 or 2, both or none? ;) Thank you! Alfredo On 7 April 2017 at 18:30, Alfredo Di Napoli <alfredo.dinapoli(a)gmail.com> wrote: Hey Ben, thanks for the quite exhaustive reply! I’m on the go right now, but I promise to get back to you with a meaningful reply later this weekend ;) Alfredo On 7 April 2017 at 18:22, Ben Gamari <ben(a)smart-cactus.org> wrote: Alfredo Di Napoli <alfredo.dinapoli(a)gmail.com> writes: > Hey folks, > Hi Alfredo! First, thanks for writing. More eyes looking at GHC's compiler performance is badly needed. > maybe I’m setting up for something too ambitious for me, but I would like > to take an active stance to the overlasting “GHC compilation times are > terrible” matter, instead of simply stare at the screen with despair > whenever GHC compiles a sufficiently large Haskell program ;) > > To make this even more interesting, I have never contributed to GHC either! > The max I have pushed myself into was 2 years ago when I successfully built > GHC head from source and tried to fix an Haddock “easy” ticket I don’t even > recall (full disclosure, eventually I didn’t :D ). > > Specifically, I would love community recommendations & guidance about: > > 1. Is this simply too daunting for somebody like me? Maybe is better to > first start contributing more regularly, take confidence with the code base > AND then move forward? > As with any software project, it is possible to treat the compiler as a black box, throw a profiler at it and see what hotspots show up. This gives you a place to focus your effort, allowing you to learn a small area and broaden your knowledge as necessary. However, I think it's fair to say that you will be significantly more productive if you first develop a basic understanding of the compilation pipeline. I'd recommend having a look at the GHC Commentary [1] for a start. I think it also helps to have a rough idea of what "slow" means to you. I find it is quite helpful if you have a particular program which you feel compiles more slowly than you would like (especially if it even compiles slowly with -O0, since then much less of the compiler is involved in compilation). Another approach is to look for programs whose compilation time has regressed over the course of GHC releases. It is not hard to find these examples and it is often possible to bisect your way back to the regressing commit. Also, note that I have collected some notes pertaining to compiler performance on the Wiki [2]. Here you will find a number of tickets of interest (as well a some rough themes which I've noticed), some nofib results which might guide your efforts, as well as a list of some fixes which have been committed in the past. [1] https://ghc.haskell.org/trac/ghc/wiki/Commentary/Compiler [2] https://ghc.haskell.org/trac/ghc/wiki/Performance/Compiler > 2. Are compilation times largely dependant from the target platform (I’m on > Darwin) or there is something which can be done “globally” so that the > benefits can be experienced by everybody? > There are some external considerations (e.g. the platform's compiler and linking toolchain) which contribute to GHC's runtime. For instance, it is known that the BFD ld linker implementation that many Linux distributions use by default is a great deal slower than it could be. This particular issue has come up recently and I'm currently working on allowing us to use the more performant gold linker when available. However, I think it's fair to say that for most programs GHC's runtime is largely independent of platform. I would invite you to try compiling a package which you consider GHC to compile "slowly" with GHC's -v flag (and GHC 8.0.1 or newer). This will give you a rough breakdown of where time is spent. For many packages you will find that the simplifier and/or typechecker dominate, followed (often distantly) by native code generation. Of these steps native code generation is the only one with a strong platform dependence. > 3. Is there any recommended workflow to profile GHC compilation times? Is > there any build flavour one should prefer when doing so? (Maybe the full, > slowest one?) > There are a few options here: * As of GHC 8.0 the compiler will output timing and allocation information for its various stages if run with -v. This can be extremely helpful to get a high-level picture of where the compiler is spending its time while compiling your program. This is almost always the right place to start. * As with any Haskell program, the cost centre profiler can be used to characterize the memory and CPU behavior of various parts of the compiler. GHC's source tree includes a "prof" build flavour which builds the compiler with profiling enabled. However it only includes a handful of cost-centres and is best used when you already have a rough idea where you are looking and can add further cost-centres to drill down to your hotspot. Simply enabling -fprof-exported across the entire tree just doesn't work in my experience: not only is the resulting compiler quite slow, but the profile you get is far too unwieldy to learn from. * Occassionally the ticky-ticky profiler can be helpful in identifying allocation hotspots without the full overhead of the cost-centre profiler. * In principle our newly-stable DWARF debug information can be used for profiling, although this is still a work in progress and requires a patched GHC for best results. It's probably best to stick to the more traditional profiling mechanisms for now. Anyways, I hope this helps. Always feel free to get in touch with me personally (IRC and email are both great) if you would like to discuss particular issues. Thanks again for your interest! Cheers, - Ben

1 0

Re: GHC 8.2.1-rc1 source tarball availability
by David Feuer 08 Apr '17

08 Apr '17

I'm not sure why you're trying to run things from the libffi directory. As far as I know, the test suite is normally run from ghc/testsuite. David FeuerWell-Typed, LLP -------- Original message --------From: George Colpitts <george.colpitts(a)gmail.com> Date: 4/5/17 9:17 PM (GMT-05:00) To: Jens Petersen <juhpetersen(a)gmail.com>, Ben Gamari <ben(a)well-typed.com> Cc: GHC developers <ghc-devs(a)haskell.org> Subject: Re: GHC 8.2.1-rc1 source tarball availability I'd like to run the testsuite on macOS but I am having trouble following the documentation at https://ghc.haskell.org/trac/ghc/wiki/Building/RunningTests/Running Do I need to download something in addition to the source tarball or am I making some mistake? Following is what I tried: pwd/Users/gcolpitts/Downloads/ghc-8.2.0.20170404/libffi# doc says: The commands on this page can all be executed from the testsuite directory.bash-3.2$ find . -name testsuite./libffi/build/testsuite./libffi/build/x86_64-apple-darwin/testsuitebash-3.2$ pushd libffi/build/x86_64-apple-darwin/testsuite~/Downloads/ghc-8.2.0.20170404/libffi/build/x86_64-apple-darwin/testsuite ~/Downloads/ghc-8.2.0.20170404bash-3.2$ make testmake: *** No rule to make target `test'. Stop.bash-3.2$ popd~/Downloads/ghc-8.2.0.20170404bash-3.2$ pushd libffi/build/testsuite~/Downloads/ghc-8.2.0.20170404/libffi/build/testsuite ~/Downloads/ghc-8.2.0.20170404bash-3.2$ make testmake: *** No rule to make target `test'. Stop.bash-3.2$ popd~/Downloads/ghc-8.2.0.20170404bash-3.2$ make test/Applications/Xcode.app/Contents/Developer/usr/bin/make -C testsuite/tests CLEANUP=1 SUMMARY_FILE=../../testsuite_summary.txtmake: *** testsuite/tests: No such file or directory. Stop.make: *** [test] Error 2 ThanksGeorge On Wed, Apr 5, 2017 at 9:43 PM Jens Petersen <juhpetersen(a)gmail.com> wrote: On 4 April 2017 at 13:21, Ben Gamari <ben(a)well-typed.com> wrote: I am happy to announce the release of the 8.2.1-rc1 source distribution to binary packagers. It seems to build okay for me on Fedora 26 so far. But the testsuite completely failed in timeout: see https://ghc.haskell.org/trac/ghc/ticket/13534 Cheers, Jens _______________________________________________ ghc-devs mailing list ghc-devs(a)haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

5 7

testsuite failures on Mac
by Richard Eisenberg 07 Apr '17

07 Apr '17

Hi devs, On today's HEAD, I built from a cleaned tree and then ran the testsuite. I got gobs of errors. Here's one: --- ./T2713.run/T2713.stderr.normalised 2017-04-07 15:13:22.000000000 -0400 +++ ./T2713.run/T2713.comp.stderr.normalised 2017-04-07 15:13:22.000000000 -0400 @@ -1,8 +1,4 @@ - -T2713.hs:11:10: - The fixity signature for ‘.*.’ lacks an accompanying binding - (The fixity signature must be given where ‘.*.’ is declared) - -T2713.hs:12:1: - The type signature for ‘f’ lacks an accompanying binding - (The type signature must be given where ‘f’ is declared) +ghc-iserv.bin: +lookupSymbol failed in relocateSection (RELOC_GOT) +/Users/rae/ghc/ghc/libraries/integer-gmp/dist-install/build/HSinteger-<IMPL>-<VERSION>o: unknown symbol `___gmp_rands' +ghc: unable to load package `integer-<IMPL>-<VERSION>' *** unexpected failure for T2713(ext-interp) Although I have minor changes in some type-y stuff, nothing that should cause problems with ghc-iserv. Any thoughts? I'm on a Mac. Thanks! Richard

2 3

GHC Core simplifier question: turn off all passes?
by Christopher Done 07 Apr '17

07 Apr '17

Hi all, Just checking, if I want to see the Haskell code desugared to core BEFORE any simplification passes, is this the way to do it? bash-3.2$ cat > X.hs module X where it = (\x -> x * 2) 123 bash-3.2$ stack exec -- ghc -ddump-simpl X.hs -fforce-recomp -fmax-simplifier-iterations=0 -O0 [1 of 1] Compiling X ( X.hs, X.o ) ==================== Tidy Core ==================== Result size of Tidy Core = {terms: 11, types: 3, coercions: 0} -- RHS size: {terms: 4, types: 1, coercions: 0} it :: Integer [GblId, Str=DmdType] it = * @ Integer GHC.Num.$fNumInteger 123 2 I was a bit surprised that the lambda is collapsed already with optimizations turned off and the simplifier iterations set to 0. I changed this to (\x -> x * x) and it produced a let instead. Is this just one of the things the HS->Core desugarer decides to do? Ciao!

3 5

Re: testsuite not in GHC 8.2.1-rc1 source tarball ?
by David Feuer 06 Apr '17

06 Apr '17

That's not really too surprising to me. The test suite is primarily intended for GHC developers, and at present only works reliably when GHC is compiled for validation. Including it in the distribution would force users who had no use for it to pay for it anyway. David FeuerWell-Typed, LLP -------- Original message --------From: George Colpitts <george.colpitts(a)gmail.com> Date: 4/6/17 9:39 AM (GMT-05:00) To: David Feuer <david(a)well-typed.com>, Jens Petersen <juhpetersen(a)gmail.com>, Ben Gamari <ben(a)well-typed.com> Cc: GHC developers <ghc-devs(a)haskell.org> Subject: Re: testsuite not in GHC 8.2.1-rc1 source tarball ? Thanks Brandon After downloading the source tarball and doing a build successfully I wanted to run the testsuite. You writeAs far as I know, the test suite is normally run from ghc/testsuite. That directory doesn't exist for me: pwd /Users/gcolpitts/Downloads/ghc-8.2.0.20170404/ghc bash-3.2$ ls testsuite ls: testsuite: No such file or directory bash-3.2$ so I guess the source tarball doesn't contain it and those who do a build can't test their build with the testsuite. I was hoping I could do that. I didn't think the libffi directories were the right place to run from but they were only testsuite directories that the find command gave me. Thanks againGeorge On Thu, Apr 6, 2017 at 2:10 AM David Feuer <david(a)well-typed.com> wrote: I'm not sure why you're trying to run things from the libffi directory. As far as I know, the test suite is normally run from ghc/testsuite. David FeuerWell-Typed, LLP -------- Original message --------From: George Colpitts <george.colpitts(a)gmail.com> Date: 4/5/17 9:17 PM (GMT-05:00) To: Jens Petersen <juhpetersen(a)gmail.com>, Ben Gamari <ben(a)well-typed.com> Cc: GHC developers <ghc-devs(a)haskell.org> Subject: Re: GHC 8.2.1-rc1 source tarball availability I'd like to run the testsuite on macOS but I am having trouble following the documentation at https://ghc.haskell.org/trac/ghc/wiki/Building/RunningTests/Running Do I need to download something in addition to the source tarball or am I making some mistake? Following is what I tried: pwd/Users/gcolpitts/Downloads/ghc-8.2.0.20170404/libffi# doc says: The commands on this page can all be executed from the testsuite directory.bash-3.2$ find . -name testsuite./libffi/build/testsuite./libffi/build/x86_64-apple-darwin/testsuitebash-3.2$ pushd libffi/build/x86_64-apple-darwin/testsuite~/Downloads/ghc-8.2.0.20170404/libffi/build/x86_64-apple-darwin/testsuite ~/Downloads/ghc-8.2.0.20170404bash-3.2$ make testmake: *** No rule to make target `test'. Stop.bash-3.2$ popd~/Downloads/ghc-8.2.0.20170404bash-3.2$ pushd libffi/build/testsuite~/Downloads/ghc-8.2.0.20170404/libffi/build/testsuite ~/Downloads/ghc-8.2.0.20170404bash-3.2$ make testmake: *** No rule to make target `test'. Stop.bash-3.2$ popd~/Downloads/ghc-8.2.0.20170404bash-3.2$ make test/Applications/Xcode.app/Contents/Developer/usr/bin/make -C testsuite/tests CLEANUP=1 SUMMARY_FILE=../../testsuite_summary.txtmake: *** testsuite/tests: No such file or directory. Stop.make: *** [test] Error 2 ThanksGeorge On Wed, Apr 5, 2017 at 9:43 PM Jens Petersen <juhpetersen(a)gmail.com> wrote: On 4 April 2017 at 13:21, Ben Gamari <ben(a)well-typed.com> wrote: I am happy to announce the release of the 8.2.1-rc1 source distribution to binary packagers. It seems to build okay for me on Fedora 26 so far. But the testsuite completely failed in timeout: see https://ghc.haskell.org/trac/ghc/ticket/13534 Cheers, Jens _______________________________________________ ghc-devs mailing list ghc-devs(a)haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

2 1