January 2019 - ghc-devs

Gitlab notifications
by Simon Peyton Jones 18 Jan '19

18 Jan '19

I don't seem to be receiving notifications for my own MR: https://gitlab.haskell.org/ghc/ghc/merge_requests/128 Richard and Ryan both commented, but I received literally no email about it. I'm set to "Watch" the GHC project. Any ideas? Simon PS: I am getting some notifications * Thurs (today): 3 emails, about !79, !133 * Weds: 6 emails about !51, !125, !124 * Tues: 22 messages about a variety of tickets

2 2

Hackage and ghc shipped package contents mismatch
by Moritz Angermann 18 Jan '19

18 Jan '19

Dear friends, the other day I've run into an issue where I could not build a package. It turned out that the underlying reason was that the packages ghc ships with are not necessarily the same as they are on hackage. Ryan was kind enough to open Ticket 16199[1]. My use case is that I reduce the set of packages I use from the package database that ghc ships, and build the others myself. Thus if packages in the package database as shipped with ghc do not match the ones found on hackage for the SAME VERSION, I run into issues. I've since devised a script to compute the difference between packages in GHC and the ones on hackage with the same version[2]. I've then sat out to compute the differences for ghc8.4 and ghc8.6 using the following approach: for release in ghc-8.4.1-release ghc-8.4.2-release ghc-8.4.3-release ghc-8.4.4-release \ ghc-8.6.4-release ghc-8.6.2-release ghc-8.6.3-release; do git checkout $release git reset --hard HEAD && git clean -xffd git submodule update --init --recursive && git clean -xffd ../verify-packages.sh mkdir -p ../$release find package-diffs -not -empty -type f -exec cp {} ../$release \; done I've compiled them[3] for inspection (and because I need to patch my hackage packages to match the ones that ghc ships). I'm sorry to report that I found discrepancies between the package we ship with GHC and the ones on haskell for each ghc release in 8.4 and 8.6. Some changes are minor, such as version bumps, as can be represented with revisions on hackage as well. Other are not so minor. The one over which I tripped was transformers-0.5.5.0. The diff[4] is 20K. I therefore propose that we make sure to only ship packages with GHC that match their respective versions on hackage. Cheers, Moritz -- [1]: http://ghc.haskell.org/trac/ghc/ticket/16199 [2]: https://gitlab.haskell.org/ghc/ghc/merge_requests/139 [3]: https://github.com/angerman/haskell.nix/tree/master/patches [4]: https://github.com/angerman/haskell.nix/blob/master/patches/ghc863/transfor…

2 1

MutVar# and GC
by chessai . 18 Jan '19

18 Jan '19

Devs, I've heard from a few friends that MutVars, TVars, etc. are more challenging for the garbage collector. I'm writing to ask if someone can answer: 1. Is this true, and 2: Why? I can't seem to find anything like a writeup or documentation that mentions this. The HeapObjects trac page also mentions nothing about these supposed difficulties that GC faces with mutable heap objects. Thanks

3 4

RE: [GHC] #16105: Haddock's resource directory isn't properly handled by Hadrian
by Simon Peyton Jones 17 Jan '19

17 Jan '19

I feel as if I'm seeing the same commits many times. Is that right? Simon | -----Original Message----- | From: ghc-tickets <ghc-tickets-bounces(a)haskell.org> On Behalf Of GHC | Sent: 17 January 2019 17:47 | Subject: Re: [GHC] #16105: Haddock's resource directory isn't properly | handled by Hadrian | | #16105: Haddock's resource directory isn't properly handled by Hadrian | -------------------------------------+------------------------------------- | Reporter: harpocrates | Owner: harpocrates | Type: bug | Status: patch | Priority: normal | Milestone: | Component: Build System | Version: 8.6.3 | (Hadrian) | | Resolution: | Keywords: | Operating System: Unknown/Multiple | Architecture: | | Unknown/Multiple | Type of failure: None/Unknown | Test Case: | Blocked By: | Blocking: | Related Tickets: | Differential Rev(s): | Wiki Page: | | https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.ha | skell.org%2Fghc%2Fghc%2Fmerge_requests%2F107&data=02%7C01%7Csimonpj%40m | icrosoft.com%7C372045a12b644a9571cb08d67ca3db5e%7C72f988bf86f141af91ab2d7cd | 011db47%7C1%7C0%7C636833440531332748&sdata=5xl9%2FYs97X%2FZx6gFnQllwe0G | %2F6nns48JAQLpFH%2FcptU%3D&reserved=0 | -------------------------------------+------------------------------------- | | Comment (by Ben Gamari <ben@…>): | | In [changeset:"2e05912086bbb8eab213d44af300ecc396d912aa/ghc" 2e05912/ghc]: | {{{ | #!CommitTicketReference repository="ghc" | revision="2e05912086bbb8eab213d44af300ecc396d912aa" | Hadrian: handle Haddock's resource directory | | Fixes #16105 | | * Require Haddock's resource as runtime dependencies of the Haddock | builder. This means we no longer have to `need` particular resources | in every other documentation rule. | | * Do a _tracked_ copy of both the 'html' and 'latex' folder resource | folders. | | * Move resources into `stage1/lib` (NB: the `haddock` binary goes in | `stage1/bin`). Besides now actually matching the Haddock script | wrapper generated by BinaryDist, this also prepares for Haddock | in relocatable build folder detecting its own resources. | }}} | | -- | Ticket URL: | <https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fghc.haske | ll.org%2Ftrac%2Fghc%2Fticket%2F16105%23comment%3A4&data=02%7C01%7Csimon | pj%40microsoft.com%7C372045a12b644a9571cb08d67ca3db5e%7C72f988bf86f141af91a | b2d7cd011db47%7C1%7C0%7C636833440531332748&sdata=bYvB5fV1dorg3j1nJogVvh | %2Fs7c4onmFfOXJXZ1ZAZj8%3D&reserved=0> | GHC | <https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.haske | ll.org%2Fghc%2F&data=02%7C01%7Csimonpj%40microsoft.com%7C372045a12b644a | 9571cb08d67ca3db5e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C63683344053 | 1332748&sdata=3xcWX15vR8Vcl3wNn3P%2FsM%2FeBp6nTusSMSkfs%2FXTrGo%3D& | reserved=0> | The Glasgow Haskell Compiler

1 0

[FYI] GitLab upgraded
by Ben Gamari 16 Jan '19

16 Jan '19

Hi everyone, I have upgraded our GitLab instance. While generally the changes are pretty minor, one significant change is that batched review comments should now result in a single email notification. Anyways, as always, let me know whether there is any trouble. Cheers, - Ben

1 0

Bug in "changes" tab in Gitlab
by Ömer Sinan Ağacan 16 Jan '19

16 Jan '19

Hi, I think there's a currently a bug in "changes" tab in gitlab. If you look at [1] it shows as if I added a new line in `Main.hs`, but actually I just changed one word: diff --git a/utils/genapply/Main.hs b/utils/genapply/Main.hs index 71b84fde79..7038dc5c09 100644 --- a/utils/genapply/Main.hs +++ b/utils/genapply/Main.hs @@ -903,7 +903,7 @@ genStackApply regstatus args = -- -- These code fragments are used to save registers on the stack at a heap -- check failure in the entry code for a function. We also have to save R1 --- and the return address (stg_gc_fun_info) on the stack. See stg_gc_fun_gen +-- and the return address (stg_gc_fun_info) on the stack. See __stg_gc_fun -- in HeapStackCheck.cmm for more details. I'm guessing that Gitlab is confused by the `---` prefix in the diff. I was going to report it but I realized that we're not using the latest version (the "help" page says "update asap"), so perhaps we should try updating first? [1]: https://gitlab.haskell.org/ghc/ghc/merge_requests/125/diffs?view=parallel Ömer

2 1

RE: GHC | Some refactoring in tcInferApps (!116)
by Simon Peyton Jones 15 Jan '19

15 Jan '19

Thanks. But none of the pictures arrived, so I can’t interpret what you say. I think I did see Richards face here and there (and mine), if that’s want avatars means. Hovering showed a snippet of a comment; but clicking did nothing. I’m also terribly reluctant to scroll through thousands of lines of diff looking for avarars. Simon From: ghc-devs <ghc-devs-bounces(a)haskell.org> On Behalf Of Sylvain Henry Sent: 14 January 2019 16:21 To: ghc-devs(a)haskell.org Subject: Re: GHC | Some refactoring in tcInferApps (!116) Hi Simon, In the diff view, you can click on the avatars on the left to expand discussions: [cid:part1.E17582DB.274298F8@haskus.fr] Or you can click on the "toggle comments for this file" button: [cid:part2.D9953BB2.A74D4E27@haskus.fr] If you are willing to use GreaseMonkey (Firefox extension) or TamperMonkey (Chrome/Chromium extension), you can use the attached script to add new buttons to GitLab UI: [cid:part3.9CF91D30.FC1AF3DA@haskus.fr] [cid:part4.5144A0AF.98359F8A@haskus.fr] Tested on Firefox and Chromium on Linux. Sylvain On 14/01/2019 11:58, Simon Peyton Jones via ghc-devs wrote: | (without the 'diff' at the end) you can see the collapsed discussion items? Yes, in the discussion tab I can. But of course that is out of context; you just get a little (non-expandable) snippet. Simon | -----Original Message----- | From: Mikolaj Konarski <mikolaj(a)well-typed.com><mailto:mikolaj@well-typed.com> | Sent: 14 January 2019 10:30 | To: Simon Peyton Jones <simonpj(a)microsoft.com><mailto:simonpj@microsoft.com> | Cc: ghc-devs <ghc-devs(a)haskell.org><mailto:ghc-devs@haskell.org> | Subject: Re: GHC | Some refactoring in tcInferApps (!116) | | > Looking here | > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitl | > ab.haskell.org%2Fghc%2Fghc%2Fmerge_requests%2F116%2F%2Fdiffs&data= | > 02%7C01%7Csimonpj%40microsoft.com%7Cb565eeb2f6fe445fc64f08d67a0b40fe%7 | > C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636830586093208883&sda | > ta=qAcz0zoXCCQHFeJ39ABKAVwtN5a2pIwyRSbfJcLSurk%3D&reserved=0 | > I see literally NO discussions with a "toggle discussion" button. Indeed | if I search for "toggle" I get no hits. | | Oh, I see, you are right with respect to the link you cited now. | None of the buttons help, just as you say. I have to navigate back from the | "Changes" to the "Discussion" tab, which gets me to the link you gave | initially | (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h | askell.org%2Fghc%2Fghc%2Fmerge_requests%2F116&data=02%7C01%7Csimonpj%40 | microsoft.com%7Cb565eeb2f6fe445fc64f08d67a0b40fe%7C72f988bf86f141af91ab2d7c | d011db47%7C1%7C0%7C636830586093208883&sdata=1pFmcwPyptWE8XOs%2FdnykEqsm | 4ag7%2BqBi3c4qpAE7sE%3D&reserved=0) | where the discussions are available, but I can't see them in the context of | the whole diff and none of the buttons there let me extend the view of the | diff. That's quite suboptimal. | | Could you confirm that at | | https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.ha | skell.org%2Fghc%2Fghc%2Fmerge_requests%2F116&data=02%7C01%7Csimonpj%40m | icrosoft.com%7Cb565eeb2f6fe445fc64f08d67a0b40fe%7C72f988bf86f141af91ab2d7cd | 011db47%7C1%7C0%7C636830586093208883&sdata=1pFmcwPyptWE8XOs%2FdnykEqsm4 | ag7%2BqBi3c4qpAE7sE%3D&reserved=0 | | (without the 'diff' at the end) you can see the collapsed discussion items? _______________________________________________ ghc-devs mailing list ghc-devs(a)haskell.org<mailto:ghc-devs@haskell.org> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs<https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.haske…>

3 2

Max identifier length
by Christopher Done 14 Jan '19

14 Jan '19

Hey, Quick question: Does GHC have an upper limit on the length of binding names? Cheers!

3 2

RE: GHC | Some refactoring in tcInferApps (!116)
by Simon Peyton Jones 14 Jan '19

14 Jan '19

Devs I’m at a loss for how to review GitLab changes. Richard sent me the message below. So I follow the link to “View on GitLab”, or I manually edit the URL to plain https://gitlab.haskell.org/ghc/ghc/merge_requests/116 Either way, I can’t see any comments whatsoever! It says 5/5 discussions resolved, but I can’t actually see them. There is not “toggle discussion” button anywhere. What should I do? This is quite a big problem. I suppose we could issue guidance NEVER to resolve a discussion, but that seems like the wrong conclusion. Simon From: Richard Eisenberg <gitlab(a)gitlab.haskell.org> Sent: 14 January 2019 03:03 To: Simon Peyton Jones <simonpj(a)microsoft.com> Subject: Re: GHC | Some refactoring in tcInferApps (!116) Richard Eisenberg<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.ha…> commented on a discussion on compiler/typecheck/TcHsType.hs<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.ha…>: 1022 + (vcat [ ppr ki_binder 1023 + , ppr ki_arg 1024 + , ppr (tyBinderType ki_binder) 1025 + , ppr subst 1026 + , ppr (isInvisibleBinder ki_binder) ]) 1027 + ; ty_app_err ki_arg $ nakedSubstTy subst $ 1028 + mkPiTys all_ki_binders inner_ki } 1029 + 1030 + -- no binder; try applying the substitution, or fail if that's not possible 1031 + | otherwise 1032 + = try_again_after_substing_or n subst fun inner_ki all_args $ \ substed_inner_ki -> 1033 + ty_app_err ki_arg substed_inner_ki 1034 + 1035 + go n subst fun all_ki_binders inner_ki all_args@(HsValArg arg : args) 1036 + | ki_binder : ki_binders <- all_ki_binders 1037 + = if isInvisibleBinder ki_binder See if you like how I've done this now. — View it on GitLab<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.ha…>. You're receiving this email because of your account on gitlab.haskell.org. If you'd like to receive fewer emails, you can unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.ha…> from this thread or adjust your notification settings.

4 8

Reviews
by Simon Peyton Jones 11 Jan '19

11 Jan '19

When reviewing a MR, I sometimes want to look at (and even add comments to) code that isn't displayed in the MR window. With Phab there was a "show 20 more lines" link, and even "show the whole file". How do I do that in GitLab? When submitting a review, I often want to add an overall comment, not related to a particular line of code? How do I do that? Thanks Simoin

5 14