- ghc-devs - Haskell.org

Gitlab bug?
by Simon Peyton Jones 26 Feb '19

26 Feb '19

Look here: https://gitlab.haskell.org/ghc/ghc/merge_requests/444/diffs#350c4076427c611… Look at the comment "Is this zipping necessary? We haven't zonked the scoped_kvs or the tc_tvs, I think" from Richard Eisenberg, just below line 1925 in TcHsType. Now click on the grey "..." above his comment, to expand more code lines above. Uh oh! * The same comment now occurs twice, just below line 1904, and again just below 1925. * The first time it's on the wrong line of code * But in the second position (the correct one) the "Reply" box is inactive. I can't type into it. Is this is a bug? How to report it? Simon

3 5

RE: --share option for hadrian doesn't work with hs-boot files
by Andrey Mokhov 22 Feb '19

22 Feb '19

Hi Matt, Thanks! Switching branches that add/remove hs-boot files is exactly the kind of scenario which is hard to predict :) This looks like a bug, so please create a ticket. If you manage to reproduce this somehow without switching branches, e.g. by just adding or removing an hs-boot file, that would make it easier to debug. > Could you please write down some advice Andrey about > how to solve issues like this? It seems very fragile making > sure that every case is covered. Shake 0.17.6 has the following two commands that may help to partially clean up the cache in presence of such bugs: --share-list List the shared cache files. --share-remove[=SUBSTRING] Remove the shared cache keys. By running Hadrian with --share-remove=_build/stage0/compiler/build/Var* you should be able to evict the corresponding build rules from the cache and hopefully the build will go through. If this does help, please also mention this in the ticket. Cheers, Andrey From: Matthew Pickering [mailto:matthewtpickering@gmail.com] Sent: 22 February 2019 08:53 To: GHC developers <ghc-devs(a)haskell.org>; Andrey Mokhov <andrey.mokhov(a)newcastle.ac.uk> Subject: --share option for hadrian doesn't work with hs-boot files I have been trying the new `--share` option implemented in hadrian but I haven't actually managed to complete any builds yet with it enabled after the initial one. The current error is ``` <no location info>: error: ‘Var.AnonArgFlag’ is exported by the hs-boot file, but not exported by the module Error when running Shake build system: at action, called at src/Rules.hs:35:19 in main:Rules at need, called at src/Rules.hs:52:5 in main:Rules * Depends on: _build/stage0/bin/ghc at need, called at src/Utilities.hs:71:18 in main:Utilities * Depends on: _build/stage0/compiler/build/libHSghc-8.9.a at need, called at src/Rules/Library.hs:118:5 in main:Rules.Library * Depends on: _build/stage0/compiler/build/Var.o * Raised the exception: user error (Development.Shake.cmd, system command failed ``` I get this after building Simon's `FunTy` patch which does add this flag and the definition to `Var.hs-boot` and then switching back to master with the cache enabled. Could you please write down some advice Andrey about how to solve issues like this? It seems very fragile making sure that every case is covered. Cheers, Matt

1 0

--share option for hadrian doesn't work with hs-boot files
by Matthew Pickering 22 Feb '19

22 Feb '19

I have been trying the new `--share` option implemented in hadrian but I haven't actually managed to complete any builds yet with it enabled after the initial one. The current error is ``` <no location info>: error: ‘Var.AnonArgFlag’ is exported by the hs-boot file, but not exported by the module Error when running Shake build system: at action, called at src/Rules.hs:35:19 in main:Rules at need, called at src/Rules.hs:52:5 in main:Rules * Depends on: _build/stage0/bin/ghc at need, called at src/Utilities.hs:71:18 in main:Utilities * Depends on: _build/stage0/compiler/build/libHSghc-8.9.a at need, called at src/Rules/Library.hs:118:5 in main:Rules.Library * Depends on: _build/stage0/compiler/build/Var.o * Raised the exception: user error (Development.Shake.cmd, system command failed ``` I get this after building Simon's `FunTy` patch which does add this flag and the definition to `Var.hs-boot` and then switching back to master with the cache enabled. Could you please write down some advice Andrey about how to solve issues like this? It seems very fragile making sure that every case is covered. Cheers, Matt

1 0

spj-wibbles
by Simon Peyton Jones 21 Feb '19

21 Feb '19

Matthew, Ben, David I've just submitted MR 426. It's a batch of four patches<https://gitlab.haskell.org/ghc/ghc/merge_requests/426/commits>, one of which makes the GHC tree validate again. Might you keep an eye on it. David/anyone: one of them "Stop inferring polymorphic kinds" makes a small change to HsSyn (removing a field). I don't know whether that'll require changing Haddock - or how to do so. Might you check? Gotta run Thanks! Simon

1 0

CI failing
by Simon Peyton Jones 21 Feb '19

21 Feb '19

Ben, Matthew I believe that 'master' fails validate. See Trac #16346. The question is: how did it get past CI? The bug would only show up if -dcore-lint was on for libraries. Simon

2 1

ZipN fusion
by Simon Peyton Jones 21 Feb '19

21 Feb '19

Dear devs Can someone help Alexandre by merging Phab:5249? See https://phabricator.haskell.org/D5249#151827 Many thanks Simon

2 1

Validate has died
by Simon Peyton Jones 19 Feb '19

19 Feb '19

>From master I'm getting 2052 "framework failures" in the testsuite, which all look like the one below. I also get 4468 expected passes, so not every test fails. This is with "sh validate". Yes I know I should get onto Hadrian, and I have a branch for that. But Hadrian isn't really working for me because it's putting build artefacts in my source tree rather than in my build tree (talking to Andrey about that). But I think that old 'validate' is still supposed to work, isn't it? I'm a bit stuck Thanks Simon Unexpected results from: TEST="AmapCoerce ArithInt16 ArithInt8 ArithWord16 ArithWord8 AtomicPrimops BinaryArray BinaryLiterals0 BinaryLiterals1 BinaryLiterals2 CPRRepeat CPUTime001 CallArity1 Capi_Ctype_001 Capi_Ctype_002 CarryOverflow CgStaticPointers CgStaticPointersNoFullLazyness Chan002 Chan003 CmmSwitchTest64 CmpInt16 CmpInt8 CmpWord16 CmpWord8 CopySmallArray Defer01 Defer02 DeriveNullTermination DocsInHiFile0 DocsInHiFile1 DsLambdaCase DsMultiWayIf DsStaticPointers DsStrict DsStrictData DsStrictFail DsStrictLet EvalTest EventlogOutput1 EventlogOutput2 FloatFnInverses Freeman GEq1 GEq2 GFullyStrict GFunctor1 GHCiWildcardKind GMap1 GMapAssoc GMapTop GShow1 GUniplate1 GcStaticPointers GenNewtype GhciCurDir GhciKinds HexFloatLiterals HooplPostorder IOError001 IOError002 IndT... etc... snip of a typical error subprocess.CalledProcessError: Command '['git', 'rev-parse', 'HEAD']' returned non-zero exit status 128 Traceback (most recent call last): File "/home/simonpj/code/HEAD-4/testsuite/driver/testlib.py", line 840, in test_common_work do_test(name, way, func, args, files) File "/home/simonpj/code/HEAD-4/testsuite/driver/testlib.py", line 928, in do_test result = func(*[name,way] + args) File "/home/simonpj/code/HEAD-4/testsuite/driver/testlib.py", line 1019, in makefile_test return run_command(name, way, cmd) File "/home/simonpj/code/HEAD-4/testsuite/driver/testlib.py", line 1012, in run_command return simple_run( name, '', override_options(cmd), '' ) File "/home/simonpj/code/HEAD-4/testsuite/driver/testlib.py", line 1396, in simple_run return check_stats(name, way, stats_file, opts.stats_range_fields) File "/home/simonpj/code/HEAD-4/testsuite/driver/testlib.py", line 1185, in check_stats head_commit = Perf.commit_hash('HEAD') File "/home/simonpj/code/HEAD-4/testsuite/driver/perf_notes.py", line 92, in commit_hash stderr=subprocess.STDOUT) \ File "/usr/lib/python3.5/subprocess.py", line 626, in check_output **kwargs).stdout File "/usr/lib/python3.5/subprocess.py", line 708, in run output=stdout, stderr=stderr)

3 4

Put 'haddock' in the 'ghc' repo
by Vladislav Zavialov 19 Feb '19

19 Feb '19

Hello devs, There appears to be no good workflow for contributing patches that change both GHC and Haddock. For contributors who have push access to both repositories, it is at least tolerable: 1. create a Haddock branch with the required changes 2. create a GHC branch with the required changes Then wait for the GHC change to get merged to `master`, and 3a. fast-forward the Haddock change to the `ghc-head` branch 3b. in case a fast-forward is impossible, cherry-pick the commit to `ghc-head` and push another commit to GHC `master` to update the Haddock submodule Roundabout, but possible. For contributors who do not have push access to both repositories, each step is much harder, as working with forks implies messing with .gitmodules, which arguably should stay constant. To avoid all this friction, I propose the following principle: * all SCC (strongly connected components) of dependencies must go to the same repo. For example, since GHC depends on Haddock to build documentation, and Haddock depends on GHC, they must go to the same repo. This way, a single commit can update both of them in sync. All the best, Vladislav

2 1

CI Docker Images
by Matthew Pickering 18 Feb '19

18 Feb '19

Hi Mark, Ben Where are the dockerfiles (or nix expressions) which are used to build the docker images? I want to update them and push some new images to ghcci but I can't find any trace about how the images have been made. Cheers, Matt

1 1

GItLab commenting
by Simon Peyton Jones 18 Feb '19

18 Feb '19

Friends In reviewing MR!361, I wanted to point out that a Note on line 1481 of a file needed rewriting. But the patch only modified lines 236 or so. How can I get it to display line 1481? (Or, more simply, just display the whole file?) I can get it to show 10 more lines at a time by clicking the little grey "..." symbols. But getting 1000 lines down would take 100 clicks - hardly sensible. Moreover, what if I want to comment on a file that isn't in the patch at all? Thanks Simon

2 3