- ghc-devs - Haskell.org

How do I make a constraint tuple in Core?
by Ryan Scott 19 Jun '18

19 Jun '18

I'm currently working on some code in which I need to produce a Core Type that mentions a constraint tuple. I thought that there must surely exist some way to construct a constraint tuple using the GHC API, but to my astonishment, I could not find anything. The closest thing I found was mk_tuple [1], which gives you the ability to make boxed and unboxed tuples, but not constraint tuples. I then thought to myself, "But wait, PartialTypeSignatures has to create constraint tuples, right? How does that part of the code work?" To my horror, I discovered that PartialTypeSignatures actually creates *boxed* tuples (see mk_ctuple here [2]), then hackily treats them as constraint tuples, as explained in Note [Extra-constraint holes in partial type signatures] [3]. I tried reading that Note, but I couldn't follow the details. Is there a simpler way to create a constraint tuple that I'm not aware of? Ryan S. ----- [1] http://git.haskell.org/ghc.git/blob/676c5754e3f9e1beeb5f01e0265ffbdc0e6f49e… [2] http://git.haskell.org/ghc.git/blob/676c5754e3f9e1beeb5f01e0265ffbdc0e6f49e… [3] http://git.haskell.org/ghc.git/blob/676c5754e3f9e1beeb5f01e0265ffbdc0e6f49e…

2 4

Use of -dead_strip_dylibs by default makes the -framework flag appear broken.
by Travis Whitaker 19 Jun '18

19 Jun '18

Hello Haskell Friends, GHC always passes <https://github.com/ghc/ghc/blob/master/compiler/main/DriverPipeline.hs#L1888> -dead_strip_dylibs to the linker on macOS. This means that Haskell programs that use Objective-C-style dynamic binding (via objc_getClass or similar) won't actually be able to find the Objective-C methods they need at runtime. Here's an example illustrating the problem: Consider this small example program: #include <stdio.h> extern void *objc_getClass(char *n); void test_get_class(char *n) { void *cp = objc_getClass(n); if(cp == NULL) { printf("Didn't find class %s\n", n); } else { printf("Found class %s\n", n); } } int main(int argc, char *argv[]) { test_get_class(argv[1]); return 0; } Building like this: clang -o hasclass main.c -lobjc -L/usr/lib -framework Foundation -F /System/Library/Frameworks/ Yields an executable that works like this: $ ./hasclass NSObject Found class NSObject $ ./hasclass NSString Found class NSString $ ./hasclass NSDate Found class NSDate otool shows that we're linked against Foundation properly: hasclass: /usr/lib/libobjc.A.dylib (compatibility version 1.0.0, current version 228.0.0) /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation (compatibility version 300.0.0, current version 1452.23.0) /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.50.4) Now consider this equivalent Haskell example: module Main where import Foreign.C.String import Foreign.Ptr import System.Environment foreign import ccall objc_getClass :: CString -> IO (Ptr a) testGetClass :: String -> IO () testGetClass n = withCString n $ \cn -> do cp <- objc_getClass cn let m | cp == nullPtr = "Didn't find class " ++ n | otherwise = "Found class " ++ n putStrLn m main :: IO () main = getArgs >>= (testGetClass . head) Building like this: ghc -o hasclass Main.hs -lobjc -L/usr/lib -framework foundation -framework-path /System/Library/Frameworks/ Yields an executable that works like this: $ ./hasclass NSObject Found class NSObject $ ./hasclass NSString Didn't find class NSString $ ./hasclass NSDate Didn't find class NSDate otool shows that our load commands for Foundation are missing: hasclass: /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.50.4) /usr/lib/libobjc.A.dylib (compatibility version 1.0.0, current version 228.0.0) /nix/store/7jdxjpy1p5ynl9qrr3ymx01973a1abf6-gmp-6.1.2/lib/libgmp.10.dylib (compatibility version 14.0.0, current version 14.2.0) /usr/lib/libiconv.2.dylib (compatibility version 7.0.0, current version 7.0.0) Interestingly, the testGetClass function will work just fine in GHCi, since it always loads all of the shared objects and frameworks it's asked to. As far as I can tell the only way to get a hasclass executable with the correct behavior is to do the final linking manually with Clang. My understanding is that this behavior was introduced to work around symbol count limitations introduced in macOS Sierra. It would be nice to wrap the frameworks passed to the linker in some flags that spares them from -dead_strip_dylibs. I haven't found such a feature in my limited digging around, but perhaps someone who knows more about systems programming on macOS will have an idea. Statically linking against the system frameworks would be a workable stopgap solution, but I have yet to find an easy way to do that. I'm curious what others' thoughts are on this issue; it's very difficult to call Objective-C methods from Haskell (without generating Objective-C) without a fix for this. Regards, Travis Whitaker

3 2

Strace
by Simon Peyton Jones 18 Jun '18

18 Jun '18

Tamar I'm getting megabytes of output from 'sh validate' on windows. It looks like this 629 151745 [main] sh 2880 fhandler_base::fhaccess: returning 0 291 152036 [main] sh 2880 faccessat: returning 0 7757 159793 [main] sh 2880 fhandler_base_overlapped::wait_overlapped: wfres 0, wores 1, bytes 7 179457 1608947 [main] make 11484 fhandler_base_overlapped::wait_overlapped: wfres 0, wores 1, bytes 7 99 159892 [main] sh 2880 fhandler_base_overlapped::wait_overlapped: normal write, 7 bytes ispipe() 1 180 1609127 [main] make 11484 fhandler_base_overlapped::wait_overlapped: normal read, 7 bytes ispipe() 1 139 160031 [main] sh 2880 write: 7 = write(1, 0x6000396A0, 7) 142 1609269 [main] make 11484 fhandler_base::read: returning 7, binary mode 139 1609408 [main] make 11484 read: 7 = read(5, 0x60005B4B0, 7) 136 1609544 [main] make 11484 read: read(5, 0x60005B4B7, 193) blocking 4693 164724 [main] sh 2880 set_signal_mask: setmask 0, newmask 80000, mask_bits 0 but with hundreds of thousands of lines. (I have not counted) I believe that it may be the result of this line, earlier in the log cd "/c/Users/simonpj/AppData/Local/Temp/ghctest-8fa9s6rk/test spaces/./plugins/plugins07.run" && strace $MAKE -s --no-print-directory -C rule-defining-plugin package.plugins07 TOP=/c/code/HEAD/testsuite# Note the strace. That in turn was added in your commit commit 60fb2b2160aa16194b74262f4df8fad5af171b0f Author: Tamar Christina <tamar(a)zhox.com> Date: Mon May 28 19:34:11 2018 +0100 Clean up Windows testsuite failures Summary: Another round and attempt at getting these down to 0. Could you perhaps have made a mistake here? Currently validate is unusable. Thanks! Simon

2 6

Functor, Foldable and Traversable for Expr
by Sebastian Graf 18 Jun '18

18 Jun '18

Hi everyone, I'm repeatedly wondering why there are no `Functor`, `Foldable` and `Traversable` instances for `Expr`. Is this just by lack of motive? I could help there: I was looking for a function that would tell me if an expression mentions `makeStatic`. After spending some minutes searching in the code base, I decided to roll my own thing in `CoreUtils`. I really couldn't think about a good name, so I settled for `anyReferenceMatching :: (b -> Bool) -> Expr b -> Bool` and realized that I could generalize the function to `foldMapExpr :: Monoid m => (b -> m) -> Expr b -> m`. Occasionally this need pops up and I really want to avoid writing my own traversals over the syntax tree. So, would anyone object to a patch implementing these instances? Thanks Sebastian

2 2

DEBUG-on
by Simon Peyton Jones 18 Jun '18

18 Jun '18

Ben We don't really test with a DEBUG-enabled compiler. And yet, those assertions are all there for a reason. In our CI infrastructure, I wonder if we might do a regression-test run on at least one architecture with DEBUG on? e.g. https://ghc.haskell.org/trac/ghc/ticket/14904 Simon

3 3

#10789
by sasa bogicevic 18 Jun '18

18 Jun '18

Hello, I am looking at this task https://ghc.haskell.org/trac/ghc/ticket/10789 <https://ghc.haskell.org/trac/ghc/ticket/10789> and need some help on implementing it. With the help of @int_index I found the place in TcErrors.hs where the error printing occurs and I think the check that I need to add will look similar to this one https://github.com/ghc/ghc/blob/master/compiler/typecheck/TcErrors.hs#L1935 <https://github.com/ghc/ghc/blob/master/compiler/typecheck/TcErrors.hs#L1935>. So I guess that we need to check if one of the kinds of two types we are comparing defaults to * (or Type if you will) and then add new warning that will be more descriptive as to why the failure happened. Maybe there is a way to check if what we are comparing are actually type families so that would make the job easier I guess. Richard Eisenberg offered some help on this but I am not sure how to grab hold of him so I'd appreciate any help I could get. Thanks, Sasa

3 3

Re: [commit: ghc] master: Embrace -XTypeInType, add -XStarIsType (d650729)
by Gabor Greif 15 Jun '18

15 Jun '18

My `happy` chokes on the unicode sequence you added: (if isUnicode $1 then "★" else "*") Casn this be done with unicode escapes somehow? Cheers, Gabor PS: Happy Version 1.19.9 Copyright (c) 1993-1996 Andy Gill, Simon Marlow (c) 1997-2005 Simon Marlow On 6/14/18, git(a)git.haskell.org <git(a)git.haskell.org> wrote: > Repository : ssh://git@git.haskell.org/ghc > > On branch : master > Link : > http://ghc.haskell.org/trac/ghc/changeset/d650729f9a0f3b6aa5e6ef2d5fba337f6… > >>--------------------------------------------------------------- > > commit d650729f9a0f3b6aa5e6ef2d5fba337f6f70fa60 > Author: Vladislav Zavialov <vlad.z.4096(a)gmail.com> > Date: Thu Jun 14 15:02:36 2018 -0400 > > Embrace -XTypeInType, add -XStarIsType > > Summary: > Implement the "Embrace Type :: Type" GHC proposal, > .../ghc-proposals/blob/master/proposals/0020-no-type-in-type.rst > > GHC 8.0 included a major change to GHC's type system: the Type :: Type > axiom. Though casual users were protected from this by hiding its > features behind the -XTypeInType extension, all programs written in GHC > 8+ have the axiom behind the scenes. In order to preserve backward > compatibility, various legacy features were left unchanged. For example, > with -XDataKinds but not -XTypeInType, GADTs could not be used in types. > Now these restrictions are lifted and -XTypeInType becomes a redundant > flag that will be eventually deprecated. > > * Incorporate the features currently in -XTypeInType into the > -XPolyKinds and -XDataKinds extensions. > * Introduce a new extension -XStarIsType to control how to parse * in > code and whether to print it in error messages. > > Test Plan: Validate > > Reviewers: goldfire, hvr, bgamari, alanz, simonpj > > Reviewed By: goldfire, simonpj > > Subscribers: rwbarton, thomie, mpickering, carter > > GHC Trac Issues: #15195 > > Differential Revision: https://phabricator.haskell.org/D4748 > > >>--------------------------------------------------------------- > > d650729f9a0f3b6aa5e6ef2d5fba337f6f70fa60 > .gitignore | 1 + > .gitmodules | 4 +- > compiler/basicTypes/DataCon.hs | 22 +- > compiler/basicTypes/Name.hs | 21 +- > compiler/basicTypes/RdrName.hs | 96 +++- > compiler/basicTypes/SrcLoc.hs | 5 +- > compiler/deSugar/DsMeta.hs | 7 +- > compiler/hsSyn/Convert.hs | 37 +- > compiler/hsSyn/HsDecls.hs | 9 +- > compiler/hsSyn/HsExtension.hs | 16 +- > compiler/hsSyn/HsInstances.hs | 5 - > compiler/hsSyn/HsTypes.hs | 117 +---- > compiler/iface/IfaceType.hs | 8 +- > compiler/main/DynFlags.hs | 31 ++ > compiler/main/DynFlags.hs-boot | 1 + > compiler/main/HscTypes.hs | 3 +- > compiler/parser/Lexer.x | 104 +++-- > compiler/parser/Parser.y | 88 ++-- > compiler/parser/RdrHsSyn.hs | 190 ++++---- > compiler/prelude/PrelNames.hs | 7 +- > compiler/prelude/PrelNames.hs-boot | 3 +- > compiler/prelude/TysWiredIn.hs | 24 +- > compiler/rename/RnEnv.hs | 43 +- > compiler/rename/RnSource.hs | 4 +- > compiler/rename/RnTypes.hs | 186 ++------ > compiler/typecheck/TcDeriv.hs | 14 +- > compiler/typecheck/TcHsType.hs | 82 ++-- > compiler/typecheck/TcInstDcls.hs | 4 +- > compiler/typecheck/TcMType.hs | 2 +- > compiler/typecheck/TcPatSyn.hs | 2 +- > compiler/typecheck/TcRnTypes.hs | 6 - > compiler/typecheck/TcSplice.hs | 4 +- > compiler/typecheck/TcTyClsDecls.hs | 43 +- > compiler/types/Kind.hs | 33 +- > compiler/types/TyCoRep.hs | 1 + > compiler/types/TyCon.hs | 8 +- > compiler/types/Type.hs | 11 +- > compiler/types/Unify.hs | 2 +- > compiler/utils/Outputable.hs | 11 +- > docs/users_guide/8.6.1-notes.rst | 30 +- > docs/users_guide/glasgow_exts.rst | 482 > +++++++++------------ > libraries/base/Data/Data.hs | 4 +- > libraries/base/Data/Kind.hs | 2 +- > libraries/base/Data/Proxy.hs | 2 +- > libraries/base/Data/Type/Equality.hs | 4 +- > libraries/base/Data/Typeable.hs | 26 +- > libraries/base/Data/Typeable/Internal.hs | 1 - > libraries/base/GHC/Base.hs | 3 +- > libraries/base/GHC/Err.hs | 2 +- > libraries/base/GHC/Generics.hs | 50 +-- > libraries/base/Type/Reflection/Unsafe.hs | 2 +- > libraries/base/tests/CatEntail.hs | 4 +- > .../ghc-boot-th/GHC/LanguageExtensions/Type.hs | 1 + > libraries/ghc-prim/GHC/Magic.hs | 3 +- > libraries/ghc-prim/GHC/Types.hs | 8 +- > testsuite/tests/codeGen/should_fail/T13233.hs | 2 +- > testsuite/tests/dependent/ghci/T11549.script | 2 +- > testsuite/tests/dependent/ghci/T14238.stdout | 2 +- > testsuite/tests/dependent/should_compile/Dep1.hs | 2 +- > testsuite/tests/dependent/should_compile/Dep2.hs | 2 +- > testsuite/tests/dependent/should_compile/Dep3.hs | 2 +- > .../tests/dependent/should_compile/DkNameRes.hs | 9 + > .../dependent/should_compile/InferDependency.hs | 6 - > .../dependent/should_compile/KindEqualities.hs | 2 +- > .../dependent/should_compile/KindEqualities2.hs | 3 +- > .../tests/dependent/should_compile/KindLevels.hs | 2 +- > .../tests/dependent/should_compile/RAE_T32b.hs | 24 +- > testsuite/tests/dependent/should_compile/Rae31.hs | 23 +- > .../tests/dependent/should_compile/RaeBlogPost.hs | 27 +- > .../tests/dependent/should_compile/RaeJobTalk.hs | 2 +- > testsuite/tests/dependent/should_compile/T11405.hs | 2 +- > testsuite/tests/dependent/should_compile/T11635.hs | 2 +- > testsuite/tests/dependent/should_compile/T11711.hs | 1 - > testsuite/tests/dependent/should_compile/T11719.hs | 6 +- > testsuite/tests/dependent/should_compile/T11966.hs | 1 - > testsuite/tests/dependent/should_compile/T12176.hs | 2 +- > testsuite/tests/dependent/should_compile/T12442.hs | 4 +- > testsuite/tests/dependent/should_compile/T12742.hs | 2 +- > testsuite/tests/dependent/should_compile/T13910.hs | 9 +- > testsuite/tests/dependent/should_compile/T13938.hs | 3 +- > .../tests/dependent/should_compile/T13938a.hs | 3 +- > testsuite/tests/dependent/should_compile/T14038.hs | 3 +- > .../tests/dependent/should_compile/T14066a.hs | 2 +- > testsuite/tests/dependent/should_compile/T14556.hs | 3 +- > testsuite/tests/dependent/should_compile/T14720.hs | 3 +- > testsuite/tests/dependent/should_compile/T14749.hs | 2 +- > testsuite/tests/dependent/should_compile/T14991.hs | 3 +- > testsuite/tests/dependent/should_compile/T9632.hs | 2 +- > .../tests/dependent/should_compile/TypeLevelVec.hs | 2 +- > testsuite/tests/dependent/should_compile/all.T | 1 + > .../dependent/should_compile/dynamic-paper.hs | 27 +- > .../tests/dependent/should_compile/mkGADTVars.hs | 2 +- > .../tests/dependent/should_fail/BadTelescope.hs | 2 +- > .../tests/dependent/should_fail/BadTelescope2.hs | 2 +- > .../tests/dependent/should_fail/BadTelescope3.hs | 2 +- > .../tests/dependent/should_fail/BadTelescope4.hs | 2 +- > testsuite/tests/dependent/should_fail/DepFail1.hs | 2 +- > .../tests/dependent/should_fail/InferDependency.hs | 2 +- > .../tests/dependent/should_fail/KindLevelsB.hs | 9 - > .../tests/dependent/should_fail/KindLevelsB.stderr | 5 - > .../tests/dependent/should_fail/PromotedClass.hs | 2 +- > testsuite/tests/dependent/should_fail/RAE_T32a.hs | 28 +- > .../tests/dependent/should_fail/RAE_T32a.stderr | 6 +- > .../tests/dependent/should_fail/RenamingStar.hs | 2 +- > .../dependent/should_fail/RenamingStar.stderr | 10 +- > testsuite/tests/dependent/should_fail/SelfDep.hs | 2 + > .../tests/dependent/should_fail/SelfDep.stderr | 8 +- > testsuite/tests/dependent/should_fail/T11407.hs | 2 +- > testsuite/tests/dependent/should_fail/T11473.hs | 2 +- > testsuite/tests/dependent/should_fail/T12081.hs | 2 +- > testsuite/tests/dependent/should_fail/T12174.hs | 2 +- > testsuite/tests/dependent/should_fail/T13135.hs | 4 +- > testsuite/tests/dependent/should_fail/T13601.hs | 2 +- > testsuite/tests/dependent/should_fail/T13780a.hs | 2 +- > testsuite/tests/dependent/should_fail/T13780b.hs | 3 +- > testsuite/tests/dependent/should_fail/T13780c.hs | 2 +- > .../tests/dependent/should_fail/T13780c.stderr | 6 +- > testsuite/tests/dependent/should_fail/T14066.hs | 4 +- > testsuite/tests/dependent/should_fail/T14066c.hs | 2 +- > testsuite/tests/dependent/should_fail/T14066d.hs | 2 +- > testsuite/tests/dependent/should_fail/T14066e.hs | 2 +- > testsuite/tests/dependent/should_fail/T14066f.hs | 2 +- > testsuite/tests/dependent/should_fail/T14066g.hs | 2 +- > testsuite/tests/dependent/should_fail/T14066h.hs | 2 +- > testsuite/tests/dependent/should_fail/T15245.hs | 10 + > .../tests/dependent/should_fail/T15245.stderr | 7 + > .../tests/dependent/should_fail/TypeSkolEscape.hs | 2 +- > testsuite/tests/dependent/should_fail/all.T | 2 +- > testsuite/tests/dependent/should_run/T11964a.hs | 2 +- > testsuite/tests/deriving/should_compile/T11416.hs | 3 +- > testsuite/tests/deriving/should_compile/T11732a.hs | 2 +- > testsuite/tests/deriving/should_compile/T11732b.hs | 2 +- > testsuite/tests/deriving/should_compile/T11732c.hs | 2 +- > testsuite/tests/deriving/should_compile/T14331.hs | 2 +- > testsuite/tests/deriving/should_compile/T14579.hs | 3 +- > testsuite/tests/deriving/should_compile/T14932.hs | 4 +- > testsuite/tests/deriving/should_fail/T12512.hs | 2 +- > testsuite/tests/deriving/should_fail/T14728a.hs | 2 +- > testsuite/tests/deriving/should_fail/T14728b.hs | 2 +- > testsuite/tests/deriving/should_fail/T15073.hs | 2 +- > testsuite/tests/determinism/determ004/determ004.hs | 2 +- > testsuite/tests/determinism/determ014/A.hs | 6 +- > testsuite/tests/driver/T4437.hs | 1 + > testsuite/tests/gadt/T7293.hs | 6 +- > testsuite/tests/gadt/T7293.stderr | 4 +- > testsuite/tests/gadt/T7294.hs | 6 +- > testsuite/tests/gadt/T7294.stderr | 4 +- > testsuite/tests/generics/GEq/GEq1.hs | 5 +- > testsuite/tests/ghci/scripts/T10321.hs | 3 +- > testsuite/tests/ghci/scripts/T11252.script | 2 +- > testsuite/tests/ghci/scripts/T11376.script | 2 +- > testsuite/tests/ghci/scripts/T12550.script | 2 +- > testsuite/tests/ghci/scripts/T13407.script | 4 +- > testsuite/tests/ghci/scripts/T13963.script | 2 +- > testsuite/tests/ghci/scripts/T13988.hs | 2 +- > testsuite/tests/ghci/scripts/T7873.script | 2 +- > testsuite/tests/ghci/scripts/T7939.hs | 4 +- > testsuite/tests/ghci/scripts/T8357.hs | 5 +- > testsuite/tests/indexed-types/should_compile/HO.hs | 5 +- > .../tests/indexed-types/should_compile/Numerals.hs | 7 +- > .../tests/indexed-types/should_compile/T12369.hs | 4 +- > .../tests/indexed-types/should_compile/T12522b.hs | 8 +- > .../tests/indexed-types/should_compile/T12938.hs | 2 +- > .../tests/indexed-types/should_compile/T13244.hs | 2 +- > .../tests/indexed-types/should_compile/T13398b.hs | 2 +- > .../tests/indexed-types/should_compile/T14162.hs | 3 +- > .../tests/indexed-types/should_compile/T14554.hs | 5 +- > .../tests/indexed-types/should_compile/T15122.hs | 2 +- > .../tests/indexed-types/should_compile/T2219.hs | 4 +- > .../tests/indexed-types/should_compile/T7585.hs | 6 +- > .../tests/indexed-types/should_compile/T9747.hs | 9 +- > .../tests/indexed-types/should_fail/T12522a.hs | 6 +- > .../tests/indexed-types/should_fail/T12522a.stderr | 6 +- > .../tests/indexed-types/should_fail/T13674.hs | 4 +- > .../tests/indexed-types/should_fail/T13784.hs | 5 +- > .../tests/indexed-types/should_fail/T13784.stderr | 14 +- > .../tests/indexed-types/should_fail/T13877.hs | 6 +- > .../tests/indexed-types/should_fail/T13972.hs | 2 +- > .../tests/indexed-types/should_fail/T14175.hs | 2 +- > .../tests/indexed-types/should_fail/T14246.hs | 8 +- > .../tests/indexed-types/should_fail/T14246.stderr | 2 +- > .../tests/indexed-types/should_fail/T14369.hs | 2 +- > testsuite/tests/indexed-types/should_fail/T2544.hs | 4 +- > .../tests/indexed-types/should_fail/T2544.stderr | 8 +- > .../tests/indexed-types/should_fail/T3330c.hs | 6 +- > .../tests/indexed-types/should_fail/T3330c.stderr | 10 +- > testsuite/tests/indexed-types/should_fail/T4174.hs | 10 +- > .../tests/indexed-types/should_fail/T4174.stderr | 6 +- > testsuite/tests/indexed-types/should_fail/T7786.hs | 4 +- > .../tests/indexed-types/should_fail/T7786.stderr | 25 +- > testsuite/tests/indexed-types/should_fail/T7967.hs | 10 +- > .../tests/indexed-types/should_fail/T7967.stderr | 12 +- > testsuite/tests/indexed-types/should_fail/T9036.hs | 7 +- > .../tests/indexed-types/should_fail/T9036.stderr | 2 +- > testsuite/tests/indexed-types/should_fail/T9662.hs | 4 +- > .../tests/indexed-types/should_fail/T9662.stderr | 6 +- > .../tests/indexed-types/should_run/T11465a.hs | 1 - > .../should_run/overloadedrecflds_generics.hs | 5 +- > .../should_run/overloadedrecfldsrun07.hs | 6 +- > .../parser/should_compile/DumpParsedAst.stderr | 109 ++--- > .../tests/parser/should_compile/DumpRenamedAst.hs | 2 +- > .../parser/should_compile/DumpRenamedAst.stderr | 62 ++- > testsuite/tests/parser/should_compile/T10379.hs | 2 +- > testsuite/tests/parser/should_fail/T15209.stderr | 2 +- > testsuite/tests/parser/should_fail/all.T | 5 + > testsuite/tests/parser/should_fail/readFail036.hs | 4 +- > .../tests/parser/should_fail/readFail036.stderr | 4 +- > testsuite/tests/parser/should_fail/typeops_A.hs | 1 + > .../tests/parser/should_fail/typeops_A.stderr | 2 + > testsuite/tests/parser/should_fail/typeops_B.hs | 1 + > .../tests/parser/should_fail/typeops_B.stderr | 2 + > testsuite/tests/parser/should_fail/typeops_C.hs | 1 + > .../tests/parser/should_fail/typeops_C.stderr | 2 + > testsuite/tests/parser/should_fail/typeops_D.hs | 1 + > .../tests/parser/should_fail/typeops_D.stderr | 2 + > .../tests/partial-sigs/should_compile/T15039a.hs | 12 +- > .../partial-sigs/should_compile/T15039a.stderr | 11 +- > .../tests/partial-sigs/should_compile/T15039b.hs | 12 +- > .../partial-sigs/should_compile/T15039b.stderr | 44 +- > .../tests/partial-sigs/should_compile/T15039c.hs | 12 +- > .../partial-sigs/should_compile/T15039c.stderr | 11 +- > .../tests/partial-sigs/should_compile/T15039d.hs | 12 +- > .../partial-sigs/should_compile/T15039d.stderr | 44 +- > .../tests/partial-sigs/should_fail/T14040a.hs | 2 +- > testsuite/tests/partial-sigs/should_fail/T14584.hs | 2 +- > .../tests/partial-sigs/should_fail/T14584.stderr | 2 +- > testsuite/tests/patsyn/should_compile/T12698.hs | 2 +- > testsuite/tests/patsyn/should_compile/T12968.hs | 2 +- > testsuite/tests/patsyn/should_compile/T13768.hs | 8 +- > testsuite/tests/patsyn/should_compile/T14058.hs | 2 +- > testsuite/tests/patsyn/should_compile/T14058a.hs | 3 +- > testsuite/tests/patsyn/should_fail/T14507.hs | 4 +- > testsuite/tests/patsyn/should_fail/T14507.stderr | 2 +- > testsuite/tests/patsyn/should_fail/T14552.hs | 2 +- > testsuite/tests/perf/compiler/T12227.hs | 17 +- > testsuite/tests/perf/compiler/T12545a.hs | 3 +- > testsuite/tests/perf/compiler/T13035.hs | 13 +- > testsuite/tests/perf/compiler/T13035.stderr | 2 +- > testsuite/tests/perf/compiler/T9872d.hs | 186 ++++++-- > testsuite/tests/pmcheck/complete_sigs/T14253.hs | 2 +- > testsuite/tests/pmcheck/should_compile/T14086.hs | 2 +- > testsuite/tests/pmcheck/should_compile/T3927b.hs | 8 +- > testsuite/tests/polykinds/MonoidsTF.hs | 4 +- > testsuite/tests/polykinds/PolyKinds10.hs | 27 +- > testsuite/tests/polykinds/SigTvKinds3.hs | 2 +- > testsuite/tests/polykinds/T10134a.hs | 3 +- > testsuite/tests/polykinds/T10934.hs | 6 +- > testsuite/tests/polykinds/T11142.hs | 2 +- > testsuite/tests/polykinds/T11399.hs | 2 +- > testsuite/tests/polykinds/T11480b.hs | 24 +- > testsuite/tests/polykinds/T11520.hs | 2 +- > testsuite/tests/polykinds/T11523.hs | 1 - > testsuite/tests/polykinds/T11554.hs | 2 +- > testsuite/tests/polykinds/T11616.hs | 2 +- > testsuite/tests/polykinds/T11640.hs | 2 +- > testsuite/tests/polykinds/T11648.hs | 4 +- > testsuite/tests/polykinds/T11648b.hs | 2 +- > testsuite/tests/polykinds/T11821a.hs | 2 +- > testsuite/tests/polykinds/T12055.hs | 4 +- > testsuite/tests/polykinds/T12055a.hs | 4 +- > testsuite/tests/polykinds/T12593.hs | 2 +- > testsuite/tests/polykinds/T12668.hs | 2 +- > testsuite/tests/polykinds/T12718.hs | 2 +- > testsuite/tests/polykinds/T13391.hs | 7 - > testsuite/tests/polykinds/T13391.stderr | 7 - > testsuite/tests/polykinds/T13625.hs | 2 +- > testsuite/tests/polykinds/T13659.hs | 4 +- > testsuite/tests/polykinds/T13659.stderr | 2 +- > testsuite/tests/polykinds/T13738.hs | 2 +- > testsuite/tests/polykinds/T13985.stderr | 10 +- > testsuite/tests/polykinds/T14174.hs | 2 +- > testsuite/tests/polykinds/T14174a.hs | 7 +- > testsuite/tests/polykinds/T14209.hs | 2 +- > testsuite/tests/polykinds/T14270.hs | 2 +- > testsuite/tests/polykinds/T14450.hs | 4 +- > testsuite/tests/polykinds/T14450.stderr | 2 +- > testsuite/tests/polykinds/T14515.hs | 3 +- > testsuite/tests/polykinds/T14520.hs | 4 +- > testsuite/tests/polykinds/T14555.hs | 4 +- > testsuite/tests/polykinds/T14561.hs | 2 +- > testsuite/tests/polykinds/T14563.hs | 2 +- > testsuite/tests/polykinds/T14580.hs | 2 +- > testsuite/tests/polykinds/T14710.stderr | 8 - > testsuite/tests/polykinds/T14846.hs | 2 +- > testsuite/tests/polykinds/T14873.hs | 3 +- > testsuite/tests/polykinds/T15170.hs | 2 +- > testsuite/tests/polykinds/T5716.hs | 3 +- > testsuite/tests/polykinds/T5716.stderr | 10 +- > testsuite/tests/polykinds/T6021.stderr | 4 - > testsuite/tests/polykinds/T6035.hs | 4 +- > testsuite/tests/polykinds/T6039.stderr | 12 +- > testsuite/tests/polykinds/T6093.hs | 7 +- > testsuite/tests/polykinds/T7404.stderr | 4 - > testsuite/tests/polykinds/T7594.hs | 6 +- > testsuite/tests/polykinds/T7594.stderr | 9 +- > testsuite/tests/polykinds/T8566.hs | 8 +- > testsuite/tests/polykinds/T8566.stderr | 8 +- > testsuite/tests/polykinds/T8566a.hs | 8 +- > testsuite/tests/polykinds/T8985.hs | 8 +- > testsuite/tests/polykinds/T9222.hs | 3 +- > testsuite/tests/polykinds/T9222.stderr | 6 +- > testsuite/tests/polykinds/all.T | 5 +- > testsuite/tests/printer/Ppr040.hs | 2 +- > testsuite/tests/printer/Ppr045.hs | 1 + > testsuite/tests/rename/should_fail/T11592.hs | 2 +- > testsuite/tests/rename/should_fail/T13947.stderr | 2 +- > .../tests/simplCore/should_compile/T13025a.hs | 6 +- > testsuite/tests/simplCore/should_compile/T13658.hs | 2 +- > .../tests/simplCore/should_compile/T14270a.hs | 3 +- > .../tests/simplCore/should_compile/T15186A.hs | 2 +- > testsuite/tests/simplCore/should_compile/T4903a.hs | 10 +- > testsuite/tests/simplCore/should_run/T13750a.hs | 13 +- > testsuite/tests/th/T11463.hs | 2 +- > testsuite/tests/th/T11484.hs | 2 +- > testsuite/tests/th/T13642.hs | 2 +- > testsuite/tests/th/T13781.hs | 2 +- > testsuite/tests/th/T14060.hs | 2 +- > testsuite/tests/th/T14869.hs | 2 +- > testsuite/tests/th/T8031.hs | 4 +- > testsuite/tests/th/TH_RichKinds2.hs | 5 +- > testsuite/tests/th/TH_RichKinds2.stderr | 2 +- > .../tests/typecheck/should_compile/SplitWD.hs | 2 +- > testsuite/tests/typecheck/should_compile/T10432.hs | 5 +- > testsuite/tests/typecheck/should_compile/T11237.hs | 4 +- > testsuite/tests/typecheck/should_compile/T11348.hs | 1 - > testsuite/tests/typecheck/should_compile/T11524.hs | 1 - > testsuite/tests/typecheck/should_compile/T11723.hs | 2 +- > testsuite/tests/typecheck/should_compile/T11811.hs | 2 +- > testsuite/tests/typecheck/should_compile/T12133.hs | 4 +- > testsuite/tests/typecheck/should_compile/T12381.hs | 2 +- > testsuite/tests/typecheck/should_compile/T12734.hs | 38 +- > .../tests/typecheck/should_compile/T12734a.hs | 31 +- > .../tests/typecheck/should_compile/T12734a.stderr | 9 +- > .../tests/typecheck/should_compile/T12785a.hs | 2 +- > testsuite/tests/typecheck/should_compile/T12911.hs | 2 +- > testsuite/tests/typecheck/should_compile/T12919.hs | 2 +- > testsuite/tests/typecheck/should_compile/T12987.hs | 2 +- > testsuite/tests/typecheck/should_compile/T13083.hs | 5 +- > testsuite/tests/typecheck/should_compile/T13333.hs | 2 +- > testsuite/tests/typecheck/should_compile/T13337.hs | 2 +- > testsuite/tests/typecheck/should_compile/T13343.hs | 2 +- > testsuite/tests/typecheck/should_compile/T13458.hs | 2 +- > testsuite/tests/typecheck/should_compile/T13603.hs | 2 +- > testsuite/tests/typecheck/should_compile/T13643.hs | 2 +- > testsuite/tests/typecheck/should_compile/T13822.hs | 3 +- > testsuite/tests/typecheck/should_compile/T13871.hs | 2 +- > testsuite/tests/typecheck/should_compile/T13879.hs | 2 +- > .../tests/typecheck/should_compile/T13915a.hs | 2 +- > .../tests/typecheck/should_compile/T13915b.hs | 2 +- > testsuite/tests/typecheck/should_compile/T13943.hs | 2 +- > testsuite/tests/typecheck/should_compile/T14441.hs | 3 +- > .../tests/typecheck/should_compile/T14934a.hs | 3 +- > testsuite/tests/typecheck/should_compile/all.T | 4 +- > testsuite/tests/typecheck/should_compile/tc191.hs | 2 +- > testsuite/tests/typecheck/should_compile/tc205.hs | 4 +- > testsuite/tests/typecheck/should_compile/tc269.hs | 3 +- > .../should_compile/valid_hole_fits_interactions.hs | 2 +- > .../tests/typecheck/should_fail/ClassOperator.hs | 4 +- > .../typecheck/should_fail/ClassOperator.stderr | 16 +- > .../typecheck/should_fail/CustomTypeErrors04.hs | 2 +- > .../typecheck/should_fail/CustomTypeErrors05.hs | 2 +- > .../tests/typecheck/should_fail/LevPolyBounded.hs | 2 +- > testsuite/tests/typecheck/should_fail/T11313.hs | 2 - > .../tests/typecheck/should_fail/T11313.stderr | 8 +- > testsuite/tests/typecheck/should_fail/T11724.hs | 2 +- > testsuite/tests/typecheck/should_fail/T11963.hs | 29 -- > .../tests/typecheck/should_fail/T11963.stderr | 20 - > testsuite/tests/typecheck/should_fail/T12648.hs | 6 +- > testsuite/tests/typecheck/should_fail/T12709.hs | 3 +- > .../tests/typecheck/should_fail/T12709.stderr | 8 +- > testsuite/tests/typecheck/should_fail/T12785b.hs | 8 +- > testsuite/tests/typecheck/should_fail/T12973.hs | 2 +- > testsuite/tests/typecheck/should_fail/T13105.hs | 2 +- > testsuite/tests/typecheck/should_fail/T13446.hs | 4 +- > testsuite/tests/typecheck/should_fail/T13909.hs | 2 +- > testsuite/tests/typecheck/should_fail/T13929.hs | 2 +- > .../tests/typecheck/should_fail/T13983.stderr | 2 +- > testsuite/tests/typecheck/should_fail/T14350.hs | 2 +- > testsuite/tests/typecheck/should_fail/T14904a.hs | 2 +- > testsuite/tests/typecheck/should_fail/T14904b.hs | 2 +- > testsuite/tests/typecheck/should_fail/T7645.hs | 4 +- > testsuite/tests/typecheck/should_fail/T7645.stderr | 5 +- > testsuite/tests/typecheck/should_fail/all.T | 1 - > .../tests/typecheck/should_run/EtaExpandLevPoly.hs | 4 +- > .../typecheck/should_run/KindInvariant.script | 6 +- > testsuite/tests/typecheck/should_run/T11120.hs | 2 +- > testsuite/tests/typecheck/should_run/T12809.hs | 2 +- > testsuite/tests/typecheck/should_run/T13435.hs | 3 +- > testsuite/tests/typecheck/should_run/TypeOf.hs | 2 +- > testsuite/tests/typecheck/should_run/TypeRep.hs | 4 +- > testsuite/tests/unboxedsums/sum_rr.hs | 2 +- > 391 files changed, 1865 insertions(+), 1997 deletions(-) > > Diff suppressed because of size. To see it, use: > > git diff-tree --root --patch-with-stat --no-color --find-copies-harder > --ignore-space-at-eol --cc d650729f9a0f3b6aa5e6ef2d5fba337f6f70fa60 > _______________________________________________ > ghc-commits mailing list > ghc-commits(a)haskell.org > http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-commits >

2 1

Re: [commit: ghc] master: UNREG: PprC: add support for of W16 literals (Ticket #15237) (01c9d95)
by Gabor Greif 15 Jun '18

15 Jun '18

Hi Sergei, thanks for your swift response! I did: ``` $ mips64-wrsmllib64-linux-gcc -E -dM - </dev/null | grep MIPS_SIM #define _MIPS_SIM _ABI64 ``` Looks like 64 bit ABI. Cheers, Gabor On 6/15/18, Sergei Trofimovich <slyfox(a)gentoo.org> wrote: > On Fri, 15 Jun 2018 10:49:41 +0200 > Gabor Greif <ggreif(a)gmail.com> wrote: > >> Thanks for fixing this! >> >> I am in the process of building an unregisterised MIPS64 >> cross-compiler and just noticed this warning running by: >> >> HC [stage 1] libraries/base/dist-install/build/GHC/Show.p_o >> /tmp/ghc414_0/ghc_7.hc: In function '_c53i': >> >> /tmp/ghc414_0/ghc_7.hc:1483:17: error: >> warning: integer constant is so large that it is unsigned >> _s4Lo = (_s4Ld+-9223372036854775808) + (_s4Lg + _s4L9); >> ^ >> | >> 1483 | _s4Lo = (_s4Ld+-9223372036854775808) + (_s4Lg + _s4L9); >> | ^ >> >> Not sure whether I should be worried (there seem to be others of this >> kind) or a simple change in the datatype (int -> unsigned) could >> silence this. > > The overflow looks fishy. -9223372036854775808 is 0x8000000000000000. > What ABI your mips64 targets to? 64 or n32? I'd like to reproduce it > locally. > > Simplest way to check for ABI (mine is N32): > $ mips64-unknown-linux-gnu-gcc -E -dM - </dev/null | grep MIPS_SIM > #define _MIPS_SIM _ABIN32 > > -- > > Sergei >

1 0

Re: [commit: ghc] master: UNREG: PprC: add support for of W16 literals (Ticket #15237) (01c9d95)
by Gabor Greif 15 Jun '18

15 Jun '18

Thanks for fixing this! I am in the process of building an unregisterised MIPS64 cross-compiler and just noticed this warning running by: HC [stage 1] libraries/base/dist-install/build/GHC/Show.p_o /tmp/ghc414_0/ghc_7.hc: In function '_c53i': /tmp/ghc414_0/ghc_7.hc:1483:17: error: warning: integer constant is so large that it is unsigned _s4Lo = (_s4Ld+-9223372036854775808) + (_s4Lg + _s4L9); ^ | 1483 | _s4Lo = (_s4Ld+-9223372036854775808) + (_s4Lg + _s4L9); | ^ Not sure whether I should be worried (there seem to be others of this kind) or a simple change in the datatype (int -> unsigned) could silence this. Cheers, Gabor On 6/15/18, git(a)git.haskell.org <git(a)git.haskell.org> wrote: > Repository : ssh://git@git.haskell.org/ghc > > On branch : master > Link : > http://ghc.haskell.org/trac/ghc/changeset/01c9d95aca12caf5c954320a2a82335b3… > >>--------------------------------------------------------------- > > commit 01c9d95aca12caf5c954320a2a82335b32568554 > Author: Sergei Trofimovich <slyfox(a)gentoo.org> > Date: Thu Jun 14 23:13:16 2018 +0100 > > UNREG: PprC: add support for of W16 literals (Ticket #15237) > > Fix UNREG build failure for 32-bit targets. > > This change is an equivalent of commit > 0238a6c78102d43dae2f56192bd3486e4f9ecf1d > ("UNREG: PprC: add support for of W32 literals") > > The change allows combining two subwords into one word > on 32-bit targets. Tested on nios2-unknown-linux-gnu. > > GHC Trac Issues: #15237 > > Signed-off-by: Sergei Trofimovich <slyfox(a)gentoo.org> > > >>--------------------------------------------------------------- > > 01c9d95aca12caf5c954320a2a82335b32568554 > compiler/cmm/PprC.hs | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/compiler/cmm/PprC.hs b/compiler/cmm/PprC.hs > index e46fff1..8b30bbf 100644 > --- a/compiler/cmm/PprC.hs > +++ b/compiler/cmm/PprC.hs > @@ -546,6 +546,14 @@ pprStatics dflags (CmmStaticLit (CmmInt a W32) : > rest) > else pprStatics dflags (CmmStaticLit (CmmInt ((shiftL b 32) .|. a) W64) > : > rest) > +pprStatics dflags (CmmStaticLit (CmmInt a W16) : > + CmmStaticLit (CmmInt b W16) : rest) > + | wordWidth dflags == W32 > + = if wORDS_BIGENDIAN dflags > + then pprStatics dflags (CmmStaticLit (CmmInt ((shiftL a 16) .|. b) W32) > : > + rest) > + else pprStatics dflags (CmmStaticLit (CmmInt ((shiftL b 16) .|. a) W32) > : > + rest) > pprStatics dflags (CmmStaticLit (CmmInt _ w) : _) > | w /= wordWidth dflags > = pprPanic "pprStatics: cannot emit a non-word-sized static literal" (ppr > w) > > _______________________________________________ > ghc-commits mailing list > ghc-commits(a)haskell.org > http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-commits >

1 0

Why do we prevent static archives from being loaded when DYNAMIC_GHC_PROGRAMS=YES?
by Moritz Angermann 13 Jun '18

13 Jun '18

Dear friends, when we build GHC with DYNAMIC_GHC_PROGRAMS=YES, we essentially prevent ghc/ghci from using archives (.a). Is there a technical reason behind this? The only only reasoning so far I've came across was: insist on using dynamic/shared objects, because the user said so when building GHC. In that case, we don't however prevent GHC from building archive (static) only libraries. And as a consequence when we later try to build another archive of a different library, that depends via TH on the former library, GHC will bail and complain that we don't have the relevant dynamic/shared object. Of course we don't we explicitly didn't build it. But the linker code we have in GHC is perfectly capable of loading archives. So why don't we want to fall back to archives? Similarly, as @deech asked on twitter[1], why we prevent GHCi from loading static libraries? I'd like to understand the technical reason/rational for this behavior. Can someone help me out here? If there is no fundamental reason for this behavior, I'd like to go ahead and try to lift it. Thank you! Cheers, Moritz --- [1]: https://twitter.com/deech/status/1001182709555908608

4 4